Re: [forge-dev] UIValidator

Em 03/01/2015, às 11:09, Ivan St. Ivanov <ivan.st.ivanov(a)gmail.com&gt; escreveu: Hi folks, George, we are talking here about Soro's issue, the one that you reported in the JIRA. About mine, you were right that the environment variable was not set. I guess that the validator *is* called. At least from the stack trace in the JIRA, I see that the error happens while calling the AbstractUICommand validate method. Most probably the exception escapes and just gets logged. Maybe if you add catch clause for a RuntimeException to the validator, it will work. Cheers, Ivan > On Sat, Jan 3, 2015 at 3:03 PM, George Gastaldi <ggastald(a)redhat.com&gt; wrote: > Hi Ivan, > > That's because the code is on the Bootstrap class (see the stacktrace you pasted). As for the UIValidator not being called, I'll investigate further. > > > >> Em 03/01/2015, às 10:51, Ivan St. Ivanov <ivan.st.ivanov(a)gmail.com&gt; escreveu: >> > >> Hi folks, >> >> George, most probably that was the reason. >> >> I don't quite understand the problem described in this issue. Is it because there is a validation error but there is no popup in the IDE and just something in the logs? Then I guess this could be fixed if the exception that is caught here is changed to RuntimeException or if we add a new catch block for RuntimeException with different validation error. >> >> WDYT? >> >> Cheers, >> Ivan >> >>> On Sat, Jan 3, 2015 at 2:36 PM, Daniel Cunha <danielsoro(a)gmail.com&gt; wrote: >>> Hi Ivan, >>> >>> I'm looking for it. George opened a issue for it. (https://issues.jboss.org/browse/FORGE-2169). >>> http://maven.apache.org/pom.html#Maven_Coordinates >>> >>> I think that this "," (comma) not should to exist. Ok? >>> >>>> On Sat, Jan 3, 2015 at 12:28 PM, Ivan St. Ivanov <ivan.st.ivanov(a)gmail.com&gt; wrote: >>>> Hi Soro, >>>> >>>> I guess upon executing the addon install command (prior to the actual execution). >>>> >>>> Did you also get an error when trying to run: >>>> >>>> forge --install org.jboss.forge.addon:core,$FORGE_VERSION >>>> >>>> This morning I got: >>>> >>>> java.lang.IllegalArgumentException: Coordinates must be of the form 'name,version' or 'name,version,api-version >>>> at org.jboss.forge.furnace.addons.AddonId.fromCoordinates(AddonId.java:78) >>>> at org.jboss.forge.bootstrap.Bootstrap.install(Bootstrap.java:311) >>>> at org.jboss.forge.bootstrap.Bootstrap.<init>(Bootstrap.java:179) >>>> at org.jboss.forge.bootstrap.Bootstrap.main(Bootstrap.java:95) >>>> >>>> However, I did not investigate much into it. I guess I have to change the `:core` part in my script to `,core`. >>>> >>>> Cheers, >>>> Ivan >>>> >>>>> On Sat, Jan 3, 2015 at 2:19 PM, Daniel Cunha <danielsoro(a)gmail.com&gt; wrote: >>>>> When this validation is called? >>>>> https://github.com/forge/core/blob/master/addon-manager/impl/src/main/jav... >>>>> >>>>> -- >>>>> Daniel Cunha (soro) >>>>> >>>>> _______________________________________________ >>>>> forge-dev mailing list >>>>> forge-dev(a)lists.jboss.org >>>>> https://lists.jboss.org/mailman/listinfo/forge-dev >>>> >>>> >>>> _______________________________________________ >>>> forge-dev mailing list >>>> forge-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/forge-dev >>> >>> >>> >>> -- >>> Daniel Cunha (soro) >>> >>> _______________________________________________ >>> forge-dev mailing list >>> forge-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/forge-dev >> >> _______________________________________________ >> forge-dev mailing list >> forge-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/forge-dev > > _______________________________________________ > forge-dev mailing list > forge-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/forge-dev _______________________________________________ forge-dev mailing list forge-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/forge-dev