George, I think that it is not the test that do not work on Windows, but
the whole text addon is broken. I mean, the patterns that rely on \n are
there. I fixed easily the YAML patterns, but I stuck in the Groovy ones -
too few knowledge in RegExp :)
On Thu, Jul 31, 2014 at 3:46 PM, George Gastaldi <ggastald(a)redhat.com>
wrote:
Hi Ivan,
That would be good if the fix is trivial. Otherwise we can add an
Assume.assumeFalse(OperatingSystemUtils.isWindows()); in a @Before method
in the scanner tests.
Em 31/07/2014, às 09:32, "Ivan St. Ivanov" <ivan.st.ivanov(a)gmail.com>
escreveu:
Hey George,
Thanks!
What do you think, should we fix the text issues on Windows? I think yes.
If you agree with me, I will at least create a JIRA for that.
Regards,
Ivan
On Thu, Jul 31, 2014 at 3:23 PM, George Gastaldi <ggastald(a)redhat.com>
wrote:
> Hey Ivan,
>
> Good catch! You're the man!
>
> In my previous attempt to find out what the problem was, I had to ignore
> the text addon tests on Windows to proceed.
>
> The JVM crash is reported in JIRA also, I think Antonio Goncalves
> experienced something like that.
>
> Let me know if you find somehing else.
>
> Best Regards,
>
> George
>
> Em 31/07/2014, às 08:28, "Ivan St. Ivanov"
<ivan.st.ivanov(a)gmail.com>
> escreveu:
>
> Hey Daniel,
>
> The idea of this effort is just to make sure Forge tests run locally on
> Windows. And then to investigate why the central build fails. I.e. first
> clean up your own garden and only then look in the public park ;)
>
> If you have any special issues with Aesh, please share them (probably in
> another thread). I also had some, but I thought they were resolved. The
> thing is that I don't use Windows at home any more (switched to Fedora), so
> I can't catch problems with the rate I used to do before ;)
>
> Cheers,
> Ivan
>
>
> On Thu, Jul 31, 2014 at 12:54 PM, Daniel Cunha <danielsoro(a)gmail.com>
> wrote:
>
>> Hi Ivan,
>>
>> I don't know if aesh work ok on windows. In my last test I had many
>> problem and that can be the answer about forge don't run ok on windows.
>>
>>
>> On Thu, Jul 31, 2014 at 4:45 AM, Ivan St. Ivanov <
>> ivan.st.ivanov(a)gmail.com> wrote:
>>
>>> Hey everybody,
>>>
>>> As we discussed yesterday, a promised to run the build locally on my
>>> Windows computer to see if we have any issues there, fix them and only then
>>> address the failing builds on the build server.
>>>
>>> I did that, and I have the following observations:
>>>
>>> 1) The text addon tests failed, mostly because the patterns that
>>> recognize the different language elements for YAML, Groovy, JavaScript and
>>> HTML are built with the assumption that the end of line character is \n.
>>> You know, on Windows it is \r\n. So there were some tests failures. I
>>> decided to fix them and only then to continue. But after it took me more
>>> than two hours debugging and trying without much progress (fixed only YAML
>>> and most of the Groovy) I gave up. I then cloned the repo with git's
>>> autocrlf set to false and the tests passed. Nevertheless, we should fix
>>> these I guess, if we want our text addon to work on Windows
>>>
>>> 2) The JavaEE addon failed with a JVM crash (I attached the generated
>>> dump files from the three runs that I did). I tried to run it both as part
>>> of the build of the whole Forge core, as well as individually. In both
>>> cases it failed. I will install a newer version of the JDK and will try
>>> again.
>>>
>>> That is for the moment from my side. Unfortunately I spent all the time
>>> debugging the text addon, so didn't spend any effort on the JUnit
command
>>> and no email for utility methods so far from me.
>>>
>>> Cheers,
>>> Ivan
>>>
>>> _______________________________________________
>>> forge-dev mailing list
>>> forge-dev(a)lists.jboss.org
>>>
https://lists.jboss.org/mailman/listinfo/forge-dev
>>>
>>
>>
>>
>> --
>> Daniel Cunha (soro) <
http://www.cejug.net>
>> Blog:
http://www.danielsoro.com.br
>> Twitter:
https://twitter.com/dvlc_
>> GitHub:
https://github.com/danielsoro
>> LinkedIn:
http://www.linkedin.com/in/danielvlcunha
>>
>> _______________________________________________
>> forge-dev mailing list
>> forge-dev(a)lists.jboss.org
>>
https://lists.jboss.org/mailman/listinfo/forge-dev
>>
>
> _______________________________________________
> forge-dev mailing list
> forge-dev(a)lists.jboss.org
>
https://lists.jboss.org/mailman/listinfo/forge-dev
>
>
> _______________________________________________
> forge-dev mailing list
> forge-dev(a)lists.jboss.org
>
https://lists.jboss.org/mailman/listinfo/forge-dev
>
_______________________________________________
forge-dev mailing list
forge-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/forge-dev
_______________________________________________
forge-dev mailing list
forge-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/forge-dev