Responses inline.. On Tue, Oct 23, 2012 at 7:38 PM, JFlower <fiorenzino(a)gmail.com&gt; wrote: > Hi, > > i started to find material to solve the bugs in object. > > *1) (FORGE-367) [SOLVED] question: how add import with wildcard and/or > static:* > > see my comment: > https://issues.jboss.org/browse/FORGE-367#comment-12728726 > > In this version we accept wildcard inside the className and we accept > static option: > *- javaClass.addImport("org.junit.Assert.*").setStatic(true);* > I like the way you have solved this. > > If you want we could add a new method: > *- javaClass.addStaticImport("org.junit.Assert.*");* > No, I don't think this is necessary. We should be able to make the right decision. > > *2) (FORGE-563 - FORGE-424) question: creation of > some WildcardImportResolver implementation* - where this resolver should > find the complete className when we have some wildcard import? > That's the tricky part. > > - Could we use the current ClassLoader and find all classes in that? > > Well... the problem is that we can't use the Current classloader because that would be Forge's classloader. We need the classloader of the project, which is not actually classloaded, so we would need to classload the project (potentially very slow without an index.) > - Could we create some index with all classes inside all mvn > dependencies/modules jar [using jboss module capabilities? > using tattletale? ] > > We need to do *something* - I'll leave it up to you to play with some ideas and see what works well or not! > - Could we* *use jboss jandex to do that (also if jandex is processes > Java annotations)? > http://javahowto.blogspot.de/2012/08/how-to-run-jboss-jandex.html > > https://github.com/jbossas/jandex/blob/master/src/main/java/org/jboss/jan... > > > Potentially. > Have you some idea? > > Nothing you haven't already mentioned :) > > Fiorenzo > > _______________________________________________ > forge-dev mailing list > forge-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/forge-dev > > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." _______________________________________________ forge-dev mailing list forge-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/forge-dev

I may be a bit ignorant about Jandex. But what is a FlowerIndex? ;) Lol. ~Lincoln On Thu, Oct 25, 2012 at 9:08 PM, JFlower <fiorenzino(a)gmail.com&gt; wrote: > Hi, > > i created this jira: https://issues.jboss.org/browse/FORGE-699 > > my code: https://github.com/fiorenzino/jandex/tree/FORGE-699 > > Comments are always welcome!! > > Fiorenzo > > ps: my first jandex hacking https://gist.github.com/3956397 > > *numbers: 66 libraries - scanned in 1458 milliseconds - 15036 classes > (with subclasses)* > > > > 2012/10/24 Lincoln Baxter, III <lincolnbaxter(a)gmail.com&gt; > > Responses inline.. >> >> On Tue, Oct 23, 2012 at 7:38 PM, JFlower <fiorenzino(a)gmail.com&gt; wrote: >> >>> Hi, >>> >>> i started to find material to solve the bugs in object. >>> >>> *1) (FORGE-367) [SOLVED] question: how add import with wildcard and/or >>> static:* >>> >>> see my comment: >>> https://issues.jboss.org/browse/FORGE-367#comment-12728726 >>> >>> In this version we accept wildcard inside the className and we accept >>> static option: >>> *- javaClass.addImport("org.junit.Assert.*").setStatic(true);* >>> >> >> I like the way you have solved this. >> >>> >>> If you want we could add a new method: >>> *- javaClass.addStaticImport("org.junit.Assert.*");* >>> >> >> No, I don't think this is necessary. We should be able to make the right >> decision. >> >> >>> >>> *2) (FORGE-563 - FORGE-424) question: creation of >>> some WildcardImportResolver implementation* - where this resolver >>> should find the complete className when we have some wildcard import? >>> >> >> That's the tricky part. >> >> >>> >>> - Could we use the current ClassLoader and find all classes in that? >>> >>> >> Well... the problem is that we can't use the Current classloader because >> that would be Forge's classloader. We need the classloader of the project, >> which is not actually classloaded, so we would need to classload the >> project (potentially very slow without an index.) >> >> >>> - Could we create some index with all classes inside all mvn >>> dependencies/modules jar [using jboss module capabilities? >>> using tattletale? ] >>> >>> We need to do *something* - I'll leave it up to you to play with some >> ideas and see what works well or not! >> >> >>> - Could we* *use jboss jandex to do that (also if jandex is processes >>> Java annotations)? >>> http://javahowto.blogspot.de/2012/08/how-to-run-jboss-jandex.html >>> >>> https://github.com/jbossas/jandex/blob/master/src/main/java/org/jboss/jan... >>> >>> >>> Potentially. >> >> >>> Have you some idea? >>> >>> Nothing you haven't already mentioned :) >> >> >>> >>> Fiorenzo >>> >>> _______________________________________________ >>> forge-dev mailing list >>> forge-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/forge-dev >>> >>> >> >> >> -- >> Lincoln Baxter, III >> http://ocpsoft.org >> "Simpler is better." >> >> _______________________________________________ >> forge-dev mailing list >> forge-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/forge-dev >> >> > > _______________________________________________ > forge-dev mailing list > forge-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/forge-dev > > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." _______________________________________________ forge-dev mailing list forge-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/forge-dev

And why did you fork the Jandex repo? :p On Fri, Oct 26, 2012 at 10:16 AM, JFlower <fiorenzino(a)gmail.com&gt; wrote: > Dirty hacking code! > > :-) > > > 2012/10/26 Lincoln Baxter, III <lincolnbaxter(a)gmail.com&gt; > > I may be a bit ignorant about Jandex. But what is a FlowerIndex? ;) Lol. >> >> ~Lincoln >> >> >> On Thu, Oct 25, 2012 at 9:08 PM, JFlower <fiorenzino(a)gmail.com&gt; wrote: >> >>> Hi, >>> >>> i created this jira: https://issues.jboss.org/browse/FORGE-699 >>> >>> my code: https://github.com/fiorenzino/jandex/tree/FORGE-699 >>> >>> Comments are always welcome!! >>> >>> Fiorenzo >>> >>> ps: my first jandex hacking https://gist.github.com/3956397 >>> >>> *numbers: 66 libraries - scanned in 1458 milliseconds - 15036 classes >>> (with subclasses)* >>> >>> >>> >>> 2012/10/24 Lincoln Baxter, III <lincolnbaxter(a)gmail.com&gt; >>> >>> Responses inline.. >>>> >>>> On Tue, Oct 23, 2012 at 7:38 PM, JFlower <fiorenzino(a)gmail.com&gt; wrote: >>>> >>>>> Hi, >>>>> >>>>> i started to find material to solve the bugs in object. >>>>> >>>>> *1) (FORGE-367) [SOLVED] question: how add import with wildcard >>>>> and/or static:* >>>>> >>>>> see my comment: >>>>> https://issues.jboss.org/browse/FORGE-367#comment-12728726 >>>>> >>>>> In this version we accept wildcard inside the className and we accept >>>>> static option: >>>>> *- javaClass.addImport("org.junit.Assert.*").setStatic(true);* >>>>> >>>> >>>> I like the way you have solved this. >>>> >>>>> >>>>> If you want we could add a new method: >>>>> *- javaClass.addStaticImport("org.junit.Assert.*");* >>>>> >>>> >>>> No, I don't think this is necessary. We should be able to make the >>>> right decision. >>>> >>>> >>>>> >>>>> *2) (FORGE-563 - FORGE-424) question: creation of >>>>> some WildcardImportResolver implementation* - where this resolver >>>>> should find the complete className when we have some wildcard import? >>>>> >>>> >>>> That's the tricky part. >>>> >>>> >>>>> >>>>> - Could we use the current ClassLoader and find all classes in that? >>>>> >>>>> >>>> Well... the problem is that we can't use the Current classloader >>>> because that would be Forge's classloader. We need the classloader of the >>>> project, which is not actually classloaded, so we would need to classload >>>> the project (potentially very slow without an index.) >>>> >>>> >>>>> - Could we create some index with all classes inside all mvn >>>>> dependencies/modules jar [using jboss module capabilities? >>>>> using tattletale? ] >>>>> >>>>> We need to do *something* - I'll leave it up to you to play with some >>>> ideas and see what works well or not! >>>> >>>> >>>>> - Could we* *use jboss jandex to do that (also if jandex is processes >>>>> Java annotations)? >>>>> http://javahowto.blogspot.de/2012/08/how-to-run-jboss-jandex.html >>>>> >>>>> https://github.com/jbossas/jandex/blob/master/src/main/java/org/jboss/jan... >>>>> >>>>> >>>>> Potentially. >>>> >>>> >>>>> Have you some idea? >>>>> >>>>> Nothing you haven't already mentioned :) >>>> >>>> >>>>> >>>>> Fiorenzo >>>>> >>>>> _______________________________________________ >>>>> forge-dev mailing list >>>>> forge-dev(a)lists.jboss.org >>>>> https://lists.jboss.org/mailman/listinfo/forge-dev >>>>> >>>>> >>>> >>>> >>>> -- >>>> Lincoln Baxter, III >>>> http://ocpsoft.org >>>> "Simpler is better." >>>> >>>> _______________________________________________ >>>> forge-dev mailing list >>>> forge-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/forge-dev >>>> >>>> >>> >>> _______________________________________________ >>> forge-dev mailing list >>> forge-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/forge-dev >>> >>> >> >> >> -- >> Lincoln Baxter, III >> http://ocpsoft.org >> "Simpler is better." >> >> _______________________________________________ >> forge-dev mailing list >> forge-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/forge-dev >> >> > > _______________________________________________ > forge-dev mailing list > forge-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/forge-dev > > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." _______________________________________________ forge-dev mailing list forge-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/forge-dev

Okay, that makes sense, but when the time comes, I would allow Jandex to index annotations as well, since that is extremely important as we go forward with CDI and similar annotation-driven programming models. The Class index we generate could be used for more than just wildcards. Thoughts? ~Lincoln On Fri, Oct 26, 2012 at 11:59 AM, JFlower <fiorenzino(a)gmail.com&gt; wrote: > Hi Lincoln, > > > jandex does more things than i need: > > for my test, i removed some methods inside jandex ((e.g.:i don't care > about annotations inside classes - i removed the generation of jandex file > index). > > > I started using the default jandex code, but to reduce the time of > scanning my jars inside test case, i modified the jandex source code. > > > It's dirty code..but the understand how jandex works, i needed that! > > > have a nice we, > > > fiorenzo > > 2012/10/26 Lincoln Baxter, III <lincolnbaxter(a)gmail.com&gt; > >> And why did you fork the Jandex repo? :p >> >> >> On Fri, Oct 26, 2012 at 10:16 AM, JFlower <fiorenzino(a)gmail.com&gt; wrote: >> >>> Dirty hacking code! >>> >>> :-) >>> >>> >>> 2012/10/26 Lincoln Baxter, III <lincolnbaxter(a)gmail.com&gt; >>> >>> I may be a bit ignorant about Jandex. But what is a FlowerIndex? ;) Lol. >>>> >>>> ~Lincoln >>>> >>>> >>>> On Thu, Oct 25, 2012 at 9:08 PM, JFlower <fiorenzino(a)gmail.com&gt; wrote: >>>> >>>>> Hi, >>>>> >>>>> i created this jira: https://issues.jboss.org/browse/FORGE-699 >>>>> >>>>> my code: https://github.com/fiorenzino/jandex/tree/FORGE-699 >>>>> >>>>> Comments are always welcome!! >>>>> >>>>> Fiorenzo >>>>> >>>>> ps: my first jandex hacking https://gist.github.com/3956397 >>>>> >>>>> *numbers: 66 libraries - scanned in 1458 milliseconds - 15036 >>>>> classes (with subclasses)* >>>>> >>>>> >>>>> >>>>> 2012/10/24 Lincoln Baxter, III <lincolnbaxter(a)gmail.com&gt; >>>>> >>>>> Responses inline.. >>>>>> >>>>>> On Tue, Oct 23, 2012 at 7:38 PM, JFlower <fiorenzino(a)gmail.com&gt;wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> i started to find material to solve the bugs in object. >>>>>>> >>>>>>> *1) (FORGE-367) [SOLVED] question: how add import with wildcard >>>>>>> and/or static:* >>>>>>> >>>>>>> see my comment: >>>>>>> https://issues.jboss.org/browse/FORGE-367#comment-12728726 >>>>>>> >>>>>>> In this version we accept wildcard inside the className and we >>>>>>> accept static option: >>>>>>> *- javaClass.addImport("org.junit.Assert.*").setStatic(true);* >>>>>>> >>>>>> >>>>>> I like the way you have solved this. >>>>>> >>>>>>> >>>>>>> If you want we could add a new method: >>>>>>> *- javaClass.addStaticImport("org.junit.Assert.*");* >>>>>>> >>>>>> >>>>>> No, I don't think this is necessary. We should be able to make the >>>>>> right decision. >>>>>> >>>>>> >>>>>>> >>>>>>> *2) (FORGE-563 - FORGE-424) question: creation of >>>>>>> some WildcardImportResolver implementation* - where this resolver >>>>>>> should find the complete className when we have some wildcard import? >>>>>>> >>>>>> >>>>>> That's the tricky part. >>>>>> >>>>>> >>>>>>> >>>>>>> - Could we use the current ClassLoader and find all classes in that? >>>>>>> >>>>>>> >>>>>> Well... the problem is that we can't use the Current classloader >>>>>> because that would be Forge's classloader. We need the classloader of the >>>>>> project, which is not actually classloaded, so we would need to classload >>>>>> the project (potentially very slow without an index.) >>>>>> >>>>>> >>>>>>> - Could we create some index with all classes inside all mvn >>>>>>> dependencies/modules jar [using jboss module capabilities? >>>>>>> using tattletale? ] >>>>>>> >>>>>>> We need to do *something* - I'll leave it up to you to play with >>>>>> some ideas and see what works well or not! >>>>>> >>>>>> >>>>>>> - Could we* *use jboss jandex to do that (also if jandex is processes >>>>>>> Java annotations)? >>>>>>> http://javahowto.blogspot.de/2012/08/how-to-run-jboss-jandex.html >>>>>>> >>>>>>> https://github.com/jbossas/jandex/blob/master/src/main/java/org/jboss/jan... >>>>>>> >>>>>>> >>>>>>> Potentially. >>>>>> >>>>>> >>>>>>> Have you some idea? >>>>>>> >>>>>>> Nothing you haven't already mentioned :) >>>>>> >>>>>> >>>>>>> >>>>>>> Fiorenzo >>>>>>> >>>>>>> _______________________________________________ >>>>>>> forge-dev mailing list >>>>>>> forge-dev(a)lists.jboss.org >>>>>>> https://lists.jboss.org/mailman/listinfo/forge-dev >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Lincoln Baxter, III >>>>>> http://ocpsoft.org >>>>>> "Simpler is better." >>>>>> >>>>>> _______________________________________________ >>>>>> forge-dev mailing list >>>>>> forge-dev(a)lists.jboss.org >>>>>> https://lists.jboss.org/mailman/listinfo/forge-dev >>>>>> >>>>>> >>>>> >>>>> _______________________________________________ >>>>> forge-dev mailing list >>>>> forge-dev(a)lists.jboss.org >>>>> https://lists.jboss.org/mailman/listinfo/forge-dev >>>>> >>>>> >>>> >>>> >>>> -- >>>> Lincoln Baxter, III >>>> http://ocpsoft.org >>>> "Simpler is better." >>>> >>>> _______________________________________________ >>>> forge-dev mailing list >>>> forge-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/forge-dev >>>> >>>> >>> >>> _______________________________________________ >>> forge-dev mailing list >>> forge-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/forge-dev >>> >>> >> >> >> -- >> Lincoln Baxter, III >> http://ocpsoft.org >> "Simpler is better." >> >> _______________________________________________ >> forge-dev mailing list >> forge-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/forge-dev >> >> > > _______________________________________________ > forge-dev mailing list > forge-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/forge-dev > > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." _______________________________________________ forge-dev mailing list forge-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/forge-dev