Re: [jbosstools-dev] m2eclipse-mavenarchiver writes pom.xml/pom.properties too aggressively

I have just seen https://github.com/tesla/m2eclipse-mavenarchiver/pull/1 that fixes the same issue. I think, that PR will also decrease performance because it reads and compares two pom.xml file whenever the Maven Archiver configurator is called. Snjeza On 1/4/2014 7:21 PM, Snjezana Peco wrote: > Hi, > > The AbstractMavenArchiverConfigurator.writePom method is called whenever > the Maven builder is called. The method writes pom.xml/pom.properties > archive files no matter if pom.xml has been changed or not. > M2e-wtp includes the Maven Archiver configurator into different projects > (war, ear, ejb, rar...) > Since the Maven builder can often be called when there are a lot of > maven projects in the workspace (the wildfly distribution, for > instance), this issue will decrease performance. > It will also unnecessarily call other builders (CDI, KB, Arquillian > ...). If those builders are created correctly, they won't do anything, > but performance will be decreased because the following useless actions > have been run: > > - Maven Archiver writes pom.xml/pom.properties > - Eclipse runs other builders > - builders search a resource delta > > The https://github.com/tesla/m2eclipse-mavenarchiver/pull/2 PR fixes the > issue by calling the writePom method only if pom.xml is changed or if > there isn't pom.xml in the output folder. > > I have created the PR against the > https://github.com/tesla/m2eclipse-mavenarchiver repository. Not sure if > it is a valid repository for the m2eclipse-mavenarchiver plugin. > > Snjeza > > --- > This email is free from viruses and malware because avast! Antivirus > protection is active. > http://www.avast.com > > _______________________________________________ > jbosstools-dev mailing list > jbosstools-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jbosstools-dev