Re: [jbosstools-dev] Re: Need to fix a blocker issue: ESB project wizard can not work with WTP 3.03

Hi Snijeza Thanks you for your patch. In early WTP versions, there is not the * ComponentCore.createComponent(project, false);* method at all, so it still can not work. Thanks Denny Snjezana Peco wrote: > Hoping the attached patch will fix this issue for WTP 3.0.1/3.0.2/3.0.3. > > Snjeza > > John Graham wrote: >> A couple of questions: >> >> * Will fixing this for 3.0.3 mean that the wizard will no longer >> work in >> earlier versions? If so, then we need to carefully document this, since >> users will not expect this large difference between 3.0.1/2 --> 3.0.3 >> >> * Are we using the same functionality in other JBT wizards? If so, are >> they broken or have they avoided the issue somehow (if avoided, this >> might suggest a backward compatible work-around?) >> >> -- John >> >> On Wed, 2008-12-03 at 21:53 +0800, Denny Xu wrote: >> >>> Max Rydahl Andersen wrote: >>> >>>> Is this on *public* API ? >>>> >>>> If yes, we need to raise that to bugs.eclipse.org >>>> >>> yes, it's public API, the changes break a already exist API, it >>> should be a bug, I will report it to WTP. >>> >>> Denny >>> >>>> /max >>>> >>>> >>>>> Max Rydahl Andersen wrote: >>>>> >>>>>> Yes, WTP 3.0.3 is the target so needs fixing. >>>>>> >>>>>> What is causing the failure ? >>>>>> >>>>> It seems that WTP 3.03 has changed the implementation of >>>>> ModuleCore when creating a VirtualComponent for a project, it >>>>> overloads the "createComponent" method in ComponentManager class >>>>> and we have to invoke the new overloaded method to create >>>>> VirtualComponent. >>>>> >>>>> Denny >>>>> >>>>> >>>>>> /max >>>>>> >>>>>> >>>>>>> Hi all >>>>>>> >>>>>>> When change the WTP to 3.03, the ESB project wizard doesn't >>>>>>> work at all, should I commit the changes to trunk . >>>>>>> here is the JIRA: https://jira.jboss.org/jira/browse/JBIDE-3333 >>>>>>> >>>>>>> Denny >>>>>>> >>>>>> >>>>>> >>>> >>>> >>> _______________________________________________ >>> jbosstools-dev mailing list >>> jbosstools-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev >>> >> >> _______________________________________________ >> jbosstools-dev mailing list >> jbosstools-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/jbosstools-dev >> >> > _______________________________________________ jbosstools-dev mailing list jbosstools-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jbosstools-dev