Yes, seems so :-)
I'll create a JIRA for this issue.
Thank you and have a nice weekend.
----- Original Message -----
On Jan 13, 2012, at 15:57, Lucia Jelinkova wrote:
> Hi Max,
>
> to clarify if something is missing, I've decided to install Portlet
> tools using clean Eclipse Indigo SR1 (for Java developers). I've
> used the
>
http://download.jboss.org/jbosstools/updates/development/indigo/
> update site. Then I've tried to create a New Dynamic Web Project
> with Java Portlet facet enabled - and it failed with the same
> errors as the tests.
>
> Do we support installation of JBT on Eclipse for Java developers?
We recommend using Java EE version, but it should work. Thus if it
does not work after begin installed then there are missing
dependencies that needs to be added.
Sounds like you found the real bug :) A win for *not* having a
"import all features for tests" :
)
/max
> If not, then I understand that I need to specify the JEE features
> and plugins in tests by myself. But this constraint should be also
> mentioned on the update site:
>
>
http://www.jboss.org/tools/download/dev
>
> Regards,
>
> Lucia
>
> ----- Original Message -----
>>>>>
>>>>> Sorry, I've forgotten to mention that I am developing SWTBot
>>>>> tests.
>>>>> However, I still think that the UI test should basically
>>>>> reference
>>>>> just the feature under the test and not features like
>>>>> org.eclipse.jst.enterprise_ui.feature.feature.group or
>>>>> org.eclipse.jst.web_core.feature.feature.group.
>>>>
>>>> This is a wrong assumption :) How do you expect Tycho to figure
>>>> out
>>>> the proper dependency set if there are no dependencies to it ?
>>>
>>> Of course Tycho cannot handle dependencies that are not defined -
>>> my assumption however is that if there is a plugin and the plugin
>>> cannot successfully be executed without some dependencies, the
>>> plugin should define those dependencies. In my case - I am
>>> testing
>>> portlets in JBT, so I would suppose that either the portlet
>>> feature or some feature imported from that feature should
>>> reference the Eclipse JEE features if it cannot run without them.
>>
>> Yes, and you/dev should figure out if that is the case!
>>
>> If no tests found it before then it is either because Yes, this
>> plugin should be listed explicitly OR No, this plugin is implicit
>> and optional and thus something tests would need to do it.
>>
>>> So my question is, would it be a good idea to add previously
>>> mentioned features from Eclipse JEE to the JBT plugin that
>>> actually needs it and thus explicitly express the dependency?
>>
>> Which features specifically ? The epp and ide ones does not make
>> sense since they are eclipse product features AFAIK.
>>
>> /max
>>
>>>
>>>>
>>>> What is missing is a way to tell Tycho to use "everything"
from
>>>> the
>>>> target platform but that will also not always be what you want.
>>>>
>>>> I've seen musings on tycho-dev/user on this problem but I
>>>> haven't
>>>> followed through to see what options there is.
>>>>
>>>>>> And the resulting target platform was different from the
>>>>>> installation the user would have if he / she downloaded
>>>>>> Eclipse
>>>>>> and installed JBT to it. That's why I thought that
referencing
>>>>>> *.platform.ide feature and the jee feature would solve this
>>>>>> issue.
>>>>>
>>>>>> No, those are at the wrong level. They are the
"product"
>>>>>> definitions from eclipse epp packages.
>>>>>
>>>>> So do you think it not an issue that the target platform where
>>>>> the
>>>>> SWTBot tests run is not the "normal" Eclipse platform?
>>>>
>>>> Depends what your test does.
>>>>
>>>> But yes, I would like to find a way to tell Tycho to *build*
>>>> against
>>>> this target platform (which is 'everything') and then
>>>> run tests against a set of different target platforms. (i.e.
>>>> JBDS
>>>> 5,
>>>> Eclipse Java EE EPP 3.7 and 3.7.1)
>>>>
>>>> But I don't know if that is possible yet - it would be really
>>>> useful
>>>> though.
>>>>
>>>> Maybe raise this question on tycho mailing list to hear how
>>>> others
>>>> solves this if anything ?
>>>
>>> Yes, that is a good advice, thank you.
>>>
>>>>
>>>> /max
>>>>
>>>>>
>>>>>> /max
>>>>>
>>>>>>
>>>>>> Lucia
>>>>>>
>>>>>> ----- Original Message -----
>>>>>> From: "Nick Boldt" <nboldt(a)redhat.com>
>>>>>> To: "Max Rydahl Andersen"
<max.andersen(a)redhat.com>
>>>>>> Cc: "Lucia Jelinkova" <ljelinko(a)redhat.com>,
>>>>>> jbosstools-dev(a)lists.jboss.org
>>>>>> Sent: Thursday, January 12, 2012 7:00:42 PM
>>>>>> Subject: Re: [jbosstools-dev] Eclipse target platform features
>>>>>>
>>>>>> Just realized this is the public jbosstools-dev list, not the
>>>>>> internal
>>>>>> JBDS one. So... if you're not behind the VPN, you can't
access
>>>>>> that site.
>>>>>>
>>>>>> You can however see the same bits here, if you point Eclipse
>>>>>> or
>>>>>> JBDS at it:
>>>>>>
>>>>>>
http://devstudio.jboss.com/updates/5.0.0/5.0.0.M5.target-platform/
>>>>>>
>>>>>> Cheers,
>>>>>>
>>>>>> Nick
>>>>>>
>>>>>> On 01/12/2012 12:58 PM, Nick Boldt wrote:
>>>>>>> In addition to the JBT Target Platform site, there's
also the
>>>>>>> JBDS
>>>>>>> Target Platform site:
>>>>>>>
>>>>>>>
http://www.qa.jboss.com/binaries/RHDS/updates/jbds-target-platform_3.3.in...
>>>>>>>
>>>>>>>
>>>>>>> Is that what you were looking for?
>>>>>>>
>>>>>>> Nick
>>>>>>>
>>>>>>>
>>>>>>> On 01/12/2012 12:43 PM, Max Rydahl Andersen wrote:
>>>>>>>>> I am trying to run my SWTBot tests using Maven and
Tycho.
>>>>>>>>> The
>>>>>>>>> problem
>>>>>>>>> is, that besides feature under test (in my case it
is
>>>>>>>>> org.jboss.tools.portlet.feature.feature.group) I
need to
>>>>>>>>> reference
>>>>>>>>> also other Eclipse related features:
>>>>>>>>>
>>>>>>>>> org.eclipse.jst.enterprise_ui.feature.feature.group
>>>>>>>>> org.eclipse.jst.web_core.feature.feature.group
>>>>>>>>>
org.eclipse.datatools.enablement.hsqldb.feature.feature.group
>>>>>>>>>
>>>>>>>>> I also need to specify some plugins where I've
not found
>>>>>>>>> corresponding feature:
>>>>>>>>>
>>>>>>>>> org.eclipse.wst.jsdt.web.core
>>>>>>>>> org.eclipse.wst.jsdt.web.support.jsp
>>>>>>>>> org.eclipse.wst.jsdt.web.ui
>>>>>>>>>
>>>>>>>>> I'd like to get rid of these dependencies by
referencing
>>>>>>>>> only
>>>>>>>>> one or
>>>>>>>>> two features - the one of Eclipse itself (so that I
can run
>>>>>>>>> the
>>>>>>>>> tests
>>>>>>>>> against the full Eclipse installation). I've
found in my
>>>>>>>>> 'Eclipse
>>>>>>>>> Java EE IDE for Web
>>>>>>>>
>>>>>>>> Try to avoid using features as dependencies - use
plugins.
>>>>>>>>
>>>>>>>>> However, on our target platform URL
>>>>>>>>>
(
http://download.jboss.org/jbosstools/updates/target-platform_3.3.indigo.S...)
>>>>>>>>> I can find just the first one (although also some
JEE
>>>>>>>>> features
>>>>>>>>> are
>>>>>>>>> there). Am I just missing it? Would it be possible
to
>>>>>>>>> change
>>>>>>>>> the
>>>>>>>>> target platform to include both of them?
>>>>>>>>
>>>>>>>> No, app and platform.ide are product features which is
*not*
>>>>>>>> part of
>>>>>>>> our target platform.
>>>>>>>>
>>>>>>>>> Also, would it be possible to create similar site
with JBDS
>>>>>>>>> installation so that we can test against the full
product?
>>>>>>>>
>>>>>>>> Not sure what this means ?
>>>>>>>>
>>>>>>>> /max
>>>>>>>>
http://about.me/maxandersen
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> jbosstools-dev mailing list
>>>>>>>> jbosstools-dev(a)lists.jboss.org
>>>>>>>>
https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>>>>>>>
>>>>>>
>>>>>> --
>>>>>> Nick Boldt :: JBoss by Red Hat
>>>>>> Productization Lead :: JBoss Tools & Dev Studio
>>>>>>
http://nick.divbyzero.com
>>>>>
>>>>> /max
>>>>>
http://about.me/maxandersen
>>>>>
>>>>>
>>>>>
>>>>
>>>> /max
>>>>
http://about.me/maxandersen
>>>>
>>>>
>>>>
>>>>
>>
>> /max
>>
http://about.me/maxandersen
>>
>>
>>
>>
/max
http://about.me/maxandersen