2:51 p.m.
the bot tests are still in the history - its just not in trunk right now.
The bot tests will be moved over and you can either delete them in the
jbosstools-integration-test or apply whatever changes that have been made in modeshape to
jboss-integration test and run it from there.
Again, this all depends on what kind of tests you have in there - if modeshape dev (i.e.
Dan) runs these tests as part of his release these makes sense to keep close to modeshape.
If not, well then move them out.
/max
On 25 Sep 2012, at 11:33, Andrej Podhradsky <apodhrad(a)redhat.com> wrote:
Hi Martin, unfortunately there is no svn for modeshape tools :(
----- Original Message -----
From: "Martin Malina" <mmalina(a)redhat.com>
To: "Daniel Florian" <dflorian(a)redhat.com>
Cc: "Andrej Podhradsky" <apodhrad(a)redhat.com>, "Pavol Srna"
<psrna(a)redhat.com>, "Max Rydahl Andersen" <max.andersen(a)redhat.com>,
"jbosstools-dev jbosstools-dev" <jbosstools-dev(a)lists.jboss.org>
Sent: Tuesday, September 25, 2012 11:12:53 AM
Subject: Re: [jbosstools-dev] SWTBot ModeShape Tools Plugin
Sorry to be late in the game, but I thought you agreed with moving the modeshape bot
tests to the new jbosstools-integration-tests git repo as part of the jbosstools migration
to git. So why bother updating it in your modeshape git repo? Andrej could easily continue
to use jbosstools svn until we finally move everything to git (very soon) and everything
would stay up to date.
If Andrej moves his work to your modeshape git repo now then it will be more difficult to
move the test to jbosstools-integration-tests.git later I think.
Thanks,
Martin
On 20. 9. 2012, at 17:26, Daniel Florian < dflorian(a)redhat.com > wrote:
The ModeShape Tools GitHub repository [1] is now in sync with the JBT SVN trunk branch
for the SWTBot plugin [2]. Andrej and Pavol let me know if you see any problems and if you
need my help resolving.
Max: Please close down the MS Tools SVN trunk branch for business.
Thanks,
Dan
[1] https://github.com/ModeShape/modeshape-tools
[2] org.jboss.tools.modeshape.rest.ui.bot.test
----- Original Message -----
So, my main question is where should I commit changes relating to bot
tests?
Andrej.
----- Original Message -----
From: "Max Rydahl Andersen" < max.andersen(a)redhat.com >
To: "Andrej Podhradsky" < apodhrad(a)redhat.com >
Cc: "Daniel Florian" < dflorian(a)redhat.com >, "jbosstools-dev
jbosstools-dev" < jbosstools-dev(a)lists.jboss.org >
Sent: Thursday, September 20, 2012 12:13:04 PM
Subject: Re: [jbosstools-dev] SWTBot ModeShape Tools Plugin
I commited some changes into
org.jboss.tools.modeshape.rest.ui.bot.test 2 days ago. These
changes fix swt bot problems in Eclipse Juno.
Could you send me the log, please? I'm sorry for that, but I didn't
know about moving ModeShape to GitHub. Is there any email about
that which I missed?
No - thats the problem and why Daniel sent the mail. Modeshape moved
without warning to jbosstools-dev. Now trying to fix the effects of
that.
/max
Best Regards
Andrej Podhradsky
----- Original Message -----
From: "Max Rydahl Andersen" < max.andersen(a)redhat.com >
To: "Daniel Florian" < dflorian(a)redhat.com >
Cc: "jbosstools-dev jbosstools-dev"
< jbosstools-dev(a)lists.jboss.org >
Sent: Thursday, September 20, 2012 11:19:41 AM
Subject: Re: [jbosstools-dev] SWTBot ModeShape Tools Plugin
I wanted to get with you to talk about the SWTBot project you work
on in ModeShape Tools. As you know from previous emails,
ModeShape Tools has moved to GitHub and all "trunk" development
should be done there. *I apologize for not getting with you
sooner.*
Today I updated my local copy of the SVN trunk of
"org.jboss.tools.modeshape.rest.ui.bot.test" project and merged
any differences into my *local* git repository. However after
merging the latest code, I started having build errors. I was
hoping you could help me with that. The build fails quickly (see
attached log).
Daniel, on jbosstools-dev (now in cc) we've been discussing moving
these bot tests which tend to be full cross-cutting integreation
tests rather than specific to one plugin to a
jbosstools-integration-test project.
would it make sense for these tests to move there too or are these
bot test "local" and stable enough to be part of modeshape main
dev tree?
(another reason to move them out is that QE changes these *after*
the module itself have been released meaning they aren't really
part of the release anyway.)
Max: Is the SVN trunk of ModeShape Tools still closed for
business?
You tell me ;) I haven't done the svn delete yet (fighting with
git migration scripts still), but it sounds like the bot tests are
still receiving updates.
If need be we can nuke modeshape tools - just need to get clearance
from doug and nick,QE(Pavol?) to ensure no builds are dependent on
it ?
/max
_______________________________________________
jbosstools-dev mailing list
jbosstools-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbosstools-dev
_______________________________________________
jbosstools-dev mailing list
jbosstools-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbosstools-dev
--
Martin Malina
JBoss QA Engineer
Red Hat Czech s.r.o.
Purkynova 99
612 45 Brno, Czech Republic
Tel.: +420 532 294 265