Sounds like something that could be implemented in JIRA as custom workflow.
"Review" state should be added in JIRA workflow between "Resolved" and
"Open"/"Reopened". Devs after submitting pull request moves it to
"Review" (does it possible to provide link to pull request?) and assign to a
reviewer. Reviewer can review changes in pull request and apply/merge them then move issue
to "Resolved", if something is wrong move it to "Reopened".
Not sure if we have rights in JIRA to create and assign new/custom workflow to JBossTools
project.
WDYT?
Denis
Sent from my Google Nexus Phone
Nick Boldt <nboldt(a)redhat.com> wrote:
Rob proposed an idea for facilitating tracking of patches for review,
using the "review" label in JIRA.
Here's how that would work.
1. you work on a JIRA
2. you attach a patch
3. you add the "review" label to the JIRA
4. you assign the JIRA to the correct reviewer (eg., Max, Denis, Len...)
When reviewed & approved:
1. reviewer signs their approval in the JIRA
2. reviewer assigns the JIRA back to the person who attached the patch
3. review changes the label from "review" to "review_approved"
4. you then commit the change and mark the JIRA resolved, so that QE can
then later mark it resolved when verified.
If you'd like to see an example query with these labels, check this out:
https://issues.jboss.org/secure/IssueNavigator!executeAdvanced.jspa?jqlQu...
https://issues.jboss.org/secure/IssueNavigator!executeAdvanced.jspa?jqlQu...
Want to query for issues assigned to YOU to review or which you've
approved? Use "assignee = currentUser()" in your queries:
https://issues.jboss.org/secure/IssueNavigator!executeAdvanced.jspa?jqlQu...
https://issues.jboss.org/secure/IssueNavigator!executeAdvanced.jspa?jqlQu...
What do you think? Good idea? Process overkill?
--
Nick Boldt :: JBoss by Red Hat
Productization Lead :: JBoss Tools & Dev Studio
http://nick.divbyzero.com
_______________________________________________
jbosstools-dev mailing list
jbosstools-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbosstools-dev