[jbosstools-dev] RE: waaay to many jars in junittests

-----Original Message----- From: Max Rydahl Andersen [mailto:max.andersen@redhat.com] Sent: Tuesday, January 22, 2008 8:02 PM To: Max Rydahl Andersen; Denis Golovin Cc: jbosstools-dev(a)lists.jboss.org; external-exadel-list(a)redhat.com; ruby(a)exadel.com Subject: Re: waaay to many jars in junittests What is the status of this ? I just saw Victor commit yet another full seam 2 application to test *one specific issue* in JSF code completion. It cannot be true we need 80(!) files in each of our unittests. /max >> That's because it is real applications, so you can import it in JBoos >> Tools compile, deploy and run. > > What usage does that have ? > > The unit tests for testing 3-4 methods in an API have no reason for messing around with huge projects. > > e.g. I just committed a full junit test for testing the HQL query validation; that only requires 1 entity java class, 1 ejb3-persistence.jar to get the annotations to compile - done. Much easier to maintain/extend and the unit test is much more focused - meaning less wheels to turn to make things work. > > Testing if a .xhtml page is rendered correctly does *not* require that the application is deployable...heck it does not even require any jars as far as i'm concerned. It just requires a .xhtml page and that you can open the file in the editor - maybe the project needs to get JSF enabled to test some of the interactions when that is enabled; but you definitly need to check both scenarioes then (our jsf editor should be usable without the current project being fully configured) > > Note: having test that does the whole thing is relevant, but having a full app for each small test of important functionallity is a big overhead. > > /max > >> Max Rydahl Andersen wrote: >>> Hi guys, >>> >>> Why are we adding *tons* of duplicated jars and complete JSF/Seam projects just to unittests a few pages with templates?! >>> >>> I can't beleive all of those files are really necessary to check if a myfaces template page will render correctly. >>> >>> Could we please make sure our tests just include what is needed and not add tons of unused things. Thanks! >>> >>> /max >>> >>> >> >> > > > -- Using Opera's revolutionary e-mail client: http://www.opera.com/mail/