November 2011 - jbosstools-issues

[JBoss JIRA] (JBIDE-10180) VPE source navigation: open-on tld file in place corresponding to particular custom tag

by Vitali Yemialyanchyk (Created) (JIRA)

VPE source navigation: open-on tld file in place corresponding to particular custom tag --------------------------------------------------------------------------------------- Key: JBIDE-10180 URL: https://issues.jboss.org/browse/JBIDE-10180 Project: Tools (JBoss Tools) Issue Type: Sub-task Components: jsp/jsf/xml source editing Reporter: Vitali Yemialyanchyk Assignee: Alexey Kazakov Priority: Minor 1) https://issues.jboss.org/browse/JBIDE-10173 has attached projects.zip, extract 2 demo projects from projects.zip in some folder on you PC intended for such things; all steps till step 5 are the same as https://issues.jboss.org/browse/JBIDE-10173 ... 6) open stopka-ui-test\src\main\webapp\test.jspx page with VPE: {code} <stopka:page xmlns="http://www.w3.org/1999/xhtml" xmlns:stopka="http://stopka.us" xmlns:jsp="http://java.sun.com/JSP/Page" xmlns:c="http://java.sun.com/jsp/jstl/core" xmlns:utils="http://stopka.us/ui/utils"> <jsp:output xmlns:jsp="http://java.sun.com/JSP/Page" omit-xml-declaration="yes"/> <c:set var="bannerType" scope="page" value="simple"/> <html xmlns="http://www.w3.org/1999/xhtml" lang="en-us"> <head> <title>StopKa filemanager</title> <stopka:css file="system/styles/stopka.css" /> <utils:common-head-data/> <stopka:css file="system/styles/filemanager.css" /> </head> <body> <div class="component"> <div class="subitem"> </div> </div> <div class="article"/> <div class="in_stopka"> </div> <div class="in_filemanager"> </div> </body> </html> </stopka:page> {code} 7) try to open "stopka:css" or "utils:common-head-data": {code} <stopka:css file="system/styles/stopka.css" /> <utils:common-head-data/> <stopka:css file="system/styles/filemanager.css" /> {code} with Ctrl + left mouse button click it does not work; Expected result: should open related tld file -> stopka.tld for it particular case. Note: stopka.tld can be stored in jar file or directly in directory. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 5 months

4
4
0 / 0

[JBoss JIRA] Created: (JBDS-1557) Errors in JBoss Server Manager Reference Guide

by Vlado Pakan (JIRA)

Errors in JBoss Server Manager Reference Guide ---------------------------------------------- Key: JBDS-1557 URL: https://issues.jboss.org/browse/JBDS-1557 Project: Developer Studio (JBoss Developer Studio) Issue Type: Bug Components: Doc - JBossAS Affects Versions: 4.0.0.CR1 Reporter: Vlado Pakan There are these errors in JBoss Server Manager Reference Guide http://download.jboss.org/jbosstools/nightly-docs/en/as/html/index.html: Chapter 1.1 - wrong link label "runtimes_servers" Chapter 2.1.2. - wrong screenshot dialog UI was changed update also related text of chapter Missing icon after "Reset Default Button " above Figure 2.12. Figure 2.13 - Added Group "Server Behaviour" add also related descritpion Figure 3.15., 3.16., 3.20. - obsolete screenshots add description of changes Figure 4.1. - obsolete new tree item "Filter" added Figure 4.3. - new facesets added update also descritpion Figure 4.4. - new facesets Figure 5.5. - there is no menu item "Deploy To Server" in package explorer Chapter 5.1.2. - Deploying single files is maybe obsolete Chapter 6.1 - link to JBoss TPTP profile feature at http://www.jboss.org/tools/download/stable is not working there is no update site on mentioned URL -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 5 months

5
15
0 / 0

[JBoss JIRA] (JBIDE-10108) Include org.jboss.tools.common.mylyn.feature into aggregated update site

by Alexey Kazakov (Created) (JIRA)

Include org.jboss.tools.common.mylyn.feature into aggregated update site ------------------------------------------------------------------------ Key: JBIDE-10108 URL: https://issues.jboss.org/browse/JBIDE-10108 Project: Tools (JBoss Tools) Issue Type: Sub-task Components: Build/Releng Reporter: Alexey Kazakov Assignee: Nick Boldt Fix For: 3.3.0.Beta1 I've created a new feature common/features/org.jboss.tools.common.mylyn.feature for o.j.t.common.mylyn plugin. Nick please include it into the aggregated update site. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 5 months

5
6
0 / 0

[JBoss JIRA] (JBIDE-10202) VPE has leaks of resources which results to "Unhandled event loop exception - org.eclipse.swt.SWTError: No more handles"

by Vitali Yemialyanchyk (Created) (JIRA)

VPE has leaks of resources which results to "Unhandled event loop exception - org.eclipse.swt.SWTError: No more handles" ------------------------------------------------------------------------------------------------------------------------ Key: JBIDE-10202 URL: https://issues.jboss.org/browse/JBIDE-10202 Project: Tools (JBoss Tools) Issue Type: Bug Components: Visual Page Editor core Affects Versions: 3.3.0.M4 Reporter: Vitali Yemialyanchyk Assignee: Yahor Radtsevich Priority: Critical Sometimes this issue leads to {code} Error Unhandled event loop exception org.eclipse.swt.SWTError: No more handles at org.eclipse.swt.SWT.error(SWT.java:4308) at org.eclipse.swt.SWT.error(SWT.java:4197) at org.eclipse.swt.SWT.error(SWT.java:4168) at org.eclipse.swt.widgets.Widget.error(Widget.java:468) at org.eclipse.swt.widgets.Control.createHandle(Control.java:704) at org.eclipse.swt.widgets.Composite.createHandle(Composite.java:305) at org.eclipse.swt.widgets.Control.createWidget(Control.java:744) at org.eclipse.swt.widgets.Scrollable.createWidget(Scrollable.java:134) at org.eclipse.swt.widgets.Control.<init>(Control.java:112) at org.eclipse.swt.widgets.Scrollable.<init>(Scrollable.java:75) {code} and only restart of whole eclipse can helps. ImageDescriptor -> createImage() - from documentation to this function: {code} * Creates and returns a new SWT image for this image descriptor. Note that * each call returns a new SWT image object. The returned image must be * explicitly disposed using the image's dispose call. The image will not be * automatically garbage collected. ... {code} here you create images, but did not dispose it: {code} at org.jboss.tools.vpe.editor.toolbar.format.TextFormattingToolBar.createItems(TextFormattingToolBar.java:180) {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 5 months

5
7
0 / 0

[JBoss JIRA] (JBIDE-10231) org.jboss.tools.common.model has potential Image leaks

by Vitali Yemialyanchyk (Created) (JIRA)

org.jboss.tools.common.model has potential Image leaks ------------------------------------------------------ Key: JBIDE-10231 URL: https://issues.jboss.org/browse/JBIDE-10231 Project: Tools (JBoss Tools) Issue Type: Sub-task Components: common/jst/core Affects Versions: 3.3.0.M4 Reporter: Vitali Yemialyanchyk Assignee: Alexey Kazakov Priority: Minor small note -> org.jboss.tools.common.model.icons.impl.XStudioIcons: {code} public Image getImage(XModelObject obj) { <---------------- this function create Image and does not dispose it - so real name should sounds like createImage(...) String s = obj.getAttributeValue("image"); //$NON-NLS-1$ byte[] b = decode(s); if(b != null) { try { ByteArrayInputStream is = new ByteArrayInputStream(b); ImageData id = new ImageData(is); Image i = new Image(null, id); <---- create image here return i; } catch (SWTException e) { ModelPlugin.getPluginLog().logError(e); } catch (SWTError e) { ModelPlugin.getPluginLog().logError(e); } } return obj.getModelEntity().getMetaModel().getIconList().getImage("default.unknown"); //$NON-NLS-1$ } {code} org.jboss.tools.common.model.icons.impl.XModelObjectIcon {code} private static Hashtable<String,Image> cacheEclipse = new Hashtable<String,Image>(); {code} all images which XStudioIcons creates --> in cacheEclipse. but what is happens if you reload org.jboss.tools.common.model plugin? I do not sure, but look like you'll get resource leak here. may be a better choise is to use AbstractUIPlugin.getImageRegistry(), i.e. ModelPlugin.getDefault().getImageRegistry() -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 5 months

4
4
0 / 0

[JBoss JIRA] (JBIDE-10229) org.jboss.tools.jst.css.dialog.ImageSelectionDialog has GC leaks logik

by Vitali Yemialyanchyk (Created) (JIRA)

org.jboss.tools.jst.css.dialog.ImageSelectionDialog has GC leaks logik ---------------------------------------------------------------------- Key: JBIDE-10229 URL: https://issues.jboss.org/browse/JBIDE-10229 Project: Tools (JBoss Tools) Issue Type: Sub-task Components: common/jst/core Affects Versions: 3.3.0.M4 Reporter: Vitali Yemialyanchyk Assignee: Alexey Kazakov {code} canvas.addPaintListener(new PaintListener() { public void paintControl(PaintEvent e) { GC gc = new GC(canvas); <-------------------------- here you create GC gc.setForeground(emptyColor); gc.fillRectangle(1, 1, canvas.getSize().x - 2, canvas.getSize().y - 2); // resolution.setText(""); resolution.setVisible(false); if (file != null) { <-------------------------- here you check condition Cursor parentCursor = getShell().getCursor(); final Cursor waitCursor = new Cursor(getShell().getDisplay(), SWT.CURSOR_WAIT); Point previewPoint = new Point(0, 0); Point labelPoint = canvas.getSize(); InputStream stream = null; try { getShell().setCursor(waitCursor); stream = new FileInputStream(file.getLocation().toOSString()); ImageData imageData = new ImageData(stream); stream.close(); if (imageData != null) { Image image = new Image(getShell().getDisplay(), imageData); // set image in center Point imagePoint = new Point(image.getBounds().width, image.getBounds().height); String imageInfo = imagePoint.x + " x " + imagePoint.y + " px"; //$NON-NLS-1$ //$NON-NLS-2$ // change resolution if image anymore image label if ((imagePoint.x > labelPoint.x) || (imagePoint.y > labelPoint.y)) { float ratioImage = (float) imagePoint.x / (float) imagePoint.y; if (((imagePoint.y > labelPoint.y) && ((labelPoint.y * ratioImage) > labelPoint.x)) || ((imagePoint.x > labelPoint.x) && ((labelPoint.x / ratioImage) < labelPoint.y))) { imageData = imageData.scaledTo(labelPoint.x - 10, (int) (labelPoint.x / ratioImage)); } else { imageData = imageData.scaledTo((int) (labelPoint.y * ratioImage) - 10, labelPoint.y); } image.dispose(); image = new Image(getShell().getDisplay(), imageData); imagePoint.x = image.getBounds().width; imagePoint.y = image.getBounds().height; } previewPoint.x = (labelPoint.x / 2) - (imagePoint.x / 2); previewPoint.y = (labelPoint.y / 2) - (imagePoint.y / 2); gc.drawImage(image, previewPoint.x, previewPoint.y); resolution.setVisible(true); resolution.setText(imageInfo); image.dispose(); gc.dispose(); <-------------------------- here you dispose } } catch (IOException ev) { //ignore } catch (SWTException ex) { //ignore (if select not image file) } finally { getShell().setCursor(parentCursor); if (stream != null) { try { stream.close(); } catch (IOException e1) { // ignore } } } } } }); {code} here is absolutely invalid logic, guys :) you close the stream in two places - try to find: stream.close(); I've check a history of changes: >>> PMD violations fixed. InputStreams close() added where it was possible. >>> 8/29/08 - someone try to close all streams where it possible, after that all of you respect his authority and afraid to fix his error... btw., you are still has a problems with "close of all streams", after 8/29/08 changes... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 5 months

5
5
0 / 0

[JBoss JIRA] (JBIDE-10242) org.jboss.tools.common.model.util.ModelImages has image leaks

by Vitali Yemialyanchyk (Created) (JIRA)

org.jboss.tools.common.model.util.ModelImages has image leaks ------------------------------------------------------------- Key: JBIDE-10242 URL: https://issues.jboss.org/browse/JBIDE-10242 Project: Tools (JBoss Tools) Issue Type: Sub-task Components: common/jst/core Affects Versions: 3.3.0.M4 Reporter: Vitali Yemialyanchyk Assignee: Alexey Kazakov from line 33: {code} public static Image getImage(String key) { return instance.createImageDescriptor(key).createImage(); } {code} try to inspect Call Hierarchy of the function - there are a lot of places with Image leak here. imo, getImage is not correct name here -> should be createImage in minimum, maximum is necessary to change logic. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 5 months

4
3
0 / 0

[JBoss JIRA] (JBIDE-10245) org.jboss.tools.common.model.ui has 8 places with Image leaks

by Vitali Yemialyanchyk (Created) (JIRA)

org.jboss.tools.common.model.ui has 8 places with Image leaks ------------------------------------------------------------- Key: JBIDE-10245 URL: https://issues.jboss.org/browse/JBIDE-10245 Project: Tools (JBoss Tools) Issue Type: Sub-task Components: common/jst/core Affects Versions: 3.3.0.M4 Reporter: Vitali Yemialyanchyk Assignee: Alexey Kazakov XModelObjectAction line 145: {code} item.setImage(eclipseAction.getImageDescriptor().createImage()); {code} LabelDecoratorImpl lines 53, 63: {code} i = d.createImage(); {code} - here is extra strange logic and you use: {code} public static Image emptyImage = ModelUIImages.getImage("empty_co.gif"); //$NON-NLS-1$ public static Image errorImage = ModelUIImages.getImage("error_co.gif"); //$NON-NLS-1$ public static Image warningImage = ModelUIImages.getImage("warning_co.gif"); //$NON-NLS-1$ List<ILabelProviderListener> listeners = new ArrayList<ILabelProviderListener>(); static Map<Image,Image> errorImages = new HashMap<Image,Image>(); static Map<Image,Image> warningImages = new HashMap<Image,Image>(); {code} - which are never disposed. AbstractQueryDialog line 46: {code} setTitleImage(ModelUIImages.getImageDescriptor(ModelUIImages.WIZARD_DEFAULT).createImage(null)); {code} AbstractQueryWizardView line 153: {code} titleDialog.setTitleImage(ModelUIImages.getImageDescriptor(ModelUIImages.WIZARD_DEFAULT).createImage(null)); {code} DefaultSpecialWizardDialog line 56: {code} this.setTitleImage(ModelUIImages.getImageDescriptor(ModelUIImages.WIZARD_DEFAULT).createImage(null)); {code} ModelUIImages lines 58 & 98: {code} public static Image getImage(String key) { <------------------ create Image not get if(ModelUIPlugin.isDebugEnabled()) { ModelUIPlugin.getPluginLog().logInfo("Create image for key '"+key+"'."); //$NON-NLS-1$ //$NON-NLS-2$ } return INSTANCE.createImageDescriptor(key).createImage(); } ... public Image getImageByFileName(String key) { <------------------ create Image not get return createImageDescriptor(key).createImage(); } {code} - is necessary to check all places where these methods call exist. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 5 months

5
4
0 / 0

[JBoss JIRA] (JBIDE-10246) org.jboss.tools.common.ui: org.jboss.tools.common.ui.marker.ConfigureProblemSeverityMarkerResolution

by Vitali Yemialyanchyk (Created) (JIRA)

org.jboss.tools.common.ui: org.jboss.tools.common.ui.marker.ConfigureProblemSeverityMarkerResolution ---------------------------------------------------------------------------------------------------- Key: JBIDE-10246 URL: https://issues.jboss.org/browse/JBIDE-10246 Project: Tools (JBoss Tools) Issue Type: Sub-task Components: common/jst/core Affects Versions: 3.3.0.M4 Reporter: Vitali Yemialyanchyk Assignee: Alexey Kazakov Priority: Critical line 63: {code} public Image getImage() { return JavaPluginImages.DESC_ELCL_CONFIGURE_PROBLEM_SEVERITIES.createImage(); } {code} - this image has no chance to be disposed. If page has a lot of problems markers, this could be critical. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 5 months

5
4
0 / 0

[JBoss JIRA] (JBIDE-10248) org.jboss.tools.jst.web.kb creates but never dispose images

by Vitali Yemialyanchyk (Created) (JIRA)

org.jboss.tools.jst.web.kb creates but never dispose images ----------------------------------------------------------- Key: JBIDE-10248 URL: https://issues.jboss.org/browse/JBIDE-10248 Project: Tools (JBoss Tools) Issue Type: Sub-task Components: common/jst/core Affects Versions: 3.3.0.M4 Reporter: Vitali Yemialyanchyk Assignee: Alexey Kazakov Priority: Minor in these classes: ActionProposalType, ConverterIDProposalType, ConverterIDProposalType, EnumerationProposalType, FacetNameProposalType, IDProposalType, ResourceBundleNameProposalType, ResourcePathProposalType you initialize {code} private static Image ICON; {code} field with new image, but never dispose it. imo may be a better to put these images in org.jboss.tools.jst.web.kb plugin image registry, so you can avoid image leak after plugin org.jboss.tools.jst.web.kb stop it's work. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 5 months

4
3
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jbosstools-issues November 2011