[JBoss JIRA] (JBIDE-13768) Server Fails to Start (Kinda) - Mixing of JRE6/JDK7 on Mac OS X
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13768?page=com.atlassian.jira.plugi... ]
Rob Stryker reassigned JBIDE-13768:
-----------------------------------
Assignee: Rob Stryker
> Server Fails to Start (Kinda) - Mixing of JRE6/JDK7 on Mac OS X
> ---------------------------------------------------------------
>
> Key: JBIDE-13768
> URL: https://issues.jboss.org/browse/JBIDE-13768
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: JBossAS/Servers
> Reporter: Burr Sutter
> Assignee: Rob Stryker
> Attachments: Error_Failed_to_start.png, failed_start.png, Installation1.png, runtime_JDK_7_selection.png, server_state_detectors.png
>
>
> My Mac has both the Apple Java 6 and Oracle Java 7 installed.
> If I take the defaults from the JBDS Installer, allowing it to pick a Java 6 JRE, but then manually adding a server with Java 7 - the IDE fails to see that the server started.
> Installation1.png - a screenshot of the defaults selected by the installer.
> This places the following in my jbdevstudio.ini
> -vm
> /Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home/bin/java
> and in About - Installation Details - Configuration:
> -vm
> /System/Library/Frameworks/JavaVM.framework
> Adding a New Server (EAP 6 or 6.1) - but selecting Java 7 for the Runtime - is where the IDE fails to see that the server has started (runtime_JDK_7_selection.png)
> The result is a failed start (failed_start.png)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 9 months
[JBoss JIRA] (JBIDE-13856) Test jQuery Mobile Palette Wizards on different platforms
by Max Rydahl Andersen (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13856?page=com.atlassian.jira.plugi... ]
Max Rydahl Andersen commented on JBIDE-13856:
---------------------------------------------
It seems we got a hard dependency on the browser starting in this wizard.
Can we make it optional so it will still start but just not show the nice preview ?
Any reason why it needs webkit specifically and not just load the native OS browser ?
> Test jQuery Mobile Palette Wizards on different platforms
> ---------------------------------------------------------
>
> Key: JBIDE-13856
> URL: https://issues.jboss.org/browse/JBIDE-13856
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: jsp/jsf/xml/html source editing
> Reporter: Daniel Azarov
> Assignee: Daniel Azarov
> Fix For: 4.1.0.Alpha2
>
> Attachments: ubuntu_64_button.png, ubuntu_64_checkboxes.png, ubuntu_64_cjeckbox.png, ubuntu_64_collapsible.png, ubuntu_64_dialog.png, ubuntu_64_footerbar.png, ubuntu_64_grid.png, ubuntu_64_headerbar.png, ubuntu_64_large_font_toggle.png, ubuntu_64_link.png, ubuntu_64_listview.png, ubuntu_64_navbar.png, ubuntu_64_page.png, ubuntu_64_radio.png, ubuntu_64_slider.png, ubuntu_64_textinput.png, ubuntu_64_toggle.png
>
>
> If system font size is set to large, wizard should take it into account.
> For instance:
> !ubuntu_64_large_font_toggle.png!
> Windows 8 32bit (Eclipse+Java) Base+JST+VPE+Xulrunner + Safari:
> jQuery Mobile Palette Widget Wizards work fine.
> Windows 8 64bit (Eclipse+Java) Base+JST+VPE+Xulrunner + Safari:
> Wizards do not start
> {code}
> org.eclipse.swt.SWTException: Failed to execute runnable (org.eclipse.swt.SWTError: No more handles [Safari must be installed to use a SWT.WEBKIT-style Browser])
> at org.eclipse.swt.SWT.error(SWT.java:4373)
> at org.eclipse.swt.SWT.error(SWT.java:4288)
> at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:138)
> at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4144)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3761)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1057)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:941)
> at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:79)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:588)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:543)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
> at org.eclipse.equinox.launcher.Main.main(Main.java:1426)
> Caused by: org.eclipse.swt.SWTError: No more handles [Safari must be installed to use a SWT.WEBKIT-style Browser]
> at org.eclipse.swt.SWT.error(SWT.java:4399)
> at org.eclipse.swt.browser.WebKit.create(WebKit.java:542)
> at org.eclipse.swt.browser.Browser.<init>(Browser.java:99)
> at org.jboss.tools.jst.web.ui.palette.html.wizard.AbstractNewHTMLWidgetWizardPage.createControl(AbstractNewHTMLWidgetWizardPage.java:139)
> at org.eclipse.jface.wizard.Wizard.createPageControls(Wizard.java:174)
> at org.eclipse.jface.wizard.WizardDialog.createPageControls(WizardDialog.java:736)
> at org.eclipse.jface.wizard.WizardDialog.createContents(WizardDialog.java:608)
> at org.eclipse.jface.window.Window.create(Window.java:431)
> at org.eclipse.jface.dialogs.Dialog.create(Dialog.java:1104)
> at org.jboss.tools.common.model.ui.editors.dnd.DropWizardDialog.create(DropWizardDialog.java:95)
> at org.eclipse.jface.window.Window.open(Window.java:790)
> at org.jboss.tools.common.model.ui.editors.dnd.DefaultDropCommand.execute(DefaultDropCommand.java:110)
> at org.jboss.tools.jst.jsp.jspeditor.JSPTextEditor$4.run(JSPTextEditor.java:757)
> at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
> at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
> ... 24 more
> {code}
> Windows 8 32 and 64 bits (Eclipse+Java) Base+JST + Safari:
> jQuery Mobile Palette Widget Wizards work without JavaScript.
> Windows 7 32 and 64 bits (Eclipse+Java) Base+JST + Safari:
> jQuery Mobile Palette Widget Wizards work without JavaScript.
> Windows 7 32 and 64 bit (Eclipse+Java) Base+JST+VPE+Xulrunner:
> jQuery Mobile Palette Widget Wizards work fine.
> Windows 7 32bit (Eclipse+Java) Base+JST+VPE+Xulrunner + Safari:
> jQuery Mobile Palette Widget Wizards work fine.
> Windows 7 32 and 64 bits (Eclipse+Java) Base+JST:
> Wizards do not start
> {code}
> org.eclipse.swt.SWTException: Failed to execute runnable (org.eclipse.swt.SWTError: No more handles [Safari must be installed to use a SWT.WEBKIT-style Browser])
> at org.eclipse.swt.SWT.error(SWT.java:4392)
> at org.eclipse.swt.SWT.error(SWT.java:4307)
> at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:138)
> at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4145)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3762)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1108)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:992)
> at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:137)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:600)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:555)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
> at org.eclipse.equinox.launcher.Main.main(Main.java:1426)
> Caused by: org.eclipse.swt.SWTError: No more handles [Safari must be installed to use a SWT.WEBKIT-style Browser]
> at org.eclipse.swt.SWT.error(SWT.java:4418)
> at org.eclipse.swt.browser.WebKit.create(WebKit.java:542)
> at org.eclipse.swt.browser.Browser.<init>(Browser.java:99)
> at org.jboss.tools.jst.web.ui.palette.html.wizard.AbstractNewHTMLWidgetWizardPage.createControl(AbstractNewHTMLWidgetWizardPage.java:139)
> at org.eclipse.jface.wizard.Wizard.createPageControls(Wizard.java:174)
> at org.eclipse.jface.wizard.WizardDialog.createPageControls(WizardDialog.java:736)
> at org.eclipse.jface.wizard.WizardDialog.createContents(WizardDialog.java:608)
> at org.eclipse.jface.window.Window.create(Window.java:432)
> at org.eclipse.jface.dialogs.Dialog.create(Dialog.java:1104)
> at org.jboss.tools.common.model.ui.editors.dnd.DropWizardDialog.create(DropWizardDialog.java:95)
> at org.eclipse.jface.window.Window.open(Window.java:791)
> at org.jboss.tools.common.model.ui.editors.dnd.DefaultDropCommand.execute(DefaultDropCommand.java:110)
> at org.jboss.tools.jst.jsp.jspeditor.JSPTextEditor$4.run(JSPTextEditor.java:757)
> at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
> at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
> ... 24 more
> {code}
> MacOs 64 bit (Eclipse+Java) Base+JST+VPE+Xulrunner:
> and
> MacOs 64 bit (Eclipse+Java) Base+JST:
> jQuery Mobile Palette Widget Wizards work fine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 9 months
[JBoss JIRA] (JBIDE-13411) JavaEE component job can take over 8hrs to run w/ tests - move out integration tests and rewrite them to avoid UI blocking
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13411?page=com.atlassian.jira.plugi... ]
Mickael Istria edited comment on JBIDE-13411 at 4/2/13 4:30 AM:
----------------------------------------------------------------
CI job for server test succeeds to make a full build (including dependency resolution fetched from download.jboss.org) in 4 to 20 minutes. For this job, we are speaking of several hours. That shows dependency resolution is not the bottleneck of this job.
Tests by themselves take long time. Isn't there a way to speed the up (using java.nio or some other code optimizations) ?
was (Author: mickael_istria):
CI job for server test succeeds to make a full build (including dependency resolution fetched from download.jboss.org) in 4 to 20 minutes. For this job, we are speaking of several hours. That shows dependency resolution is the bottleneck of this job.
Tests by themselves take long time. Isn't there a way to speed the up (using java.nio or some other code optimizations) ?
> JavaEE component job can take over 8hrs to run w/ tests - move out integration tests and rewrite them to avoid UI blocking
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-13411
> URL: https://issues.jboss.org/browse/JBIDE-13411
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: Build/Releng, Visual Page Editor Templates
> Affects Versions: 4.0.1.Final, 4.1.0.Alpha1
> Reporter: Nick Boldt
> Assignee: Denis Golovin
> Priority: Blocker
> Fix For: 4.1.x
>
> Attachments: tests-vs-tycho-build-time.png
>
>
> On a good day, tests will run and all pass in under 4hrs.
> On a grey day, tests will have failures but complete in under 6hrs.
> On a bad day, tests will stall out and the job will fail when it hits its duration upper limit of 8hrs.
> https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/DevStudio/view/DevS...
> https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/DevStudio/view/DevS...
> Surely some of these tests are:
> a) integration, not unit test, and should be relocated to https://github.com/jbosstools/jbosstools-integration-tests/ and run as part of a new job like https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-4.1_trunk... ?
> b) reliant on UI which is blocking, and should therefore be rewritten so as to not block test execution?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 9 months
[JBoss JIRA] (JBIDE-13411) JavaEE component job can take over 8hrs to run w/ tests - move out integration tests and rewrite them to avoid UI blocking
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13411?page=com.atlassian.jira.plugi... ]
Mickael Istria commented on JBIDE-13411:
----------------------------------------
[~maxandersen] > Talking with tycho guys they pointed out that surefire tests currently resolve TP twice - one at build startup and secondly for calculating TP per test run. Again a reason to look at being able to run tests against an existing eclipse install to avoid overhead of TP calculation.
Although I totally understand that there would be value in running tests from an Eclipse installation additionally to running them as "unit tests" as part of the build; I don't think it's a valid reason to speak about the "overhead of TP calculation".
Calculating a TP is something quite fast, about a few seconds. What takes time is to download artifacts from remote repositories. And since Tycho caches locally downloaded artifacts, it actually happen that an artifact is downloaded only once on a machine.
> JavaEE component job can take over 8hrs to run w/ tests - move out integration tests and rewrite them to avoid UI blocking
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-13411
> URL: https://issues.jboss.org/browse/JBIDE-13411
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: Build/Releng, Visual Page Editor Templates
> Affects Versions: 4.0.1.Final, 4.1.0.Alpha1
> Reporter: Nick Boldt
> Assignee: Denis Golovin
> Priority: Blocker
> Fix For: 4.1.x
>
> Attachments: tests-vs-tycho-build-time.png
>
>
> On a good day, tests will run and all pass in under 4hrs.
> On a grey day, tests will have failures but complete in under 6hrs.
> On a bad day, tests will stall out and the job will fail when it hits its duration upper limit of 8hrs.
> https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/DevStudio/view/DevS...
> https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/DevStudio/view/DevS...
> Surely some of these tests are:
> a) integration, not unit test, and should be relocated to https://github.com/jbosstools/jbosstools-integration-tests/ and run as part of a new job like https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-4.1_trunk... ?
> b) reliant on UI which is blocking, and should therefore be rewritten so as to not block test execution?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 9 months
[JBoss JIRA] (JBIDE-13888) openshift-java-client: make sure useragent is sent
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13888?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-13888 at 4/2/13 4:16 AM:
------------------------------------------------------------------
built against devenv, success:
https://ci.dev.openshift.redhat.com/jenkins/job/openshift-java-client-dev...
{code}
Tests run: 65, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ openshift-java-client ---
[INFO] Building jar: /var/lib/jenkins/jobs/openshift-java-client-devenv/workspace/openshift-java-client/target/openshift-java-client-2.1.0-SNAPSHOT.jar
[INFO]
[INFO] --- maven-source-plugin:2.1.2:jar-no-fork (attach-sources) @ openshift-java-client ---
[INFO] Building jar: /var/lib/jenkins/jobs/openshift-java-client-devenv/workspace/openshift-java-client/target/openshift-java-client-2.1.0-SNAPSHOT-sources.jar
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:50.508s
[INFO] Finished at: Tue Apr 02 04:09:48 EDT 2013
[INFO] Final Memory: 23M/182M
[INFO] ------------------------------------------------------------------------
{code}
was (Author: adietish):
built against devenv, success:
{code}
Tests run: 65, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ openshift-java-client ---
[INFO] Building jar: /var/lib/jenkins/jobs/openshift-java-client-devenv/workspace/openshift-java-client/target/openshift-java-client-2.1.0-SNAPSHOT.jar
[INFO]
[INFO] --- maven-source-plugin:2.1.2:jar-no-fork (attach-sources) @ openshift-java-client ---
[INFO] Building jar: /var/lib/jenkins/jobs/openshift-java-client-devenv/workspace/openshift-java-client/target/openshift-java-client-2.1.0-SNAPSHOT-sources.jar
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:50.508s
[INFO] Finished at: Tue Apr 02 04:09:48 EDT 2013
[INFO] Final Memory: 23M/182M
[INFO] ------------------------------------------------------------------------
{code}
> openshift-java-client: make sure useragent is sent
> --------------------------------------------------
>
> Key: JBIDE-13888
> URL: https://issues.jboss.org/browse/JBIDE-13888
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.1.0.Alpha2
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Fix For: 4.1.0.Alpha2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 9 months
[JBoss JIRA] (JBIDE-13888) openshift-java-client: make sure useragent is sent
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13888?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-13888:
------------------------------------------
built against devenv, success:
{code}
Tests run: 65, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ openshift-java-client ---
[INFO] Building jar: /var/lib/jenkins/jobs/openshift-java-client-devenv/workspace/openshift-java-client/target/openshift-java-client-2.1.0-SNAPSHOT.jar
[INFO]
[INFO] --- maven-source-plugin:2.1.2:jar-no-fork (attach-sources) @ openshift-java-client ---
[INFO] Building jar: /var/lib/jenkins/jobs/openshift-java-client-devenv/workspace/openshift-java-client/target/openshift-java-client-2.1.0-SNAPSHOT-sources.jar
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:50.508s
[INFO] Finished at: Tue Apr 02 04:09:48 EDT 2013
[INFO] Final Memory: 23M/182M
[INFO] ------------------------------------------------------------------------
{code}
> openshift-java-client: make sure useragent is sent
> --------------------------------------------------
>
> Key: JBIDE-13888
> URL: https://issues.jboss.org/browse/JBIDE-13888
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.1.0.Alpha2
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Fix For: 4.1.0.Alpha2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 9 months
[JBoss JIRA] (JBIDE-13888) openshift-java-client: make sure useragent is sent
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13888?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-13888 at 4/2/13 3:28 AM:
------------------------------------------------------------------
There is also very weird code in the UrlConnectionHttpClientBuilder which holds user-agent building logic. IMHO this logic should be in the rest service, not in the builder since the user-agent should get built correctly even if you create the client directly or use the builder:
{code:title=UrlConnectionHttpClientBuilder}
public IHttpClient client() {
if (authKey != null && authKey.trim().length() > 0) {
if (userAgent == null) {
userAgent = "OpenShift";
} else if (!userAgent.startsWith("OpenShift")) {
userAgent = "OpenShift-" + userAgent;
}
}
return new UrlConnectionHttpClient(username, password, userAgent,
sslChecks, requestMediaType, acceptedMediaType, version,
authKey, authIV);
}
{code}
To me the above code should get moved to the jenkins-client which requires this. I moved this to a new issue: JBIDE-13891
was (Author: adietish):
There is also very weird code in the UrlConnectionHttpClientBuilder which holds user-agent building logic. IMHO this logic should be in the rest service, not in the builder since the user-agent should get built correctly even if you create the client directly or use the builder:
{code:title=UrlConnectionHttpClientBuilder}
public IHttpClient client() {
if (authKey != null && authKey.trim().length() > 0) {
if (userAgent == null) {
userAgent = "OpenShift";
} else if (!userAgent.startsWith("OpenShift")) {
userAgent = "OpenShift-" + userAgent;
}
}
return new UrlConnectionHttpClient(username, password, userAgent,
sslChecks, requestMediaType, acceptedMediaType, version,
authKey, authIV);
}
{code}
> openshift-java-client: make sure useragent is sent
> --------------------------------------------------
>
> Key: JBIDE-13888
> URL: https://issues.jboss.org/browse/JBIDE-13888
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.1.0.Alpha2
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Fix For: 4.1.0.Alpha2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 9 months