[JBoss JIRA] (JBIDE-18036) Decouple FTL target language syntax coloring
by Jiri Peterka (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18036?page=com.atlassian.jira.plugi... ]
Jiri Peterka commented on JBIDE-18036:
--------------------------------------
No Max, this one is just about wrong syntax highlight around comment. Not critical for GA IMO. I'm quite fine when it's fixed in 4.2.1.
> Decouple FTL target language syntax coloring
> --------------------------------------------
>
> Key: JBIDE-18036
> URL: https://issues.jboss.org/browse/JBIDE-18036
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: freemarker
> Reporter: Peter Palaga
> Assignee: Peter Palaga
> Fix For: 4.2.1.Final
>
> Attachments: coloring-issues.png
>
>
> This issue covers the requirement formulated in point (1) of my earlier comment in [JBIDE-11287|https://issues.jboss.org/browse/JBIDE-11287?focusedCommentId=...].
> The present Freemarker plugin has a hard-coded XML/HTML syntax coloring. Although XML/HTML may well be the most common target language of an FTL template, it is clearly not the only possible target language. One can target virtually any language or even plaintext, where {{<}} and {{<!--}} may have completely different meanings or no meanigs at all. Hardcoding XML highlighting for every file opened by the FTL editor is thus simply incorrect.
> Let's define the present task as follows:
> (1) Decouple the syntax coloring of the target language of a FTL template by introducing an interface (call it {{TargetLanguageSupport}}) that will provide the general functionality needed for coloring of target languages.
> (2) At least two implementations of {{TargetLanguageSupport}} should be added:
> (2.1) XML/HTML and
> (2.2) plain text.
> (3) Some kind of target-language detection should be added, e.g. based on file extensions, making XML/HTML syntax coloring active for files ending with {{\*.xml.ftl}}, {{\*.xhtml.ftl}}, {{\*.html.ftl}} and {{\*.htm.ftl}}.
> (3.1) There should be a workspace-wide preference that will say for which file extensions will e.g. XML/HTML syntax coloring be active.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years
[JBoss JIRA] (JBIDE-18036) Decouple FTL target language syntax coloring
by Max Rydahl Andersen (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18036?page=com.atlassian.jira.plugi... ]
Max Rydahl Andersen commented on JBIDE-18036:
---------------------------------------------
@jpeterka any updates?
> Decouple FTL target language syntax coloring
> --------------------------------------------
>
> Key: JBIDE-18036
> URL: https://issues.jboss.org/browse/JBIDE-18036
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: freemarker
> Reporter: Peter Palaga
> Assignee: Peter Palaga
> Fix For: 4.2.1.Final
>
> Attachments: coloring-issues.png
>
>
> This issue covers the requirement formulated in point (1) of my earlier comment in [JBIDE-11287|https://issues.jboss.org/browse/JBIDE-11287?focusedCommentId=...].
> The present Freemarker plugin has a hard-coded XML/HTML syntax coloring. Although XML/HTML may well be the most common target language of an FTL template, it is clearly not the only possible target language. One can target virtually any language or even plaintext, where {{<}} and {{<!--}} may have completely different meanings or no meanigs at all. Hardcoding XML highlighting for every file opened by the FTL editor is thus simply incorrect.
> Let's define the present task as follows:
> (1) Decouple the syntax coloring of the target language of a FTL template by introducing an interface (call it {{TargetLanguageSupport}}) that will provide the general functionality needed for coloring of target languages.
> (2) At least two implementations of {{TargetLanguageSupport}} should be added:
> (2.1) XML/HTML and
> (2.2) plain text.
> (3) Some kind of target-language detection should be added, e.g. based on file extensions, making XML/HTML syntax coloring active for files ending with {{\*.xml.ftl}}, {{\*.xhtml.ftl}}, {{\*.html.ftl}} and {{\*.htm.ftl}}.
> (3.1) There should be a workspace-wide preference that will say for which file extensions will e.g. XML/HTML syntax coloring be active.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years
[JBoss JIRA] (JBIDE-18117) Unable to remove the JAX-RS facet on a Dynamic Web Project version 3.1
by Xavier Coulon (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18117?page=com.atlassian.jira.plugi... ]
Xavier Coulon edited comment on JBIDE-18117 at 9/30/14 9:33 AM:
----------------------------------------------------------------
Marking this issue as resolved since the patch was committed (see comment from Sept. 2nd) and Luna SR1 was released.
was (Author: xcoulon):
Marking this issue as resolved since the patch was committed (see comment from Sept. 11th) and Luna SR1 was released.
> Unable to remove the JAX-RS facet on a Dynamic Web Project version 3.1
> ----------------------------------------------------------------------
>
> Key: JBIDE-18117
> URL: https://issues.jboss.org/browse/JBIDE-18117
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: upstream, webservices
> Affects Versions: 4.2.0.Beta3
> Reporter: Xavier Coulon
> Assignee: Xavier Coulon
> Fix For: 4.2.0.CR2
>
>
> A bug in Eclipse WTP causes the following exception:
> {code}
> java.lang.ClassCastException: org.eclipse.jst.javaee.web.internal.impl.WebAppImpl cannot be cast to org.eclipse.jst.j2ee.webapplication.WebApp
> at org.eclipse.jst.ws.jaxrs.core.internal.project.facet.JAXRSFacetUninstallDelegate.uninstallJAXRSReferencesFromWebApp(JAXRSFacetUninstallDelegate.java:116)
> at org.eclipse.jst.ws.jaxrs.core.internal.project.facet.JAXRSFacetUninstallDelegate.execute(JAXRSFacetUninstallDelegate.java:85)
> at org.eclipse.wst.common.project.facet.core.internal.FacetedProject.callDelegate(FacetedProject.java:1477)
> at org.eclipse.wst.common.project.facet.core.internal.FacetedProject.modifyInternal(FacetedProject.java:441)
> at org.eclipse.wst.common.project.facet.core.internal.FacetedProject.mergeChangesInternal(FacetedProject.java:1181)
> at org.eclipse.wst.common.project.facet.core.internal.FacetedProject.access$2(FacetedProject.java:1117)
> at org.eclipse.wst.common.project.facet.core.internal.FacetedProject$5.run(FacetedProject.java:1099)
> at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2313)
> at org.eclipse.wst.common.project.facet.core.internal.FacetedProject.mergeChanges(FacetedProject.java:1109)
> at org.eclipse.wst.common.project.facet.core.internal.FacetedProjectWorkingCopy.commitChanges(FacetedProjectWorkingCopy.java:2020)
> at org.eclipse.wst.common.project.facet.ui.internal.FacetsPropertyPage$4.run(FacetsPropertyPage.java:232)
> at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2313)
> at org.eclipse.wst.common.project.facet.ui.internal.FacetsPropertyPage$5.run(FacetsPropertyPage.java:246)
> at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:122)
> {code}
> the problem comes from an evaluation that checks for dynamic project facet version 2.5 or 3.0 but not higher, in {{JAXRSJEEUtils#isWebApp25or40(Object)}}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years
[JBoss JIRA] (JBIDE-18036) Decouple FTL target language syntax coloring
by Max Rydahl Andersen (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18036?page=com.atlassian.jira.plugi... ]
Max Rydahl Andersen updated JBIDE-18036:
----------------------------------------
Fix Version/s: 4.2.1.Final
(was: 4.2.0.CR2)
> Decouple FTL target language syntax coloring
> --------------------------------------------
>
> Key: JBIDE-18036
> URL: https://issues.jboss.org/browse/JBIDE-18036
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: freemarker
> Reporter: Peter Palaga
> Assignee: Peter Palaga
> Fix For: 4.2.1.Final
>
> Attachments: coloring-issues.png
>
>
> This issue covers the requirement formulated in point (1) of my earlier comment in [JBIDE-11287|https://issues.jboss.org/browse/JBIDE-11287?focusedCommentId=...].
> The present Freemarker plugin has a hard-coded XML/HTML syntax coloring. Although XML/HTML may well be the most common target language of an FTL template, it is clearly not the only possible target language. One can target virtually any language or even plaintext, where {{<}} and {{<!--}} may have completely different meanings or no meanigs at all. Hardcoding XML highlighting for every file opened by the FTL editor is thus simply incorrect.
> Let's define the present task as follows:
> (1) Decouple the syntax coloring of the target language of a FTL template by introducing an interface (call it {{TargetLanguageSupport}}) that will provide the general functionality needed for coloring of target languages.
> (2) At least two implementations of {{TargetLanguageSupport}} should be added:
> (2.1) XML/HTML and
> (2.2) plain text.
> (3) Some kind of target-language detection should be added, e.g. based on file extensions, making XML/HTML syntax coloring active for files ending with {{\*.xml.ftl}}, {{\*.xhtml.ftl}}, {{\*.html.ftl}} and {{\*.htm.ftl}}.
> (3.1) There should be a workspace-wide preference that will say for which file extensions will e.g. XML/HTML syntax coloring be active.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years
[JBoss JIRA] (JBIDE-18117) Unable to remove the JAX-RS facet on a Dynamic Web Project version 3.1
by Xavier Coulon (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18117?page=com.atlassian.jira.plugi... ]
Xavier Coulon resolved JBIDE-18117.
-----------------------------------
Resolution: Done
Marking this issue as resolved since the patch was committed (see comment from Sept. 11th) and Luna SR1 was released.
> Unable to remove the JAX-RS facet on a Dynamic Web Project version 3.1
> ----------------------------------------------------------------------
>
> Key: JBIDE-18117
> URL: https://issues.jboss.org/browse/JBIDE-18117
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: upstream, webservices
> Affects Versions: 4.2.0.Beta3
> Reporter: Xavier Coulon
> Assignee: Xavier Coulon
> Fix For: 4.2.0.CR2
>
>
> A bug in Eclipse WTP causes the following exception:
> {code}
> java.lang.ClassCastException: org.eclipse.jst.javaee.web.internal.impl.WebAppImpl cannot be cast to org.eclipse.jst.j2ee.webapplication.WebApp
> at org.eclipse.jst.ws.jaxrs.core.internal.project.facet.JAXRSFacetUninstallDelegate.uninstallJAXRSReferencesFromWebApp(JAXRSFacetUninstallDelegate.java:116)
> at org.eclipse.jst.ws.jaxrs.core.internal.project.facet.JAXRSFacetUninstallDelegate.execute(JAXRSFacetUninstallDelegate.java:85)
> at org.eclipse.wst.common.project.facet.core.internal.FacetedProject.callDelegate(FacetedProject.java:1477)
> at org.eclipse.wst.common.project.facet.core.internal.FacetedProject.modifyInternal(FacetedProject.java:441)
> at org.eclipse.wst.common.project.facet.core.internal.FacetedProject.mergeChangesInternal(FacetedProject.java:1181)
> at org.eclipse.wst.common.project.facet.core.internal.FacetedProject.access$2(FacetedProject.java:1117)
> at org.eclipse.wst.common.project.facet.core.internal.FacetedProject$5.run(FacetedProject.java:1099)
> at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2313)
> at org.eclipse.wst.common.project.facet.core.internal.FacetedProject.mergeChanges(FacetedProject.java:1109)
> at org.eclipse.wst.common.project.facet.core.internal.FacetedProjectWorkingCopy.commitChanges(FacetedProjectWorkingCopy.java:2020)
> at org.eclipse.wst.common.project.facet.ui.internal.FacetsPropertyPage$4.run(FacetsPropertyPage.java:232)
> at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2313)
> at org.eclipse.wst.common.project.facet.ui.internal.FacetsPropertyPage$5.run(FacetsPropertyPage.java:246)
> at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:122)
> {code}
> the problem comes from an evaluation that checks for dynamic project facet version 2.5 or 3.0 but not higher, in {{JAXRSJEEUtils#isWebApp25or40(Object)}}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years
[JBoss JIRA] (JBIDE-18383) forge command rely on english description label to lookup commands - fragile!
by Fred Bricon (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18383?page=com.atlassian.jira.plugi... ]
Fred Bricon commented on JBIDE-18383:
-------------------------------------
+1 for using command ids. This will need a rebuild of the cheatsheet accordingly
> forge command rely on english description label to lookup commands - fragile!
> -----------------------------------------------------------------------------
>
> Key: JBIDE-18383
> URL: https://issues.jboss.org/browse/JBIDE-18383
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: forge
> Reporter: Max Rydahl Andersen
> Assignee: Koen Aers
> Priority: Critical
> Fix For: 4.2.0.CR2
>
>
> it seems this is the way forge commands are looked up:
> org.jboss.tools.forge.ui.runForgeCommand(org.jboss.tools.forge.ui.runForgeCommand.commandName=REST: Generate Endpoints From Entities)"
> meaning if description changes the cheatsheet breaks.
> should this not us a unique id or at least the cli command name so we have *one* API to obey to ?
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years