[JBoss JIRA] (JBIDE-21590) Explorer: OpenShift connection is not refreshed upon project deletion
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21590?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich commented on JBIDE-21590:
-----------------------------------------------
I have noticed a couple of things that may not cause this issue but be related.
OpenShiftExplorerContentProvider.getChildrenFor() for connection always creates and returns new instances of OpenShiftProjectUIModel together with new instance of DeploymentResourceMapper. If previous call for connection children already created such objects and they are in projectCache map, then they are just replaced and lost, but they are not disposed, mappper remains a listener to ConnectionsRegistry, and project adapter to mapper; so that it is a possible memory leak that also actively processes changes. Request for children certainly happens on action Refresh for connection. The adding/removing a connection causes complete content refresh so that project adapters for all projects of all connections will be recreated, leaving old objects lost but not disposed.
(Note that method BaseExplorerContentProvider.handleConnectionRemoved() is never called now, it may be called from ConnectionsRegistryListener.connectionRemoved() or removed as dead code.)
Now, closer to the issue. It seems possible that getChildrenFor() may be called twice, through launchLoadingJob() and directly by loadChildren() while loadedElements has stub. Then, projectCache may have the other set of project adapters for the connection than returned to viewer as children. If that might be the case, the rest is simple: handleProjectChanges() looks for project adapter by key (connection+project) and requests the viewer to remove it from parent connection node. But it is the wrong instance. Nevertheless, viewer still could remove it if OpenShiftProjectUIModel implemented hashCode() and equals() but it does not.
[~jcantrill], could you please look into my guesses. I may have missed something of course.
> Explorer: OpenShift connection is not refreshed upon project deletion
> ---------------------------------------------------------------------
>
> Key: JBIDE-21590
> URL: https://issues.jboss.org/browse/JBIDE-21590
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta2
> Reporter: Marián Labuda
> Labels: explorer, openshift_v3
>
> Upon deletion of a project under a connection in OpenShift explorer view, the deleted project is still visible.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 8 months
[JBoss JIRA] (JBIDE-20331) install grinder fails if blocked by Firefox
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-20331?page=com.atlassian.jira.plugi... ]
Nick Boldt updated JBIDE-20331:
-------------------------------
Attachment: naginator-reschedules.png
Now getting builds to reschedule when failing... result seems to be more blue balls:
!naginator-reschedules.png!
> install grinder fails if blocked by Firefox
> -------------------------------------------
>
> Key: JBIDE-20331
> URL: https://issues.jboss.org/browse/JBIDE-20331
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build
> Affects Versions: 4.3.0.Beta2
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 4.3.x, 4.4.0.Alpha1
>
> Attachments: build-history.png, build-history2.png, build-history3.png, ff-profile-manager.png, install-grinder-bad-firefox.jpeg, install-grinder-fail.txt, install-grinder-firefox-problem-testInstall(org.jboss.tools.tests.installation.InstallTest).jpeg, naginator-reschedules.png, new-firefox-block-UI_dev112.png, new-firefox-block-UI_dev59.png, virt1-ftl.png, virt2-ftl.png
>
>
> {code:title=http://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-install-grinder.install-tests.matrix_master/PROJECT=jbosstools,eclipseBundleVersion=mars.R,jdk=jdk1.8,label_exp=%28RHEL6||RHEL7||beaker||jboss-prod%29&&%28x86||x86_64%29/3157/consoleFull}
> 08:02:18 java.lang.RuntimeException: Unable to aquire PluginConverter service during generation for: /mnt/hudson_workspace/workspace/jbosstools-install-grinder.install-tests.matrix_master/d6768101/eclipse/plugins/org.eclipse.oomph.base_1.1.0.v20150609-0914.jar{code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 8 months
[JBoss JIRA] (JBIDE-21612) Explorer: Properly Handle deployer and pre/post hook pods
by Jeff Cantrill (JIRA)
Jeff Cantrill created JBIDE-21612:
-------------------------------------
Summary: Explorer: Properly Handle deployer and pre/post hook pods
Key: JBIDE-21612
URL: https://issues.jboss.org/browse/JBIDE-21612
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: openshift
Affects Versions: 4.3.1.Beta2
Reporter: Jeff Cantrill
Special pods are not associated with the deployment. We should be able to do that by looking at the annotation:
{{{
"kind": "Pod",
"apiVersion": "v1",
"metadata": {
"name": "database-1-deploy",
"namespace": "aaa",
"selfLink": "/api/v1/namespaces/aaa/pods/database-1-deploy",
"uid": "0162415c-c6c6-11e5-80fd-080027c5bfa9",
"resourceVersion": "55087",
"creationTimestamp": "2016-01-29T20:22:23Z",
"labels": {
"openshift.io/deployer-pod-for.name": "database-1"
},
"annotations": {
"openshift.io/deployment.name": "database-1",
"openshift.io/scc": "restricted"
}
},
}}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 8 months
[JBoss JIRA] (JBIDE-21601) p2director install should support excluding IUs like platform fragments and executables
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21601?page=com.atlassian.jira.plugi... ]
Nick Boldt updated JBIDE-21601:
-------------------------------
Fix Version/s: (was: 4.4.0.Alpha1)
> p2director install should support excluding IUs like platform fragments and executables
> ---------------------------------------------------------------------------------------
>
> Key: JBIDE-21601
> URL: https://issues.jboss.org/browse/JBIDE-21601
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 4.3.1.CR1, 4.4.0.Alpha1
>
>
> p2director install test should exclude things like executable.feature.group and org.eclipse.equinox.launcher.*
> {code}
> 01:27:34 [p2.dir] Cannot complete the install because of a conflicting dependency.
> 01:27:34 [p2.dir] Software being installed: Eclipse Platform Launcher Executables 3.6.200.v20151113-1733 (org.eclipse.equinox.executable.feature.group 3.6.200.v20151113-1733)
> 01:27:34 [p2.dir] Software currently installed: Eclipse IDE for Java EE Developers 4.6.0.20151218-1543 (epp.package.jee 4.6.0.20151218-1543)
> 01:27:34 [p2.dir] Only one of the following can be installed at once:
> 01:27:34 [p2.dir] Equinox Launcher Linux X86 Fragment 1.1.300.v20151013-1129 (org.eclipse.equinox.launcher.gtk.linux.x86 1.1.300.v20151013-1129)
> 01:27:34 [p2.dir] Equinox Launcher Linux X86 Fragment 1.1.300.v20160105-0945 (org.eclipse.equinox.launcher.gtk.linux.x86 1.1.300.v20160105-0945)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 8 months
[JBoss JIRA] (JBIDE-21601) p2director install should support excluding IUs like platform fragments and executables
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21601?page=com.atlassian.jira.plugi... ]
Nick Boldt updated JBIDE-21601:
-------------------------------
Fix Version/s: 4.4.0.Alpha1
> p2director install should support excluding IUs like platform fragments and executables
> ---------------------------------------------------------------------------------------
>
> Key: JBIDE-21601
> URL: https://issues.jboss.org/browse/JBIDE-21601
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 4.3.1.CR1, 4.4.0.Alpha1
>
>
> p2director install test should exclude things like executable.feature.group and org.eclipse.equinox.launcher.*
> {code}
> 01:27:34 [p2.dir] Cannot complete the install because of a conflicting dependency.
> 01:27:34 [p2.dir] Software being installed: Eclipse Platform Launcher Executables 3.6.200.v20151113-1733 (org.eclipse.equinox.executable.feature.group 3.6.200.v20151113-1733)
> 01:27:34 [p2.dir] Software currently installed: Eclipse IDE for Java EE Developers 4.6.0.20151218-1543 (epp.package.jee 4.6.0.20151218-1543)
> 01:27:34 [p2.dir] Only one of the following can be installed at once:
> 01:27:34 [p2.dir] Equinox Launcher Linux X86 Fragment 1.1.300.v20151013-1129 (org.eclipse.equinox.launcher.gtk.linux.x86 1.1.300.v20151013-1129)
> 01:27:34 [p2.dir] Equinox Launcher Linux X86 Fragment 1.1.300.v20160105-0945 (org.eclipse.equinox.launcher.gtk.linux.x86 1.1.300.v20160105-0945)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 8 months
[JBoss JIRA] (ERT-62) Refactor JSDT Code Completion [EBZ#486776]
by Nick Boldt (JIRA)
Nick Boldt created ERT-62:
-----------------------------
Summary: Refactor JSDT Code Completion [EBZ#486776]
Key: ERT-62
URL: https://issues.jboss.org/browse/ERT-62
Project: Eclipse Release Train
Issue Type: Task
Components: JSDT
Reporter: Nick Boldt
The current code completion modules depend on JSDT's current internal AST model, and type binding. JSDT will be disabling type binding and will be deprecating the internal AST model. As such, the code completion engine needs to be refactored in such a way that complies with the new AST model. JSDT is expected to provide an elegant and useful set of code completion suggestions.
A proposal base for the code completion engine should include, but is not necessarily limited to:
- Keywords
- Identifiers (declared variables and functions in currently open JS file)
- Recently used methods of functions (currently open JS file as a bare minimum)
All proposals should be made where they are deemed practical. ECMA5 keywords should be supported first.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 8 months
[JBoss JIRA] (ERT-64) Synchronization problems between IJSONModel and the editor. [EBZ#486861]
by Nick Boldt (JIRA)
Nick Boldt created ERT-64:
-----------------------------
Summary: Synchronization problems between IJSONModel and the editor. [EBZ#486861]
Key: ERT-64
URL: https://issues.jboss.org/browse/ERT-64
Project: Eclipse Release Train
Issue Type: Task
Components: WTP Source Editing
Reporter: Nick Boldt
Synchronization of the model is the main problem today with JSON Editor. It causes problem with completion which doesn't work after updating the JSON editor content because the model is not synchronized with the editor (if you close the editor and reopen it, completion works again)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 8 months