[JBoss JIRA] (JBIDE-23815) NPE in BuildConfigPropertySource.getResourcePropertyDescriptors
by Aurélien Pupier (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23815?page=com.atlassian.jira.plugi... ]
Aurélien Pupier updated JBIDE-23815:
------------------------------------
Component/s: openshift
> NPE in BuildConfigPropertySource.getResourcePropertyDescriptors
> ---------------------------------------------------------------
>
> Key: JBIDE-23815
> URL: https://issues.jboss.org/browse/JBIDE-23815
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.2.Final
> Reporter: Aurélien Pupier
>
> {noformat}
> !ENTRY org.eclipse.jface 4 2 2017-01-31 10:27:08.951
> !MESSAGE Problems occurred when invoking code from plug-in: "org.eclipse.jface".
> !STACK 0
> java.lang.NullPointerException
> at org.jboss.tools.openshift.internal.ui.property.BuildConfigPropertySource.getResourcePropertyDescriptors(BuildConfigPropertySource.java:56)
> at org.jboss.tools.openshift.internal.ui.property.ResourcePropertySource.getPropertyDescriptors(ResourcePropertySource.java:62)
> at org.eclipse.ui.views.properties.PropertySheetEntry.computeMergedPropertyDescriptors(PropertySheetEntry.java:171)
> at org.eclipse.ui.views.properties.PropertySheetEntry.refreshChildEntries(PropertySheetEntry.java:506)
> at org.eclipse.ui.views.properties.PropertySheetEntry.setValues(PropertySheetEntry.java:732)
> at org.eclipse.ui.views.properties.PropertySheetViewer.setInput(PropertySheetViewer.java:980)
> at org.eclipse.ui.views.properties.PropertySheetPage.selectionChanged(PropertySheetPage.java:525)
> at org.jboss.tools.openshift.internal.ui.property.tabbed.OpenShiftResourcePropertySection$2.selectionChanged(OpenShiftResourcePropertySection.java:140)
> at org.eclipse.jface.viewers.Viewer$1.run(Viewer.java:158)
> at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
> at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:50)
> at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:173)
> at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java:155)
> at org.eclipse.jface.viewers.StructuredViewer.updateSelection(StructuredViewer.java:2191)
> at org.eclipse.jface.viewers.StructuredViewer.handleSelect(StructuredViewer.java:1229)
> at org.eclipse.jface.viewers.StructuredViewer$4.widgetSelected(StructuredViewer.java:1258)
> at org.eclipse.jface.util.OpenStrategy.fireSelectionEvent(OpenStrategy.java:242)
> at org.eclipse.jface.util.OpenStrategy.access$4(OpenStrategy.java:236)
> at org.eclipse.jface.util.OpenStrategy$1.handleEvent(OpenStrategy.java:405)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4410)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4228)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3816)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1022)
> at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:150)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:687)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:604)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:138)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1519)
> at org.eclipse.equinox.launcher.Main.main(Main.java:1492)
> {noformat}
> here is the json available when I click "Edit" on the application:
> {noformat}
> {
> "metadata" : {
> "name" : "camel-ose-springboot-xml",
> "namespace" : "test1",
> "selfLink" : "/api/v1/namespaces/test1/services/camel-ose-springboot-xml",
> "uid" : "a28f19cd-e298-11e6-9637-525400ee9c8f",
> "resourceVersion" : "69156",
> "creationTimestamp" : "2017-01-25T00:53:07Z",
> "labels" : {
> "expose" : "true",
> "group" : "com.mycompany",
> "project" : "camel-ose-springboot-xml",
> "provider" : "fabric8",
> "version" : "1.0.0-SNAPSHOT"
> },
> "annotations" : {
> "fabric8.io/iconUrl" : "img/icons/camel.svg",
> "prometheus.io/port" : "9779",
> "prometheus.io/scrape" : "true"
> }
> },
> "spec" : {
> "ports" : [{
> "name" : "http",
> "protocol" : "TCP",
> "port" : 80,
> "targetPort" : 8080
> }],
> "selector" : {
> "group" : "com.mycompany",
> "project" : "camel-ose-springboot-xml",
> "provider" : "fabric8"
> },
> "portalIP" : "172.30.65.90",
> "clusterIP" : "172.30.65.90",
> "type" : "ClusterIP",
> "sessionAffinity" : "None"
> },
> "status" : {"loadBalancer" : {}},
> "kind" : "Service",
> "apiVersion" : "v1"
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 9 months
[JBoss JIRA] (JBDS-4257) rh-eclipse46-devstudio provides packages that are dependencies of rh-eclipse46
by Václav Kadlčík (JIRA)
[ https://issues.jboss.org/browse/JBDS-4257?page=com.atlassian.jira.plugin.... ]
Václav Kadlčík commented on JBDS-4257:
--------------------------------------
The last part sounds like I advocate to ignore the problem completely. That wasn't my intention :-) I just wanted to add some perspective for planning...
> rh-eclipse46-devstudio provides packages that are dependencies of rh-eclipse46
> ------------------------------------------------------------------------------
>
> Key: JBDS-4257
> URL: https://issues.jboss.org/browse/JBDS-4257
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: build, rpm
> Affects Versions: 10.3.0.AM2
> Environment: RHEL7
> Reporter: Lukáš Valach
> Assignee: Nick Boldt
> Priority: Minor
> Fix For: 10.3.0.GA
>
> Attachments: rh-eclipse46-devstudio_provides.txt, rh-eclipse46_provides.txt, yum_install_rh-eclipse46.png
>
>
> I noticed rh-eclipse46-devstudio is installed as dependenci when installing rh-eclipse46.
> !yum_install_rh-eclipse46.png|thumbnail!
> [~vkadlcik] said that it is because rh-eclipse46-devstudio offers some package which rh-eclipse46 needs, so yum decides to use devstudio as library.
> He said that the best practice for end-user application like rh-eclipse46-devstudio is to have less amount of stuff in "rpm -q --provides". Rh-eclipse46 provides 4 packages, devstudio provides 539 packages.
> [^rh-eclipse46_provides.txt]
> [^rh-eclipse46-devstudio_provides.txt]
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 9 months
[JBoss JIRA] (JBDS-4257) rh-eclipse46-devstudio provides packages that are dependencies of rh-eclipse46
by Václav Kadlčík (JIRA)
[ https://issues.jboss.org/browse/JBDS-4257?page=com.atlassian.jira.plugin.... ]
Václav Kadlčík commented on JBDS-4257:
--------------------------------------
{quote}You want the RPM to not "provide" the plugins that are contained in the RPM{quote}
Yes
{quote}including not providing all the stuff from jbosstools, the devstudio branding plugins{quote}
They can be declared as Provides, I mentioned that explicitly. But, in the end, it doesn't matter, because AFAIK there are no RPMs with matching Requires, hence YUM wouldn't care.
{quote}all the 3rd party stuff from Eclipse Orbit which is needed for the jbosstools/devstudio plugins and which are not available from other rh-eclipse46-* packages{quote}
The same situation. They can be declared in Provides but there's no use case for that at this moment. They just add maintenance burden - you should react on new Provides in all the RHSCL Eclipse RPMs and blacklist in Devstudio.
Please keep in mind that the RPM Requires/Provides declarations are just about the RPM dependency management, in practical terms, how YUM would resolve dependencies. I suppose we don't want Devstudio to serve as a dependency therefore its Provides should be as minimal as possible. Maybe it's been lost a bit in the discussion, but the original problem Lukáš reported was "rh-eclipse46-devstudio is installed as dependency when installing rh-eclipse46".
{quote}How would I do that? Can you suggest a PR for this spec file?{quote}
I'm sorry, not really. At a first glance, we'd need something subtler than java_common_find_provides_and_requires but please ask Mat or other dev.
{quote}By the way, re: "Rh-eclipse46 provides 4 packages, devstudio provides 539 packages" ... rh-eclipse46 is a meta-package which just wraps other packages. Maybe you should compare rh-eclipse46-devstudio to rh-eclipse46-base? or to rh-eclipse46-eclipse-cdt-native ?{quote}
(Lukáš wrote that but I think I know what he meant.) rh-eclipse46-base is designed to provide dependencies, we do want it be recognized by YUM as a provider and installed as a dependency, so the comparison with Devstudio does not hold. rh-eclipse46-eclipse-cdt-native is just an intermediate, you mean "top" level RPMs like rh-eclipse46-eclipse-cdt, -pydev, -dltk, I guess?
{{for i in cdt pydev dltk; do echo "= $i ="; rpm -q --provides rh-eclipse46-eclipse-$i | grep -v $i; done}}
Except for org.eclipse.tools.templates.* in cdt, they are quite clean. They aren't probable to be dragged by YUM as an unwanted dependency... I can see a difference against {{rpm -q --provides -p ~/rh-eclipse46-devstudio-10.3-0.20170126.0742.el7.x86_64.rpm | grep -v jboss}}.
At the end, I'd like to point out the context of the problem. It's not that big as it may seem from the discussion. To manifest, it needs several things at once:
* a user has Devstudio's YUM repository enabled but Devstudio not installed
* Devstudio RPM has something in Provides, let's call it X, which is served by some other RPM, too (and we prefer this other RPM as the provider)
* the user installs something which needs X
* YUM decides that the best provider for X is Devstudio
I estimate there aren't many users affected. Moreover, the situation can be resolved manually with a few yum commands. Finally, Devstudio RPMs is getting slimmer over time (more and more relying on rh-eclipse46-base) and the automatically generated Provides are getting thinner so the problem is in slow "self-healing". In summary, we do have some problem here but of a limited impact and not getting worse.
> rh-eclipse46-devstudio provides packages that are dependencies of rh-eclipse46
> ------------------------------------------------------------------------------
>
> Key: JBDS-4257
> URL: https://issues.jboss.org/browse/JBDS-4257
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: build, rpm
> Affects Versions: 10.3.0.AM2
> Environment: RHEL7
> Reporter: Lukáš Valach
> Assignee: Nick Boldt
> Priority: Minor
> Fix For: 10.3.0.GA
>
> Attachments: rh-eclipse46-devstudio_provides.txt, rh-eclipse46_provides.txt, yum_install_rh-eclipse46.png
>
>
> I noticed rh-eclipse46-devstudio is installed as dependenci when installing rh-eclipse46.
> !yum_install_rh-eclipse46.png|thumbnail!
> [~vkadlcik] said that it is because rh-eclipse46-devstudio offers some package which rh-eclipse46 needs, so yum decides to use devstudio as library.
> He said that the best practice for end-user application like rh-eclipse46-devstudio is to have less amount of stuff in "rpm -q --provides". Rh-eclipse46 provides 4 packages, devstudio provides 539 packages.
> [^rh-eclipse46_provides.txt]
> [^rh-eclipse46-devstudio_provides.txt]
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 9 months
[JBoss JIRA] (JBIDE-22228) NPE when deploying to Openshift EAP
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22228?page=com.atlassian.jira.plugi... ]
Jeff MAURY updated JBIDE-22228:
-------------------------------
Sprint: devex #127 February 2017
> NPE when deploying to Openshift EAP
> -----------------------------------
>
> Key: JBIDE-22228
> URL: https://issues.jboss.org/browse/JBIDE-22228
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.CR1
> Environment: Windows 10
> Reporter: Thomas Mäder
> Assignee: Jeff MAURY
> Fix For: 4.4.3.Final
>
>
> When I try to publish to an EAP in the CDK, I get a NullPointerException:
> {code}
> java.lang.NullPointerException
> at org.jboss.tools.openshift.core.server.OpenShiftServerUtils.getService(OpenShiftServerUtils.java:309)
> at org.jboss.tools.openshift.core.server.OpenShiftServerUtils.getService(OpenShiftServerUtils.java:298)
> at org.jboss.tools.openshift.core.server.OpenShiftServerUtils.getDeploymentConfig(OpenShiftServerUtils.java:390)
> at org.jboss.tools.openshift.core.server.behavior.OpenShiftLaunchController.launch(OpenShiftLaunchController.java:87)
> at org.jboss.ide.eclipse.as.wtp.core.server.launch.ControllableServerLaunchConfiguration.launch(ControllableServerLaunchConfiguration.java:52)
> at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:885)
> at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:739)
> at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:731)
> at org.eclipse.wst.server.core.internal.Server.startImpl2(Server.java:3556)
> at org.eclipse.wst.server.core.internal.Server.startImpl(Server.java:3492)
> at org.eclipse.wst.server.core.internal.Server$PublishJob.run(Server.java:311)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 9 months
[JBoss JIRA] (JBIDE-23490) Server adapter: provide ability to link pods when no service is available
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23490?page=com.atlassian.jira.plugi... ]
Jeff MAURY updated JBIDE-23490:
-------------------------------
Sprint: devex #126 January 2017 (was: devex #127 February 2017)
> Server adapter: provide ability to link pods when no service is available
> -------------------------------------------------------------------------
>
> Key: JBIDE-23490
> URL: https://issues.jboss.org/browse/JBIDE-23490
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: openshift
> Affects Versions: 4.4.2.AM3
> Reporter: Aurélien Pupier
> Assignee: Jeff MAURY
> Labels: new_and_noteworthy, openshift_v3, server_adapter, server_adapter_wizard
> Fix For: 4.4.3.Final
>
>
> When some OpenShift applications are not providing any services. the Eclipse OpenShift Tooling is not able to create an OpenShift server adapters to deploy new version of the application.
> The only that we are sure that will be always available are pods so it would be nice to provide some fallback logic that asks you to choose a pod or uses the only one it finds when there is no service provided.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 9 months
[JBoss JIRA] (JBIDE-23490) Server adapter: provide ability to link pods when no service is available
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23490?page=com.atlassian.jira.plugi... ]
Jeff MAURY updated JBIDE-23490:
-------------------------------
Sprint: devex #127 February 2017 (was: devex #126 January 2017)
> Server adapter: provide ability to link pods when no service is available
> -------------------------------------------------------------------------
>
> Key: JBIDE-23490
> URL: https://issues.jboss.org/browse/JBIDE-23490
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: openshift
> Affects Versions: 4.4.2.AM3
> Reporter: Aurélien Pupier
> Assignee: Jeff MAURY
> Labels: new_and_noteworthy, openshift_v3, server_adapter, server_adapter_wizard
> Fix For: 4.4.3.Final
>
>
> When some OpenShift applications are not providing any services. the Eclipse OpenShift Tooling is not able to create an OpenShift server adapters to deploy new version of the application.
> The only that we are sure that will be always available are pods so it would be nice to provide some fallback logic that asks you to choose a pod or uses the only one it finds when there is no service provided.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 9 months
[JBoss JIRA] (JBIDE-23490) Server adapter: provide ability to link pods when no service is available
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23490?page=com.atlassian.jira.plugi... ]
Jeff MAURY updated JBIDE-23490:
-------------------------------
Sprint: devex #127 February 2017 (was: devex #126 January 2017)
> Server adapter: provide ability to link pods when no service is available
> -------------------------------------------------------------------------
>
> Key: JBIDE-23490
> URL: https://issues.jboss.org/browse/JBIDE-23490
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: openshift
> Affects Versions: 4.4.2.AM3
> Reporter: Aurélien Pupier
> Assignee: Jeff MAURY
> Labels: new_and_noteworthy, openshift_v3, server_adapter, server_adapter_wizard
> Fix For: 4.4.3.Final
>
>
> When some OpenShift applications are not providing any services. the Eclipse OpenShift Tooling is not able to create an OpenShift server adapters to deploy new version of the application.
> The only that we are sure that will be always available are pods so it would be nice to provide some fallback logic that asks you to choose a pod or uses the only one it finds when there is no service provided.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 9 months