[JBoss JIRA] (JBIDE-24768) openshift connection wizard advanced section persists changes when canceled
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24768?page=com.atlassian.jira.plugi... ]
Martin Malina commented on JBIDE-24768:
---------------------------------------
[~adietish], that's odd. I *think* I tried this. Definitely before the patch, but I thought that I tried this also after the patch. Anyway, trying again now with a recent build of devstudio. And.... it works for me.
What specifically doesn't work for you? What I changed was the Cluster namespace field - from "openshift" to something else. And if I press finish, the new value will be there next time I open the edit dialog.
> openshift connection wizard advanced section persists changes when canceled
> ---------------------------------------------------------------------------
>
> Key: JBIDE-24768
> URL: https://issues.jboss.org/browse/JBIDE-24768
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.0.Final
> Reporter: Rob Stryker
> Assignee: Rob Stryker
> Fix For: 4.5.0.Final
>
>
> When you have an openshift connection, if you right-click on it and edit it, you can then change it's properties. If you expand the advanced section, and make changes, and then cancel the wizard, all changes are persisted when they should not be.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 3 months
[JBoss JIRA] (JBIDE-24781) Propose to create OpenShift server adapters automatically when creating application
by Mickael Istria (JIRA)
Mickael Istria created JBIDE-24781:
--------------------------------------
Summary: Propose to create OpenShift server adapters automatically when creating application
Key: JBIDE-24781
URL: https://issues.jboss.org/browse/JBIDE-24781
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: openshift
Reporter: Mickael Istria
I'm trying to push an Eclipse project as an OpenShift application with Red Hat Developer Studio. When I create the application, the wizard asks me for an Eclipse project. I would expect that a server adapter would be created by default for this project, or that at least creating a server adapter would be proposed automatically (but remain cancellable).
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 3 months
[JBoss JIRA] (JBIDE-24748) Enable Show In Console for cdk 3
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24748?page=com.atlassian.jira.plugi... ]
Martin Malina commented on JBIDE-24748:
---------------------------------------
[~rob.stryker], I didn't say the console doesn't show up automatically for cdk 3. What I said was that we didn't have any problem with JBoss servers, because the buggy path is not really a problem anyone would encounter normally. And that applies to cdk 3 as well - the console output will be shown during startup automatically. So from the beginning my only concern was the use case where you'd want to use Show In Console when the server is already up - this works for JBoss servers, but not for cdk 3.
> Enable Show In Console for cdk 3
> --------------------------------
>
> Key: JBIDE-24748
> URL: https://issues.jboss.org/browse/JBIDE-24748
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk
> Affects Versions: 4.5.0.AM2
> Reporter: Martin Malina
> Assignee: Rob Stryker
> Fix For: 4.5.0.Final
>
>
> CDK 2 used the Terminal view, CDK 3 switched back to usiong Console view. So Show In Console on the server adapter should be enabled.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 3 months
[JBoss JIRA] (JBIDE-24774) ClassCastException while creating new Openshift connection
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24774?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-24774:
-------------------------------------
Issue is in AdvancedConnectionEditor
public Map<String, Object> getExtendedProperties() {
if( map != null ) {
return map;
}
IConnection connection = pageModel.getSelectedConnection();
if( connection != null ) {
map = ((Connection)connection).getExtendedProperties();
return map;
}
return null;
}
In this case, connection is the fake connection for a 'new' connection. I'll investigate a fix.
> ClassCastException while creating new Openshift connection
> ----------------------------------------------------------
>
> Key: JBIDE-24774
> URL: https://issues.jboss.org/browse/JBIDE-24774
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Reporter: Dmitrii Bocharov
> Assignee: Rob Stryker
> Priority: Blocker
> Fix For: 4.5.0.Final
>
> Attachments: screencast.webm
>
>
> {code:java}
> java.lang.RuntimeException: java.lang.ClassCastException: org.jboss.tools.openshift.common.core.connection.NewConnectionMarker cannot be cast to org.jboss.tools.openshift.core.connection.Connection
> at org.eclipse.core.internal.databinding.beans.BeanPropertyHelper.readProperty(BeanPropertyHelper.java:102)
> at org.eclipse.core.internal.databinding.beans.BeanValueProperty.doGetValue(BeanValueProperty.java:49)
> at org.eclipse.core.databinding.property.value.ValueProperty.getValue(ValueProperty.java:62)
> at org.eclipse.core.internal.databinding.property.value.SimplePropertyObservableValue.notifyIfChanged(SimplePropertyObservableValue.java:121)
> at org.eclipse.core.internal.databinding.property.value.SimplePropertyObservableValue.doGetValue(SimplePropertyObservableValue.java:102)
> at org.eclipse.core.databinding.observable.value.AbstractObservableValue.getValue(AbstractObservableValue.java:88)
> at org.eclipse.core.databinding.observable.value.DecoratingObservableValue.getValue(DecoratingObservableValue.java:109)
> at org.eclipse.core.databinding.observable.value.DecoratingObservableValue.getValue(DecoratingObservableValue.java:109)
> at org.eclipse.core.databinding.ValueBinding$3.run(ValueBinding.java:169)
> at org.eclipse.core.databinding.observable.Realm$1.run(Realm.java:149)
> at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
> at org.eclipse.core.databinding.observable.Realm.safeRun(Realm.java:153)
> at org.eclipse.core.databinding.observable.Realm.exec(Realm.java:171)
> at org.eclipse.core.databinding.ValueBinding.doUpdate(ValueBinding.java:162)
> at org.eclipse.core.databinding.ValueBinding.updateModelToTarget(ValueBinding.java:127)
> at org.eclipse.core.databinding.DataBindingContext.updateTargets(DataBindingContext.java:464)
> at org.jboss.tools.common.ui.WizardUtils.runInWizard(WizardUtils.java:216)
> at org.jboss.tools.openshift.internal.common.ui.connection.ConnectionWizardPage.connect(ConnectionWizardPage.java:385)
> at org.jboss.tools.openshift.internal.common.ui.connection.ConnectionWizard.performFinish(ConnectionWizard.java:77)
> at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:778)
> at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:417)
> at org.eclipse.jface.dialogs.Dialog.lambda$0(Dialog.java:619)
> at org.eclipse.swt.events.SelectionListener$1.widgetSelected(SelectionListener.java:81)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:249)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:86)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:5252)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1348)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4522)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4107)
> at org.eclipse.jface.window.Window.runEventLoop(Window.java:818)
> at org.eclipse.jface.window.Window.open(Window.java:794)
> at org.jboss.tools.openshift.internal.common.ui.explorer.OpenShiftExplorerView$2.widgetSelected(OpenShiftExplorerView.java:140)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:249)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:86)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:5252)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1348)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1374)
> at org.eclipse.swt.widgets.Widget.sendSelectionEvent(Widget.java:1488)
> at org.eclipse.swt.widgets.Link.gtk_button_release_event(Link.java:384)
> at org.eclipse.swt.widgets.Widget.windowProc(Widget.java:1956)
> at org.eclipse.swt.widgets.Control.windowProc(Control.java:6168)
> at org.eclipse.swt.widgets.Display.windowProc(Display.java:5512)
> at org.eclipse.swt.internal.gtk.OS._gtk_main_do_event(Native Method)
> at org.eclipse.swt.internal.gtk.OS.gtk_main_do_event(OS.java:9251)
> at org.eclipse.swt.widgets.Display.eventProc(Display.java:1252)
> at org.eclipse.swt.internal.gtk.OS._g_main_context_iteration(Native Method)
> at org.eclipse.swt.internal.gtk.OS.g_main_context_iteration(OS.java:2110)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4105)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1155)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1044)
> at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153)
> at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:680)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:594)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:151)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.refle
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 3 months
[JBoss JIRA] (JBIDE-24780) Creatinng an OpenShift server adapter should suggest placing Web facet on related project(s)
by Mickael Istria (JIRA)
Mickael Istria created JBIDE-24780:
--------------------------------------
Summary: Creatinng an OpenShift server adapter should suggest placing Web facet on related project(s)
Key: JBIDE-24780
URL: https://issues.jboss.org/browse/JBIDE-24780
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: openshift
Reporter: Mickael Istria
I've created an OpenShift Application from Eclipse IDE providing it an Eclipse Project as input.
Then I tried to create a server adapter for this project. It didn't work initially because the project isn't a Faceted Web project. I had to quit the OpenShift wizard, make the project a faceted one and restart the wizard.
I would expect the wizard to create a server adapter to suggest and link to a way to make the project associated with the application a web project in Eclipse IDE so it's one less step to understand for users before it works.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 3 months
[JBoss JIRA] (JBIDE-24774) ClassCastException while creating new Openshift connection
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24774?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-24774:
------------------------------------------
When fixining this in a minimal way (https://github.com/jbosstools/jbosstools-openshift/pull/1533) - which allows me to verify JBIDE-24768 - I dont see extended properties being saved as it is expected.
> ClassCastException while creating new Openshift connection
> ----------------------------------------------------------
>
> Key: JBIDE-24774
> URL: https://issues.jboss.org/browse/JBIDE-24774
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Reporter: Dmitrii Bocharov
> Assignee: Rob Stryker
> Priority: Blocker
> Fix For: 4.5.0.Final
>
> Attachments: screencast.webm
>
>
> {code:java}
> java.lang.RuntimeException: java.lang.ClassCastException: org.jboss.tools.openshift.common.core.connection.NewConnectionMarker cannot be cast to org.jboss.tools.openshift.core.connection.Connection
> at org.eclipse.core.internal.databinding.beans.BeanPropertyHelper.readProperty(BeanPropertyHelper.java:102)
> at org.eclipse.core.internal.databinding.beans.BeanValueProperty.doGetValue(BeanValueProperty.java:49)
> at org.eclipse.core.databinding.property.value.ValueProperty.getValue(ValueProperty.java:62)
> at org.eclipse.core.internal.databinding.property.value.SimplePropertyObservableValue.notifyIfChanged(SimplePropertyObservableValue.java:121)
> at org.eclipse.core.internal.databinding.property.value.SimplePropertyObservableValue.doGetValue(SimplePropertyObservableValue.java:102)
> at org.eclipse.core.databinding.observable.value.AbstractObservableValue.getValue(AbstractObservableValue.java:88)
> at org.eclipse.core.databinding.observable.value.DecoratingObservableValue.getValue(DecoratingObservableValue.java:109)
> at org.eclipse.core.databinding.observable.value.DecoratingObservableValue.getValue(DecoratingObservableValue.java:109)
> at org.eclipse.core.databinding.ValueBinding$3.run(ValueBinding.java:169)
> at org.eclipse.core.databinding.observable.Realm$1.run(Realm.java:149)
> at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
> at org.eclipse.core.databinding.observable.Realm.safeRun(Realm.java:153)
> at org.eclipse.core.databinding.observable.Realm.exec(Realm.java:171)
> at org.eclipse.core.databinding.ValueBinding.doUpdate(ValueBinding.java:162)
> at org.eclipse.core.databinding.ValueBinding.updateModelToTarget(ValueBinding.java:127)
> at org.eclipse.core.databinding.DataBindingContext.updateTargets(DataBindingContext.java:464)
> at org.jboss.tools.common.ui.WizardUtils.runInWizard(WizardUtils.java:216)
> at org.jboss.tools.openshift.internal.common.ui.connection.ConnectionWizardPage.connect(ConnectionWizardPage.java:385)
> at org.jboss.tools.openshift.internal.common.ui.connection.ConnectionWizard.performFinish(ConnectionWizard.java:77)
> at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:778)
> at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:417)
> at org.eclipse.jface.dialogs.Dialog.lambda$0(Dialog.java:619)
> at org.eclipse.swt.events.SelectionListener$1.widgetSelected(SelectionListener.java:81)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:249)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:86)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:5252)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1348)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4522)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4107)
> at org.eclipse.jface.window.Window.runEventLoop(Window.java:818)
> at org.eclipse.jface.window.Window.open(Window.java:794)
> at org.jboss.tools.openshift.internal.common.ui.explorer.OpenShiftExplorerView$2.widgetSelected(OpenShiftExplorerView.java:140)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:249)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:86)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:5252)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1348)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1374)
> at org.eclipse.swt.widgets.Widget.sendSelectionEvent(Widget.java:1488)
> at org.eclipse.swt.widgets.Link.gtk_button_release_event(Link.java:384)
> at org.eclipse.swt.widgets.Widget.windowProc(Widget.java:1956)
> at org.eclipse.swt.widgets.Control.windowProc(Control.java:6168)
> at org.eclipse.swt.widgets.Display.windowProc(Display.java:5512)
> at org.eclipse.swt.internal.gtk.OS._gtk_main_do_event(Native Method)
> at org.eclipse.swt.internal.gtk.OS.gtk_main_do_event(OS.java:9251)
> at org.eclipse.swt.widgets.Display.eventProc(Display.java:1252)
> at org.eclipse.swt.internal.gtk.OS._g_main_context_iteration(Native Method)
> at org.eclipse.swt.internal.gtk.OS.g_main_context_iteration(OS.java:2110)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4105)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1155)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1044)
> at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153)
> at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:680)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:594)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:151)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.refle
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 3 months
[JBoss JIRA] (JBIDE-24768) openshift connection wizard advanced section persists changes when canceled
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24768?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-24768 at 7/31/17 11:25 AM:
--------------------------------------------------------------------
[~rob.stryker] [~mmalina] [~rhopp] after the patch, cancel indeed wont save the changes. But "Finish" wont save them either (for me).
was (Author: adietish):
[~rob.stryker] [~mmalina] cancel indeed wont save the changes, but "Finish" wont save them either (for me).
> openshift connection wizard advanced section persists changes when canceled
> ---------------------------------------------------------------------------
>
> Key: JBIDE-24768
> URL: https://issues.jboss.org/browse/JBIDE-24768
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.0.Final
> Reporter: Rob Stryker
> Assignee: Rob Stryker
> Fix For: 4.5.0.Final
>
>
> When you have an openshift connection, if you right-click on it and edit it, you can then change it's properties. If you expand the advanced section, and make changes, and then cancel the wizard, all changes are persisted when they should not be.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 3 months
[JBoss JIRA] (JBIDE-24768) openshift connection wizard advanced section persists changes when canceled
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24768?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-24768 at 7/31/17 11:25 AM:
--------------------------------------------------------------------
[~rob.stryker] [~rhopp] after the patch, cancel indeed wont save the changes. But "Finish" wont save them either (for me).
was (Author: adietish):
[~rob.stryker] [~mmalina] [~rhopp] after the patch, cancel indeed wont save the changes. But "Finish" wont save them either (for me).
> openshift connection wizard advanced section persists changes when canceled
> ---------------------------------------------------------------------------
>
> Key: JBIDE-24768
> URL: https://issues.jboss.org/browse/JBIDE-24768
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.0.Final
> Reporter: Rob Stryker
> Assignee: Rob Stryker
> Fix For: 4.5.0.Final
>
>
> When you have an openshift connection, if you right-click on it and edit it, you can then change it's properties. If you expand the advanced section, and make changes, and then cancel the wizard, all changes are persisted when they should not be.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 3 months
[JBoss JIRA] (JBIDE-24768) openshift connection wizard advanced section persists changes when canceled
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24768?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-24768:
------------------------------------------
[~rob.stryker] [~mmalina] cancel indeed wont save the changes, but "Finish" wont save them either (for me).
> openshift connection wizard advanced section persists changes when canceled
> ---------------------------------------------------------------------------
>
> Key: JBIDE-24768
> URL: https://issues.jboss.org/browse/JBIDE-24768
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.0.Final
> Reporter: Rob Stryker
> Assignee: Rob Stryker
> Fix For: 4.5.0.Final
>
>
> When you have an openshift connection, if you right-click on it and edit it, you can then change it's properties. If you expand the advanced section, and make changes, and then cancel the wizard, all changes are persisted when they should not be.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 3 months