[JBoss JIRA] (JBIDE-24733) WTP reorganization
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24733?page=com.atlassian.jira.plugi... ]
Rob Stryker updated JBIDE-24733:
--------------------------------
Fix Version/s: 4.6.0.AM1
> WTP reorganization
> ------------------
>
> Key: JBIDE-24733
> URL: https://issues.jboss.org/browse/JBIDE-24733
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: upstream
> Affects Versions: 4.5.x
> Reporter: Rob Stryker
> Assignee: Rob Stryker
> Fix For: 4.6.0.AM1
>
>
> Webtools (upstream project) is in sorry shape and needs a lot of things. First, it needs a proper build system, including jobs. To make this less painful, consolidating repositories is also encouraged. Making sure the monolith gets broken up into proper swimlanes is also a necessity.
> Finally, once the plugins are properly organized and swim-laned, lots of attention will need to be paid to the features and tests. Right now most tests appear to be full product integration tests, no matter what repo they live in.
> There's a lot of work to do.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 10 months
[JBoss JIRA] (JBIDE-25674) NPE in JolokiaConnectionWrapper.extractStatus
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25674?page=com.atlassian.jira.plugi... ]
Rob Stryker updated JBIDE-25674:
--------------------------------
Fix Version/s: 4.5.3.AM1
> NPE in JolokiaConnectionWrapper.extractStatus
> ---------------------------------------------
>
> Key: JBIDE-25674
> URL: https://issues.jboss.org/browse/JBIDE-25674
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: jmx
> Reporter: Aurélien Pupier
> Fix For: 4.5.3.AM1
>
>
> {noformat}
> !ENTRY org.eclipse.core.jobs 4 2 2018-01-29 15:56:34.020
> !MESSAGE An internal error occurred during: "Connect Job".
> !STACK 0
> java.lang.NullPointerException
> at org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.extractStatus(JolokiaConnectionWrapper.java:340)
> at org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.verifyServerReachable(JolokiaConnectionWrapper.java:324)
> at org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.connect(JolokiaConnectionWrapper.java:113)
> at org.jboss.tools.jmx.core.ConnectJob.run(ConnectJob.java:29)
> at org.jboss.tools.jmx.ui.internal.actions.DoubleClickAction$1.run(DoubleClickAction.java:71)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:56)
> {noformat}
> I put a breakpoint in org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.verifyServerReachable() to see which exception it was and it is a "503 Service Unavailable"
> in this case the "response" is null
> 2 possibilities:
> - it is normal that it is null in this case Jboss Tools need to handle this case
> - it is not normal that it is null and in this case, it needs to be reported upstream (even if a null check might nice as a workaround for now)
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 10 months
[JBoss JIRA] (JBIDE-25674) NPE in JolokiaConnectionWrapper.extractStatus
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25674?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-25674:
-------------------------------------
Would you be able to list full steps? CDK version, environment, etc?
> NPE in JolokiaConnectionWrapper.extractStatus
> ---------------------------------------------
>
> Key: JBIDE-25674
> URL: https://issues.jboss.org/browse/JBIDE-25674
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: jmx
> Reporter: Aurélien Pupier
>
> {noformat}
> !ENTRY org.eclipse.core.jobs 4 2 2018-01-29 15:56:34.020
> !MESSAGE An internal error occurred during: "Connect Job".
> !STACK 0
> java.lang.NullPointerException
> at org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.extractStatus(JolokiaConnectionWrapper.java:340)
> at org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.verifyServerReachable(JolokiaConnectionWrapper.java:324)
> at org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.connect(JolokiaConnectionWrapper.java:113)
> at org.jboss.tools.jmx.core.ConnectJob.run(ConnectJob.java:29)
> at org.jboss.tools.jmx.ui.internal.actions.DoubleClickAction$1.run(DoubleClickAction.java:71)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:56)
> {noformat}
> I put a breakpoint in org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.verifyServerReachable() to see which exception it was and it is a "503 Service Unavailable"
> in this case the "response" is null
> 2 possibilities:
> - it is normal that it is null in this case Jboss Tools need to handle this case
> - it is not normal that it is null and in this case, it needs to be reported upstream (even if a null check might nice as a workaround for now)
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 10 months
[JBoss JIRA] (JBIDE-25674) NPE in JolokiaConnectionWrapper.extractStatus
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25674?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-25674:
-------------------------------------
[~aurelien.pupier] I've updated my patch a bit with your new added information, however, I *still* feel like I don't have enough information to submit a proper bug report upstream.
What we know is there is a HttpResponse, and the jolokia libraries are trying to parse the stream into JSON. The parse fails, and so it resorts to the status line instead, and throws an exception that doesn't have a JSONObject pJsonRespObject (because the parse failed, so no such object exists).
However, we still don't know what was in the actual stream. What we can assume is that the stream wasn't valid JSON, but we still have no idea what the stream contained. This is a critical bit of information before we open a bug report upstream. We need to know what the actual response is.
To actually get at what request was made, we'd need to set a breakpoint in J4pRequestHandler and exactly what type of org.apache.http.* request they're making, then make an identical request in a Main class of our own, and read the stream. Alternatively, we could come up with a curl request or something similar.
Unfortunately I can't replicate your usecase, so I'm not quite sure what to do here. It'd be very helpful if we could determine what exactly is in the stream. I'll look to see if eventually I can make a main class that does a similar request.
> NPE in JolokiaConnectionWrapper.extractStatus
> ---------------------------------------------
>
> Key: JBIDE-25674
> URL: https://issues.jboss.org/browse/JBIDE-25674
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: jmx
> Reporter: Aurélien Pupier
>
> {noformat}
> !ENTRY org.eclipse.core.jobs 4 2 2018-01-29 15:56:34.020
> !MESSAGE An internal error occurred during: "Connect Job".
> !STACK 0
> java.lang.NullPointerException
> at org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.extractStatus(JolokiaConnectionWrapper.java:340)
> at org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.verifyServerReachable(JolokiaConnectionWrapper.java:324)
> at org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.connect(JolokiaConnectionWrapper.java:113)
> at org.jboss.tools.jmx.core.ConnectJob.run(ConnectJob.java:29)
> at org.jboss.tools.jmx.ui.internal.actions.DoubleClickAction$1.run(DoubleClickAction.java:71)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:56)
> {noformat}
> I put a breakpoint in org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.verifyServerReachable() to see which exception it was and it is a "503 Service Unavailable"
> in this case the "response" is null
> 2 possibilities:
> - it is normal that it is null in this case Jboss Tools need to handle this case
> - it is not normal that it is null and in this case, it needs to be reported upstream (even if a null check might nice as a workaround for now)
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 10 months
[JBoss JIRA] (ERT-602) [templates] Templates for empty .java files [EBZ#505610]
by Friendly Jira Robot (JIRA)
Friendly Jira Robot created ERT-602:
---------------------------------------
Summary: [templates] Templates for empty .java files [EBZ#505610]
Key: ERT-602
URL: https://issues.jboss.org/browse/ERT-602
Project: Eclipse Release Train
Issue Type: Task
Components: JDT
Reporter: Friendly Jira Robot
Priority: Trivial
Assuming someone tries content-assist on an empty .java file, it would be nice to show templates such as "Create new class <fileName>", "Create new interface <fileName>", "Create new enum <fileName>"... that would scaffold a minimal content (packange and object declaration at least).
Or maybe those completion items could directly open the right New wizard without leaving opportunity to change the name and let the wizard perform the change.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 10 months
[JBoss JIRA] (ERT-537) Update to com.spotify.docker.client 8.9.2 [EBZ#522659]
by Roland Grunberg (JIRA)
[ https://issues.jboss.org/browse/ERT-537?page=com.atlassian.jira.plugin.sy... ]
Roland Grunberg commented on ERT-537:
-------------------------------------
CQs and ATO CQs have all been filed and approved so I just need to carve out some time to rebase, and push.
> Update to com.spotify.docker.client 8.9.2 [EBZ#522659]
> ------------------------------------------------------
>
> Key: ERT-537
> URL: https://issues.jboss.org/browse/ERT-537
> Project: Eclipse Release Train
> Issue Type: Task
> Components: Linux Tools
> Reporter: Friendly Jira Robot
> Assignee: Roland Grunberg
> Labels: Docker, bzira
>
> This is currently the latest upstream version of docker-client. There are also some API breaking changes, so aside from just bringing a newer version into Orbit, we'll also need to update the sources.
> (/) Update Jackson 2.9.2 Stack in Orbit (from 2.6.2)
> (/) Confirm the changes made should allow Docker Tooling to function
> (/) Create CQs, ATO CQs for JNR stack update
> (?) Update JNR stack, along with docker-client in Orbit
> (?) Push all changes necessary to Docker Tooling
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 10 months
[JBoss JIRA] (ERT-537) Update to com.spotify.docker.client 8.9.2 [EBZ#522659]
by Roland Grunberg (JIRA)
[ https://issues.jboss.org/browse/ERT-537?page=com.atlassian.jira.plugin.sy... ]
Roland Grunberg updated ERT-537:
--------------------------------
Summary: Update to com.spotify.docker.client 8.9.2 [EBZ#522659] (was: Update to com.spotify.docker.client 8.9.0 [EBZ#522659])
> Update to com.spotify.docker.client 8.9.2 [EBZ#522659]
> ------------------------------------------------------
>
> Key: ERT-537
> URL: https://issues.jboss.org/browse/ERT-537
> Project: Eclipse Release Train
> Issue Type: Task
> Components: Linux Tools
> Reporter: Friendly Jira Robot
> Assignee: Roland Grunberg
> Labels: Docker, bzira
>
> This is currently the latest upstream version of docker-client. There are also some API breaking changes, so aside from just bringing a newer version into Orbit, we'll also need to update the sources.
> (/) Update Jackson 2.9.2 Stack in Orbit (from 2.6.2)
> (/) Confirm the changes made should allow Docker Tooling to function
> (?) Create CQs, ATO CQs for JNR stack update
> (?) Update JNR stack, along with docker-client in Orbit
> (?) Push all changes necessary to Docker Tooling
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 10 months