[jbosstools-issues] [JBoss JIRA] (JBIDE-12911) CLONE - Review error handling code in as plugins

CLONE - Review error handling code in as plugins ------------------------------------------------ Key: JBIDE-12911 URL: https://issues.jboss.org/browse/JBIDE-12911 Project: Tools (JBoss Tools) Issue Type: Bug Components: JBossAS/Servers Affects Versions: 4.0.0.Beta1 Reporter: Andre Dietisheim Fix For: 4.0.0.CR1 It is still very easy to find (search Exception in *.java files and review results) wrong exception handling like: * hiding exception by returning null or default value in catch block without proper logging (Examples: JBossLaunchAdapter, XPathQuery, AS7DeploymentScannerUtility) * use empty catch blocks (examples: ModelChangeListenerWithRefresh, FilesetWizard, RSEJBoss7BehaviourDelegate, BossSARFacetInstallationDelegate) * use generic Exception instead of specific ones (Examples: FilesetWizard, RSEJBoss7BehaviourDelegate, JBossSARFacetInstallationDelegate) * use printStackTrace in try/catch blocks which is not always visible unles eclipse is started with console (Example: RSEDeploymentPreferenceUI, DeploymentModuleOptionCompositeAssistant, JBossSARFacetInstallationDelegate, NewMessageDrivenBeanWizardPage) Please review the error handling code in JBossAS plugin. I replaced a lot of e.printStackTrace() (in JBIDE-8434) by proper logging. I might have missed some, in some cases more handling is needed, some might not be correct.