[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-2025) Autocomplete (Ctrl+Space) for java types suddenly stop working on JBDS

[ http://jira.jboss.com/jira/browse/JBIDE-2025?page=comments#action_12410121 ] Snjezana Peco commented on JBIDE-2025: -------------------------------------- I haven't reproduced the case, but have found a code that changes the jdt.ui preferences. The org.jboss.tools.common.model.ui plugin overrides the initializeDefaultPreferences(IPreferenceStore store) method and from within this method tries to set the default preferences for the jdt.ui plugin. This method is unnecessary because the jdt.ui plugin initializes its preferences correctly using the org.eclipse.core.runtime.preferences extension point (initializer element). The org.jboss.tools.common.model.ui plugin also adds its preference store to this method. This is confusing because a client can search the same preference using two plugins. If the client searches it with the model.ui plugin, it will always get the default value no matter what the jdt.ui preference page contains. The initializeDefaultPreferences method is deprecated. It is called when a plugin is loaded/started. Using the extension point is more surely because the initialization is done when the plugin is resolved. If we remove this method, the code that searches the jdt.ui preferences using the model.ui plugin will be broken (I haven't found such a code, but not sure if it exists because the ModelUIPlugin class has more than 500 references). The ModelUIPlugin.initializeDefaultPreferences () method is basically incorrect, but the question is when to remove it. That would require some additional testing. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira