[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-5831) Smooks Editor Usability Tweaks

[ https://jira.jboss.org/jira/browse/JBIDE-5831?page=com.atlassian.jira.plu... ] Brian Fitzpatrick commented on JBIDE-5831: ------------------------------------------ Hey Dart... Took a quick look at your patch. Though all it seems to do is add the ability to select something in the task graph (i.e. Input or Java Mapping) and hit the Delete key, it seems to work ok. You might also look at adding Undo (Ctrl+Z) and Redo (Ctrl+Y I think) as potential things to add on both canvases. And does the Delete work on the lower canvas, such as to delete a class you've added? Tom, as far as recreating the RetargetAction.patch, it works fine on what's in the trunk, so I'm confused. It would be impossible for Dart to recreate a patch for code changes you haven't checked in yet I think. :( But Dart, I totally agree with Tom in that you need to document what it is we're supposed to be reviewing for a particular patch. In this case, the only functionality I can seem to find by looking at the code is that hitting the Delete key will delete the task currently selected. --Fitz -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira