]
Jeff MAURY updated JBIDE-24439:
-------------------------------
Fix Version/s: 4.5.0.Final
(was: 4.5.0.AM1)
Block PRs for merge untill the Jenkins build is successful
----------------------------------------------------------
Key: JBIDE-24439
URL:
https://issues.jboss.org/browse/JBIDE-24439
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: build
Affects Versions: 4.5.0.AM1
Reporter: Nick Boldt
Assignee: Jeff MAURY
Fix For: 4.5.0.Final
As discussed in this thread [1], we'd like to implement *Protected Branches* and
*Required Status Checks* [2] for some jbosstools-* projects.
[1]
http://lists.jboss.org/pipermail/jbosstools-dev/2017-May/011948.html
[2]
https://help.github.com/articles/defining-the-mergeability-of-pull-requests/
We will therefore need to document some requirements in jbosstools-devdoc about how to
properly submit PRs when version-bumping is required:
{quote}Make sure if your PR requires a version bump that the PR includes TWO commits. One
for the change, and one for the version bump. That way the pair of commits can be built in
the PR build and verify it works, AND when cherry picking the commit across branches, you
can pick only the change and not the version-bump commit too.
{quote}
And we need to decide if we want to do what Fuse Tools does and require that PRs be
reviewed before they can be merged, if we're ready to have that additional overhead on
every PR.
[~jeffmaury] as project lead can you state which project(s) you'd like to see changed
in github, and which ones should be changed as such:
* jbosstools-_____
** Protected Branch = master
** Required Status Check(s) = ....? (which checks do we want)
** PR reviews required = [true/false]
From that list of projects / requirements, we can then create subtask JIRAs to track the
workj & the changes.