[
https://jira.jboss.org/jira/browse/JBIDE-3321?page=com.atlassian.jira.plu...
]
Sean Flanigan commented on JBIDE-3321:
--------------------------------------
Oh, I didn't understand Snjezana at first, but I realise now that the only features
which show up in About Features (or Configuration Details) are those which have branding
plugins, so naturally adding branding will make them show up and fix problem #5. Has it
always been this way, or did this change in Eclipse 3.4?
This new knowledge does suggest another cleanup item:
6. If I install "JBoss Tools RichFaces" through the Update Manager, it's
counter-intuitive for About Features to show it as "Visual Page Editor". (The
first name comes from the feature manifest (or feature.properties), the second comes from
the branding plugin.) Shouldn't these names be similar, if not identical?
There's another reason we would want branding plugins: I don't think it's
possible to create "fragment features" to contain translations of the feature
metadata (eg feature_es.properties), but if every feature has a branding plugin, we can
translate those plugins like any others.
You would have to install the relevant branding langpack fragment before you would see the
translated feature names, and in any case, it looks as the update manager uses names from
the features, not from the branding plugins. So users won't see localised feature
names in the Update Manager when installing JBT features, or when updating JBDS features
(assuming there is an update site for JBDS).
The alternative is to put translated properties files into the actual feature:
feature_es.properties, feature_fr.properties, feature_de.properties, etc. That way, when
the feature is built it will contain the translated feature names, and it should be
available anywhere it's needed, eg in the Update Manager. There are logistical
problems with this (the L10n team having to deal with these properties files, for one, and
making the main build dependent on L10n data), but it is one option.
In summary, we can get localised feature names in About by using localised branding
plugins. It should be possible to have localised feature names in the Update Manager, but
only by including translations in features, not if they are kept separate. (As far as I
can tell, no-one has come up with a solution for that. To solve it would probably require
the update manager to understand locales and how to find the right feature langpack for a
given feature.)
Bad metadata for various features
---------------------------------
Key: JBIDE-3321
URL:
https://jira.jboss.org/jira/browse/JBIDE-3321
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Cleanup
Affects Versions: 3.0.0.beta1
Reporter: Sean Flanigan
Priority: Critical
Fix For: 3.0.0.cr1, 3.0.0.GA
[1. I see Nick Boldt has fixed the badly-formed feature.xml for
org.jboss.tools.birt.integration.wtp.feature for JBIDE-3216]
2. org.jboss.tools.common.feature depends on org.jboss.tools.common.text.ext_feature.
This feature appears not to exist, but org.jboss.tools.common.text.ext.feature does.
3. Eclipse's feature manifest editor shows a warning in the Dependencies tab for
org.jboss.tools.common.text.ext.feature, because it has a hard-coded dependency on
org.jboss.tools.common.core.feature 1.0.0. Changing it to greaterOrEqual seems to fix the
warning.
4. org.jboss.tools.common.ui.feature and org.jboss.tools.seam.feature have dependency
warnings, similar to #3
5. Several of JBT's features don't show up in JBDS's About Features. For
instance, org.jboss.tools.ws.feature. It looks as if the WS plugins are being activated,
but not the features. Perhaps a dependency problem like
https://bugs.eclipse.org/bugs/show_bug.cgi?id=236111 ?
(I'm not sure yet, but I think problem #5 might be the reason some of my JBT langpack
features refuse to install into JBDS 3.0.0.beta1.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira