[jbosstools-issues] [JBoss JIRA] (JBIDE-12144) EGitUtils#push is throwing an exception if push fails. It should use the same semantics as EGit

EGitUtils#push is throwing an exception if push fails. It should use the same semantics as EGit ----------------------------------------------------------------------------------------------- Key: JBIDE-12144 URL: https://issues.jboss.org/browse/JBIDE-12144 Project: Tools (JBoss Tools) Issue Type: Enhancement Components: openshift Affects Versions: 3.3.0.CR1 Reporter: Andre Dietisheim Assignee: Andre Dietisheim Fix For: 4.0.0.Alpha2 EgitUtils#push throws an exception if the push failed because of ex. "non fastforward push". {code} private static PushOperationResult push(Repository repository, RemoteConfig remoteConfig, boolean force, IProgressMonitor monitor) throws CoreException { ... PushOperationResult pushResult = op.getOperationResult(); if (hasFailedEntries(pushResult)) { throw new CoreException( EGitCoreActivator.createErrorStatus( NLS.bind("Could not push repository {0}: {1}", repository.toString(), getErrors(pushResult)) , null)); } return pushResult; {code} EGit is not throwing an exception in this case. You simply get the failure in the PushResult object you'll have to look at. EGitUtils#push is thus changing the API semantics of EGit and it shouldn't.