[
https://issues.jboss.org/browse/JBIDE-8599?page=com.atlassian.jira.plugin...
]
Andre Dietisheim commented on JBIDE-8599:
-----------------------------------------
you might be right in saying that the patch touches several separate concerns, but
they're tightly realted and I still believe that they belong to a single patch.
* The first concern is to prepend http:// to urls if there's no scheme to it.
* The 2nd issue is related to it in the sense that setting the url was handled in a messy
way, which I tried to correct: First the url was passed to the constructor of the model,
which checked if it had a scheme and prepended http:// to it otherwise. Then the url was
read from the preferences and set to the model on behalf of the appropriate setter. This
approach lead to weird effects where you could have an url in the prefs which had no
scheme, set it to the model and no http:// was prepended to it. The straight-forward fix
would have been to call the http-prepending code in the setter, too. But would have been
pretty straight forward but basically is a workaround for messy code.
* The code checkes for name identiy since cloud names have to be unique. It did that by
searching for a cloud by name and did an exception to it if the name of the current cloud
was kept untouched (ex. change it and get back to it in a 2nd step). It did that on behalf
of an additional instance variable which held the name. This exception may just be
fullfilled by checking instance identity, there's no need for the additional instance
variable. I therefore dropped it.
Cloud connection wizard: should not need to type http:// for the URL
--------------------------------------------------------------------
Key: JBIDE-8599
URL:
https://issues.jboss.org/browse/JBIDE-8599
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: deltacloud
Affects Versions: 3.3.0.M1
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 3.3.0.M1
Attachments: prepend-http-2.patch, prepend-http-3.patch, prepend-http.patch
If you create a new cloud connection you have to indicate an URL to the deltacloud
server. The current implementation needs you to add http:// in front of this url. This
shouldn't be necessary since the deltacloud server offers a REST server wich is
basically only accessible by http
--
This message is automatically generated by JIRA.
For more information on JIRA, see:
http://www.atlassian.com/software/jira