[ https://issues.jboss.org/browse/JBIDE-13158?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-13158: ------------------------------------- Steps to Reproduce: # EXEC: create a connection to the default server, but make sure that you *UNCHECK* the *use default server* checkbox (while having it pointing to the default server) # ASSERT: make sure you dont have a 2nd, *DEFAULT* connection to the very same server ("use default server" IS checked) # In OpenShift Explorer: pick *Edit Embedded Cartridges...* Result: Nothing happens. In the Eclipse log you'll spot the following: {code} java.lang.IllegalArgumentException: No connection provided at org.eclipse.core.runtime.Assert.isLegal(Assert.java:63) at org.jboss.tools.openshift.express.internal.ui.wizard.application.ApplicationWizardModel.<init>(ApplicationWizardModel.java:30) at org.jboss.tools.openshift.express.internal.ui.wizard.embed.EmbedCartridgeWizard.<init>(EmbedCartridgeWizard.java:28) at org.jboss.tools.openshift.express.internal.ui.action.EditCartridgesAction.run(EditCartridgesAction.java:46) at org.eclipse.jface.action.Action.runWithEvent(Action.java:498) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584) at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501) at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1276) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3554) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3179) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1029) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:923) at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:86) at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:588) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:543) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:353) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:180) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:629) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:584) at org.eclipse.equinox.launcher.Main.run(Main.java:1438) at org.eclipse.equinox.launcher.Main.main(Main.java:1414) {code} was: # EXEC: create a connection to the default server, but make sure that you *UNCHECK* the *use default server* checkbox (while having it pointing to the default server) # ASSERT: make sure you dont have a 2nd, *DEFAULT* connection to the very same server ("use default server" IS checked) # In OpenShift Explorer: pick *Edit Embedded Cartridges...* Result: Nothing happens. In the Eclipse log you'll spot the following: {code} {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-13158?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-13158: ------------------------------------------ Looking through the code and discussing to max I found out that the lookup is not even required. The lookup is remaining code from the times when we were using the legacy client. The embed cartridges wizard is requiring a connection to create the jenkins application when you embed the jenkins client. Back in the times with the legacy client the only one that could create an applciation was the connection (called user back then). With the new client we can use the domain to do create applications. Thus given that you launch the wizard selecting an application, you can get its domain (IApplication#getDomain) and create the jenkins application (IDomain#createApplication). There's no need to get the connection any more. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-13158?page=com.atlassian.jira.plugi... ] Xavier Coulon commented on JBIDE-13158: --------------------------------------- Patch works great. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-13158?page=com.atlassian.jira.plugi... ] Vlado Pakan closed JBIDE-13158. ------------------------------- Verified with JBT 4.0.0.CR1-v20121128-2332-B107. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira