[ https://jira.jboss.org/jira/browse/JBDS-729?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBDS-729: --------------------------------- Looks like this templating work needs to be done in two places: /devstudio-3.0.0.M1/releng/org.jboss.ide.eclipse.releng/builders/equinox-transforms/customTargets.xml and /devstudio-3.0.0.M1/devstudio-installer/build.xml -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBDS-729?page=com.atlassian.jira.plugi... ] Nick Boldt updated JBDS-729: ---------------------------- Attachment: clipboard.txt patch to switch to templated values for plugin & eclipse.buildId versions -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBDS-729?page=com.atlassian.jira.plugi... ] Nick Boldt updated JBDS-729: ---------------------------- Attachment: clipboard.txt revised patch includes more replacements for org.eclipse.equinox.transforms.{hook,xslt} -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBDS-729?page=com.atlassian.jira.plugi... ] Nick Boldt reassigned JBDS-729: ------------------------------- Assignee: Nick Boldt (was: Denis Golovin) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBDS-729?page=com.atlassian.jira.plugi... ] Nick Boldt updated JBDS-729: ---------------------------- Attachment: (was: clipboard.txt) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBDS-729?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBDS-729: --------------------------------- With build #237: * eclipse/Eclipse.app/Contents/MacOS/eclipse.ini contains expanded Ant vars: FIXED * eclipse/JBoss Developer Studio.app/Contents/MacOS/eclipse.ini contains unexpanded Ant vars (but has correct carbon.macosx entry): STILL BROKEN Workaround: copy good eclipse.ini over top of bad one; double-clicking the JBoss Developer Studio.app folder then runs JBDS; or, run from the Eclipse.app folder. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBDS-729?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen updated JBDS-729: ------------------------------------- Fix Version/s: 2.1.0 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBDS-729?page=com.atlassian.jira.plugi... ] Denis Golovin updated JBDS-729: ------------------------------- Fix Version/s: 3.0.0.M4 (was: 2.1.0) version moved in one place in devstudio-installer/version.properties file -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBDS-729?page=com.atlassian.jira.plugi... ] Denis Golovin commented on JBDS-729: ------------------------------------ Build now alters original eclipse.ini and config.ini files. Issue https://jira.jboss.org/jira/browse/JBDS-729 was fixed in devstudio-3.0.0.M4 branch For eclipse.ini build: 1. Removes -showsplash option and next line by <replaceregexp file="${distribution.dir}/eclipse/eclipse.ini" match="\-showsplash[\n\r]*org.eclipse.platform[\n\r]*" replace="" /> 2. Loads osgi.bundles from configuration/config.ini and adds it to vmargs as last line in eclipse.ini as Java System property -Dosgi.bundles=${osgi.bundles},org.eclipse.equinox.transforms.xslt@1:start,org.jboss.tools.equinox.transforms.xslt@1:start For configuration/config.ini it altered properties this way: 1. Finds org.eclipse.equinox.transforms.hook plug-in in eclipse/plugins and initialise transforms.hook ant property with full plug-in jar name 2. Alters config.ini as <propertyfile file="${distribution.dir}/eclipse/configuration/config.ini"> <entry key="eclipse.product" value="com.jboss.jbds.product.product"/> <entry key="osgi.splashPath" value="platform:/base/plugins/com.jboss.jbds.product"/> <entry key="osgi.framework.extensions" value="reference:file:${transforms.hook}"/> </propertyfile> It also handles the case of Mac OSX, where eclipse.ini file is placed in eclipse/Eclipse.app/Contents/MacOS folder. I'm going to check it tomorrow in the office on Mac. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBDS-729?page=com.atlassian.jira.plugi... ] Denis Golovin updated JBDS-729: ------------------------------- Fix Version/s: 3.0.0.CR2 (was: 3.0.0.M4) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBDS-729?page=com.atlassian.jira.plugi... ] Denis Golovin updated JBDS-729: ------------------------------- Summary: Generate plugin dependencies in eclipse.ini/config.ini rather than hardcoding versions (was: generate plugin dependencies in eclipse.ini/config.ini rather than hardcoding versions) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira