[ https://jira.jboss.org/jira/browse/JBIDE-5715?page=com.atlassian.jira.plu... ] Burr Sutter updated JBIDE-5715: ------------------------------- Attachment: New_WS_Project.pdf -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5715?page=com.atlassian.jira.plu... ] Feng Qian commented on JBIDE-5715: ---------------------------------- Ok, got it. Did you got my mail for this feature request yesterday? If yes, I think this issue is a answer for that mail. You and Burr have given a decision for this. It's ok. I will fix it by the steps as the pdf. For the pdf, there are some questions: 1 for the new wizard, I need to have one default java class and copy it into the generate web project if user choose the check-box for this, right? And I need a default web.xml for the default java class if user choose the check-box for this, right? If un-choose, we don't generate them, right? 2 for the new wizard, if user un-choose the check-box for generating a default web service java class, the generated dynamic project is the exactly same to a wtp dynamic project, is user confused for this? Why the jboss web service project is same to the dynamic web project? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5715?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-5715: -------------------------------------------- As far as I understood there are *zero* JBoss WS specific code in any of this. Am I wrong about that ? About the checkbox then there simply shouldn't be an explicit option for it - you started the web services project wizard and you will get one. The proper way of doing this would be to have a webservice facet that you enable and then get the additional pages for it but I don't think we should try to do that this close to release. Lets keep it simple. If the user decides to uncheck the web.xml file then I guess we should error or at least warn the user that he still needs it for whatever goes into the web.xml file ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5715?page=com.atlassian.jira.plu... ] Feng Qian commented on JBIDE-5715: ---------------------------------- Yes, Max. We just update the web.xml and give a default java class. Today, I search some documents for this wizard, I found wtp guys don't encourage extending their wizard. So the wizard is temp resolve for this release? or a stable resolve? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5715?page=com.atlassian.jira.plu... ] Burr Sutter commented on JBIDE-5715: ------------------------------------ Max: "btw. wouldn'it be simpler to just create a Hello World Webservice wizard that adjusted an existing dynamic web project's web.xml and added the java class ? " Burr: Yes, if that is the most simple solution then let's go with that. Grid: "So the wizard is temp resolve for this release? or a stable resolve? Burr: We are looking for a solution for this moment - to allow our users to easily build a new JSR 181 WS endpoint, the challenge is getting the web.xml updated for the servlet entries. The New Web Service Project wizard is one way, a New Web Service that injects itself into a currently opened Dynamic Web Project is another way. We should take the most simple path. Grid: "3 for the new wizard, we name it 'Web Service Project'. If user don't use jboss web service, for example axis, how do we handle this? So I think maybe we should call the wizard: 'JBoss web service project'? " Burr: The generated artifacts for the 181-annotated class and the entries in the web.xml are based on the EE specification therefore they are applicable to JBossWS, Metro or any EE-based WS implementation. It might not work with Axis but that is just fine. I should also mention that once we figure this trick out (new project wizard or new class wizard) then we should also do the same thing for a helloworld JAX-RS endpoint. :-) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5715?page=com.atlassian.jira.plu... ] Burr Sutter commented on JBIDE-5715: ------------------------------------ Would it be easier to just add a menu option for "Add New WebService" into an existing Dynamic Web Project? This could drop in a "hello world" endpoint and update the web.xml accordingly? Our goal is to reduce the number of steps involved to get a WS up and running quickly. http://community.jboss.org/wiki/CreatingaJSR181WebServiceusingJBTJBDSTooling -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5715?page=com.atlassian.jira.plu... ] Feng Qian commented on JBIDE-5715: ---------------------------------- Today, I begin to work on this task. As if there are some problems. If I use the extending the wizard method to resolve this issue, I met a problem. I can change these labels and titles. But when I want to add the checkbox on the wizard page for the web service servlet, I need to extending the wtp wizardpage, but this wtp wizardpage is added from it's plugin.xml. I can't change it's plugin.xml, so I can't add my extengding page into the framework. So I want to know if don't add the checkbox, no change for this page, just generate web service java class and add the web service servlet into web.xml directly? Or add a seperate page at the first or at the second of the wizard for the checkbox? Or add the checkbox into the first wizard page directly? And I think about the facet way. If we give a facet for this issue, it need to be different with the existing jbossws facet. Because it's purpose is different with the existing jbossws facet. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5715?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-5715: -------------------------------------------- Grid, about requirements from Burr those are not in any way requirements, they were a suggestion for how this could be realized. It is our job to find the best way of doing this so it fits into the exsiting workflows of the IDE and is possible to implement in due time. Considering this I would say having a New Basic WebService Wizard which simply create the .java file and modify web.xml would be the simplest way. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5715?page=com.atlassian.jira.plu... ] Brian Fitzpatrick commented on JBIDE-5715: ------------------------------------------ Grid, to answer your question here: https://jira.jboss.org/jira/browse/JBIDE-5715?focusedCommentId=12508020#a... I think we want to not modify the existing New Web Service wizard from WTP, but create our own as outlined in my last comment. Let's keep this as simple as possible. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5715?page=com.atlassian.jira.plu... ] Brian Fitzpatrick commented on JBIDE-5715: ------------------------------------------ Ok... I've committed my changes to make this work as a "New Wizard". Grid, can you work on adding some validation to these pages. It would be good to pop up a warning if a web service name has already been used in the web.xml or if the package/class name has already been used in the project. But other than that, this looks good to me. Based on a chat with Burr, it works for him conceptually as well. He looks forward to playing with it in a future build. :) So good work! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5715?page=com.atlassian.jira.plu... ] Feng Qian commented on JBIDE-5715: ---------------------------------- Thanks,Brian! I commit my codes and just want to get feedback. Then I can improve it. Thank you for your improvement for this. For the validation, the package name don't need to be validate. We can generate codes in a exiting package not affect other class in this package. The class name and web service name, yes, need to be validated. Grid -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5715?page=com.atlassian.jira.plu... ] Brian Fitzpatrick resolved JBIDE-5715. -------------------------------------- Resolution: Done -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-5715?page=com.atlassian.jira.plugin.s... ] Lukas Jungmann closed JBIDE-5715. --------------------------------- v. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira