9:10 a.m.
Incoherent module assembly structure
------------------------------------
Key: JBIDE-5713
URL: https://jira.jboss.org/jira/browse/JBIDE-5713
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.1.0.CR1
Environment: Vista, JBT 3.1.CR1
Reporter: Fred Bricon
Priority: Minor
I was a bit puzzled -and kinda worried- after opening the module assembly page of an EJB
project.
As you can see on the following screenshot (incoherent_module_assembly_structure.jpg), the
page indicates EJB dependencies of my testEJB2 project should be exported in the resulting
jar. Fortunately, they aren't (hence the minor priority), but it's pretty
disturbing.
My understanding of the module assembly page is that :
- it's just a GUI over ./settings/org.eclipse.wst.common.component
- it should reflect the content of the produced assembly. i.e everything in this page
should be present in the resulting .jar/.ear/.sar, whatever.
well, it's also probable I misunderstood a lot :-)
regards,
Fred Bricon
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:12 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-5713) Incoherent module assembly structure
[
https://jira.jboss.org/jira/browse/JBIDE-5713?page=com.atlassian.jira.plu...
]
Fred Bricon updated JBIDE-5713:
-------------------------------
Attachment: incoherent_module_assembly_structure.jpg
Incoherent module assembly structure
------------------------------------
Key: JBIDE-5713
URL: https://jira.jboss.org/jira/browse/JBIDE-5713
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.1.0.CR1
Environment: Vista, JBT 3.1.CR1
Reporter: Fred Bricon
Priority: Minor
Attachments: incoherent_module_assembly_structure.jpg
I was a bit puzzled -and kinda worried- after opening the module assembly page of an EJB
project.
As you can see on the following screenshot (incoherent_module_assembly_structure.jpg),
the page indicates EJB dependencies of my testEJB2 project should be exported in the
resulting jar. Fortunately, they aren't (hence the minor priority), but it's
pretty disturbing.
My understanding of the module assembly page is that :
- it's just a GUI over ./settings/org.eclipse.wst.common.component
- it should reflect the content of the produced assembly. i.e everything in this page
should be present in the resulting .jar/.ear/.sar, whatever.
well, it's also probable I misunderstood a lot :-)
regards,
Fred Bricon
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:27 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-5713) Incoherent module assembly structure
[
https://jira.jboss.org/jira/browse/JBIDE-5713?page=com.atlassian.jira.plu...
]
Max Rydahl Andersen updated JBIDE-5713:
---------------------------------------
Fix Version/s: 3.1.0.CR2
Assignee: Rob Stryker
Priority: Critical (was: Minor)
not minor - that page is supposed to be correct.
Rob, is that a bug or simply how the model beneath looks like ?
Incoherent module assembly structure
------------------------------------
Key: JBIDE-5713
URL: https://jira.jboss.org/jira/browse/JBIDE-5713
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.1.0.CR1
Environment: Vista, JBT 3.1.CR1
Reporter: Fred Bricon
Assignee: Rob Stryker
Priority: Critical
Fix For: 3.1.0.CR2
Attachments: incoherent_module_assembly_structure.jpg
I was a bit puzzled -and kinda worried- after opening the module assembly page of an EJB
project.
As you can see on the following screenshot (incoherent_module_assembly_structure.jpg),
the page indicates EJB dependencies of my testEJB2 project should be exported in the
resulting jar. Fortunately, they aren't (hence the minor priority), but it's
pretty disturbing.
My understanding of the module assembly page is that :
- it's just a GUI over ./settings/org.eclipse.wst.common.component
- it should reflect the content of the produced assembly. i.e everything in this page
should be present in the resulting .jar/.ear/.sar, whatever.
well, it's also probable I misunderstood a lot :-)
regards,
Fred Bricon
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:15 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-5713) Incoherent module assembly structure
[
https://jira.jboss.org/jira/browse/JBIDE-5713?page=com.atlassian.jira.plu...
]
Rob Stryker commented on JBIDE-5713:
------------------------------------
What's shown in the image doesn't match *at all* what's being shown in the
xml file. If it was just hte ejb reference that was missing I'd be torn.
Right now, all I can say by looking at this screenshot is that the user may have added
references to the wizard and not clicked "apply" yet to save them, which means
the page was out of sync with the xml file.
Without a project to test it with, I have no idea what's going on here. It does not
seem to make sense at all and aside from free-testing, theres virtually nothing I can do.
Incoherent module assembly structure
------------------------------------
Key: JBIDE-5713
URL: https://jira.jboss.org/jira/browse/JBIDE-5713
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.1.0.CR1
Environment: Vista, JBT 3.1.CR1
Reporter: Fred Bricon
Assignee: Rob Stryker
Priority: Critical
Fix For: 3.1.0.CR2
Attachments: incoherent_module_assembly_structure.jpg
I was a bit puzzled -and kinda worried- after opening the module assembly page of an EJB
project.
As you can see on the following screenshot (incoherent_module_assembly_structure.jpg),
the page indicates EJB dependencies of my testEJB2 project should be exported in the
resulting jar. Fortunately, they aren't (hence the minor priority), but it's
pretty disturbing.
My understanding of the module assembly page is that :
- it's just a GUI over ./settings/org.eclipse.wst.common.component
- it should reflect the content of the produced assembly. i.e everything in this page
should be present in the resulting .jar/.ear/.sar, whatever.
well, it's also probable I misunderstood a lot :-)
regards,
Fred Bricon
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:59 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-5713) Incoherent module assembly structure
[
https://jira.jboss.org/jira/browse/JBIDE-5713?page=com.atlassian.jira.plu...
]
Fred Bricon updated JBIDE-5713:
-------------------------------
Attachment: incoherentModulAssemblyProjects.zip
Rob,
I thought I attached the test projects, sorry my bad. Here they are.
The user, err ... that would be me, followed these steps :
* Opened the JavaEE dependency modules for testEJB2
* selected the available libraries from the EAR
* Applied and clicked OK
* opened the module assembly page and got surprised
* verified the content of the .component file
Closing and reopening the workspace showed the same content in both pages and file.
regards,
Fred Bricon
Incoherent module assembly structure
------------------------------------
Key: JBIDE-5713
URL: https://jira.jboss.org/jira/browse/JBIDE-5713
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.1.0.CR1
Environment: Vista, JBT 3.1.CR1
Reporter: Fred Bricon
Assignee: Rob Stryker
Priority: Critical
Fix For: 3.1.0.CR2
Attachments: incoherent_module_assembly_structure.jpg,
incoherentModulAssemblyProjects.zip
I was a bit puzzled -and kinda worried- after opening the module assembly page of an EJB
project.
As you can see on the following screenshot (incoherent_module_assembly_structure.jpg),
the page indicates EJB dependencies of my testEJB2 project should be exported in the
resulting jar. Fortunately, they aren't (hence the minor priority), but it's
pretty disturbing.
My understanding of the module assembly page is that :
- it's just a GUI over ./settings/org.eclipse.wst.common.component
- it should reflect the content of the produced assembly. i.e everything in this page
should be present in the resulting .jar/.ear/.sar, whatever.
well, it's also probable I misunderstood a lot :-)
regards,
Fred Bricon
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:29 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-5713) Incoherent module assembly structure
[
https://jira.jboss.org/jira/browse/JBIDE-5713?page=com.atlassian.jira.plu...
]
Rob Stryker commented on JBIDE-5713:
------------------------------------
Ok =D I can work on this now.
Sorry if I came off abrupt ;)
Incoherent module assembly structure
------------------------------------
Key: JBIDE-5713
URL: https://jira.jboss.org/jira/browse/JBIDE-5713
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.1.0.CR1
Environment: Vista, JBT 3.1.CR1
Reporter: Fred Bricon
Assignee: Rob Stryker
Priority: Critical
Fix For: 3.1.0.CR2
Attachments: incoherent_module_assembly_structure.jpg,
incoherentModulAssemblyProjects.zip
I was a bit puzzled -and kinda worried- after opening the module assembly page of an EJB
project.
As you can see on the following screenshot (incoherent_module_assembly_structure.jpg),
the page indicates EJB dependencies of my testEJB2 project should be exported in the
resulting jar. Fortunately, they aren't (hence the minor priority), but it's
pretty disturbing.
My understanding of the module assembly page is that :
- it's just a GUI over ./settings/org.eclipse.wst.common.component
- it should reflect the content of the produced assembly. i.e everything in this page
should be present in the resulting .jar/.ear/.sar, whatever.
well, it's also probable I misunderstood a lot :-)
regards,
Fred Bricon
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:49 a.m.
New subject: [JBoss JIRA] Resolved: (JBIDE-5713) Incoherent module assembly structure
[
https://jira.jboss.org/jira/browse/JBIDE-5713?page=com.atlassian.jira.plu...
]
Rob Stryker resolved JBIDE-5713.
--------------------------------
Resolution: Done
Ok... so to clarify, what you *should* see on the module assembly page for each of the
ejbs is, essentially, NOTHING. Nada. You shouldn't see a damn thing ;) Except for
the root folder (EarContent) mapping. Why? Because in "Module Assembly", all
you're doing is telling it how to put the stuff together. Pretty simple.
The 2 lib jars are sitting in the Ear project, not inside the ejb jars, so the ejb jars
have no need to "assemble" the libs.
Anyway, it turns out the problem is that J2EEVirtualComponent.getReferences() is returning
all sorts of made up references, not just the hard-coded references from the xml file. So
I've done a little API addition to allow for module types to filter down to just their
hard-coded references.
Should work better now.
I'm pretty sure I'll need to make slightly different changes upstream, but this
should be ok.
Incoherent module assembly structure
------------------------------------
Key: JBIDE-5713
URL: https://jira.jboss.org/jira/browse/JBIDE-5713
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.1.0.CR1
Environment: Vista, JBT 3.1.CR1
Reporter: Fred Bricon
Assignee: Rob Stryker
Priority: Critical
Fix For: 3.1.0.CR2
Attachments: incoherent_module_assembly_structure.jpg,
incoherentModulAssemblyProjects.zip
I was a bit puzzled -and kinda worried- after opening the module assembly page of an EJB
project.
As you can see on the following screenshot (incoherent_module_assembly_structure.jpg),
the page indicates EJB dependencies of my testEJB2 project should be exported in the
resulting jar. Fortunately, they aren't (hence the minor priority), but it's
pretty disturbing.
My understanding of the module assembly page is that :
- it's just a GUI over ./settings/org.eclipse.wst.common.component
- it should reflect the content of the produced assembly. i.e everything in this page
should be present in the resulting .jar/.ear/.sar, whatever.
well, it's also probable I misunderstood a lot :-)
regards,
Fred Bricon
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:55 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-5713) Incoherent module assembly structure
[
https://jira.jboss.org/jira/browse/JBIDE-5713?page=com.atlassian.jira.plu...
]
Rob Stryker updated JBIDE-5713:
-------------------------------
Attachment: JBIDE-5713.jpg
a bit better?
Incoherent module assembly structure
------------------------------------
Key: JBIDE-5713
URL: https://jira.jboss.org/jira/browse/JBIDE-5713
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.1.0.CR1
Environment: Vista, JBT 3.1.CR1
Reporter: Fred Bricon
Assignee: Rob Stryker
Priority: Critical
Fix For: 3.1.0.CR2
Attachments: incoherent_module_assembly_structure.jpg,
incoherentModulAssemblyProjects.zip, JBIDE-5713.jpg
I was a bit puzzled -and kinda worried- after opening the module assembly page of an EJB
project.
As you can see on the following screenshot (incoherent_module_assembly_structure.jpg),
the page indicates EJB dependencies of my testEJB2 project should be exported in the
resulting jar. Fortunately, they aren't (hence the minor priority), but it's
pretty disturbing.
My understanding of the module assembly page is that :
- it's just a GUI over ./settings/org.eclipse.wst.common.component
- it should reflect the content of the produced assembly. i.e everything in this page
should be present in the resulting .jar/.ear/.sar, whatever.
well, it's also probable I misunderstood a lot :-)
regards,
Fred Bricon
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:03 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-5713) Incoherent module assembly structure
[
https://jira.jboss.org/jira/browse/JBIDE-5713?page=com.atlassian.jira.plu...
]
Fred Bricon commented on JBIDE-5713:
------------------------------------
OK, thanks Rob.
I totally agree with the fact that, in this case, we shouldn't see a thing -hence your
fix-, but to my understanding the root folder we see in the module assembly page
corresponds to the root of the jar, not the EAR.
Of course, there's no need to assemble anything for an EJB, but if, for some silly
reason, I decided to a add jars to this page, I expect these jars would be assembled
inside the resulting .jar. Actually that's the point of
https://jira.jboss.org/jira/browse/JBIDE-5691 (I need that for handling sar projects)
Will your fix make it to WTP 3.2 (as I understood JBoss/RH donated this feature to
eclipse)?
Incoherent module assembly structure
------------------------------------
Key: JBIDE-5713
URL: https://jira.jboss.org/jira/browse/JBIDE-5713
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.1.0.CR1
Environment: Vista, JBT 3.1.CR1
Reporter: Fred Bricon
Assignee: Rob Stryker
Priority: Critical
Fix For: 3.1.0.CR2
Attachments: incoherent_module_assembly_structure.jpg,
incoherentModulAssemblyProjects.zip, JBIDE-5713.jpg
I was a bit puzzled -and kinda worried- after opening the module assembly page of an EJB
project.
As you can see on the following screenshot (incoherent_module_assembly_structure.jpg),
the page indicates EJB dependencies of my testEJB2 project should be exported in the
resulting jar. Fortunately, they aren't (hence the minor priority), but it's
pretty disturbing.
My understanding of the module assembly page is that :
- it's just a GUI over ./settings/org.eclipse.wst.common.component
- it should reflect the content of the produced assembly. i.e everything in this page
should be present in the resulting .jar/.ear/.sar, whatever.
well, it's also probable I misunderstood a lot :-)
regards,
Fred Bricon
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:11 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-5713) Incoherent module assembly structure
[
https://jira.jboss.org/jira/browse/JBIDE-5713?page=com.atlassian.jira.plu...
]
Rob Stryker commented on JBIDE-5713:
------------------------------------
I've attached a new patch to the upstream, but cannot commit today because WTP is in
the middle of the M5 final build. In fact my fix probably won't make it out until 1
week after 3.2 M5 is released.
but the patch is attached and it should be good to go ;)
And yes, if you added jars inside the ejb, they would be bundled inside the ejb.
Incoherent module assembly structure
------------------------------------
Key: JBIDE-5713
URL: https://jira.jboss.org/jira/browse/JBIDE-5713
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.1.0.CR1
Environment: Vista, JBT 3.1.CR1
Reporter: Fred Bricon
Assignee: Rob Stryker
Priority: Critical
Fix For: 3.1.0.CR2
Attachments: incoherent_module_assembly_structure.jpg,
incoherentModulAssemblyProjects.zip, JBIDE-5713.jpg
I was a bit puzzled -and kinda worried- after opening the module assembly page of an EJB
project.
As you can see on the following screenshot (incoherent_module_assembly_structure.jpg),
the page indicates EJB dependencies of my testEJB2 project should be exported in the
resulting jar. Fortunately, they aren't (hence the minor priority), but it's
pretty disturbing.
My understanding of the module assembly page is that :
- it's just a GUI over ./settings/org.eclipse.wst.common.component
- it should reflect the content of the produced assembly. i.e everything in this page
should be present in the resulting .jar/.ear/.sar, whatever.
well, it's also probable I misunderstood a lot :-)
regards,
Fred Bricon
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:13 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-5713) Incoherent module assembly structure
[
https://jira.jboss.org/jira/browse/JBIDE-5713?page=com.atlassian.jira.plu...
]
Rob Stryker commented on JBIDE-5713:
------------------------------------
meant to link: https://bugs.eclipse.org/bugs/show_bug.cgi?id=300469
Incoherent module assembly structure
------------------------------------
Key: JBIDE-5713
URL: https://jira.jboss.org/jira/browse/JBIDE-5713
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.1.0.CR1
Environment: Vista, JBT 3.1.CR1
Reporter: Fred Bricon
Assignee: Rob Stryker
Priority: Critical
Fix For: 3.1.0.CR2
Attachments: incoherent_module_assembly_structure.jpg,
incoherentModulAssemblyProjects.zip, JBIDE-5713.jpg
I was a bit puzzled -and kinda worried- after opening the module assembly page of an EJB
project.
As you can see on the following screenshot (incoherent_module_assembly_structure.jpg),
the page indicates EJB dependencies of my testEJB2 project should be exported in the
resulting jar. Fortunately, they aren't (hence the minor priority), but it's
pretty disturbing.
My understanding of the module assembly page is that :
- it's just a GUI over ./settings/org.eclipse.wst.common.component
- it should reflect the content of the produced assembly. i.e everything in this page
should be present in the resulting .jar/.ear/.sar, whatever.
well, it's also probable I misunderstood a lot :-)
regards,
Fred Bricon
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:04 p.m.
New subject: [JBoss JIRA] Updated: (JBIDE-5713) Incoherent module assembly structure
[
https://jira.jboss.org/jira/browse/JBIDE-5713?page=com.atlassian.jira.plu...
]
Denis Golovin updated JBIDE-5713:
---------------------------------
Component/s: UpStream
Incoherent module assembly structure
------------------------------------
Key: JBIDE-5713
URL: https://jira.jboss.org/jira/browse/JBIDE-5713
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: UpStream
Affects Versions: 3.1.0.CR1
Environment: Vista, JBT 3.1.CR1
Reporter: Fred Bricon
Assignee: Rob Stryker
Priority: Critical
Fix For: 3.1.0.CR2
Attachments: incoherent_module_assembly_structure.jpg,
incoherentModulAssemblyProjects.zip, JBIDE-5713.jpg
I was a bit puzzled -and kinda worried- after opening the module assembly page of an EJB
project.
As you can see on the following screenshot (incoherent_module_assembly_structure.jpg),
the page indicates EJB dependencies of my testEJB2 project should be exported in the
resulting jar. Fortunately, they aren't (hence the minor priority), but it's
pretty disturbing.
My understanding of the module assembly page is that :
- it's just a GUI over ./settings/org.eclipse.wst.common.component
- it should reflect the content of the produced assembly. i.e everything in this page
should be present in the resulting .jar/.ear/.sar, whatever.
well, it's also probable I misunderstood a lot :-)
regards,
Fred Bricon
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5349
days inactive
5371
days old
jbosstools-issues@lists.jboss.org
11 comments
4 participants
participants (4)
-
Denis Golovin (JIRA) -
Fred Bricon (JIRA)
-
Max Rydahl Andersen (JIRA)
-
Rob Stryker (JIRA)