[JBoss JIRA] Created: (JBIDE-3494) using source tab breaks design view (UI changes are not undone cleanly)
by Nick Boldt (JIRA)
using source tab breaks design view (UI changes are not undone cleanly)
-----------------------------------------------------------------------
Key: JBIDE-3494
URL: https://jira.jboss.org/jira/browse/JBIDE-3494
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jbpm
Affects Versions: 3.0.0.cr1
Reporter: Nick Boldt
Priority: Minor
Tested with JBoss Dev Studio Version: 2.0.0.CR1, Build id: R200812221144
Steps to repro:
1. Install JBDS.
2. download http://www.jboss.org/downloading/?projectId=jbossjbpm&url=http://download...
3. `java -jar jbpm-installer-3.3.0.GA.jar`. I installed into ~/jbpm-3.3.0.GA
4. New > Other > Process Project
5. Go into src/main/jpdl/simple and open processdefinition.xml with jBPM Graphical Process Designer
6. Add a couple nodes, then connect them to the existing flow. Or create your own.
7. Switch to Source tab. I had this:
<?xml version="1.0" encoding="UTF-8"?>
<process-definition xmlns="urn:jbpm.org:jpdl-3.2" name="simple">
<start-state name="start-state1">
<transition to="state1"></transition>
</start-state>
<state name="state1">
<transition to="end-state2"></transition>
</state>
<end-state name="end-state2"></end-state>
</process-definition>
and gpd.xml contained this -- three nodes in top-left to bottom-right cascade:
<?xml version="1.0" encoding="UTF-8"?>
<root-container name="simple" width="1058" height="740">
<node name="start-state1" x="32" y="19" width="132" height="36">
<edge>
<label x="5" y="-10"/>
</edge>
</node>
<node name="state1" x="77" y="103" width="132" height="36">
<edge>
<label x="5" y="-10"/>
</edge>
</node>
<node name="end-state2" x="115" y="203" width="132" height="36"/>
</root-container>
8. On the Source tab of the jBPM editor, select the middle state node and cut it out (CTRL-X). Note the outline view refreshes correctly.
9. Paste it back in, perhaps in the same location from where it was cut. (Use case: user wants to reorder the XML for personal taste reasons, or accidentally deleted and restored a block of XML).
10. Switch to diagram view. The middle node is now at 0,0 instead of where it used to be, eg., at (77,103)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
16 years, 6 months
[JBoss JIRA] Created: (JBIDE-3496) should multiple nodes with the same name be allowed?
by Nick Boldt (JIRA)
should multiple nodes with the same name be allowed?
----------------------------------------------------
Key: JBIDE-3496
URL: https://jira.jboss.org/jira/browse/JBIDE-3496
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jbpm
Affects Versions: 3.0.0.cr1
Reporter: Nick Boldt
Priority: Minor
Tested with JBoss Dev Studio Version: 2.0.0.CR1, Build id: R200812221144
Steps to repro:
1. Install JBDS.
2. download http://www.jboss.org/downloading/?projectId=jbossjbpm&url=http://download...
3. `java -jar jbpm-installer-3.3.0.GA.jar`. I installed into ~/jbpm-3.3.0.GA
4. New > Other > Process Project
5. Go into src/main/jpdl/simple and open processdefinition.xml with jBPM Graphical Process Designer
6. Add a couple nodes, then connect them to the existing flow.
7. Switch to Source tab and copy some nodes so you have multiple copies of some node and its transitions:
<?xml version="1.0" encoding="UTF-8"?>
<process-definition xmlns="urn:jbpm.org:jpdl-3.2" name="simple">
<start-state name="start-state1">
<transition to="state1"></transition>
</start-state>
<state name="state1">
<transition to="end-state2"></transition>
</state>
<state name="state1">
<transition to="end-state2"></transition>
</state>
<end-state name="end-state2"></end-state>
</process-definition>
8. Save and close. Reopen in jBPM editor. Note that copied node appear ON TOP of original node, because the gpd.xml only contains one set of location data for the two nodes called "state1"
9. Right-click on editor and select Validate.
No errors are reported for this condition, but I'd argue that the model is in an invalid state if there can be two nodes sharing the same location data. Additionally, transitions are specific to nodes, even if they share a non-unique name. In the source above, I have one flow from start-state1 to state1 to end-state2, and another from state1 to end-state2 (without linkage to start-state1). Again, this suggests there may be something broken in the model, resolved by telling the user that s/he cannot have two nodes of the same type with the same name.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
16 years, 6 months
[JBoss JIRA] Created: (JBIDE-3618) jPDL designer loses changes and cannot edit file anymore
by Hedley Proctor (JIRA)
jPDL designer loses changes and cannot edit file anymore
--------------------------------------------------------
Key: JBIDE-3618
URL: https://jira.jboss.org/jira/browse/JBIDE-3618
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jbpm
Affects Versions: LATER
Environment: Windows xp 32-bit
Reporter: Hedley Proctor
I've created a number of workflows using the Eclipse jPDL designer. Yesterday I created a fourth workflow by copying a previous one. After about an hours work, I had added another 10 states to the workflow. I saved it and shutdown Eclipse. Now I have opened Eclipse and none of the changes to the workflow have been saved. The Eclipse local history shows the last file version available as 17:22 yesterday, whereas in fact I worked until about 18:30.
Also, the file that remains is corrupt. It has transitions into and out of a state that doesn't exist. When I try to delete the transition in, in is deleted from the file, but it still remains on the graphical view. The Eclipse log shows a DOM parsing error:
org.w3c.dom.DOMException:
at org.eclipse.wst.xml.core.internal.document.NodeContainer.removeChild(NodeContainer.java:371)
at org.jbpm.gd.common.xml.XmlAdapter.removeElement(Unknown Source)
at org.jbpm.gd.common.xml.XmlAdapter.removeElement(Unknown Source)
at org.jbpm.gd.jpdl.xml.StartStateDomAdapter.doPropertyChange(Unknown Source)
at org.jbpm.gd.common.xml.XmlAdapter.propertyChange(Unknown Source)
at java.beans.PropertyChangeSupport.firePropertyChange(Unknown Source)
at java.beans.PropertyChangeSupport.firePropertyChange(Unknown Source)
at org.jbpm.gd.common.model.AbstractSemanticElement.firePropertyChange(Unknown Source)
at org.jbpm.gd.jpdl.model.AbstractNode.removeTransition(Unknown Source)
at org.jbpm.gd.jpdl.command.EdgeDeleteCommand.execute(Unknown Source)
at org.eclipse.gef.commands.CompoundCommand.execute(CompoundCommand.java:107)
at org.eclipse.gef.commands.CommandStack.execute(CommandStack.java:149)
at org.eclipse.gef.ui.actions.WorkbenchPartAction.execute(WorkbenchPartAction.java:76)
at org.eclipse.gef.ui.actions.DeleteAction.run(DeleteAction.java:125)
at org.eclipse.jface.action.Action.runWithEvent(Action.java:498)
at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:546)
at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:490)
at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:402)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:938)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3682)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3293)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2389)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2353)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2219)
at org.eclipse.ui.internal.Workbench$4.run(Workbench.java:466)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:289)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:461)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:106)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:169)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:106)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:76)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:363)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:176)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:508)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:447)
at org.eclipse.equinox.launcher.Main.run(Main.java:1173)
Eclipse version: 3.3.2 M20080221-1800
jPDL designer version: 3.1.3 SP2
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
16 years, 6 months
[JBoss JIRA] Created: (JBIDE-3611) Saving jBPM Project clears out "Java Classes and Resources" settings in jBPM deployment tab
by Aaron Pestel (JIRA)
Saving jBPM Project clears out "Java Classes and Resources" settings in jBPM deployment tab
-------------------------------------------------------------------------------------------
Key: JBIDE-3611
URL: https://jira.jboss.org/jira/browse/JBIDE-3611
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jbpm
Environment: JBoss Developer Studio
Version: 2.0.0.CR1
Build id: R200812221144
Build date: 12/22/2008 11:54
Reporter: Aaron Pestel
Priority: Minor
Maybe this is a feature request, but I would tend to call it a bug.
When deploying a jBPM project from JBDS, you click on the deployment tab of the jBPM process editor. If there are any Java files in your jBPM project (like a custom jBPM action), you have to select the "src/main/Java" checkbox in the "Java Classes and Resources Panel" or the Java class will not be deployed to the server when you deploy the jBPM process and you'll get class not found exceptions when you run the jBPM process. That's all fine. What is annoying is that every time you save the jBPM project, it automatically unselects all the checkboxes in the "Java Classes and Resources Panel". So, if you don't recheck that "src/main/Java" checkbox every time you save the jBPM project (which is pretty much every time you change the project), then you'll end up deploying the jBPM project without the necessary custom Java actions. I'm requesting that the check boxes not be reset every time the jBPM project is saved.
It looks like saving the jBPM project also resets all "Files and Folders" panel of the jBPM deployment tab. i wouldn't think anything should be reset when the project is saved.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
16 years, 6 months
[JBoss JIRA] Created: (JBIDE-3489) source editor breaks XML when undoing
by Nick Boldt (JIRA)
source editor breaks XML when undoing
-------------------------------------
Key: JBIDE-3489
URL: https://jira.jboss.org/jira/browse/JBIDE-3489
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jbpm
Affects Versions: 3.0.0.cr1
Reporter: Nick Boldt
Tested with JBoss Dev Studio Version: 2.0.0.CR1, Build id: R200812221144
Steps to repro:
1. Install JBDS.
2. download http://www.jboss.org/downloading/?projectId=jbossjbpm&url=http://download...
3. `java -jar jbpm-installer-3.3.0.GA.jar`. I installed into ~/jbpm-3.3.0.GA
4. New > Other > Process Project
5. Go into src/main/jpdl/simple and open processdefinition.xml with jBPM Graphical Process Designer
6. Add a couple nodes, then connect them to the existing flow.
7. Switch to Source tab. I had this:
<?xml version="1.0" encoding="UTF-8"?>
<process-definition
xmlns="urn:jbpm.org:jpdl-3.2"
name="simple">
<start-state name="start">
<transition name="to_state" to="first">
<action name="action" class="com.sample.action.MessageActionHandler">
<message>Going to the first state!</message>
</action>
</transition>
<transition to="mail-node1" name="to mail-node1"></transition>
</start-state>
<state name="first">
<transition name="to_end" to="end">
<action name="action" class="com.sample.action.MessageActionHandler">
<message>About to finish!</message>
</action>
</transition>
</state>
<task-node name="task-node1">
<transition to="end"></transition>
</task-node>
<mail-node name="mail-node1">
<transition to="task-node1"></transition>
</mail-node>
<end-state name="end"></end-state>
</process-definition>
8. Select the name of some node, eg., "mail-node1". Hit delete. Cursor jumps here:
<mail-node name="">
<tran|sition to="task-node1"></transition>
</mail-node>
9. CTRL-Z to undo change(s). Now I get this:
<mail-node name="">
<tranmail-node1sition to="task-node1"></transition>
</mail-node>
10. Save. Close. Reopen. Diagram is now in a broken state, with a Transition pointing into space, and the Mail Node no longer coupled to anything.
11. Switch to source view again. Paste the correct text from step 7 into the editor. Close. Reopen. The UI layout in the Diagram view is corrupt, with nodes all moved to the 0,0 coord corner (top left).
12. Switch to the source view. Select the name of the task-node, and change it. Undo w/ CTRL-Z. Continue undoing, and watch as the XML gets corrupted to this:
<task-node name="task-node1">
<transition to="end"></transition>
</task-node>
<mail-node name="mail-node1">
<trans"task-node1"on to=""a"</transition>
</mail-node>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
16 years, 6 months
[JBoss JIRA] Created: (JBIDE-3490) dirty jBPM Graphical Process Designer editor saves layout changes without prompting user or loses changes if gpd.xml is open to Source tab
by Nick Boldt (JIRA)
dirty jBPM Graphical Process Designer editor saves layout changes without prompting user or loses changes if gpd.xml is open to Source tab
------------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-3490
URL: https://jira.jboss.org/jira/browse/JBIDE-3490
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.0.0.cr1
Reporter: Nick Boldt
Tested with JBoss Dev Studio Version: 2.0.0.CR1, Build id: R200812221144
Steps to repro:
1. Install JBDS.
2. download http://www.jboss.org/downloading/?projectId=jbossjbpm&url=http://download...
3. `java -jar jbpm-installer-3.3.0.GA.jar`. I installed into ~/jbpm-3.3.0.GA
4. New > Other > Process Project
5. Go into src/main/jpdl/simple and open processdefinition.xml with jBPM Graphical Process Designer
6. Add a couple nodes, then connect them to the existing flow.
7. Switch to Source tab. I had this:
<?xml version="1.0" encoding="UTF-8"?>
<process-definition
xmlns="urn:jbpm.org:jpdl-3.2"
name="simple">
<start-state name="start">
<transition name="to_state" to="first">
<action name="action" class="com.sample.action.MessageActionHandler">
<message>Going to the first state!</message>
</action>
</transition>
<transition to="mail-node1" name="to mail-node1"></transition>
</start-state>
<state name="first">
<transition name="to_end" to="end">
<action name="action" class="com.sample.action.MessageActionHandler">
<message>About to finish!</message>
</action>
</transition>
</state>
<task-node name="task-node1">
<transition to="end"></transition>
</task-node>
<mail-node name="mail-node1">
<transition to="task-node1"></transition>
</mail-node>
<end-state name="end"></end-state>
</process-definition>
8. Click [x] on editor tab to close it. You should be prompted to save dirty editor. Save.
9. Reopen editor. Move some nodes around. Note editor is again in 'dirty' state.
10. Click [x] on editor tab to close it. This time you're not prompted to save (because the changes are in a different file, gpd.xml).
11. Repeat steps 9-10, verifying that changes to layout are saved into gpd.xml.
** Surely these changes to UI layout shouldn't be automatically written without the user's confirmation? **
--
11. Open gpd.xml using xml editor. Switch to Source tab and note (x,y) coords for the start node.
12. Reopen processdefinition.xml in jBPM Graphical Process Designer editor. Move the start node. Note editor is again in 'dirty' state, as in step 9 above.
13. Click [x] on editor tab to close it. Still not prompted, as in step 10. Close gpd.xml too.
14. Reopen gpd.xml. This time, nothing has changed!
** Surely layout changes shouldn't just vanish if the gpd.xml file's open in parallel with the jBPM Graphical Process Designer editor? **
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
16 years, 6 months
[JBoss JIRA] Created: (JBIDE-4254) Prevent diagram nodes from overlapping
by Nick Boldt (JIRA)
Prevent diagram nodes from overlapping
--------------------------------------
Key: JBIDE-4254
URL: https://jira.jboss.org/jira/browse/JBIDE-4254
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jbpm
Affects Versions: 3.0.0.GA
Reporter: Nick Boldt
Steps to repro:
1. Using JBDS 2.0.0.GA and jbpm 3.3.0.GA, create a new Process Project.
2. Open /<project>/src/main/jpdl/simple/processdefinition.xml
3. Add a new State node.
4. Drag it on top/under the existing (generated) State node. Resize it as necessary until they overlap perfectly.
Compare to JBPM Editor 1.0.2 from SOA Tools project @ Eclipse.org.
1. Using Eclipse 3.4.2 and BPMN Editor 1.0.2 (http://download.eclipse.org/stp/bpmn-modeler/1.0.2/updates/), create an empty project.
2. Create a new Bpmn Diagram (under "Other" group).
3. Create some nodes.
4. When you try to drop a node onto another one, the overlapping area turns red to indicate you cannot overlap them. If you release while in this red state, the node returns to its previous location.
In other words, you are prevented from overlapping nodes - only transition lines can overlap.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
16 years, 6 months