December 2011 - jbosstools-issues

[JBoss JIRA] (JBIDE-10314) Back out "Seam 2" changes, reverting to just "Seam"

by Alexey Kazakov (Commented) (JIRA)

[ https://issues.jboss.org/browse/JBIDE-10314?page=com.atlassian.jira.plugi... ] Alexey Kazakov commented on JBIDE-10314: ---------------------------------------- fixed for trunk > Back out "Seam 2" changes, reverting to just "Seam" > --------------------------------------------------- > > Key: JBIDE-10314 > URL: https://issues.jboss.org/browse/JBIDE-10314 > Project: Tools (JBoss Tools) > Issue Type: Task > Components: Seam 2 > Affects Versions: 3.3.0.M4 > Reporter: mark yarborough > Assignee: Alexey Kazakov > Fix For: 3.3.0.M5, 3.3.0.Beta1 > > > Multiple locations in the JBDS code that formerly referred to "Seam" now refer to "Seam 2". This was based on need to distinguish Seam 2 from Seam 3, which is no longer relevant. The code has already been changed to denote Seam 2, but this alters the screens and may necessitate re-shoot of many screenshots for the JBDS 5 documentation. So, a decision to be made... Which is easier and/or more appropriate? To back out the "Seam 2" code changes (and skip the need for new screenshots) or to leave the "Seam 2" label in the existing M4 code and re-shoot the screens for the docs? Personal opinion: If the need to distinguish Seam 2 from Seam 3 has gone away, then using "Seam 2" instead of "Seam" clutters things up... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 6 months

1
0
0 / 0

[JBoss JIRA] Created: (JBDS-1557) Errors in JBoss Server Manager Reference Guide

by Vlado Pakan (JIRA)

Errors in JBoss Server Manager Reference Guide ---------------------------------------------- Key: JBDS-1557 URL: https://issues.jboss.org/browse/JBDS-1557 Project: Developer Studio (JBoss Developer Studio) Issue Type: Bug Components: Doc - JBossAS Affects Versions: 4.0.0.CR1 Reporter: Vlado Pakan There are these errors in JBoss Server Manager Reference Guide http://download.jboss.org/jbosstools/nightly-docs/en/as/html/index.html: Chapter 1.1 - wrong link label "runtimes_servers" Chapter 2.1.2. - wrong screenshot dialog UI was changed update also related text of chapter Missing icon after "Reset Default Button " above Figure 2.12. Figure 2.13 - Added Group "Server Behaviour" add also related descritpion Figure 3.15., 3.16., 3.20. - obsolete screenshots add description of changes Figure 4.1. - obsolete new tree item "Filter" added Figure 4.3. - new facesets added update also descritpion Figure 4.4. - new facesets Figure 5.5. - there is no menu item "Deploy To Server" in package explorer Chapter 5.1.2. - Deploying single files is maybe obsolete Chapter 6.1 - link to JBoss TPTP profile feature at http://www.jboss.org/tools/download/stable is not working there is no update site on mentioned URL -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 6 months

5
15
0 / 0

[JBoss JIRA] (JBIDE-10314) Back out "Seam 2" changes, reverting to just "Seam"

by Max Rydahl Andersen (Commented) (JIRA)

[ https://issues.jboss.org/browse/JBIDE-10314?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-10314: --------------------------------------------- just keep seam in plugin names. > Back out "Seam 2" changes, reverting to just "Seam" > --------------------------------------------------- > > Key: JBIDE-10314 > URL: https://issues.jboss.org/browse/JBIDE-10314 > Project: Tools (JBoss Tools) > Issue Type: Task > Components: Seam 2 > Affects Versions: 3.3.0.M4 > Reporter: mark yarborough > Assignee: Alexey Kazakov > Fix For: 3.3.0.M5, 3.3.0.Beta1 > > > Multiple locations in the JBDS code that formerly referred to "Seam" now refer to "Seam 2". This was based on need to distinguish Seam 2 from Seam 3, which is no longer relevant. The code has already been changed to denote Seam 2, but this alters the screens and may necessitate re-shoot of many screenshots for the JBDS 5 documentation. So, a decision to be made... Which is easier and/or more appropriate? To back out the "Seam 2" code changes (and skip the need for new screenshots) or to leave the "Seam 2" label in the existing M4 code and re-shoot the screens for the docs? Personal opinion: If the need to distinguish Seam 2 from Seam 3 has gone away, then using "Seam 2" instead of "Seam" clutters things up... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 6 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-10108) Include org.jboss.tools.common.mylyn.feature into aggregated update site

by Alexey Kazakov (Created) (JIRA)

Include org.jboss.tools.common.mylyn.feature into aggregated update site ------------------------------------------------------------------------ Key: JBIDE-10108 URL: https://issues.jboss.org/browse/JBIDE-10108 Project: Tools (JBoss Tools) Issue Type: Sub-task Components: Build/Releng Reporter: Alexey Kazakov Assignee: Nick Boldt Fix For: 3.3.0.Beta1 I've created a new feature common/features/org.jboss.tools.common.mylyn.feature for o.j.t.common.mylyn plugin. Nick please include it into the aggregated update site. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 6 months

5
6
0 / 0

[JBoss JIRA] (JBIDE-10329) Upgrade Seam 3 test project to the latest Seam 3.1.0.CR1

by Alexey Kazakov (Created) (JIRA)

Upgrade Seam 3 test project to the latest Seam 3.1.0.CR1 -------------------------------------------------------- Key: JBIDE-10329 URL: https://issues.jboss.org/browse/JBIDE-10329 Project: Tools (JBoss Tools) Issue Type: Task Components: CDI extensions Affects Versions: 3.3.0.M5 Reporter: Alexey Kazakov Assignee: Alexey Kazakov Fix For: 3.3.0.M5 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 6 months

2
1
0 / 0

[JBoss JIRA] (JBIDE-10314) Back out "Seam 2" changes, reverting to just "Seam"

by Alexey Kazakov (Commented) (JIRA)

[ https://issues.jboss.org/browse/JBIDE-10314?page=com.atlassian.jira.plugi... ] Alexey Kazakov commented on JBIDE-10314: ---------------------------------------- What about "Seam" in plugin names, packages and descriptions? We don't have Seam in any Seam3 UI as far as I remember. > Back out "Seam 2" changes, reverting to just "Seam" > --------------------------------------------------- > > Key: JBIDE-10314 > URL: https://issues.jboss.org/browse/JBIDE-10314 > Project: Tools (JBoss Tools) > Issue Type: Task > Components: Seam 2 > Affects Versions: 3.3.0.M4 > Reporter: mark yarborough > Assignee: Alexey Kazakov > Fix For: 3.3.0.M5, 3.3.0.Beta1 > > > Multiple locations in the JBDS code that formerly referred to "Seam" now refer to "Seam 2". This was based on need to distinguish Seam 2 from Seam 3, which is no longer relevant. The code has already been changed to denote Seam 2, but this alters the screens and may necessitate re-shoot of many screenshots for the JBDS 5 documentation. So, a decision to be made... Which is easier and/or more appropriate? To back out the "Seam 2" code changes (and skip the need for new screenshots) or to leave the "Seam 2" label in the existing M4 code and re-shoot the screens for the docs? Personal opinion: If the need to distinguish Seam 2 from Seam 3 has gone away, then using "Seam 2" instead of "Seam" clutters things up... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 6 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-10202) VPE has leaks of resources which results to "Unhandled event loop exception - org.eclipse.swt.SWTError: No more handles"

by Vitali Yemialyanchyk (Created) (JIRA)

VPE has leaks of resources which results to "Unhandled event loop exception - org.eclipse.swt.SWTError: No more handles" ------------------------------------------------------------------------------------------------------------------------ Key: JBIDE-10202 URL: https://issues.jboss.org/browse/JBIDE-10202 Project: Tools (JBoss Tools) Issue Type: Bug Components: Visual Page Editor core Affects Versions: 3.3.0.M4 Reporter: Vitali Yemialyanchyk Assignee: Yahor Radtsevich Priority: Critical Sometimes this issue leads to {code} Error Unhandled event loop exception org.eclipse.swt.SWTError: No more handles at org.eclipse.swt.SWT.error(SWT.java:4308) at org.eclipse.swt.SWT.error(SWT.java:4197) at org.eclipse.swt.SWT.error(SWT.java:4168) at org.eclipse.swt.widgets.Widget.error(Widget.java:468) at org.eclipse.swt.widgets.Control.createHandle(Control.java:704) at org.eclipse.swt.widgets.Composite.createHandle(Composite.java:305) at org.eclipse.swt.widgets.Control.createWidget(Control.java:744) at org.eclipse.swt.widgets.Scrollable.createWidget(Scrollable.java:134) at org.eclipse.swt.widgets.Control.<init>(Control.java:112) at org.eclipse.swt.widgets.Scrollable.<init>(Scrollable.java:75) {code} and only restart of whole eclipse can helps. ImageDescriptor -> createImage() - from documentation to this function: {code} * Creates and returns a new SWT image for this image descriptor. Note that * each call returns a new SWT image object. The returned image must be * explicitly disposed using the image's dispose call. The image will not be * automatically garbage collected. ... {code} here you create images, but did not dispose it: {code} at org.jboss.tools.vpe.editor.toolbar.format.TextFormattingToolBar.createItems(TextFormattingToolBar.java:180) {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 6 months

5
7
0 / 0

[JBoss JIRA] (JBIDE-10231) org.jboss.tools.common.model has potential Image leaks

by Vitali Yemialyanchyk (Created) (JIRA)

org.jboss.tools.common.model has potential Image leaks ------------------------------------------------------ Key: JBIDE-10231 URL: https://issues.jboss.org/browse/JBIDE-10231 Project: Tools (JBoss Tools) Issue Type: Sub-task Components: common/jst/core Affects Versions: 3.3.0.M4 Reporter: Vitali Yemialyanchyk Assignee: Alexey Kazakov Priority: Minor small note -> org.jboss.tools.common.model.icons.impl.XStudioIcons: {code} public Image getImage(XModelObject obj) { <---------------- this function create Image and does not dispose it - so real name should sounds like createImage(...) String s = obj.getAttributeValue("image"); //$NON-NLS-1$ byte[] b = decode(s); if(b != null) { try { ByteArrayInputStream is = new ByteArrayInputStream(b); ImageData id = new ImageData(is); Image i = new Image(null, id); <---- create image here return i; } catch (SWTException e) { ModelPlugin.getPluginLog().logError(e); } catch (SWTError e) { ModelPlugin.getPluginLog().logError(e); } } return obj.getModelEntity().getMetaModel().getIconList().getImage("default.unknown"); //$NON-NLS-1$ } {code} org.jboss.tools.common.model.icons.impl.XModelObjectIcon {code} private static Hashtable<String,Image> cacheEclipse = new Hashtable<String,Image>(); {code} all images which XStudioIcons creates --> in cacheEclipse. but what is happens if you reload org.jboss.tools.common.model plugin? I do not sure, but look like you'll get resource leak here. may be a better choise is to use AbstractUIPlugin.getImageRegistry(), i.e. ModelPlugin.getDefault().getImageRegistry() -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 6 months

4
4
0 / 0

[JBoss JIRA] (JBIDE-10229) org.jboss.tools.jst.css.dialog.ImageSelectionDialog has GC leaks logik

by Vitali Yemialyanchyk (Created) (JIRA)

org.jboss.tools.jst.css.dialog.ImageSelectionDialog has GC leaks logik ---------------------------------------------------------------------- Key: JBIDE-10229 URL: https://issues.jboss.org/browse/JBIDE-10229 Project: Tools (JBoss Tools) Issue Type: Sub-task Components: common/jst/core Affects Versions: 3.3.0.M4 Reporter: Vitali Yemialyanchyk Assignee: Alexey Kazakov {code} canvas.addPaintListener(new PaintListener() { public void paintControl(PaintEvent e) { GC gc = new GC(canvas); <-------------------------- here you create GC gc.setForeground(emptyColor); gc.fillRectangle(1, 1, canvas.getSize().x - 2, canvas.getSize().y - 2); // resolution.setText(""); resolution.setVisible(false); if (file != null) { <-------------------------- here you check condition Cursor parentCursor = getShell().getCursor(); final Cursor waitCursor = new Cursor(getShell().getDisplay(), SWT.CURSOR_WAIT); Point previewPoint = new Point(0, 0); Point labelPoint = canvas.getSize(); InputStream stream = null; try { getShell().setCursor(waitCursor); stream = new FileInputStream(file.getLocation().toOSString()); ImageData imageData = new ImageData(stream); stream.close(); if (imageData != null) { Image image = new Image(getShell().getDisplay(), imageData); // set image in center Point imagePoint = new Point(image.getBounds().width, image.getBounds().height); String imageInfo = imagePoint.x + " x " + imagePoint.y + " px"; //$NON-NLS-1$ //$NON-NLS-2$ // change resolution if image anymore image label if ((imagePoint.x > labelPoint.x) || (imagePoint.y > labelPoint.y)) { float ratioImage = (float) imagePoint.x / (float) imagePoint.y; if (((imagePoint.y > labelPoint.y) && ((labelPoint.y * ratioImage) > labelPoint.x)) || ((imagePoint.x > labelPoint.x) && ((labelPoint.x / ratioImage) < labelPoint.y))) { imageData = imageData.scaledTo(labelPoint.x - 10, (int) (labelPoint.x / ratioImage)); } else { imageData = imageData.scaledTo((int) (labelPoint.y * ratioImage) - 10, labelPoint.y); } image.dispose(); image = new Image(getShell().getDisplay(), imageData); imagePoint.x = image.getBounds().width; imagePoint.y = image.getBounds().height; } previewPoint.x = (labelPoint.x / 2) - (imagePoint.x / 2); previewPoint.y = (labelPoint.y / 2) - (imagePoint.y / 2); gc.drawImage(image, previewPoint.x, previewPoint.y); resolution.setVisible(true); resolution.setText(imageInfo); image.dispose(); gc.dispose(); <-------------------------- here you dispose } } catch (IOException ev) { //ignore } catch (SWTException ex) { //ignore (if select not image file) } finally { getShell().setCursor(parentCursor); if (stream != null) { try { stream.close(); } catch (IOException e1) { // ignore } } } } } }); {code} here is absolutely invalid logic, guys :) you close the stream in two places - try to find: stream.close(); I've check a history of changes: >>> PMD violations fixed. InputStreams close() added where it was possible. >>> 8/29/08 - someone try to close all streams where it possible, after that all of you respect his authority and afraid to fix his error... btw., you are still has a problems with "close of all streams", after 8/29/08 changes... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 6 months

5
5
0 / 0

[JBoss JIRA] (JBIDE-10242) org.jboss.tools.common.model.util.ModelImages has image leaks

by Vitali Yemialyanchyk (Created) (JIRA)

org.jboss.tools.common.model.util.ModelImages has image leaks ------------------------------------------------------------- Key: JBIDE-10242 URL: https://issues.jboss.org/browse/JBIDE-10242 Project: Tools (JBoss Tools) Issue Type: Sub-task Components: common/jst/core Affects Versions: 3.3.0.M4 Reporter: Vitali Yemialyanchyk Assignee: Alexey Kazakov from line 33: {code} public static Image getImage(String key) { return instance.createImageDescriptor(key).createImage(); } {code} try to inspect Call Hierarchy of the function - there are a lot of places with Image leak here. imo, getImage is not correct name here -> should be createImage in minimum, maximum is necessary to change logic. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 6 months

4
3
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jbosstools-issues December 2011