[JBoss JIRA] Created: (JBIDE-9525) PublishCopyUtil#copyFile throws an Exception but it's impl catches it and returns an IStatus instead
by Andre Dietisheim (JIRA)
PublishCopyUtil#copyFile throws an Exception but it's impl catches it and returns an IStatus instead
----------------------------------------------------------------------------------------------------
Key: JBIDE-9525
URL: https://issues.jboss.org/browse/JBIDE-9525
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: JBossAS
Affects Versions: 3.3.0.M3
Reporter: Andre Dietisheim
Assignee: Rob Stryker
Fix For: 3.3.x
see https://source.jboss.org/cru/REV-JBIDE-4/#c79
PublishCopyUtil#copyFile should either throw Exceptions or return status objects. The current impl where exceptions are declared in the method signature but catched in the impl makes no sense. We have to decide what strategy to take (either throw or catch and return status).
{code}
private IStatus copyFile(InputStream in, IPath to, long ts, IModuleFile mf) throws CoreException {
File tempFile = null;
try {
File file = to.toFile();
tempFile = writeToTempFile(in, to);
moveTempFile(tempFile, file);
if (ts != IResource.NULL_STAMP && ts != 0)
file.setLastModified(ts);
} catch (CoreException e) {
throw e;
} catch (Exception e) {
IPath path = mf.getModuleRelativePath().append(mf.getName());
return new Status(IStatus.ERROR, ServerPlugin.PLUGIN_ID, IEventCodes.JST_PUB_FAIL, NLS.bind(Messages.errorCopyingFile, path.toOSString(), e.getLocalizedMessage()), null);
} finally {
if (tempFile != null && tempFile.exists())
tempFile.deleteOnExit();
try {
if (in != null)
in.close();
} catch (Exception ex) {
// ignore
}
}
return null;
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 1 month
[JBoss JIRA] Created: (JBIDE-9076) Port text field in server editor should not allow you to enter alphanumeric values
by Andre Dietisheim (JIRA)
Port text field in server editor should not allow you to enter alphanumeric values
----------------------------------------------------------------------------------
Key: JBIDE-9076
URL: https://issues.jboss.org/browse/JBIDE-9076
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: JBossAS
Affects Versions: 3.3.0.M1
Reporter: Andre Dietisheim
Assignee: Rob Stryker
Fix For: 3.3.x
Attachments: invalid-port-value.png, saved-even-though-invalid.png
The server editor allows you to enter alphanumeric aka invalid port values. If you then try to save the editor, you'll get an error that tells you that the editor could not be saved because of invalid values.
!invalid-port-value.png!
The editor gets saved though - the editor gets clean even though the value is still present in the editor.
!saved-even-though-invalid.png!
We can avoid this easily by disallowing alphanumeric values while typing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 1 month
[JBoss JIRA] Created: (JBIDE-9326) Replace Delegates-mapping by proper solution
by Andre Dietisheim (JIRA)
Replace Delegates-mapping by proper solution
--------------------------------------------
Key: JBIDE-9326
URL: https://issues.jboss.org/browse/JBIDE-9326
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: JBossAS
Affects Versions: 3.3.0.M3
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 3.3.x
We implementation our own delegation on top of the wtp delegation because WTP is not flexible enough for our needs. We did not want to have separate servers for remote/local behavior and we therefore provide a single server which may be switch to local/remote behavior and delegates to appropriate components.
The components are currently mapped to local/remote behaviors on behalf of static maps:
* DelegatingJBoss7ServerBehavior#addDelegateMapping
* DelegatingJBoss7ServerBehavior#getDelegateMap
* DelegatingServerBehavior#addDelegateMapping
* DelegatingServerBehavior#getDelegate
etc.
This solution works but is far from optimal since all those statics make subclassing pretty hard. Furthermore it basically does what the platform provides by extensions and osgi services.
We should replace the current implementation by those platform mechanisms.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 1 month
[JBoss JIRA] Created: (JBIDE-8458) Mavenized Seam EAR Project can't be deployed to JBoss AS 6.0.0.Final
by Snjezana Peco (JIRA)
Mavenized Seam EAR Project can't be deployed to JBoss AS 6.0.0.Final
--------------------------------------------------------------------
Key: JBIDE-8458
URL: https://issues.jboss.org/browse/JBIDE-8458
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: maven
Affects Versions: 3.2.0.Final
Reporter: Snjezana Peco
Assignee: Snjezana Peco
Fix For: 3.3.0.M1
If you create a mavenized Seam EAR project using the New Seam Web Project wizard, it will create application.xml that contains the following entries:
...
<module>
<ejb>/test-ejb.jar</ejb>
</module>
<module>
<ejb>/jboss-seam-2.2.1.Final.jar</ejb>
</module>
<module>
<web>
<web-uri>/test.war</web-uri>
<context-root>test</context-root>
</web>
</module>
...
Such a project can be deployed to JBoss AS <= 6.0, but can't to JBoss AS 6.0.0
A workaround is to open the EAR's pom.xml and remove the bundleDir element for ejb and web modules.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 1 month