[JBoss JIRA] Created: (JBIDE-9524) PublishCopyUtil#copyFile should not catch Exception but IOException
by Andre Dietisheim (JIRA)
PublishCopyUtil#copyFile should not catch Exception but IOException
-------------------------------------------------------------------
Key: JBIDE-9524
URL: https://issues.jboss.org/browse/JBIDE-9524
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: JBossAS
Affects Versions: 3.3.0.M3
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 3.3.0.M3
see https://source.jboss.org/cru/REV-JBIDE-4/#c80
{code}
private IStatus copyFile(InputStream in, String to) {
try {
FileUtils.writeTo(in, to);
return Status.OK_STATUS;
} catch (Exception e) {
//Trace.trace(Trace.SEVERE, "Error copying file", e);
return new Status(IStatus.ERROR, ServerPlugin.PLUGIN_ID, IEventCodes.JST_PUB_FAIL, NLS.bind(Messages.errorCopyingFile, new String[] {to, e.getLocalizedMessage()}), e);
} finally {
try {
if (in != null)
in.close();
} catch (Exception ex) {
// ignore
}
}
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years
[JBoss JIRA] Created: (JBIDE-9549) add egit/jgit bundles to target platform
by Andre Dietisheim (JIRA)
add egit/jgit bundles to target platform
----------------------------------------
Key: JBIDE-9549
URL: https://issues.jboss.org/browse/JBIDE-9549
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: JBossAS
Affects Versions: 3.3.0.M3
Reporter: Andre Dietisheim
Assignee: Nick Boldt
the build on hudson currently fails. it misses the egit/jgit bundles:
Bundle org.jboss.ide.eclipse.as.egit.core - Missing Constraint: Require-Bundle: org.eclipse.jgit; bundle-version="[1.1.0,2.0.0)"
Bundle org.jboss.ide.eclipse.as.egit.core - Missing Constraint: Require-Bundle: org.eclipse.egit; bundle-version="[1.1.0,2.0.0)"
Bundle org.jboss.ide.eclipse.as.egit.core - Missing Constraint: Require-Bundle: org.eclipse.egit.core; bundle-version="[1.1.0,2.0.0)"
Bundle org.jboss.ide.eclipse.as.egit.core - Missing Constraint: Require-Bundle: org.eclipse.egit.ui; bundle-version="[1.1.0,2.0.0)"
see http://hudson.qa.jboss.com/hudson/job/jbosstools-3.3_trunk.continuous/254...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years
[JBoss JIRA] Created: (JBIDE-9367) Launch remote server: build command from scratch, dont take the local launch and convert it
by Andre Dietisheim (JIRA)
Launch remote server: build command from scratch, dont take the local launch and convert it
-------------------------------------------------------------------------------------------
Key: JBIDE-9367
URL: https://issues.jboss.org/browse/JBIDE-9367
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: JBossAS
Affects Versions: 3.3.0.M3
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 3.3.0.M3
The current implementation that launches remote servers takes the current configuration (launch config tab) for local launches and changes it so that it works for remote servers. We have to build that remote launch from scratch instead since our goal would be to offer the local OR the remote launch (depending on the server config) at some point.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years
[JBoss JIRA] Created: (JBIDE-9359) Refactor PollThread so that it does not call server behavior but informs a listener
by Andre Dietisheim (JIRA)
Refactor PollThread so that it does not call server behavior but informs a listener
-----------------------------------------------------------------------------------
Key: JBIDE-9359
URL: https://issues.jboss.org/browse/JBIDE-9359
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: JBossAS
Affects Versions: 3.3.0.M3
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 3.3.0.M3
The current impl of PollThread is instantiated by the server behavior and then calls the server behavior again (calls stop(force) on it). This is pretty much not what a dumb user programmer would expect. He would expect the poll thread to poll and return it's result to its caller. Furthermore this is not ideal in terms of separations of concerns, since the poll thread implements a strategy to apply if the polling did not reach the expected state (server is up / server is down). A proper design would be to have a poller that polls for the state only and then passes back to the server behavior that then decides what to do in these cases.
We can achieve this by replacing the call to the behavior by a listener.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years
[JBoss JIRA] Created: (JBIDE-9398) Wizard "Add JSF capabilities..." not conform with JSF 2
by Juergen Zimmermann (JIRA)
Wizard "Add JSF capabilities..." not conform with JSF 2
-------------------------------------------------------
Key: JBIDE-9398
URL: https://issues.jboss.org/browse/JBIDE-9398
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: JSF
Affects Versions: 3.3.0.M2
Reporter: Juergen Zimmermann
Assignee: Alexey Kazakov
When the wizard for "Add JSF capabilities..." is invoked and the Servlet version "3.0" is selected, then the wizard adds to web.xml the following lines:
<servlet>
<servlet-name>Faces Config</servlet-name>
<servlet-class>javax.faces.webapp.FacesServlet</servlet-class>
</servlet>
<servlet-mapping>
<servlet-name>Faces Config</servlet-name>
<url-pattern>*.jsf</url-pattern>
</servlet-mapping>
However, according to the JSF 2.0 spec two additional mappings are also defined:
<servlet-mapping>
<servlet-name>Faces Config</servlet-name>
<url-pattern>/faces/*</url-pattern>
</servlet-mapping>
<servlet-mapping>
<servlet-name>Faces Config</servlet-name>
<url-pattern>*.faces</url-pattern>
</servlet-mapping>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years
[JBoss JIRA] Created: (JBIDE-9397) Create a separate feature for JSF Tools
by Alexey Kazakov (JIRA)
Create a separate feature for JSF Tools
---------------------------------------
Key: JBIDE-9397
URL: https://issues.jboss.org/browse/JBIDE-9397
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Build/Releng
Affects Versions: 3.3.0.M2
Reporter: Alexey Kazakov
Assignee: Denis Golovin
Right now, if you need JSF tools you have to install RichFaces feature that bundles a set of components: JST, JSF, VPE, ...
It can confuse users.
Here is the story that illustrates the possible problem:
Jose Freitas (Seam 3 team) complained that code completion is not working for seam faces tags. It turned out that he installed CDI, Maven, AS, Hibernate tools but didn't install RichFaces feature. He just didn't realize that the RichFaces feature is much more than just RichFaces support. He didn't install it and as a result he didn't get JSF Tools. So JSF code completion didn't work for his project.
It would be good to have a separate JSF Tools feature that requires only reasonable dependencies (such as Common, JST) and doesn't require VPE.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years
[JBoss JIRA] Created: (JBIDE-9500) AS7: org.jboss.ide.eclipse.as.management.as7 has inconsistent package naming
by Andre Dietisheim (JIRA)
AS7: org.jboss.ide.eclipse.as.management.as7 has inconsistent package naming
----------------------------------------------------------------------------
Key: JBIDE-9500
URL: https://issues.jboss.org/browse/JBIDE-9500
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: JBossAS
Affects Versions: 3.3.0.M3
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 3.3.0.M3
The plugin org.jboss.ide.eclipse.as.management.as7 does not comply to the general eclipse rule where internal package are not exported whereas non-internal packages are exported. We need to correct this.
Furthermore the internal marker appears in the wrong location in the naming scheme. It is called org.jboss.ide.eclipse.as.management.as7.internal whereas it should be called org.jboss.ide.eclipse.as.internal.management.as7
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years