[JBoss JIRA] (JBIDE-11799) code cleanup for runtime as detector
by Rob Stryker (JIRA)
Rob Stryker created JBIDE-11799:
-----------------------------------
Summary: code cleanup for runtime as detector
Key: JBIDE-11799
URL: https://issues.jboss.org/browse/JBIDE-11799
Project: Tools (JBoss Tools)
Issue Type: Task
Components: runtime detection
Affects Versions: 3.3.0.CR1
Reporter: Rob Stryker
Assignee: Snjezana Peco
Fix For: 3.3.0.CR1
Attachments: JBIDE-11799.patch
The code for as-detector is pretty hard to read. It seems much of the design was because effort was made to avoid depending on ASTools. The AS-detector has depended on ASTools for a while, though, so it seems like a good time to really clean that code and help make the number of problems smaller wherever possible.
I'm attaching a patch which makes use of newer APIs in astools which helped remove a lot of the code in the ASHandler. I also separated out the driver stuff into its own class to keep it cleaner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 11 months
[JBoss JIRA] (JBIDE-11667) PortForward: When not using 127.0.0.1 I get hard error - should just bring the status into "error"
by Max Rydahl Andersen (JIRA)
Max Rydahl Andersen created JBIDE-11667:
-------------------------------------------
Summary: PortForward: When not using 127.0.0.1 I get hard error - should just bring the status into "error"
Key: JBIDE-11667
URL: https://issues.jboss.org/browse/JBIDE-11667
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Reporter: Max Rydahl Andersen
Assignee: Andre Dietisheim
Fix For: 3.3.0.Beta3
On a Mac, Start forward, uncheck 127.0.0.1 and press start all
Gets hard error and no info.
Error logs says:
com.openshift.client.OpenShiftSSHOperationException: Failed to start port forwarding on 127.4.92.2:8080
at com.openshift.internal.client.ssh.ApplicationPortForwarding.start(ApplicationPortForwarding.java:56)
at com.openshift.internal.client.ApplicationResource.startPortForwarding(ApplicationResource.java:611)
at org.jboss.tools.openshift.express.internal.core.portforward.ApplicationPortForwardingWizardPage$3$1.run(ApplicationPortForwardingWizardPage.java:156)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Caused by: com.jcraft.jsch.JSchException: PortForwardingL: local port 127.4.92.2:8080 cannot be bound.
at com.jcraft.jsch.PortWatcher.<init>(PortWatcher.java:146)
at com.jcraft.jsch.PortWatcher.addPort(PortWatcher.java:99)
at com.jcraft.jsch.Session.setPortForwardingL(Session.java:1617)
at com.jcraft.jsch.Session.setPortForwardingL(Session.java:1614)
at com.openshift.internal.client.ssh.ApplicationPortForwarding.start(ApplicationPortForwarding.java:53)
... 3 more
Caused by: java.net.BindException: Can't assign requested address
at java.net.PlainSocketImpl.socketBind(Native Method)
at java.net.PlainSocketImpl.bind(PlainSocketImpl.java:383)
at java.net.ServerSocket.bind(ServerSocket.java:328)
at java.net.ServerSocket.<init>(ServerSocket.java:194)
at com.jcraft.jsch.PortWatcher.<init>(PortWatcher.java:138)
... 7 more
This is an expected error but could just happen for a few out of all ports - should just collect these errors and show info about which ip/ports could not be forwarded and have them be in error state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 11 months
[JBoss JIRA] Created: (JBDS-1379) JBDS 4 Beta 1 installer fails on Create Shortcuts (8 of 9)
by Burr Sutter (JIRA)
JBDS 4 Beta 1 installer fails on Create Shortcuts (8 of 9)
----------------------------------------------------------
Key: JBDS-1379
URL: https://jira.jboss.org/browse/JBDS-1379
Project: Developer Studio (JBoss Developer Studio)
Issue Type: Bug
Components: installer
Affects Versions: 4.0.0.Beta1
Environment: Win7 64-bit, Java 6 64-bit running the installer
Reporter: Burr Sutter
D:\Users\Burr\Downloads>java -jar jbdevstudio-win32-4.0.0.v201010160636R-H52-Bet
a1.jar
C:\Program Files\Java\jre6
calltarget:
main:
[echo] Run p2 metadata generator
[p2] Generating metadata for D:\tools\jbdevstudio4_beta1_again\eclipse.
[p2] Generation completed with success [0 seconds].
[delete] Deleting: C:\Users\Burr\AppData\Local\Temp\artifacts.jar
[delete] Deleting: C:\Users\Burr\AppData\Local\Temp\content.jar
[delete] Deleting directory C:\Users\Burr\AppData\Local\Temp\binary
could not create shortcut instance
java.lang.Exception: error loading library
java.lang.Exception: can't locate library
at com.izforge.izpack.util.Librarian.loadArchSpecificLibrary(Unknown Sou
rce)
at com.izforge.izpack.util.Librarian.loadLibrary(Unknown Source)
at com.izforge.izpack.util.os.ShellLink.initialize(Unknown Source)
at com.izforge.izpack.util.os.ShellLink.<init>(Unknown Source)
at com.izforge.izpack.util.os.Win_Shortcut.initialize(Unknown Source)
at com.izforge.izpack.panels.ShortcutPanel.panelActivate(Unknown Source)
at com.izforge.izpack.installer.InstallerFrame.switchPanel(Unknown Sourc
e)
at com.izforge.izpack.installer.InstallerFrame.navigateNext(Unknown Sour
ce)
at com.izforge.izpack.installer.InstallerFrame.skipPanel(Unknown Source)
at com.jboss.jbds.installer.CreateLinkPanel.panelActivate(CreateLinkPane
l.java:61)
at com.izforge.izpack.installer.InstallerFrame.switchPanel(Unknown Sourc
e)
at com.izforge.izpack.installer.InstallerFrame.navigateNext(Unknown Sour
ce)
at com.izforge.izpack.installer.InstallerFrame.navigateNext(Unknown Sour
ce)
at com.izforge.izpack.installer.InstallerFrame$NavigationHandler.actionP
erformed(Unknown Source)
at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Sour
ce)
at java.awt.Component.processMouseEvent(Unknown Source)
at javax.swing.JComponent.processMouseEvent(Unknown Source)
at java.awt.Component.processEvent(Unknown Source)
at java.awt.Container.processEvent(Unknown Source)
at java.awt.Component.dispatchEventImpl(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Window.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)
java.lang.NullPointerException
at com.izforge.izpack.util.os.Win_Shortcut.getProgramsFolder(Unknown Sou
rce)
at com.izforge.izpack.panels.ShortcutPanel.getProgramsFolder(Unknown Sou
rce)
at com.izforge.izpack.panels.ShortcutPanel.panelActivate(Unknown Source)
at com.izforge.izpack.installer.InstallerFrame.switchPanel(Unknown Sourc
e)
at com.izforge.izpack.installer.InstallerFrame.navigateNext(Unknown Sour
ce)
at com.izforge.izpack.installer.InstallerFrame.skipPanel(Unknown Source)
at com.jboss.jbds.installer.CreateLinkPanel.panelActivate(CreateLinkPane
l.java:61)
at com.izforge.izpack.installer.InstallerFrame.switchPanel(Unknown Sourc
e)
at com.izforge.izpack.installer.InstallerFrame.navigateNext(Unknown Sour
ce)
at com.izforge.izpack.installer.InstallerFrame.navigateNext(Unknown Sour
ce)
at com.izforge.izpack.installer.InstallerFrame$NavigationHandler.actionP
erformed(Unknown Source)
at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Sour
ce)
at java.awt.Component.processMouseEvent(Unknown Source)
at javax.swing.JComponent.processMouseEvent(Unknown Source)
at java.awt.Component.processEvent(Unknown Source)
at java.awt.Container.processEvent(Unknown Source)
at java.awt.Component.dispatchEventImpl(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Window.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)
D:\Users\Burr\Downloads>java -version
java version "1.6.0_20"
Java(TM) SE Runtime Environment (build 1.6.0_20-b02)
Java HotSpot(TM) 64-Bit Server VM (build 16.3-b01, mixed mode)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 11 months
[JBoss JIRA] (JBDS-1931) evaluate Jenkins slave use for JBDS/JBT build jobs
by Nick Boldt (Created) (JIRA)
evaluate Jenkins slave use for JBDS/JBT build jobs
--------------------------------------------------
Key: JBDS-1931
URL: https://issues.jboss.org/browse/JBDS-1931
Project: Developer Studio (JBoss Developer Studio)
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: Build
Affects Versions: 5.0.0.Beta1
Reporter: Nick Boldt
Assignee: Nick Boldt
Fix For: 5.0.0.Beta1
Most jobs run on
{code}
<assignedNode>RHEL_any&&!RHEL4-ia64</assignedNode>
or
<assignedNode>RHEL5_any</assignedNode>
{code}
However, a few are still tied to either RHEL5_x86, RHEL5_x86_64, RHEL4_x86 or RHEL4_x86_64.
And there's a new group of 5 slaves under RHEL6_x86_64 on which we could be building.
TODO:
1. fix jobs' assignedNodes
2. assign nodes to better labels (for example, there's no RHEL6_any and I don't know if the 5 slaves in RHEL6_x86_64 are also included in RHEL_any).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 11 months
[JBoss JIRA] (JBIDE-11696) portforward: start/stop errors instantly so no error handling possible and if one port fails all other fails too
by Max Rydahl Andersen (JIRA)
Max Rydahl Andersen created JBIDE-11696:
-------------------------------------------
Summary: portforward: start/stop errors instantly so no error handling possible and if one port fails all other fails too
Key: JBIDE-11696
URL: https://issues.jboss.org/browse/JBIDE-11696
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Reporter: Max Rydahl Andersen
Assignee: Andre Dietisheim
Fix For: 3.3.0.Beta3
workaround patch for client:
diff --git a/src/main/java/com/openshift/internal/client/ApplicationResource.java b/src/main/java/com/openshift/internal/client/ApplicationResource.java
index 60b4bfe..aaebd09 100755
--- a/src/main/java/com/openshift/internal/client/ApplicationResource.java
+++ b/src/main/java/com/openshift/internal/client/ApplicationResource.java
@@ -616,14 +616,24 @@ public class ApplicationResource extends AbstractOpenShiftResource implements IA
throw new OpenShiftSSHOperationException("SSH session for application \"{0}\" is closed or null. Cannot start port forwarding", this.getName());
}
for (IApplicationPortForwarding port : ports) {
- port.start(session);
+ try {
+ port.start(session);
+ } catch(OpenShiftSSHOperationException oss) {
+ // ignore for now
+ // should store this error on the forward to let user know why it could not start/stop
+ }
}
return ports;
}
public List<IApplicationPortForwarding> stopPortForwarding() throws OpenShiftSSHOperationException {
for (IApplicationPortForwarding port : ports) {
- port.stop(session);
+ try {
+ port.stop(session);
+ } catch(OpenShiftSSHOperationException oss) {
+ // ignore for now
+ // should store this error on the forward to let user know why it could not start/stop
+ }
}
// make sure port forwarding is stopped by closing session...
session.disconnect();
patch in ui:
Index: plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/core/portforward/ApplicationPortForwardingWizardPage.java
===================================================================
--- plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/core/portforward/ApplicationPortForwardingWizardPage.java (revision 40574)
+++ plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/core/portforward/ApplicationPortForwardingWizardPage.java (working copy)
@@ -194,7 +194,7 @@
wizardModel.startPortForwarding();
refreshViewerInput();
} catch (Exception e) {
- Logger.error("Failed to start port-forwarding", e);
+ return OpenShiftUIActivator.createErrorStatus("Failed to start port-forwarding.", e);
}
return Status.OK_STATUS;
}
@@ -227,7 +227,7 @@
wizardModel.stopPortForwarding();
refreshViewerInput();
} catch (Exception e) {
- Logger.error("Failed to stop Port-forwarding", e);
+ return OpenShiftUIActivator.createErrorStatus("Failed to stop port-forwarding.", e);
}
return Status.OK_STATUS;
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 11 months
[JBoss JIRA] (JBIDE-11301) no stacktrace when junit tests fail
by Alexey Kazakov (JIRA)
Alexey Kazakov created JBIDE-11301:
--------------------------------------
Summary: no stacktrace when junit tests fail
Key: JBIDE-11301
URL: https://issues.jboss.org/browse/JBIDE-11301
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Build/Releng
Affects Versions: 3.3.0.Beta2
Reporter: Alexey Kazakov
Assignee: Nick Boldt
If I run JBT tycho build locally for trunk, for example:
mvn clean install -fae -e -P default -f cdi/tests/pom.xml
and there is some test failures then I don't see any stacktrace in console. Just a text message from the JUnit test assert.
-Dsurefire.useFile=false does not help.
But I see the stacktrace in <target>/surefire-reports
In Beta1 branch it works fine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 11 months