[JBoss JIRA] (JBIDE-12398) Bug in PollThread, mixing up expected nad actual when alerting listeners
by Rob Stryker (JIRA)
Rob Stryker created JBIDE-12398:
-----------------------------------
Summary: Bug in PollThread, mixing up expected nad actual when alerting listeners
Key: JBIDE-12398
URL: https://issues.jboss.org/browse/JBIDE-12398
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: JBossAS/Servers
Affects Versions: 3.4.0.M1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 3.4.0.M1
There is currently only one implementer of the interface which is being misued, and that specific instance is not affected by the bug. This is a bug only discoverable via unit test. There is no behaviour change at all for it.
The interface IPollResultListener has two methods:
public void stateAsserted(boolean expectedState, boolean currentState);
public void stateNotAsserted(boolean expectedState, boolean currentState);
The PollThread class is misusing these methods, and instead calling with the parameters reversed. In the case of stateAsserted(bool, bool), this is not able to be noticed. In this case, it is saying the transition worked, so both values will be the same no matter what. Either expected is up or down, and, necessarily, the actual value will be the same as expected.
In the case of stateNotAsserted, however, the ordering definitely matters. Either the server is up when it should be down, or it is down when it should be up. This difference matters.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years
[JBoss JIRA] (JBIDE-12360) Wrapper bug for mistake commit
by Rob Stryker (JIRA)
Rob Stryker created JBIDE-12360:
-----------------------------------
Summary: Wrapper bug for mistake commit
Key: JBIDE-12360
URL: https://issues.jboss.org/browse/JBIDE-12360
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: JBossAS/Servers
Affects Versions: 3.3.1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 3.3.2, 3.4.0.M1
The following commit was mistakenly sent in at once due to a faulty commit command. Committed revision 42683.
https://source.jboss.org/changelog/JBossTools?cs=42683
The changes include:
1) Organizing imports
2) A significant error in WorkspaceFIlesetVirtualComponent
3) An error in WTPZippedPublisher which sent the zipped archive to the remote machine TWICE unnecessarily.
4) Slightly enhanced API (added api, none changed or removed) to allow easier access to the deployment per-module preferences
5) An *INCORRECT* change to ServerCreationUtils turning off auto-deployment for newly created servers. This should properly be placed in teh TEST SUITE, and not in the main code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years
[JBoss JIRA] (JBIDE-12362) ZIpped publish over the wire sends zip file twice instead of once
by Rob Stryker (JIRA)
Rob Stryker created JBIDE-12362:
-----------------------------------
Summary: ZIpped publish over the wire sends zip file twice instead of once
Key: JBIDE-12362
URL: https://issues.jboss.org/browse/JBIDE-12362
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: JBossAS/Servers
Affects Versions: 3.3.1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 3.3.2, 3.4.0.M1
3) An error in WTPZippedPublisher which sent the zipped archive to the remote machine TWICE unnecessarily.
4) Slightly enhanced API (added api, none changed or removed) to allow easier access to the deployment per-module preferences
To reproduce, well, you'd have to use breakpoints really. Inspecting the progress monitor won't do much, because it will still look like it's sending the same file. It will be hard to tell when the first transfer has finished and the second began.
The original commit to trunk was made over at JBIDE-12360
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years
[JBoss JIRA] (JBIDE-11990) When as7 server fails to start correctly but process is running it fails to stop the process after reaching time out
by Martin Malina (JIRA)
Martin Malina created JBIDE-11990:
-------------------------------------
Summary: When as7 server fails to start correctly but process is running it fails to stop the process after reaching time out
Key: JBIDE-11990
URL: https://issues.jboss.org/browse/JBIDE-11990
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: JBossAS/Servers
Affects Versions: 3.3.0.CR1
Environment: JBT 3.3 nightly 2012-05-24
Reporter: Martin Malina
Assignee: Rob Stryker
Fix For: 3.3.1
As a consequence of hitting JBIDE-11989 I found another problem. If for whatever reason the server fails to start properly (e.g. -Djboss.bind.address.management set to null) this is what happens:
1. The process keeps running on the remote host
2. The server is in Starting state until it reaches time out
3. This is where remote and local servers differ, but both behave wrongly
3.a - remote server: When time out is reached, server stops, but the process keeps running - you have to kill it manually
3.b - local server: When time out is reached, server tries to stop, but fails doing so. So you have to force stop and then it stops and the process is killed.
The the bigger problem is with remote servers - you have no way of stopping the server other than sshing to the server and killing the process.
In the case of local server, it is not so bad, but still after the time out the tools should be able to stop the server on first attempt.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years
[JBoss JIRA] (JBIDE-12361) PRoblem with WorkspaceFIlesetVirtualComponent, publish using fileset virtual component
by Rob Stryker (JIRA)
Rob Stryker created JBIDE-12361:
-----------------------------------
Summary: PRoblem with WorkspaceFIlesetVirtualComponent, publish using fileset virtual component
Key: JBIDE-12361
URL: https://issues.jboss.org/browse/JBIDE-12361
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: JBossAS/Servers
Affects Versions: 3.3.1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 3.3.2, 3.4.0.M1
Steps to reproduce:
1) Create a dynamic web project
2) Create a POJP
3) Inside POJP, make some file structure (foldera, foldera/file1.txt, foldera/file2.txt, folderb, folderb/b1.txt, etc)
4) Right-click web project, go to deployment assembly page
5) click add
6) click 'fileset'
7) set root to /pojp
8) set includes pattern to **/file1*
9) finish
10) publish this to some server
You will note that matching files inside a subdirectory that is not explicitly included in the includes pattern does not get included. In this case, foldera/file1.txt will not be included, and folder 'foldera' will also not be created in the deployment. This is a bug.
Part of this commit has been made over at JBIDE-12360 by accident
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years
[JBoss JIRA] (JBIDE-12033) New Seam Project Wizard - when AS7 runtime is set, seam config is not set properly after changing to EAP5.1.2 runtime
by Martin Malina (JIRA)
Martin Malina created JBIDE-12033:
-------------------------------------
Summary: New Seam Project Wizard - when AS7 runtime is set, seam config is not set properly after changing to EAP5.1.2 runtime
Key: JBIDE-12033
URL: https://issues.jboss.org/browse/JBIDE-12033
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Seam 2
Affects Versions: 3.3.0.CR1
Environment: jbdevstudio-product-universal-5.0.0.v201205272317M-H143-CR1.jar
Reporter: Martin Malina
Assignee: Alexey Kazakov
Fix For: 3.3.1
I guess this is not really so urgent, so targeting for 3.3.1.
While verifying JBIDE-11815, I noticed the following:
When you open the New Seam Project Wizard and select AS7/EAP6 runtime, both Dynamic web module and Configuration are set properly, to 3.0 and Dynamic Web Project with Seam 2.3, respectively.
But when you then change the runtime to EAP 5.1.2 the web module version is not changed (it stays empty) and the Configuration is set to <custom>. Even if set the web module to 2.5, Configuration is not set to Seam 2.2.
I would expect that after changing runtime to EAP 5.1, both web module version and configuration would be changed accordingly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years