[JBoss JIRA] (JBIDE-15853) plugins w/o test classes should not be set to packaging=eclipse-test-plugin
by Vlado Pakan (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15853?page=com.atlassian.jira.plugi... ]
Vlado Pakan commented on JBIDE-15853:
-------------------------------------
PR applied
> plugins w/o test classes should not be set to packaging=eclipse-test-plugin
> ---------------------------------------------------------------------------
>
> Key: JBIDE-15853
> URL: https://issues.jboss.org/browse/JBIDE-15853
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: testing-tools
> Affects Versions: 4.1.1.Beta1
> Reporter: Nick Boldt
>
> 4 plugins in jbosstools-integration-tests have no test classes, but are set via their pom to packaging type eclipse-test-plugin instead of eclipse-plugin.
> As a result, these four plugins fail to run tests and the resulting build is red.
> {code:title=https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-integration-tests.aggregate_master/101/consoleFull}
> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.18.1:test (default-test) on project org.jboss.tools.archives.reddeer: No tests found.
> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.18.1:test (default-test) on project org.jboss.tools.common.reddeer: No tests found.
> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.18.1:test (default-test) on project org.jboss.tools.cdi.reddeer: No tests found.
> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.18.1:test (default-test) on project org.jboss.tools.ws.reddeer: No tests found.
> {code}
> I propose that if these plugins are meant to be framework/API code, containing no actual JUnit tests to run, that their poms be changed as follows:
> {code}
> - <packaging>eclipse-test-plugin</packaging>
> + <packaging>eclipse-plugin</packaging>
> {code}
> And they be moved from
> https://github.com/jbosstools/jbosstools-integration-tests/tree/master/te...
> into
> https://github.com/jbosstools/jbosstools-integration-tests/tree/master/pl...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
[JBoss JIRA] (JBDS-2818) Text in Early Access and Update page needs minor editing
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBDS-2818?page=com.atlassian.jira.plugin.... ]
Nick Boldt edited comment on JBDS-2818 at 11/5/13 3:03 PM:
-----------------------------------------------------------
[~mmurray] If you're happy w/ the changes, please close this JIRA. If not, please submit new PRs or suggest additional changes. Thanks!
was (Author: nickboldt):
[~mmurray] If you're happy w/ the changes, please close this JIRA. If not, please submit new PRs or suggest changes. Thanks!
> Text in Early Access and Update page needs minor editing
> --------------------------------------------------------
>
> Key: JBDS-2818
> URL: https://issues.jboss.org/browse/JBDS-2818
> Project: Developer Studio (JBoss Developer Studio)
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: documentation
> Affects Versions: 7.0.1.GA
> Reporter: Michelle Murray
> Assignee: Nick Boldt
> Fix For: 7.1.0.CR1, 8.0.0.Alpha1
>
>
> Both of these templates need the text modifying (to fit Red Hat writing style and 508 compliance):
> https://devstudio.jboss.com/updates/7.0/
> https://devstudio.jboss.com/earlyaccess/7.0.0.GA.html
> *Common text modifications:*
> * Section "Installation :: Core Tooling"
> {quote}
> 1. If not already installed, download and install Oracle JDK or OpenJDK 7 (or 6).
> 2. Download the JBDS universal installer from <link>.
> 3. To start the installer, double-click the installer file or in a CLI enter java -jar jbdevstudio-*.jar
> {quote}
> * Section "Looking for JBoss EAP ..."
> Logo has changed, now just logotype. Looking for link.
> * Section "Getting Started Guide:"
> {quote}
> Adding *JBoss* EAP to JBDS
> {quote}
> *Early Access text modifications:*
> * Title should be "*Red Hat* JBoss Developer Studio ......"
> * Intro text
> {quote}
> We wish to give customers and users early access to *JBoss Developer Studio* so *that* we can make the next version of JBoss Developer Studio an even better environment for developing with and for Red Hat JBoss Middleware.
> {quote}
> *Updates text modifications*
> * Why do we have this text? I ask because, for example, in https://devstudio.jboss.com/updates/7.0/, on the right-hand side the "installer" link in installation step 2 takes you to https://devstudio.jboss.com/earlyaccess/7.0.0.GA.html where you can download what looks like the GA version without subscription or opting in to a trial. Also you can get JBDS BYOE without subscription or trial on Eclipse marketplace. Seems the text is outdated but I don't know all the ins and outs of JBDS marketing and alike - hence asking the question.
> {quote}
> If you do not already have a copy of JBoss Developer Studio, you can purchase a subscription or get a
> 30-day Free Trial from here: https://access.redhat.com/downloads/.
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
[JBoss JIRA] (JBDS-2818) Text in Early Access and Update page needs minor editing
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBDS-2818?page=com.atlassian.jira.plugin.... ]
Nick Boldt commented on JBDS-2818:
----------------------------------
[~mmurray] If you're happy w/ the changes, please close this JIRA. If not, please submit new PRs or suggest changes. Thanks!
> Text in Early Access and Update page needs minor editing
> --------------------------------------------------------
>
> Key: JBDS-2818
> URL: https://issues.jboss.org/browse/JBDS-2818
> Project: Developer Studio (JBoss Developer Studio)
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: documentation
> Affects Versions: 7.0.1.GA
> Reporter: Michelle Murray
> Assignee: Nick Boldt
> Fix For: 7.1.0.CR1, 8.0.0.Alpha1
>
>
> Both of these templates need the text modifying (to fit Red Hat writing style and 508 compliance):
> https://devstudio.jboss.com/updates/7.0/
> https://devstudio.jboss.com/earlyaccess/7.0.0.GA.html
> *Common text modifications:*
> * Section "Installation :: Core Tooling"
> {quote}
> 1. If not already installed, download and install Oracle JDK or OpenJDK 7 (or 6).
> 2. Download the JBDS universal installer from <link>.
> 3. To start the installer, double-click the installer file or in a CLI enter java -jar jbdevstudio-*.jar
> {quote}
> * Section "Looking for JBoss EAP ..."
> Logo has changed, now just logotype. Looking for link.
> * Section "Getting Started Guide:"
> {quote}
> Adding *JBoss* EAP to JBDS
> {quote}
> *Early Access text modifications:*
> * Title should be "*Red Hat* JBoss Developer Studio ......"
> * Intro text
> {quote}
> We wish to give customers and users early access to *JBoss Developer Studio* so *that* we can make the next version of JBoss Developer Studio an even better environment for developing with and for Red Hat JBoss Middleware.
> {quote}
> *Updates text modifications*
> * Why do we have this text? I ask because, for example, in https://devstudio.jboss.com/updates/7.0/, on the right-hand side the "installer" link in installation step 2 takes you to https://devstudio.jboss.com/earlyaccess/7.0.0.GA.html where you can download what looks like the GA version without subscription or opting in to a trial. Also you can get JBDS BYOE without subscription or trial on Eclipse marketplace. Seems the text is outdated but I don't know all the ins and outs of JBDS marketing and alike - hence asking the question.
> {quote}
> If you do not already have a copy of JBoss Developer Studio, you can purchase a subscription or get a
> 30-day Free Trial from here: https://access.redhat.com/downloads/.
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
[JBoss JIRA] (JBIDE-15853) plugins w/o test classes should not be set to packaging=eclipse-test-plugin
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15853?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-15853:
------------------------------------
Tried again w/ current PR and now get this:
{code}
mvn clean install -Dmaven.test.failure.ignore=true -Dmaven.test.error.ignore=true
...
[INFO] integration-tests.all ............................. SUCCESS [2.103s]
[INFO] integration-tests.plugins ......................... SUCCESS [0.037s]
[INFO] org.jboss.ide.eclipse.as.reddeer .................. SUCCESS [1.508s]
[INFO] org.jboss.tools.archives.reddeer .................. SUCCESS [0.415s]
[INFO] org.jboss.tools.common.reddeer .................... SUCCESS [0.248s]
[INFO] org.jboss.tools.cdi.reddeer ....................... SUCCESS [0.266s]
[INFO] org.jboss.tools.ui.bot.ext ........................ SUCCESS [3.695s]
[INFO] org.jboss.tools.jst.ui.bot.test ................... SUCCESS [2.222s]
[INFO] org.jboss.tools.hibernate.reddeer ................. SUCCESS [0.364s]
[INFO] org.jboss.tools.ws.reddeer ........................ SUCCESS [0.516s]
[INFO] integration-tests.tests ........................... SUCCESS [0.051s]
[INFO] org.jboss.ide.eclipse.as.ui.bot.test .............. SUCCESS [4:25.148s]
[INFO] org.jboss.tools.aerogear.ui.bot.test .............. SUCCESS [0.836s]
[INFO] org.jboss.tools.archives.ui.bot.test .............. SUCCESS [6.578s]
[INFO] org.jboss.tools.cdi.bot.test ...................... SUCCESS [1.384s]
[INFO] org.jboss.tools.cdi.seam3.bot.test ................ SUCCESS [2.665s]
[INFO] org.jboss.tools.central.test.ui.bot ............... SUCCESS [1.312s]
[INFO] org.jboss.tools.deltaspike.ui.bot.test ............ SUCCESS [0.747s]
[INFO] org.jboss.tools.dummy.ui.bot.test ................. SUCCESS [0.430s]
[INFO] org.jboss.tools.forge.ui.bot.test ................. SUCCESS [8.335s]
[INFO] org.jboss.tools.freemarker.ui.bot.test ............ SUCCESS [0.528s]
[INFO] org.jboss.tools.hibernate.ui.bot.test ............. SUCCESS [3.234s]
[INFO] org.jboss.tools.vpe.ui.bot.test ................... SUCCESS [20.675s]
[INFO] org.jboss.tools.jsf.ui.bot.test ................... SUCCESS [0.763s]
[INFO] org.jboss.tools.maven.ui.bot.test ................. SUCCESS [46.934s]
[INFO] org.jboss.tools.mylyn.ui.bot.test ................. SUCCESS [1.074s]
[INFO] org.jboss.tools.openshift.ui.bot.test ............. SUCCESS [1.054s]
[INFO] org.jboss.tools.runtime.as.ui.bot.test ............ SUCCESS [27:32.545s]
[INFO] org.jboss.tools.seam.ui.bot.test .................. SUCCESS [1.646s]
[INFO] org.jboss.tools.ui.bot.ext.test ................... SUCCESS [0.595s]
[INFO] org.jboss.tools.ws.ui.bot.test .................... SUCCESS [12.054s]
[INFO] integration-tests.features ........................ SUCCESS [0.160s]
[INFO] org.jboss.tools.itests.feature .................... SUCCESS [3.890s]
[INFO] integration-tests.site ............................ SUCCESS [1:38.051s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 37:53.175s
[INFO] Finished at: Tue Nov 05 13:54:12 EST 2013
[INFO] Final Memory: 136M/497M
{code}
> plugins w/o test classes should not be set to packaging=eclipse-test-plugin
> ---------------------------------------------------------------------------
>
> Key: JBIDE-15853
> URL: https://issues.jboss.org/browse/JBIDE-15853
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: testing-tools
> Affects Versions: 4.1.1.Beta1
> Reporter: Nick Boldt
>
> 4 plugins in jbosstools-integration-tests have no test classes, but are set via their pom to packaging type eclipse-test-plugin instead of eclipse-plugin.
> As a result, these four plugins fail to run tests and the resulting build is red.
> {code:title=https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-integration-tests.aggregate_master/101/consoleFull}
> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.18.1:test (default-test) on project org.jboss.tools.archives.reddeer: No tests found.
> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.18.1:test (default-test) on project org.jboss.tools.common.reddeer: No tests found.
> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.18.1:test (default-test) on project org.jboss.tools.cdi.reddeer: No tests found.
> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.18.1:test (default-test) on project org.jboss.tools.ws.reddeer: No tests found.
> {code}
> I propose that if these plugins are meant to be framework/API code, containing no actual JUnit tests to run, that their poms be changed as follows:
> {code}
> - <packaging>eclipse-test-plugin</packaging>
> + <packaging>eclipse-plugin</packaging>
> {code}
> And they be moved from
> https://github.com/jbosstools/jbosstools-integration-tests/tree/master/te...
> into
> https://github.com/jbosstools/jbosstools-integration-tests/tree/master/pl...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
[JBoss JIRA] (JBIDE-15853) plugins w/o test classes should not be set to packaging=eclipse-test-plugin
by Vlado Pakan (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15853?page=com.atlassian.jira.plugi... ]
Vlado Pakan commented on JBIDE-15853:
-------------------------------------
SWTBot tests are quite frequently giving different results running with the same settings and conditions more times unfortunately.
> plugins w/o test classes should not be set to packaging=eclipse-test-plugin
> ---------------------------------------------------------------------------
>
> Key: JBIDE-15853
> URL: https://issues.jboss.org/browse/JBIDE-15853
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: testing-tools
> Affects Versions: 4.1.1.Beta1
> Reporter: Nick Boldt
>
> 4 plugins in jbosstools-integration-tests have no test classes, but are set via their pom to packaging type eclipse-test-plugin instead of eclipse-plugin.
> As a result, these four plugins fail to run tests and the resulting build is red.
> {code:title=https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-integration-tests.aggregate_master/101/consoleFull}
> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.18.1:test (default-test) on project org.jboss.tools.archives.reddeer: No tests found.
> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.18.1:test (default-test) on project org.jboss.tools.common.reddeer: No tests found.
> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.18.1:test (default-test) on project org.jboss.tools.cdi.reddeer: No tests found.
> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.18.1:test (default-test) on project org.jboss.tools.ws.reddeer: No tests found.
> {code}
> I propose that if these plugins are meant to be framework/API code, containing no actual JUnit tests to run, that their poms be changed as follows:
> {code}
> - <packaging>eclipse-test-plugin</packaging>
> + <packaging>eclipse-plugin</packaging>
> {code}
> And they be moved from
> https://github.com/jbosstools/jbosstools-integration-tests/tree/master/te...
> into
> https://github.com/jbosstools/jbosstools-integration-tests/tree/master/pl...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
[JBoss JIRA] (JBIDE-12646) web.xml servlet-name validation is not case-sensitive
by Alexey Kazakov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-12646?page=com.atlassian.jira.plugi... ]
Alexey Kazakov updated JBIDE-12646:
-----------------------------------
Fix Version/s: 4.2.x
(was: LATER)
> web.xml servlet-name validation is not case-sensitive
> -----------------------------------------------------
>
> Key: JBIDE-12646
> URL: https://issues.jboss.org/browse/JBIDE-12646
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: jsp/jsf/xml/html source editing
> Affects Versions: 4.0.0.Alpha1
> Reporter: Xavier Coulon
> Assignee: Viacheslav Kabanovich
> Fix For: 4.2.x
>
> Attachments: JBIDE-12646 - Wi-Fi.m4v, ServletNameValidation.png
>
>
> [Using the HTML5 sample project generated from Central]
> I'm adding a servlet declaration in the web.xml file but the web.xml editor does not report a warning when the servlet name case is wrong:
> {code}
> <servlet-mapping>
> <servlet-name>org.jboss.tools.example.html5.rest.JaxrsActivator</servlet-name>
> <url-pattern>/hello/*</url-pattern>
> </servlet-mapping>
> {code}
> In the example above, the class name should be JaxRsActivator, not JaxrsActivator.
> On the other hand, it properly reports a warning when a letter is missing in the classname.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
[JBoss JIRA] (JBIDE-15853) plugins w/o test classes should not be set to packaging=eclipse-test-plugin
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15853?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-15853:
------------------------------------
My original PR compiled fine, but the order of building stuff now that some additional things have moved (or moved back) seems to be less optimal. Or there's a difference between the first run where runtimes had to be downloaded and subsequent ones where they're already in my ~/.m2 cache.
> plugins w/o test classes should not be set to packaging=eclipse-test-plugin
> ---------------------------------------------------------------------------
>
> Key: JBIDE-15853
> URL: https://issues.jboss.org/browse/JBIDE-15853
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: testing-tools
> Affects Versions: 4.1.1.Beta1
> Reporter: Nick Boldt
>
> 4 plugins in jbosstools-integration-tests have no test classes, but are set via their pom to packaging type eclipse-test-plugin instead of eclipse-plugin.
> As a result, these four plugins fail to run tests and the resulting build is red.
> {code:title=https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-integration-tests.aggregate_master/101/consoleFull}
> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.18.1:test (default-test) on project org.jboss.tools.archives.reddeer: No tests found.
> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.18.1:test (default-test) on project org.jboss.tools.common.reddeer: No tests found.
> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.18.1:test (default-test) on project org.jboss.tools.cdi.reddeer: No tests found.
> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.18.1:test (default-test) on project org.jboss.tools.ws.reddeer: No tests found.
> {code}
> I propose that if these plugins are meant to be framework/API code, containing no actual JUnit tests to run, that their poms be changed as follows:
> {code}
> - <packaging>eclipse-test-plugin</packaging>
> + <packaging>eclipse-plugin</packaging>
> {code}
> And they be moved from
> https://github.com/jbosstools/jbosstools-integration-tests/tree/master/te...
> into
> https://github.com/jbosstools/jbosstools-integration-tests/tree/master/pl...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months