[JBoss JIRA] (JBIDE-12013) Application wizard, Embedding wizard: disallow all non-scalable cartridges for scalable applications
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-12013?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-12013:
-------------------------------------
Assignee: (was: Andre Dietisheim)
> Application wizard, Embedding wizard: disallow all non-scalable cartridges for scalable applications
> ----------------------------------------------------------------------------------------------------
>
> Key: JBIDE-12013
> URL: https://issues.jboss.org/browse/JBIDE-12013
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 3.3.0.Beta3
> Reporter: Andre Dietisheim
> Priority: Minor
> Fix For: LATER
>
> Attachments: can-only-embed-mysql-and-jenkins.png, can-only-embed-mysql-and-jenkins.png
>
>
> # EXEC: open the *New OpenShift Application* wizard
> # EXEC: check *enable scaling*
> # EXEC: check *phpmysql* embedded cartridge
> # EXEC: hit *Finish*
> Result:
> You get the following error:
> !can-only-embed-mysql-and-jenkins.png!
> Only *mysql*, *mongodb*, *postgres* and *jenkins-client* may be embedded to scalable apps!
> IMHO we should not hardcode any list of allowed embeddable cartridges since this list would get outdated very quickly. The backend should allow us to query such a list. Since there's no cartridge metadata yet, we currently have a local embedding strategy. This should get enhanced to disallow certrain cartridges for scalable applications
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months
[JBoss JIRA] (JBIDE-12013) Application wizard, Embedding wizard: disallow all non-scalable cartridges for scalable applications
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-12013?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-12013:
-------------------------------------
Labels: application_wizard embed_wizard (was: )
Estimated Difficulty: High
> Application wizard, Embedding wizard: disallow all non-scalable cartridges for scalable applications
> ----------------------------------------------------------------------------------------------------
>
> Key: JBIDE-12013
> URL: https://issues.jboss.org/browse/JBIDE-12013
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 3.3.0.Beta3
> Reporter: Andre Dietisheim
> Priority: Minor
> Labels: application_wizard, embed_wizard
> Fix For: LATER
>
> Attachments: can-only-embed-mysql-and-jenkins.png, can-only-embed-mysql-and-jenkins.png
>
>
> # EXEC: open the *New OpenShift Application* wizard
> # EXEC: check *enable scaling*
> # EXEC: check *phpmysql* embedded cartridge
> # EXEC: hit *Finish*
> Result:
> You get the following error:
> !can-only-embed-mysql-and-jenkins.png!
> Only *mysql*, *mongodb*, *postgres* and *jenkins-client* may be embedded to scalable apps!
> IMHO we should not hardcode any list of allowed embeddable cartridges since this list would get outdated very quickly. The backend should allow us to query such a list. Since there's no cartridge metadata yet, we currently have a local embedding strategy. This should get enhanced to disallow certrain cartridges for scalable applications
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months
[JBoss JIRA] (JBIDE-12144) EGitUtils#push is throwing an exception if push fails. It should use the same semantics as EGit
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-12144?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-12144:
-------------------------------------
Assignee: (was: Andre Dietisheim)
> EGitUtils#push is throwing an exception if push fails. It should use the same semantics as EGit
> -----------------------------------------------------------------------------------------------
>
> Key: JBIDE-12144
> URL: https://issues.jboss.org/browse/JBIDE-12144
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 3.3.0.CR1
> Reporter: Andre Dietisheim
> Priority: Minor
> Labels: cleanup
> Fix For: LATER
>
>
> EgitUtils#push throws an exception if the push failed because of ex. "non fastforward push".
> {code}
> private static PushOperationResult push(Repository repository, RemoteConfig remoteConfig, boolean force, IProgressMonitor monitor) throws CoreException {
> ...
> PushOperationResult pushResult = op.getOperationResult();
> if (hasFailedEntries(pushResult)) {
> throw new CoreException(
> EGitCoreActivator.createErrorStatus(
> NLS.bind("Could not push repository {0}: {1}",
> repository.toString(), getErrors(pushResult))
> , null));
> }
> return pushResult;
> {code}
> EGit is not throwing an exception in this case. You simply get the failure in the PushResult object you'll have to look at.
> EGitUtils#push is thus changing the API semantics of EGit and it shouldn't.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months
[JBoss JIRA] (JBIDE-12144) EGitUtils#push is throwing an exception if push fails. It should use the same semantics as EGit
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-12144?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-12144:
-------------------------------------
Estimated Difficulty: Low
> EGitUtils#push is throwing an exception if push fails. It should use the same semantics as EGit
> -----------------------------------------------------------------------------------------------
>
> Key: JBIDE-12144
> URL: https://issues.jboss.org/browse/JBIDE-12144
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 3.3.0.CR1
> Reporter: Andre Dietisheim
> Priority: Minor
> Labels: cleanup
> Fix For: LATER
>
>
> EgitUtils#push throws an exception if the push failed because of ex. "non fastforward push".
> {code}
> private static PushOperationResult push(Repository repository, RemoteConfig remoteConfig, boolean force, IProgressMonitor monitor) throws CoreException {
> ...
> PushOperationResult pushResult = op.getOperationResult();
> if (hasFailedEntries(pushResult)) {
> throw new CoreException(
> EGitCoreActivator.createErrorStatus(
> NLS.bind("Could not push repository {0}: {1}",
> repository.toString(), getErrors(pushResult))
> , null));
> }
> return pushResult;
> {code}
> EGit is not throwing an exception in this case. You simply get the failure in the PushResult object you'll have to look at.
> EGitUtils#push is thus changing the API semantics of EGit and it shouldn't.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months