[JBoss JIRA] (JBIDE-13452) investigate removing JBT_VERSION, JBDS_VERSION, and TARGET_PLATFORM_VERSION from parent pom
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13452?page=com.atlassian.jira.plugi... ]
Mickael Istria commented on JBIDE-13452:
----------------------------------------
JBDS_VERSION version is already removed
JBT_VERSION should be put into aggregate site (it's the only place where it's used), and could even be replaced by the ${project.version} of the aggregate pom.
TARGET_PLATFORM_VERSION should be kept as we want the default "mvn clean verify" to still work.
> investigate removing JBT_VERSION, JBDS_VERSION, and TARGET_PLATFORM_VERSION from parent pom
> -------------------------------------------------------------------------------------------
>
> Key: JBIDE-13452
> URL: https://issues.jboss.org/browse/JBIDE-13452
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: Build/Releng, target-platform, updatesite
> Affects Versions: 4.1.0.Alpha1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
>
> investigate removing JBT_VERSION, JBDS_VERSION, and TARGET_PLATFORM_VERSION (min and max) from parent pom
> Can we switch to using dynamic maven variables like project.version instead?
> Moving forward, jobs will override/set the version of target platform used to build (min) and test (max), and developers will be required to decide when/if to move to a newer parent pom or target platform version(s) if needed. For projects that are released, jobs will run only when TP changes (ie., will watch the jbosstools-target-platforms repo for changes).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 1 month
[JBoss JIRA] (JBIDE-13446) Forge pick-up command throws NPE
by Michelle Murray (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13446?page=com.atlassian.jira.plugi... ]
Michelle Murray updated JBIDE-13446:
------------------------------------
Release Notes Text: Use of the pick-up command in Forge console results in a null pointer exception. Consequently, the Forge console displays an error message and fails to move into the requested directory.
> Forge pick-up command throws NPE
> --------------------------------
>
> Key: JBIDE-13446
> URL: https://issues.jboss.org/browse/JBIDE-13446
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: forge
> Affects Versions: 4.0.0.Final, 4.1.0.Alpha1
> Environment: OS X Mountain Lion
> Apple JDK 1.6 32bit
> JBDS 6.0.0.GA / JBT master nightly 4.1.0.Alpha1-v20130129-1449-B6053 on Eclipse Kepler M4
> And:
> Fedora 17, JDK 1.7.0_13, JBDS 6.0.0 GA - all 64-bit
> Reporter: Martin Malina
> Assignee: Koen Aers
> Priority: Critical
> Fix For: 4.0.x, 4.1.0.Alpha2
>
>
> When playing around w/ Ticket Monster [1] I found out that Show in -> Forge console does not work for me on a project or directory in Project Explorer.
> It throws this exception:
> {code}
> [no project] workspace $ set VERBOSE true
> [no project] workspace $ pick-up /Users/rasp/jbossqa/JBDS/nightly-jbt-2013-01-30/workspace/jboss-javaee6-webapp
> java.lang.NullPointerException***ERROR*** Exception encountered: (type "set VERBOSE false" to disable stack traces)
> [no project] workspace $
> at org.apache.maven.RepositoryUtils.getLayout(RepositoryUtils.java:214)
> at org.apache.maven.RepositoryUtils.toRepo(RepositoryUtils.java:200)
> at org.apache.maven.RepositoryUtils.toRepos(RepositoryUtils.java:190)
> at org.apache.maven.project.DefaultProjectBuilder$InternalConfig.<init>(DefaultProjectBuilder.java:662)
> at org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:102)
> at org.jboss.forge.maven.facets.MavenCoreFacetImpl.getPartialProjectBuildingResult(MavenCoreFacetImpl.java:86)
> at org.jboss.forge.maven.facets.MavenCoreFacetImpl.resolveProperties(MavenCoreFacetImpl.java:304)
> at org.jboss.forge.maven.facets.MavenDependencyFacet.resolveProperties(MavenDependencyFacet.java:393)
> at org.jboss.forge.maven.facets.MavenDependencyFacet.hasEffectiveDependency(MavenDependencyFacet.java:171)
> at org.jboss.forge.shell.project.DependencyInstallerImpl.isInstalled(DependencyInstallerImpl.java:170)
> at org.jboss.forge.git.GitAPIFacet.isInstalled(GitAPIFacet.java:42)
> at org.jboss.forge.project.BaseProject.registerFacet(BaseProject.java:153)
> at org.jboss.forge.project.services.ProjectFactory.registerSingleFacet(ProjectFactory.java:208)
> at org.jboss.forge.project.services.ProjectFactory.registerSingleFacet(ProjectFactory.java:186)
> at org.jboss.forge.project.services.ProjectFactory.registerFacets(ProjectFactory.java:178)
> at org.jboss.forge.project.services.ProjectFactory.findProjectRecursively(ProjectFactory.java:117)
> at org.jboss.forge.shell.project.ProjectInitializer.doInit(ProjectInitializer.java:91)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:601)
> at org.jboss.weld.util.reflection.SecureReflections$13.work(SecureReflections.java:305)
> at org.jboss.weld.util.reflection.SecureReflectionAccess.run(SecureReflectionAccess.java:54)
> at org.jboss.weld.util.reflection.SecureReflectionAccess.runAsInvocation(SecureReflectionAccess.java:163)
> at org.jboss.weld.util.reflection.SecureReflections.invoke(SecureReflections.java:299)
> at org.jboss.weld.introspector.jlr.WeldMethodImpl.invokeOnInstance(WeldMethodImpl.java:188)
> at org.jboss.weld.introspector.ForwardingWeldMethod.invokeOnInstance(ForwardingWeldMethod.java:59)
> at org.jboss.weld.injection.MethodInjectionPoint.invokeOnInstanceWithSpecialValue(MethodInjectionPoint.java:198)
> at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:282)
> at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:265)
> at org.jboss.weld.event.ObserverMethodImpl.notify(ObserverMethodImpl.java:234)
> at org.jboss.weld.manager.BeanManagerImpl.notifyObservers(BeanManagerImpl.java:635)
> at org.jboss.weld.manager.BeanManagerImpl.fireEvent(BeanManagerImpl.java:628)
> at org.jboss.weld.event.EventImpl.fire(EventImpl.java:75)
> at org.jboss.forge.shell.project.CurrentProject.setCurrentResource(CurrentProject.java:80)
> at org.jboss.forge.shell.ShellImpl.setCurrentResource(ShellImpl.java:1239)
> at org.jboss.forge.shell.ShellImpl$Proxy$_$$_WeldClientProxy.setCurrentResource(ShellImpl$Proxy$_$$_WeldClientProxy.java)
> at org.jboss.forge.shell.plugins.builtin.PickupResourcePlugin.run(PickupResourcePlugin.java:85)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:601)
> at org.jboss.forge.shell.command.Execution.perform(Execution.java:134)
> at org.jboss.forge.shell.command.fshparser.FSHRuntime.run(FSHRuntime.java:109)
> at org.jboss.forge.shell.command.fshparser.FSHRuntime.run(FSHRuntime.java:47)
> at org.jboss.forge.shell.ShellImpl$ExecutorThread.run(ShellImpl.java:818)
> at org.jboss.forge.shell.ShellImpl.execute(ShellImpl.java:841)
> at org.jboss.forge.shell.ShellImpl.doShell(ShellImpl.java:631)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:601)
> at org.jboss.weld.bean.proxy.AbstractBeanInstance.invoke(AbstractBeanInstance.java:48)
> at org.jboss.weld.bean.proxy.ProxyMethodHandler.invoke(ProxyMethodHandler.java:125)
> at org.jboss.forge.shell.ShellImpl$Proxy$_$$_WeldClientProxy.doShell(ShellImpl$Proxy$_$$_WeldClientProxy.java)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:601)
> at org.jboss.weld.util.reflection.SecureReflections$13.work(SecureReflections.java:305)
> at org.jboss.weld.util.reflection.SecureReflectionAccess.run(SecureReflectionAccess.java:54)
> at org.jboss.weld.util.reflection.SecureReflectionAccess.runAsInvocation(SecureReflectionAccess.java:163)
> at org.jboss.weld.util.reflection.SecureReflections.invoke(SecureReflections.java:299)
> at org.jboss.weld.introspector.jlr.WeldMethodImpl.invokeOnInstance(WeldMethodImpl.java:188)
> at org.jboss.weld.introspector.ForwardingWeldMethod.invokeOnInstance(ForwardingWeldMethod.java:59)
> at org.jboss.weld.injection.MethodInjectionPoint.invokeOnInstanceWithSpecialValue(MethodInjectionPoint.java:198)
> at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:282)
> at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:265)
> at org.jboss.weld.event.ObserverMethodImpl.notify(ObserverMethodImpl.java:234)
> at org.jboss.weld.manager.BeanManagerImpl.notifyObservers(BeanManagerImpl.java:635)
> at org.jboss.weld.manager.BeanManagerImpl.fireEvent(BeanManagerImpl.java:622)
> at org.jboss.weld.manager.BeanManagerImpl.fireEvent(BeanManagerImpl.java:616)
> at org.jboss.forge.shell.Bootstrap$1.run(Bootstrap.java:172)
> at java.lang.Thread.run(Thread.java:722)
> {code}
> This happens in both JBDS 6 and JBT 4.1 nightly, but not in JBDS 5. It's probably only reproducible on Mac - psrna verified this on Linux today and it worked for him. I tried two different instances of JBDS 6 and one instance of JBT 4.1.0.Alpha1 nightly installed on Eclipse Kepler M4.
> Please let me know if I should create a FORGE issue.
> The forge runtime versions:
> JBDS 6: org.jboss.tools.forge.runtime_1.1.0.Final-v20121205-1934-B69
> JBT nightly: org.jboss.tools.forge.runtime_1.2.0.Alpha1-v20130128-1407-B204
> [1] http://www.jboss.org/jdf/examples/ticket-monster/tutorial/Introduction/#_...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 1 month
[JBoss JIRA] (JBIDE-13446) Forge pick-up command throws NPE
by Michelle Murray (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13446?page=com.atlassian.jira.plugi... ]
Michelle Murray updated JBIDE-13446:
------------------------------------
Release Notes Docs Status: Documented as Known Issue
Writer: mmurray
Affects: Release Notes
> Forge pick-up command throws NPE
> --------------------------------
>
> Key: JBIDE-13446
> URL: https://issues.jboss.org/browse/JBIDE-13446
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: forge
> Affects Versions: 4.0.0.Final, 4.1.0.Alpha1
> Environment: OS X Mountain Lion
> Apple JDK 1.6 32bit
> JBDS 6.0.0.GA / JBT master nightly 4.1.0.Alpha1-v20130129-1449-B6053 on Eclipse Kepler M4
> And:
> Fedora 17, JDK 1.7.0_13, JBDS 6.0.0 GA - all 64-bit
> Reporter: Martin Malina
> Assignee: Koen Aers
> Priority: Critical
> Fix For: 4.0.x, 4.1.0.Alpha2
>
>
> When playing around w/ Ticket Monster [1] I found out that Show in -> Forge console does not work for me on a project or directory in Project Explorer.
> It throws this exception:
> {code}
> [no project] workspace $ set VERBOSE true
> [no project] workspace $ pick-up /Users/rasp/jbossqa/JBDS/nightly-jbt-2013-01-30/workspace/jboss-javaee6-webapp
> java.lang.NullPointerException***ERROR*** Exception encountered: (type "set VERBOSE false" to disable stack traces)
> [no project] workspace $
> at org.apache.maven.RepositoryUtils.getLayout(RepositoryUtils.java:214)
> at org.apache.maven.RepositoryUtils.toRepo(RepositoryUtils.java:200)
> at org.apache.maven.RepositoryUtils.toRepos(RepositoryUtils.java:190)
> at org.apache.maven.project.DefaultProjectBuilder$InternalConfig.<init>(DefaultProjectBuilder.java:662)
> at org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:102)
> at org.jboss.forge.maven.facets.MavenCoreFacetImpl.getPartialProjectBuildingResult(MavenCoreFacetImpl.java:86)
> at org.jboss.forge.maven.facets.MavenCoreFacetImpl.resolveProperties(MavenCoreFacetImpl.java:304)
> at org.jboss.forge.maven.facets.MavenDependencyFacet.resolveProperties(MavenDependencyFacet.java:393)
> at org.jboss.forge.maven.facets.MavenDependencyFacet.hasEffectiveDependency(MavenDependencyFacet.java:171)
> at org.jboss.forge.shell.project.DependencyInstallerImpl.isInstalled(DependencyInstallerImpl.java:170)
> at org.jboss.forge.git.GitAPIFacet.isInstalled(GitAPIFacet.java:42)
> at org.jboss.forge.project.BaseProject.registerFacet(BaseProject.java:153)
> at org.jboss.forge.project.services.ProjectFactory.registerSingleFacet(ProjectFactory.java:208)
> at org.jboss.forge.project.services.ProjectFactory.registerSingleFacet(ProjectFactory.java:186)
> at org.jboss.forge.project.services.ProjectFactory.registerFacets(ProjectFactory.java:178)
> at org.jboss.forge.project.services.ProjectFactory.findProjectRecursively(ProjectFactory.java:117)
> at org.jboss.forge.shell.project.ProjectInitializer.doInit(ProjectInitializer.java:91)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:601)
> at org.jboss.weld.util.reflection.SecureReflections$13.work(SecureReflections.java:305)
> at org.jboss.weld.util.reflection.SecureReflectionAccess.run(SecureReflectionAccess.java:54)
> at org.jboss.weld.util.reflection.SecureReflectionAccess.runAsInvocation(SecureReflectionAccess.java:163)
> at org.jboss.weld.util.reflection.SecureReflections.invoke(SecureReflections.java:299)
> at org.jboss.weld.introspector.jlr.WeldMethodImpl.invokeOnInstance(WeldMethodImpl.java:188)
> at org.jboss.weld.introspector.ForwardingWeldMethod.invokeOnInstance(ForwardingWeldMethod.java:59)
> at org.jboss.weld.injection.MethodInjectionPoint.invokeOnInstanceWithSpecialValue(MethodInjectionPoint.java:198)
> at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:282)
> at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:265)
> at org.jboss.weld.event.ObserverMethodImpl.notify(ObserverMethodImpl.java:234)
> at org.jboss.weld.manager.BeanManagerImpl.notifyObservers(BeanManagerImpl.java:635)
> at org.jboss.weld.manager.BeanManagerImpl.fireEvent(BeanManagerImpl.java:628)
> at org.jboss.weld.event.EventImpl.fire(EventImpl.java:75)
> at org.jboss.forge.shell.project.CurrentProject.setCurrentResource(CurrentProject.java:80)
> at org.jboss.forge.shell.ShellImpl.setCurrentResource(ShellImpl.java:1239)
> at org.jboss.forge.shell.ShellImpl$Proxy$_$$_WeldClientProxy.setCurrentResource(ShellImpl$Proxy$_$$_WeldClientProxy.java)
> at org.jboss.forge.shell.plugins.builtin.PickupResourcePlugin.run(PickupResourcePlugin.java:85)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:601)
> at org.jboss.forge.shell.command.Execution.perform(Execution.java:134)
> at org.jboss.forge.shell.command.fshparser.FSHRuntime.run(FSHRuntime.java:109)
> at org.jboss.forge.shell.command.fshparser.FSHRuntime.run(FSHRuntime.java:47)
> at org.jboss.forge.shell.ShellImpl$ExecutorThread.run(ShellImpl.java:818)
> at org.jboss.forge.shell.ShellImpl.execute(ShellImpl.java:841)
> at org.jboss.forge.shell.ShellImpl.doShell(ShellImpl.java:631)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:601)
> at org.jboss.weld.bean.proxy.AbstractBeanInstance.invoke(AbstractBeanInstance.java:48)
> at org.jboss.weld.bean.proxy.ProxyMethodHandler.invoke(ProxyMethodHandler.java:125)
> at org.jboss.forge.shell.ShellImpl$Proxy$_$$_WeldClientProxy.doShell(ShellImpl$Proxy$_$$_WeldClientProxy.java)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:601)
> at org.jboss.weld.util.reflection.SecureReflections$13.work(SecureReflections.java:305)
> at org.jboss.weld.util.reflection.SecureReflectionAccess.run(SecureReflectionAccess.java:54)
> at org.jboss.weld.util.reflection.SecureReflectionAccess.runAsInvocation(SecureReflectionAccess.java:163)
> at org.jboss.weld.util.reflection.SecureReflections.invoke(SecureReflections.java:299)
> at org.jboss.weld.introspector.jlr.WeldMethodImpl.invokeOnInstance(WeldMethodImpl.java:188)
> at org.jboss.weld.introspector.ForwardingWeldMethod.invokeOnInstance(ForwardingWeldMethod.java:59)
> at org.jboss.weld.injection.MethodInjectionPoint.invokeOnInstanceWithSpecialValue(MethodInjectionPoint.java:198)
> at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:282)
> at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:265)
> at org.jboss.weld.event.ObserverMethodImpl.notify(ObserverMethodImpl.java:234)
> at org.jboss.weld.manager.BeanManagerImpl.notifyObservers(BeanManagerImpl.java:635)
> at org.jboss.weld.manager.BeanManagerImpl.fireEvent(BeanManagerImpl.java:622)
> at org.jboss.weld.manager.BeanManagerImpl.fireEvent(BeanManagerImpl.java:616)
> at org.jboss.forge.shell.Bootstrap$1.run(Bootstrap.java:172)
> at java.lang.Thread.run(Thread.java:722)
> {code}
> This happens in both JBDS 6 and JBT 4.1 nightly, but not in JBDS 5. It's probably only reproducible on Mac - psrna verified this on Linux today and it worked for him. I tried two different instances of JBDS 6 and one instance of JBT 4.1.0.Alpha1 nightly installed on Eclipse Kepler M4.
> Please let me know if I should create a FORGE issue.
> The forge runtime versions:
> JBDS 6: org.jboss.tools.forge.runtime_1.1.0.Final-v20121205-1934-B69
> JBT nightly: org.jboss.tools.forge.runtime_1.2.0.Alpha1-v20130128-1407-B204
> [1] http://www.jboss.org/jdf/examples/ticket-monster/tutorial/Introduction/#_...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 1 month
[JBoss JIRA] (JBIDE-13733) Clean up JBossASHandler
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13733?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-13733:
-------------------------------------
looking deeper, in EsbHandler, the following method is basically empty!
{code}
@Override
public RuntimeDefinition getRuntimeDefinition(File root,
IProgressMonitor monitor) {
if (monitor.isCanceled() || root == null) {
return null;
}
// standalone ESB runtime
return null;
}
{code}
It seems that the EsbHandler is incomplete and is doing no work at all in this situation.
> Clean up JBossASHandler
> -----------------------
>
> Key: JBIDE-13733
> URL: https://issues.jboss.org/browse/JBIDE-13733
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: JBossAS/Servers
> Affects Versions: 4.1.0.Alpha1
> Reporter: Rob Stryker
> Assignee: Rob Stryker
> Fix For: 4.1.0.Alpha2
>
>
> JBossASHandler is a pretty messy class with many confusing parts to it. Several things need to be changed.
> 1) Why are default names for server required in this class? Don't runtime type and server type already do this in getDefaults() when the working copy is created?
> 2) The code to check for nested runtimes is very messy and hard to understand.
> 3) Why are ESB and Drools added separately? Shouldn't the check for all nested runtimes using all handlers be able to find this itself? It seems drools and esb have their own detectors. So why is this required here?
> 4) The drools runtime seems to be not added to any model at all. It seems to just be returned. Is this only cosmetic? What is the purpose here? The drools detector would be adding this to the drools model, but we do not add it to any model, so what is the purpose?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 1 month
[JBoss JIRA] (JBIDE-13733) Clean up JBossASHandler
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13733?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-13733:
-------------------------------------
Snjezana:
I've just run a test as follows:
1) Disable AS handler
2) Point to a soa-p installation
3) Run the runtime search dialog
There are no results found. This means that the ESB Detector is *not* finding the esb runtime if pointed to an soa-p installation unless the AS Handler is enabled.
This would seem like a bug in the ESB detector to me, and it seems that JBossASHandler returning an esb runtime itself is actually a workaround this bug. It is NOT a workaround that the locator stops searching after finding an AS server and no longer searches the nested paths. It is a workaround in that the esb detector will not even recognize esb runtimes nested inside a soa-p installation.
I haven't had a chance to test drools yet, but I suspect it is a similar issue.
> Clean up JBossASHandler
> -----------------------
>
> Key: JBIDE-13733
> URL: https://issues.jboss.org/browse/JBIDE-13733
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: JBossAS/Servers
> Affects Versions: 4.1.0.Alpha1
> Reporter: Rob Stryker
> Assignee: Rob Stryker
> Fix For: 4.1.0.Alpha2
>
>
> JBossASHandler is a pretty messy class with many confusing parts to it. Several things need to be changed.
> 1) Why are default names for server required in this class? Don't runtime type and server type already do this in getDefaults() when the working copy is created?
> 2) The code to check for nested runtimes is very messy and hard to understand.
> 3) Why are ESB and Drools added separately? Shouldn't the check for all nested runtimes using all handlers be able to find this itself? It seems drools and esb have their own detectors. So why is this required here?
> 4) The drools runtime seems to be not added to any model at all. It seems to just be returned. Is this only cosmetic? What is the purpose here? The drools detector would be adding this to the drools model, but we do not add it to any model, so what is the purpose?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 1 month