[JBoss JIRA] (JBIDE-13599) externalize Central site URL into a commandline property so that testing or mirroring is easier
by Snjezana Peco (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13599?page=com.atlassian.jira.plugi... ]
Snjezana Peco commented on JBIDE-13599:
---------------------------------------
It would be the best that you merge the PR.
> externalize Central site URL into a commandline property so that testing or mirroring is easier
> -----------------------------------------------------------------------------------------------
>
> Key: JBIDE-13599
> URL: https://issues.jboss.org/browse/JBIDE-13599
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: central
> Affects Versions: 4.1.0.Alpha1
> Reporter: Nick Boldt
> Assignee: Snjezana Peco
> Fix For: 4.1.0.Alpha2
>
>
> As discussed in https://issues.jboss.org/browse/JBDS-2469?focusedCommentId=12755106&page=... testing Central is tricky if it's not properly bootstrapped, and bootstrapping is hard when we're on an early Alpha and don't want bits to be public before they've passed QE.
> A better approach than having the update site URL used in Central's discovery plugin.xml hardcoded into that file would be to have it read from a Preference in Eclipse or JBDS. This would allow it to be overwritten/overridden should a user want to test installation from a different URL than the default value.
> This might even make it possible to have the same discovery plugin used for JBT and JBDS (assuming the list of connectors were the same, and certification was to appear for both instances) simply by having the preference changed to a different default URL when installing JBT or JBDS BYOE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 1 month
[JBoss JIRA] (JBIDE-13599) externalize Central site URL into a commandline property so that testing or mirroring is easier
by Max Rydahl Andersen (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13599?page=com.atlassian.jira.plugi... ]
Max Rydahl Andersen commented on JBIDE-13599:
---------------------------------------------
Here is a pullrequest (https://github.com/jbosstools/jbosstools-central/pull/75) which incorporates majority of the concerns raised in here.
basic usage/sytax is the same as described by Snjezana.
But to answer the concerns which seemed to have drowned:
1) There is no longer any need to have this be a maven only test thus made it so can test with built-in properties PLUS I just set the system properties from within the test since the values does not need to point to anything for the tests.
2) "I can also see that DMR would throw an exception if something wrong is resolved - is that the behavior we need" - I think it makes sense, but we need to add code to handle this error case so the user can know what is going on. (simple to do I think, just a todo)
3) "DMR actually does seem to handle multiple values",
yes - ${foo,bar} now works.
4) "the default replacement seem to treat file seperators and path seperators as a special case and return different results based on OS values"
This just means that {:} and {/} can be used to specify portal file locations (i.e. {/}file{/}path becomes /file/path on Linux, \file\path on Windows.
Not something we need for this but I kept it in for consistency.
4) "But why we want to add a direct dependency on this library for this simple functionality I do not grok." - no dependency on this anymore.
5) "We should just copy the code and adjust it for what we need (looks like no changes needed except a few for the above issues) - note, this is tough LGPL so need to adjust for that." -- this is now done, put in internal package since its not to be a public API for now and put in .xpl package and with no dependencies to EPL to oblige to LGPL/EPL.
If you could give this a try it would be great - I'll try add the error handling; but if you have time to do it that would be great too :)
> externalize Central site URL into a commandline property so that testing or mirroring is easier
> -----------------------------------------------------------------------------------------------
>
> Key: JBIDE-13599
> URL: https://issues.jboss.org/browse/JBIDE-13599
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: central
> Affects Versions: 4.1.0.Alpha1
> Reporter: Nick Boldt
> Assignee: Snjezana Peco
> Fix For: 4.1.0.Alpha2
>
>
> As discussed in https://issues.jboss.org/browse/JBDS-2469?focusedCommentId=12755106&page=... testing Central is tricky if it's not properly bootstrapped, and bootstrapping is hard when we're on an early Alpha and don't want bits to be public before they've passed QE.
> A better approach than having the update site URL used in Central's discovery plugin.xml hardcoded into that file would be to have it read from a Preference in Eclipse or JBDS. This would allow it to be overwritten/overridden should a user want to test installation from a different URL than the default value.
> This might even make it possible to have the same discovery plugin used for JBT and JBDS (assuming the list of connectors were the same, and certification was to appear for both instances) simply by having the preference changed to a different default URL when installing JBT or JBDS BYOE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 1 month
[JBoss JIRA] (JBIDE-13760) New Grid wizard
by Viacheslav Kabanovich (JIRA)
Viacheslav Kabanovich created JBIDE-13760:
---------------------------------------------
Summary: New Grid wizard
Key: JBIDE-13760
URL: https://issues.jboss.org/browse/JBIDE-13760
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: jsp/jsf/xml/html source editing
Reporter: Viacheslav Kabanovich
Assignee: Viacheslav Kabanovich
Fix For: 4.1.0.Alpha2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 1 month
[JBoss JIRA] (JBIDE-13758) Update Forge Embedded Runtime to 1.2.2.Final
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13758?page=com.atlassian.jira.plugi... ]
George Gastaldi commented on JBIDE-13758:
-----------------------------------------
Forge 1.2.2.Final has just been released to the Maven central repos
> Update Forge Embedded Runtime to 1.2.2.Final
> --------------------------------------------
>
> Key: JBIDE-13758
> URL: https://issues.jboss.org/browse/JBIDE-13758
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: forge
> Affects Versions: 4.0.0.Final, 4.1.0.Alpha1
> Reporter: Koen Aers
> Assignee: Koen Aers
> Priority: Blocker
> Fix For: 4.0.1.Final, 4.1.0.Alpha2
>
>
> The embedded forge should be updated to make sure that the html5 scaffolding works well with it.
> The ticket monster tutorial was checked to work fine with Forge 1.2.1.
> As for the ticket monster demo part, it needs a little fix in the admin_layer.fsh file. But running this file seems to fail also with Forge 1.1.2.
> The problem can be viewed here: http://pastebin.com/tgxGgrN0
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 1 month
[JBoss JIRA] (JBIDE-13463) Replace eclipse-update-site for aggregator by eclipse-repository
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13463?page=com.atlassian.jira.plugi... ]
Nick Boldt edited comment on JBIDE-13463 at 3/8/13 4:21 PM:
------------------------------------------------------------
PR looked good, but I added some extra bling to it: https://github.com/jbosstools/jbosstools-build-sites/pull/36
Verified w/ webtools-site and corestest-site.
Next:
* need to verify this works for the more complex cases of site and soa-site, which have additional steps (custom.build instead of basic.build task in build.xml).
* need to verify that publish.sh will work with a repository folder instead of a site folder. Might have to update shell scripts in jobs.
* need to disable redundant steps:
** migrate contents of associate.properties into <associateSites> in the pom.xml; disable that task
** disable duplicate generation of the index.html
was (Author: nickboldt):
PR looked good, but I added some extra bling to it: https://github.com/jbosstools/jbosstools-build-sites/pull/36
Verified w/ webtools-site and corestest-site.
Next, need to verify this works for the more complex cases of site and soa-site, which have additional steps (custom.build instead of basic.build task in build.xml).
Also need to verify that publish.sh will work with a repository folder instead of a site folder. Might have to update shell scripts in jobs.
> Replace eclipse-update-site for aggregator by eclipse-repository
> ----------------------------------------------------------------
>
> Key: JBIDE-13463
> URL: https://issues.jboss.org/browse/JBIDE-13463
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: Build/Releng
> Reporter: Mickael Istria
> Assignee: Mickael Istria
> Fix For: 4.1.0.Alpha2
>
>
> The "eclipse-update-site" packaging type we've been using for aggregate sites is deprecated. Moreover it now shows some limitations (doesn't support pack.gz and other new Tycho stuff) that make it worth migrating to "eclipse-repository".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 1 month
[JBoss JIRA] (JBIDE-13463) Replace eclipse-update-site for aggregator by eclipse-repository
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13463?page=com.atlassian.jira.plugi... ]
Nick Boldt edited comment on JBIDE-13463 at 3/8/13 4:18 PM:
------------------------------------------------------------
PR looked good, but I added some extra bling to it: https://github.com/jbosstools/jbosstools-build-sites/pull/36
Verified w/ webtools-site and corestest-site.
Next, need to verify this works for the more complex cases of site and soa-site, which have additional steps (custom.build instead of basic.build task in build.xml).
Also need to verify that publish.sh will work with a repository folder instead of a site folder. Might have to update shell scripts in jobs.
was (Author: nickboldt):
PR looked good, but I added some extra bling to it: https://github.com/jbosstools/jbosstools-build-sites/pull/36
Verified w/ webtools-site and corestest-site.
Next, need to verify this works for the more complex cases of site and soa-site, which have additional steps (custom.build instead of basic.build task in build.xml).
> Replace eclipse-update-site for aggregator by eclipse-repository
> ----------------------------------------------------------------
>
> Key: JBIDE-13463
> URL: https://issues.jboss.org/browse/JBIDE-13463
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: Build/Releng
> Reporter: Mickael Istria
> Assignee: Mickael Istria
> Fix For: 4.1.0.Alpha2
>
>
> The "eclipse-update-site" packaging type we've been using for aggregate sites is deprecated. Moreover it now shows some limitations (doesn't support pack.gz and other new Tycho stuff) that make it worth migrating to "eclipse-repository".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 1 month