[JBoss JIRA] (JBIDE-13452) investigate removing JBT_VERSION, JBDS_VERSION from parent pom
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13452?page=com.atlassian.jira.plugi... ]
Nick Boldt edited comment on JBIDE-13452 at 3/24/13 12:47 PM:
--------------------------------------------------------------
JBT_VERSION is still used in these files:
*{color:red}
./jbosstools-build/parent/pom.xml
{color}*
{code}
<JBT_VERSION>4.1.0</JBT_VERSION>
{code}
Cleaned from these files:
*{color:green}
-./jbosstools-build-sites/aggregate/build.xml-
-./jbosstools-build-sites/aggregate/**/pom.xml-
-./jbosstools-build-sites/results/build.xml-
-./jbosstools-build-sites/results/pom.xml-
-./jbosstools-base/site/pom.xml-
-./jbosstools-server/site/pom.xml-
-./jbosstools-javaee/site/pom.xml-
{color}*
Meanwhile, JBDS_VERSION is set in product/pom.xml (devstudio SVN) and used in these files:
*{color:red}
./product/installer/build.xml
./product/installer/pom.xml
./product/results/build.xml
./product/results/index-earlyaccess-template.html
./product/results/index-internal-template.html
./product/results/index-local-template.html
./product/results/pom.xml
./product/site/build.xml
./product/site/pom.xml
./product-soa/site/build.xml
./product-soa/site/pom.xml
./product/sources/build.xml
./product/sources/pom.xml{color}*
was (Author: nickboldt):
JBT_VERSION is still used in these files:
*{color:red}
./jbosstools-build/parent/pom.xml
{color}*
{code}
<JBT_VERSION>4.1.0</JBT_VERSION>
{code}
Cleaned from these files:
*{color:green}
-./jbosstools-build-sites/aggregate/build.xml-
-./jbosstools-build-sites/aggregate/**/pom.xml-
-./jbosstools-build-sites/results/build.xml-
-./jbosstools-build-sites/results/pom.xml-
-./jbosstools-base/site/pom.xml-
-./jbosstools-server/site/pom.xml-
./jbosstools-javaee/site/pom.xml
{color}*
Meanwhile, JBDS_VERSION is set in product/pom.xml (devstudio SVN) and used in these files:
*{color:red}
./product/installer/build.xml
./product/installer/pom.xml
./product/results/build.xml
./product/results/index-earlyaccess-template.html
./product/results/index-internal-template.html
./product/results/index-local-template.html
./product/results/pom.xml
./product/site/build.xml
./product/site/pom.xml
./product-soa/site/build.xml
./product-soa/site/pom.xml
./product/sources/build.xml
./product/sources/pom.xml{color}*
> investigate removing JBT_VERSION, JBDS_VERSION from parent pom
> --------------------------------------------------------------
>
> Key: JBIDE-13452
> URL: https://issues.jboss.org/browse/JBIDE-13452
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: Build/Releng, target-platform, updatesite
> Affects Versions: 4.1.0.Alpha1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
>
> investigate removing JBT_VERSION, JBDS_VERSION, and TARGET_PLATFORM_VERSION (min and max) from parent pom
> Can we switch to using dynamic maven variables like project.version instead?
> Moving forward, jobs will override/set the version of target platform used to build (min) and test (max), and developers will be required to decide when/if to move to a newer parent pom or target platform version(s) if needed. For projects that are released, jobs will run only when TP changes (ie., will watch the jbosstools-target-platforms repo for changes).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years
[JBoss JIRA] (JBIDE-13452) investigate removing JBT_VERSION, JBDS_VERSION from parent pom
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13452?page=com.atlassian.jira.plugi... ]
Nick Boldt edited comment on JBIDE-13452 at 3/24/13 12:46 PM:
--------------------------------------------------------------
DONE:
* Remove JBT_VERSION from parent/pom.xml (master only) - see https://github.com/jbosstools/jbosstools-build/pull/79
* Remove TARGET_PLATFORM_VERSION-maximum from parent/pom.xml (master only, see JBIDE-13821) - see https://github.com/jbosstools/jbosstools-build/pull/79
Still to do:
* Determine if JBDS_VERSION can be replaced with $\{project.version\} in these 14 files:
{code}
./product/pom.xml
./product/installer/build.xml
./product/installer/pom.xml
./product/results/build.xml
./product/results/index-earlyaccess-template.html
./product/results/index-internal-template.html
./product/results/index-local-template.html
./product/results/pom.xml
./product/site/build.xml
./product/site/pom.xml
./product-soa/site/build.xml
./product-soa/site/pom.xml
./product/sources/build.xml
./product/sources/pom.xml
{code}
was (Author: nickboldt):
DONE:
* Remove JBT_VERSION from parent/pom.xml (master only) - see https://github.com/jbosstools/jbosstools-build/pull/79
* Remove TARGET_PLATFORM_VERSION-maximum from parent/pom.xml (master only, see JBIDE-13821) - see https://github.com/jbosstools/jbosstools-build/pull/79
Still to do:
* Determine if JBDS_VERSION can be replaced with ${project.version} in these files:
{code}
./product/pom.xml
./product/installer/build.xml
./product/installer/pom.xml
./product/results/build.xml
./product/results/index-earlyaccess-template.html
./product/results/index-internal-template.html
./product/results/index-local-template.html
./product/results/pom.xml
./product/site/build.xml
./product/site/pom.xml
./product-soa/site/build.xml
./product-soa/site/pom.xml
./product/sources/build.xml
./product/sources/pom.xml
{code}
> investigate removing JBT_VERSION, JBDS_VERSION from parent pom
> --------------------------------------------------------------
>
> Key: JBIDE-13452
> URL: https://issues.jboss.org/browse/JBIDE-13452
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: Build/Releng, target-platform, updatesite
> Affects Versions: 4.1.0.Alpha1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
>
> investigate removing JBT_VERSION, JBDS_VERSION, and TARGET_PLATFORM_VERSION (min and max) from parent pom
> Can we switch to using dynamic maven variables like project.version instead?
> Moving forward, jobs will override/set the version of target platform used to build (min) and test (max), and developers will be required to decide when/if to move to a newer parent pom or target platform version(s) if needed. For projects that are released, jobs will run only when TP changes (ie., will watch the jbosstools-target-platforms repo for changes).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years
[JBoss JIRA] (JBIDE-13452) investigate removing JBT_VERSION, JBDS_VERSION from parent pom
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13452?page=com.atlassian.jira.plugi... ]
Nick Boldt edited comment on JBIDE-13452 at 3/24/13 12:47 PM:
--------------------------------------------------------------
PRs for cleaning up update sites and removing dependency on JBT_VERSION:
https://github.com/jbosstools/jbosstools-base/pull/66
https://github.com/jbosstools/jbosstools-javaee/pull/62
https://github.com/jbosstools/jbosstools-server/pull/63
All these PRs have been applied.
was (Author: nickboldt):
PRs for cleaning up update sites and removing dependency on JBT_VERSION:
https://github.com/jbosstools/jbosstools-base/pull/66
https://github.com/jbosstools/jbosstools-javaee/pull/62
https://github.com/jbosstools/jbosstools-server/pull/63
> investigate removing JBT_VERSION, JBDS_VERSION from parent pom
> --------------------------------------------------------------
>
> Key: JBIDE-13452
> URL: https://issues.jboss.org/browse/JBIDE-13452
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: Build/Releng, target-platform, updatesite
> Affects Versions: 4.1.0.Alpha1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
>
> investigate removing JBT_VERSION, JBDS_VERSION, and TARGET_PLATFORM_VERSION (min and max) from parent pom
> Can we switch to using dynamic maven variables like project.version instead?
> Moving forward, jobs will override/set the version of target platform used to build (min) and test (max), and developers will be required to decide when/if to move to a newer parent pom or target platform version(s) if needed. For projects that are released, jobs will run only when TP changes (ie., will watch the jbosstools-target-platforms repo for changes).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years
[JBoss JIRA] (JBIDE-13452) investigate removing JBT_VERSION, JBDS_VERSION from parent pom
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13452?page=com.atlassian.jira.plugi... ]
Nick Boldt edited comment on JBIDE-13452 at 3/24/13 12:45 PM:
--------------------------------------------------------------
DONE:
* Remove JBT_VERSION from parent/pom.xml (master only) - see https://github.com/jbosstools/jbosstools-build/pull/79
* Remove TARGET_PLATFORM_VERSION-maximum from parent/pom.xml (master only, see JBIDE-13821) - see https://github.com/jbosstools/jbosstools-build/pull/79
Still to do:
* Determine if JBDS_VERSION can be replaced with ${project.version} in these files:
{code}
./product/pom.xml
./product/installer/build.xml
./product/installer/pom.xml
./product/results/build.xml
./product/results/index-earlyaccess-template.html
./product/results/index-internal-template.html
./product/results/index-local-template.html
./product/results/pom.xml
./product/site/build.xml
./product/site/pom.xml
./product-soa/site/build.xml
./product-soa/site/pom.xml
./product/sources/build.xml
./product/sources/pom.xml
{code}
was (Author: nickboldt):
Still to do:
* Remove JBT_VERSION from parent/pom.xml (master only)
* Remove TARGET_PLATFORM_VERSION-maximum from parent/pom.xml (master only, see JBIDE-13821)
* Determine if JBDS_VERSION can be replaced with ${project.version} in these files:
{code}
./product/pom.xml
./product/installer/build.xml
./product/installer/pom.xml
./product/results/build.xml
./product/results/index-earlyaccess-template.html
./product/results/index-internal-template.html
./product/results/index-local-template.html
./product/results/pom.xml
./product/site/build.xml
./product/site/pom.xml
./product-soa/site/build.xml
./product-soa/site/pom.xml
./product/sources/build.xml
./product/sources/pom.xml
{code}
> investigate removing JBT_VERSION, JBDS_VERSION from parent pom
> --------------------------------------------------------------
>
> Key: JBIDE-13452
> URL: https://issues.jboss.org/browse/JBIDE-13452
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: Build/Releng, target-platform, updatesite
> Affects Versions: 4.1.0.Alpha1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
>
> investigate removing JBT_VERSION, JBDS_VERSION, and TARGET_PLATFORM_VERSION (min and max) from parent pom
> Can we switch to using dynamic maven variables like project.version instead?
> Moving forward, jobs will override/set the version of target platform used to build (min) and test (max), and developers will be required to decide when/if to move to a newer parent pom or target platform version(s) if needed. For projects that are released, jobs will run only when TP changes (ie., will watch the jbosstools-target-platforms repo for changes).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years
[JBoss JIRA] (JBIDE-13452) investigate removing JBT_VERSION, JBDS_VERSION from parent pom
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13452?page=com.atlassian.jira.plugi... ]
Nick Boldt edited comment on JBIDE-13452 at 3/24/13 12:38 PM:
--------------------------------------------------------------
Still to do:
* Remove JBT_VERSION from parent/pom.xml (master only)
* Remove TARGET_PLATFORM_VERSION-maximum from parent/pom.xml (master only, see JBIDE-13821)
* Determine if JBDS_VERSION can be replaced with ${project.version} in these files:
{code}
./product/pom.xml
./product/installer/build.xml
./product/installer/pom.xml
./product/results/build.xml
./product/results/index-earlyaccess-template.html
./product/results/index-internal-template.html
./product/results/index-local-template.html
./product/results/pom.xml
./product/site/build.xml
./product/site/pom.xml
./product-soa/site/build.xml
./product-soa/site/pom.xml
./product/sources/build.xml
./product/sources/pom.xml
{code}
was (Author: nickboldt):
Still to do:
* Remove JBT_VERSION from parent/pom.xml (master only)
* Remove TARGET_PLATFORM_VERSION-maximum from parent/pom.xml (master only, see JBIDE-13821)
* Determine if JBDS_VERSION can be replaced with ${project.version} in these files:
{code}
./product/pom.xml
./product/installer/build.xml
./product/installer/pom.xml
./product/results/build.xml
./product/results/index-earlyaccess-template.html
./product/results/index-internal-template.html
./product/results/index-local-template.html
./product/results/pom.xml
./product/site/build.xml
./product/site/pom.xml
./product-soa/site/build.xml
./product-soa/site/pom.xml
{code}
./product/sources/build.xml
./product/sources/pom.xml
> investigate removing JBT_VERSION, JBDS_VERSION from parent pom
> --------------------------------------------------------------
>
> Key: JBIDE-13452
> URL: https://issues.jboss.org/browse/JBIDE-13452
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: Build/Releng, target-platform, updatesite
> Affects Versions: 4.1.0.Alpha1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
>
> investigate removing JBT_VERSION, JBDS_VERSION, and TARGET_PLATFORM_VERSION (min and max) from parent pom
> Can we switch to using dynamic maven variables like project.version instead?
> Moving forward, jobs will override/set the version of target platform used to build (min) and test (max), and developers will be required to decide when/if to move to a newer parent pom or target platform version(s) if needed. For projects that are released, jobs will run only when TP changes (ie., will watch the jbosstools-target-platforms repo for changes).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years
[JBoss JIRA] (JBIDE-13673) jenkins jobs for components and aggregates should set overrides for TARGET_PLATFORM_VERSION and TARGET_PLATFORM_VERSION-maximum so we ensure that builds use the correct TP regardless of their root pom's included parent pom version
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13673?page=com.atlassian.jira.plugi... ]
Nick Boldt edited comment on JBIDE-13673 at 3/24/13 12:29 PM:
--------------------------------------------------------------
With the fix for JBIDE-13821 in place, and jobs updated to define job parameters for TARGET_PLATFORM_VERSION and TARGET_PLATFORM_VERSION_MAXIMUM, we can now do this:
* *when building*: clean install -DTARGET_PLATFORM_VERSION=$\{TARGET_PLATFORM_VERSION\}
* *when testing*: verify -DTARGET_PLATFORM_VERSION=$\{TARGET_PLATFORM_VERSION_MAXIMUM\}
I've also removed -Pmaximum from the jobs so that we're only overriding the target platform version rather than calling an extra profile.
was (Author: nickboldt):
With the fix for JBIDE-13821 in place, and jobs updated to define job parameters for TARGET_PLATFORM_VERSION and TARGET_PLATFORM_VERSION_MAXIMUM, we can now do this:
* -DTARGET_PLATFORM_VERSION=${TARGET_PLATFORM_VERSION} *when building* or
* -DTARGET_PLATFORM_VERSION=${TARGET_PLATFORM_VERSION_MAXIMUM} *when running tests*
I've also removed -Pmaximum from the jobs so that we're only overriding the target platform version rather than calling an extra profile.
> jenkins jobs for components and aggregates should set overrides for TARGET_PLATFORM_VERSION and TARGET_PLATFORM_VERSION-maximum so we ensure that builds use the correct TP regardless of their root pom's included parent pom version
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-13673
> URL: https://issues.jboss.org/browse/JBIDE-13673
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: Build/Releng
> Affects Versions: 4.1.0.Alpha1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 4.1.0.Alpha2
>
>
> jenkins jobs for components and aggregates should set overrides for TARGET_PLATFORM_VERSION and TARGET_PLATFORM_VERSION-maximum so we ensure that builds use the correct TP regardless of their root pom's included parent pom version
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years
[JBoss JIRA] (JBIDE-13452) investigate removing JBT_VERSION, JBDS_VERSION from parent pom
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13452?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-13452:
------------------------------------
Still to do:
* Remove JBT_VERSION from parent/pom.xml (master only)
* Remove TARGET_PLATFORM_VERSION-maximum from parent/pom.xml (master only, see JBIDE-13821)
* Determine if JBDS_VERSION can be replaced with ${project.version} in these files:
{code}
./product/pom.xml
./product/installer/build.xml
./product/installer/pom.xml
./product/results/build.xml
./product/results/index-earlyaccess-template.html
./product/results/index-internal-template.html
./product/results/index-local-template.html
./product/results/pom.xml
./product/site/build.xml
./product/site/pom.xml
./product-soa/site/build.xml
./product-soa/site/pom.xml
{code}
./product/sources/build.xml
./product/sources/pom.xml
> investigate removing JBT_VERSION, JBDS_VERSION from parent pom
> --------------------------------------------------------------
>
> Key: JBIDE-13452
> URL: https://issues.jboss.org/browse/JBIDE-13452
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: Build/Releng, target-platform, updatesite
> Affects Versions: 4.1.0.Alpha1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
>
> investigate removing JBT_VERSION, JBDS_VERSION, and TARGET_PLATFORM_VERSION (min and max) from parent pom
> Can we switch to using dynamic maven variables like project.version instead?
> Moving forward, jobs will override/set the version of target platform used to build (min) and test (max), and developers will be required to decide when/if to move to a newer parent pom or target platform version(s) if needed. For projects that are released, jobs will run only when TP changes (ie., will watch the jbosstools-target-platforms repo for changes).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years
[JBoss JIRA] (JBIDE-13821) CI runs tests against minimum instead of maximum
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13821?page=com.atlassian.jira.plugi... ]
Nick Boldt reassigned JBIDE-13821:
----------------------------------
Assignee: Max Rydahl Andersen (was: Nick Boldt)
Max, please resolve or close this if you're satisfied or assign it back to me if you feel there's more I need to do here.
> CI runs tests against minimum instead of maximum
> ------------------------------------------------
>
> Key: JBIDE-13821
> URL: https://issues.jboss.org/browse/JBIDE-13821
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: Build/Releng
> Affects Versions: 4.0.x, 4.1.0.Alpha2
> Reporter: Mickael Istria
> Assignee: Max Rydahl Andersen
> Priority: Critical
> Fix For: 4.0.1.Final, 4.1.0.Alpha2
>
>
> As Maven executions set a value for the TARGET_PLATFORM_VERSION value, this property is not overriden by the maximum profile.
> Maven order to set properties is
> # look a -D... to set property, if not found
> # look at active profiles to set property, if not found
> # look at default value of property to set it
> This makes that in mvn execution for tests, the TARGET_PLATFORM_VERSION is set to minimal is CI jobs, whereas with using the -Pmaximun profile, we expect maximum.
> This is a critical issue since it caused hours of confusions to debug on 4.0.x branch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years