[JBoss JIRA] (JBIDE-13888) openshift-java-client: make sure useragent is sent
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13888?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-13888 at 4/2/13 3:28 AM:
------------------------------------------------------------------
There is also very weird code in the UrlConnectionHttpClientBuilder which holds user-agent building logic. IMHO this logic should be in the rest service, not in the builder since the user-agent should get built correctly even if you create the client directly or use the builder:
{code:title=UrlConnectionHttpClientBuilder}
public IHttpClient client() {
if (authKey != null && authKey.trim().length() > 0) {
if (userAgent == null) {
userAgent = "OpenShift";
} else if (!userAgent.startsWith("OpenShift")) {
userAgent = "OpenShift-" + userAgent;
}
}
return new UrlConnectionHttpClient(username, password, userAgent,
sslChecks, requestMediaType, acceptedMediaType, version,
authKey, authIV);
}
{code}
To me the above code should get moved to the jenkins-client which requires this. I moved this to a new issue: JBIDE-13891
was (Author: adietish):
There is also very weird code in the UrlConnectionHttpClientBuilder which holds user-agent building logic. IMHO this logic should be in the rest service, not in the builder since the user-agent should get built correctly even if you create the client directly or use the builder:
{code:title=UrlConnectionHttpClientBuilder}
public IHttpClient client() {
if (authKey != null && authKey.trim().length() > 0) {
if (userAgent == null) {
userAgent = "OpenShift";
} else if (!userAgent.startsWith("OpenShift")) {
userAgent = "OpenShift-" + userAgent;
}
}
return new UrlConnectionHttpClient(username, password, userAgent,
sslChecks, requestMediaType, acceptedMediaType, version,
authKey, authIV);
}
{code}
> openshift-java-client: make sure useragent is sent
> --------------------------------------------------
>
> Key: JBIDE-13888
> URL: https://issues.jboss.org/browse/JBIDE-13888
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.1.0.Alpha2
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Fix For: 4.1.0.Alpha2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years
[JBoss JIRA] (JBIDE-13891) openshift-java-client: client should not hard-code user-agent if you're usign keys
by Andre Dietisheim (JIRA)
Andre Dietisheim created JBIDE-13891:
----------------------------------------
Summary: openshift-java-client: client should not hard-code user-agent if you're usign keys
Key: JBIDE-13891
URL: https://issues.jboss.org/browse/JBIDE-13891
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: openshift
Affects Versions: 4.1.0.Alpha2
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 4.1.x
There is also very weird code in the UrlConnectionHttpClientBuilder which holds user-agent building logic. IMHO this logic should be in the rest service, not in the builder since the user-agent should get built correctly even if you create the client directly or use the builder:
{code:title=UrlConnectionHttpClientBuilder}
public IHttpClient client() {
if (authKey != null && authKey.trim().length() > 0) {
if (userAgent == null) {
userAgent = "OpenShift";
} else if (!userAgent.startsWith("OpenShift")) {
userAgent = "OpenShift-" + userAgent;
}
}
return new UrlConnectionHttpClient(username, password, userAgent,
sslChecks, requestMediaType, acceptedMediaType, version,
authKey, authIV);
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years
[JBoss JIRA] (JBIDE-13890) OpenOn for <div data-role="page">: "Open With BrowserSim"
by Alexey Kazakov (JIRA)
Alexey Kazakov created JBIDE-13890:
--------------------------------------
Summary: OpenOn for <div data-role="page">: "Open With BrowserSim"
Key: JBIDE-13890
URL: https://issues.jboss.org/browse/JBIDE-13890
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: jsp/jsf/xml/html source editing
Reporter: Alexey Kazakov
Assignee: Daniel Azarov
Fix For: 4.1.x
This feature may be useful for multi-page documents.
1. Open any jQueryMobile html page with HTML Editor.
2. Ctrl+Click on <div data-role="page">
3. There should be "Open With BrowserSim" option available which opens this page with BrowserSim.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years