[JBoss JIRA] (JBDS-3187) enforce rule that JBDS com.jboss.* bits must have GA, not Final qualifier
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBDS-3187?page=com.atlassian.jira.plugin.... ]
Nick Boldt edited comment on JBDS-3187 at 10/17/14 3:11 PM:
------------------------------------------------------------
Tests build of JBDS in master branch with different settings:
*works for master branch with 4.3.0.Alpha1-SNAPSHOT parent pom*
{code}
mvn clean install -P hudson -Djbosstools-site-stream=master -Dtpc.version=4.41.0.Final-SNAPSHOT
{code}
* now fails (as expected) for master branch with this change to root pom to use 4.2.0.Final-SNAPSHOT*
{code}
$➔ gd pom.xml
diff --git a/pom.xml b/pom.xml
index fd3a6ae..ead19f7 100644
--- a/pom.xml
+++ b/pom.xml
@@ -6,7 +6,7 @@
<parent>
<groupId>org.jboss.tools</groupId>
<artifactId>parent</artifactId>
- <version>4.3.0.Alpha1-SNAPSHOT</version>
+ <version>4.2.0.Final-SNAPSHOT</version>
</parent>
<groupId>com.jboss.devstudio</groupId>
<artifactId>product</artifactId>
mvn install -P hudson -Djbosstools-site-stream=4.2.luna -Dtpc.version=4.41.0.Final-SNAPSHOT
[INFO] ParentPomVersionCheckRule ......................... SUCCESS [2.312s]
[INFO] JBDS - Product, Installers ........................ FAILURE [0.209s]
[WARNING] Rule 0: com.jboss.devstudio.enforcer.rule.ParentPomVersionCheckRule failed with message:
** Parent pom version (4.2.0.Final-SNAPSHOT) contains .Final; must set -DBUILD_ALIAS=GA **
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:1.0-beta-1:enforce (enforce) on project product: Some Enforcer rules have failed. Look above for specific messages explaining why the rule failed. -> [Help 1]
{code}
*works for master branch with the above same change to root pom to use 4.2.0.Final-SNAPSHOT, and -DBUILD_ALIAS=GA flag added on*
{code}
mvn install -P hudson -Djbosstools-site-stream=4.2.luna -Dtpc.version=4.41.0.Final-SNAPSHOT -DBUILD_ALIAS=GA
[INFO] ParentPomVersionCheckRule ......................... SUCCESS [0.393s]
[INFO] JBDS - Product, Installers ........................ SUCCESS [1.490s]
[INFO] JBDS - Product - Build Rules ...................... SUCCESS [0.008s]
[INFO] JBDS - Product Plugins - Core ..................... SUCCESS [0.007s]
[INFO] com.jboss.devstudio.core .......................... SUCCESS [3.762s]
[INFO] com.jboss.devstudio.core.project.examples ......... SUCCESS [0.228s]
[INFO] com.jboss.devstudio.core.usage.branding ........... SUCCESS [0.265s]
[INFO] com.jboss.devstudio.core.central .................. SUCCESS [1.122s]
[INFO] JBDS - Product Features - Core .................... SUCCESS [0.027s]
[INFO] com.jboss.devstudio.core.feature .................. SUCCESS [0.616s]
[INFO] com.jboss.devstudio.core.feature.source ........... SUCCESS [0.446s]
[INFO] com.jboss.devstudio.core.site ..................... SUCCESS [1:27.254s]
[INFO] p2-director ....................................... SUCCESS [0.168s]
[INFO] com.jboss.devstudio.core.p2.director .............. SUCCESS [0.920s]
[INFO] p2-director ....................................... SUCCESS [21.242s]
[INFO] installer ......................................... SUCCESS [10:45.227s]
[INFO] JBoss Developer Studio Sources .................... SUCCESS [15.659s]
[INFO] JBoss Developer Studio Build Results .............. SUCCESS [7.716s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
{code}
So, I've pushed the above PR to master.
[~maxandersen] [~mickael_istria], if you want it pushed to 4.2.x, let me know.
was (Author: nickboldt):
Tests build of JBDS in master branch with different settings:
{code:works for master branch with 4.3.0.Alpha1-SNAPSHOT parent pom}
mvn clean install -P hudson -Djbosstools-site-stream=master -Dtpc.version=4.41.0.Final-SNAPSHOT
{code}
{code:fails for master branch with this change to root pom to use 4.2.0.Final-SNAPSHOT}
$➔ gd pom.xml
diff --git a/pom.xml b/pom.xml
index fd3a6ae..ead19f7 100644
--- a/pom.xml
+++ b/pom.xml
@@ -6,7 +6,7 @@
<parent>
<groupId>org.jboss.tools</groupId>
<artifactId>parent</artifactId>
- <version>4.3.0.Alpha1-SNAPSHOT</version>
+ <version>4.2.0.Final-SNAPSHOT</version>
</parent>
<groupId>com.jboss.devstudio</groupId>
<artifactId>product</artifactId>
mvn install -P hudson -Djbosstools-site-stream=4.2.luna -Dtpc.version=4.41.0.Final-SNAPSHOT
[INFO] ParentPomVersionCheckRule ......................... SUCCESS [2.312s]
[INFO] JBDS - Product, Installers ........................ FAILURE [0.209s]
[WARNING] Rule 0: com.jboss.devstudio.enforcer.rule.ParentPomVersionCheckRule failed with message:
** Parent pom version (4.2.0.Final-SNAPSHOT) contains .Final; must set -DBUILD_ALIAS=GA **
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:1.0-beta-1:enforce (enforce) on project product: Some Enforcer rules have failed. Look above for specific messages explaining why the rule failed. -> [Help 1]
{code}
{code:works for master branch with the above same change to root pom to use 4.2.0.Final-SNAPSHOT}
mvn install -P hudson -Djbosstools-site-stream=4.2.luna -Dtpc.version=4.41.0.Final-SNAPSHOT -DBUILD_ALIAS=GA
[INFO] ParentPomVersionCheckRule ......................... SUCCESS [0.393s]
[INFO] JBDS - Product, Installers ........................ SUCCESS [1.490s]
[INFO] JBDS - Product - Build Rules ...................... SUCCESS [0.008s]
[INFO] JBDS - Product Plugins - Core ..................... SUCCESS [0.007s]
[INFO] com.jboss.devstudio.core .......................... SUCCESS [3.762s]
[INFO] com.jboss.devstudio.core.project.examples ......... SUCCESS [0.228s]
[INFO] com.jboss.devstudio.core.usage.branding ........... SUCCESS [0.265s]
[INFO] com.jboss.devstudio.core.central .................. SUCCESS [1.122s]
[INFO] JBDS - Product Features - Core .................... SUCCESS [0.027s]
[INFO] com.jboss.devstudio.core.feature .................. SUCCESS [0.616s]
[INFO] com.jboss.devstudio.core.feature.source ........... SUCCESS [0.446s]
[INFO] com.jboss.devstudio.core.site ..................... SUCCESS [1:27.254s]
[INFO] p2-director ....................................... SUCCESS [0.168s]
[INFO] com.jboss.devstudio.core.p2.director .............. SUCCESS [0.920s]
[INFO] p2-director ....................................... SUCCESS [21.242s]
[INFO] installer ......................................... SUCCESS [10:45.227s]
[INFO] JBoss Developer Studio Sources .................... SUCCESS [15.659s]
[INFO] JBoss Developer Studio Build Results .............. SUCCESS [7.716s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
{code}
So, I've pushed the above PR to master.
[~maxandersen] [~mickael_istria], if you want it pushed to 4.2.x, let me know.
> enforce rule that JBDS com.jboss.* bits must have GA, not Final qualifier
> -------------------------------------------------------------------------
>
> Key: JBDS-3187
> URL: https://issues.jboss.org/browse/JBDS-3187
> Project: Developer Studio (JBoss Developer Studio)
> Issue Type: Task
> Components: build
> Affects Versions: 8.0.0.CR2
> Reporter: Nick Boldt
> Assignee: Nick Boldt
>
> Add a custom enforcer rule (using org.apache.maven.enforcer.rule) that will check if the parent pom contains .Final, and if so, will fail the build unless BUILD_ALIAS is set to "GA".
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 6 months
[JBoss JIRA] (JBDS-3187) enforce rule that JBDS com.jboss.* bits must have GA, not Final qualifier
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBDS-3187?page=com.atlassian.jira.plugin.... ]
Nick Boldt commented on JBDS-3187:
----------------------------------
Tests build of JBDS in master branch with different settings:
{code:works for master branch with 4.3.0.Alpha1-SNAPSHOT parent pom}
mvn clean install -P hudson -Djbosstools-site-stream=master -Dtpc.version=4.41.0.Final-SNAPSHOT
{code}
{code:fails for master branch with this change to root pom to use 4.2.0.Final-SNAPSHOT}
$➔ gd pom.xml
diff --git a/pom.xml b/pom.xml
index fd3a6ae..ead19f7 100644
--- a/pom.xml
+++ b/pom.xml
@@ -6,7 +6,7 @@
<parent>
<groupId>org.jboss.tools</groupId>
<artifactId>parent</artifactId>
- <version>4.3.0.Alpha1-SNAPSHOT</version>
+ <version>4.2.0.Final-SNAPSHOT</version>
</parent>
<groupId>com.jboss.devstudio</groupId>
<artifactId>product</artifactId>
mvn install -P hudson -Djbosstools-site-stream=4.2.luna -Dtpc.version=4.41.0.Final-SNAPSHOT
[INFO] ParentPomVersionCheckRule ......................... SUCCESS [2.312s]
[INFO] JBDS - Product, Installers ........................ FAILURE [0.209s]
[WARNING] Rule 0: com.jboss.devstudio.enforcer.rule.ParentPomVersionCheckRule failed with message:
** Parent pom version (4.2.0.Final-SNAPSHOT) contains .Final; must set -DBUILD_ALIAS=GA **
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:1.0-beta-1:enforce (enforce) on project product: Some Enforcer rules have failed. Look above for specific messages explaining why the rule failed. -> [Help 1]
{code}
{code:works for master branch with the above same change to root pom to use 4.2.0.Final-SNAPSHOT}
mvn install -P hudson -Djbosstools-site-stream=4.2.luna -Dtpc.version=4.41.0.Final-SNAPSHOT -DBUILD_ALIAS=GA
[INFO] ParentPomVersionCheckRule ......................... SUCCESS [0.393s]
[INFO] JBDS - Product, Installers ........................ SUCCESS [1.490s]
[INFO] JBDS - Product - Build Rules ...................... SUCCESS [0.008s]
[INFO] JBDS - Product Plugins - Core ..................... SUCCESS [0.007s]
[INFO] com.jboss.devstudio.core .......................... SUCCESS [3.762s]
[INFO] com.jboss.devstudio.core.project.examples ......... SUCCESS [0.228s]
[INFO] com.jboss.devstudio.core.usage.branding ........... SUCCESS [0.265s]
[INFO] com.jboss.devstudio.core.central .................. SUCCESS [1.122s]
[INFO] JBDS - Product Features - Core .................... SUCCESS [0.027s]
[INFO] com.jboss.devstudio.core.feature .................. SUCCESS [0.616s]
[INFO] com.jboss.devstudio.core.feature.source ........... SUCCESS [0.446s]
[INFO] com.jboss.devstudio.core.site ..................... SUCCESS [1:27.254s]
[INFO] p2-director ....................................... SUCCESS [0.168s]
[INFO] com.jboss.devstudio.core.p2.director .............. SUCCESS [0.920s]
[INFO] p2-director ....................................... SUCCESS [21.242s]
[INFO] installer ......................................... SUCCESS [10:45.227s]
[INFO] JBoss Developer Studio Sources .................... SUCCESS [15.659s]
[INFO] JBoss Developer Studio Build Results .............. SUCCESS [7.716s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
{code}
So, I've pushed the above PR to master.
[~maxandersen] [~mickael_istria], if you want it pushed to 4.2.x, let me know.
> enforce rule that JBDS com.jboss.* bits must have GA, not Final qualifier
> -------------------------------------------------------------------------
>
> Key: JBDS-3187
> URL: https://issues.jboss.org/browse/JBDS-3187
> Project: Developer Studio (JBoss Developer Studio)
> Issue Type: Task
> Components: build
> Affects Versions: 8.0.0.CR2
> Reporter: Nick Boldt
> Assignee: Nick Boldt
>
> Add a custom enforcer rule (using org.apache.maven.enforcer.rule) that will check if the parent pom contains .Final, and if so, will fail the build unless BUILD_ALIAS is set to "GA".
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 6 months
[JBoss JIRA] (JBIDE-18662) use getProjectSHAs.sh to control when to run aggregate builds, instead of doing composite site installs
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18662?page=com.atlassian.jira.plugi... ]
Nick Boldt updated JBIDE-18662:
-------------------------------
Fix Version/s: 4.2.1.Final
4.3.0.Alpha1
> use getProjectSHAs.sh to control when to run aggregate builds, instead of doing composite site installs
> -------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-18662
> URL: https://issues.jboss.org/browse/JBIDE-18662
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build
> Affects Versions: 4.2.0.CR2
> Reporter: Nick Boldt
> Fix For: 4.2.1.Final, 4.3.0.Alpha1
>
>
> Nick said:
> >> How else would you determine if/when the aggregates should be built?
> >> Using a variation on getProjectSHAs.sh script and diffing the last run
> >> w/ the current run? Or something else?
> And Mickael replied:
> > It could be built as often as the composite-install job runs because it
> > takes more or less the same time, and even if one builds aggregator for
> > nothing, it won't change the aggregate repository output (only the
> > content.jar and artifact.jar would be updated to a newer timestamp).
> > So since it's totally possible directly aggregate whenever something
> > changes for the same price, it seems more straightforward to do it
> > instead of introducing an intermediary control job, which can have bugs.
> Then Nick said:
> Yeah, I still like the fact that the composite install job performs an install test... but maybe it can be downstream of the TP change and NOT upstream of the aggregate builds?
> I could look at creating a more "diffable digest" as output of getProjectSHAs.sh and have that run in Jenkins as the gatekeeper (or keymaster?) for when to run aggregates.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 6 months
[JBoss JIRA] (JBIDE-18662) use getProjectSHAs.sh to control when to run aggregate builds, instead of doing composite site installs
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18662?page=com.atlassian.jira.plugi... ]
Nick Boldt reassigned JBIDE-18662:
----------------------------------
Assignee: Nick Boldt
> use getProjectSHAs.sh to control when to run aggregate builds, instead of doing composite site installs
> -------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-18662
> URL: https://issues.jboss.org/browse/JBIDE-18662
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build
> Affects Versions: 4.2.0.CR2
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 4.2.1.Final, 4.3.0.Alpha1
>
>
> Nick said:
> >> How else would you determine if/when the aggregates should be built?
> >> Using a variation on getProjectSHAs.sh script and diffing the last run
> >> w/ the current run? Or something else?
> And Mickael replied:
> > It could be built as often as the composite-install job runs because it
> > takes more or less the same time, and even if one builds aggregator for
> > nothing, it won't change the aggregate repository output (only the
> > content.jar and artifact.jar would be updated to a newer timestamp).
> > So since it's totally possible directly aggregate whenever something
> > changes for the same price, it seems more straightforward to do it
> > instead of introducing an intermediary control job, which can have bugs.
> Then Nick said:
> Yeah, I still like the fact that the composite install job performs an install test... but maybe it can be downstream of the TP change and NOT upstream of the aggregate builds?
> I could look at creating a more "diffable digest" as output of getProjectSHAs.sh and have that run in Jenkins as the gatekeeper (or keymaster?) for when to run aggregates.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 6 months
[JBoss JIRA] (JBIDE-18662) use getProjectSHAs.sh to control when to run aggregate builds, instead of doing composite site installs
by Nick Boldt (JIRA)
Nick Boldt created JBIDE-18662:
----------------------------------
Summary: use getProjectSHAs.sh to control when to run aggregate builds, instead of doing composite site installs
Key: JBIDE-18662
URL: https://issues.jboss.org/browse/JBIDE-18662
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: build
Affects Versions: 4.2.0.CR2
Reporter: Nick Boldt
Nick said:
>> How else would you determine if/when the aggregates should be built?
>> Using a variation on getProjectSHAs.sh script and diffing the last run
>> w/ the current run? Or something else?
And Mickael replied:
> It could be built as often as the composite-install job runs because it
> takes more or less the same time, and even if one builds aggregator for
> nothing, it won't change the aggregate repository output (only the
> content.jar and artifact.jar would be updated to a newer timestamp).
> So since it's totally possible directly aggregate whenever something
> changes for the same price, it seems more straightforward to do it
> instead of introducing an intermediary control job, which can have bugs.
Then Nick said:
Yeah, I still like the fact that the composite install job performs an install test... but maybe it can be downstream of the TP change and NOT upstream of the aggregate builds?
I could look at creating a more "diffable digest" as output of getProjectSHAs.sh and have that run in Jenkins as the gatekeeper (or keymaster?) for when to run aggregates.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 6 months
[JBoss JIRA] (JBIDE-18661) CSS content assist: Multiple error messages in case of invalid URI
by Alexey Kazakov (JIRA)
Alexey Kazakov created JBIDE-18661:
--------------------------------------
Summary: CSS content assist: Multiple error messages in case of invalid URI
Key: JBIDE-18661
URL: https://issues.jboss.org/browse/JBIDE-18661
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml/html source editing
Affects Versions: 4.2.0.CR2
Reporter: Alexey Kazakov
Assignee: Alexey Kazakov
Fix For: 4.2.1.Final, 4.3.0.Alpha1
I have an html page with the following CSS link:
<link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Open+Sans:300,300italic,400,400it...">
Ctrl+Click for any <* class="|"> causes multiple error messages:
{code}
java.lang.IllegalArgumentException: Invalid uri 'https://fonts.googleapis.com/css?family=Open+Sans:300,300italic,400,400it...': Invalid query
at org.apache.commons.httpclient.HttpMethodBase.<init>(HttpMethodBase.java:222)
at org.apache.commons.httpclient.methods.GetMethod.<init>(GetMethod.java:89)
at org.jboss.tools.common.util.HttpUtil.executeGetMethod(HttpUtil.java:141)
at org.jboss.tools.common.util.HttpUtil.executeGetMethod(HttpUtil.java:126)
at org.jboss.tools.common.util.HttpUtil.getInputStreamFromUrlByGetMethod(HttpUtil.java:55)
at org.jboss.tools.jst.web.kb.internal.RemoteFileManager$DownloaderImpl.getInputStream(RemoteFileManager.java:394)
at org.jboss.tools.jst.web.kb.internal.RemoteFileManager$DownloadingJob.run(RemoteFileManager.java:327)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
{code}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 6 months
[JBoss JIRA] (JBIDE-10777) Use Sonar for Code Quality Analysis
by Len DiMaggio (JIRA)
[ https://issues.jboss.org/browse/JBIDE-10777?page=com.atlassian.jira.plugi... ]
Len DiMaggio resolved JBIDE-10777.
----------------------------------
Resolution: Done
> Use Sonar for Code Quality Analysis
> -----------------------------------
>
> Key: JBIDE-10777
> URL: https://issues.jboss.org/browse/JBIDE-10777
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: qa
> Affects Versions: 3.1.2
> Environment: any
> Reporter: Mickael Istria
> Assignee: Len DiMaggio
> Priority: Minor
> Fix For: LATER
>
> Original Estimate: 1 week
> Remaining Estimate: 1 week
>
> Sonar provides a very powerful tool to get report about tests, code coverage, and static analysis in a project (errors, duplications...). It is easy to use, there is a nice integration with Maven and Hudson/Jenkins. It provides reporting tools for everything existing in the Java world, and more.
> Adding Sonar to Hudson really helps to make code better.
> http://www.sonarsource.org/
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 6 months