[JBoss JIRA] (JBIDE-18818) Test timeout in org.jboss.tools.jsf.verification.test
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18818?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-18818:
------------------------------------
If you give me a list of which test classes/suites are "integration" and "prone to freezing" I'll throw you a PR for how to move those into a profile so that Jenkins can skip them (-PskipITests) and you can still run them locally.
> Test timeout in org.jboss.tools.jsf.verification.test
> -----------------------------------------------------
>
> Key: JBIDE-18818
> URL: https://issues.jboss.org/browse/JBIDE-18818
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: jsf
> Affects Versions: 4.2.1.CR1
> Reporter: Nick Boldt
> Assignee: Alexey Kazakov
> Priority: Blocker
> Fix For: 4.2.1.Final
>
>
> Tests that time out due to blocking UI or other thread lock result in builds that are recorded as ABORTED [0]. This isn't a problem in terms of publishing new content because the build runs quickly, publishes the new bits, and THEN starts running tests.
> [0] https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-javaee_4....
> But where it IS a problem is where we use a buildflow job to run the whole stack of JBT projects. Buildflows will also abort if they encounter an aborted job [1].
> [1] https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-buildflow...
> Why is this a problem? Because when we do a weekend spin (or respin) not all the projects in the stack are guaranteed to rebuild to verify all the downstream component tests all still work.
> --
> If you cannot fix these tests so they run cleanly in Jenkins, please disable them or move them such that they can still be run LOCALLY using a profile, but will be skipped in Jenkins.
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
11 years, 8 months
[JBoss JIRA] (JBIDE-18794) Move shared properties related to JRE paths and itest.skip into parent pom
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18794?page=com.atlassian.jira.plugi... ]
Nick Boldt edited comment on JBIDE-18794 at 11/24/14 3:03 PM:
--------------------------------------------------------------
Generally, things move faster w/ a PR. Thus: https://github.com/jbosstools/jbosstools-build/pull/158
Seems like you changed your poms in jbosstools-server to use skipITests (more consistent w/ existing variables in parent pom) instead of itest(s).skip so I used that. Also don't see an itest profile in your code anymore, so I guess that's no longer needed in the parent pom?
[~maxandersen] [~mickael_istria] [~dgolovin] [~rob.stryker] ... discuss!
was (Author: nickboldt):
Generally, things move faster w/ a PR. Thus: https://github.com/jbosstools/jbosstools-build/pull/158
Seems like you changed your poms in jbosstools-server to use skipITests (more consistent w/ existing variables in parent pom) instead of itests.skip so I used that. Also don't see an itest profile in your code anymore, so I guess that's no longer needed in the parent pom?
[~maxandersen] [~mickael_istria] [~dgolovin] [~rob.stryker] ... discuss!
> Move shared properties related to JRE paths and itest.skip into parent pom
> --------------------------------------------------------------------------
>
> Key: JBIDE-18794
> URL: https://issues.jboss.org/browse/JBIDE-18794
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: build, server
> Affects Versions: 4.3.0.Alpha1
> Reporter: Nick Boldt
> Fix For: 4.3.0.Alpha1
>
>
> Some properties (and maybe the -Pitest profile) in the root of jbosstools-server can eventually be moved into the parent pom for reuse by other projects.
> (This was suggested by Max to Rob at some point on 2014/11/20.)
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
11 years, 8 months
[JBoss JIRA] (JBIDE-18794) Move shared properties related to JRE paths and itest.skip into parent pom
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18794?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-18794:
------------------------------------
Generally, things move faster w/ a PR. Thus: https://github.com/jbosstools/jbosstools-build/pull/158
Seems like you changed your poms in jbosstools-server to use skipITests (more consistent w/ existing variables in parent pom) instead of itests.skip so I used that. Also don't see an itest profile in your code anymore, so I guess that's no longer needed in the parent pom?
[~maxandersen] [~mickael_istria] [~dgolovin] [~rob.stryker] ... discuss!
> Move shared properties related to JRE paths and itest.skip into parent pom
> --------------------------------------------------------------------------
>
> Key: JBIDE-18794
> URL: https://issues.jboss.org/browse/JBIDE-18794
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: build, server
> Affects Versions: 4.3.0.Alpha1
> Reporter: Nick Boldt
> Fix For: 4.3.0.Alpha1
>
>
> Some properties (and maybe the -Pitest profile) in the root of jbosstools-server can eventually be moved into the parent pom for reuse by other projects.
> (This was suggested by Max to Rob at some point on 2014/11/20.)
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
11 years, 8 months
[JBoss JIRA] (JBIDE-18818) Test timeout in org.jboss.tools.jsf.verification.test
by Alexey Kazakov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18818?page=com.atlassian.jira.plugi... ]
Alexey Kazakov commented on JBIDE-18818:
----------------------------------------
The tests pass locally but I know that our tests can freeze from time to time. It's a very old problem with our integration tests.
> Test timeout in org.jboss.tools.jsf.verification.test
> -----------------------------------------------------
>
> Key: JBIDE-18818
> URL: https://issues.jboss.org/browse/JBIDE-18818
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: jsf
> Affects Versions: 4.2.1.CR1
> Reporter: Nick Boldt
> Assignee: Alexey Kazakov
> Priority: Blocker
> Fix For: 4.2.1.Final
>
>
> Tests that time out due to blocking UI or other thread lock result in builds that are recorded as ABORTED [0]. This isn't a problem in terms of publishing new content because the build runs quickly, publishes the new bits, and THEN starts running tests.
> [0] https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-javaee_4....
> But where it IS a problem is where we use a buildflow job to run the whole stack of JBT projects. Buildflows will also abort if they encounter an aborted job [1].
> [1] https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-buildflow...
> Why is this a problem? Because when we do a weekend spin (or respin) not all the projects in the stack are guaranteed to rebuild to verify all the downstream component tests all still work.
> --
> If you cannot fix these tests so they run cleanly in Jenkins, please disable them or move them such that they can still be run LOCALLY using a profile, but will be skipped in Jenkins.
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
11 years, 8 months
[JBoss JIRA] (JBIDE-18820) define how to handle ide.properties and avoid parent pom to always change
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18820?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-18820:
------------------------------------
* jbosstools.version is used to define the version of JBoss Tools that is checked in ide-config.properties. It needs to include the parent pom version (not the version of project examples, foundation, or central) AND the BUILD_ALIAS so we can differentiate between the current milestone, the staged-for-QE milestone, and the latest (nightly. In fact this 4.2.1.CR1 build cycle showcases how bad it is to have that version embedded inside a Foundation plugin since the version is used to resolve stuff for Central, which didn't upversion for this release.)
* devstudio.version is used to define the version of JBoss Tools that is checked in ide-config.properties. Unlike jbosstools.version, it cannot inherit from the parent pom because 4.2.1 != 8.0.1. It can also not inherit from a pom version in jbdevstudio-product because the poms are 8.0.1-SNAPSHOT, not 8.0.1.${BUILD_ALIAS}-SNAPSHOT.
So either we hardcode it in a Foundation plugin (where it was) and a JBDS plugin (where it was) and risk forgetting to update it with every milestone release, or we move it into the parent pom and make it less likely that it's forgotten. Of course Foundation still needs to be rebuilt every time we release a milestone (which will then trigger downstream aggregates), but odds are VERY good that will happen since they're always changes in there.
> define how to handle ide.properties and avoid parent pom to always change
> -------------------------------------------------------------------------
>
> Key: JBIDE-18820
> URL: https://issues.jboss.org/browse/JBIDE-18820
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: build
> Reporter: Max Rydahl Andersen
>
> As illustrated in JBIDE-18806 our current setup of how ide.properties and project versioning are not working or at least we seem to not get it updated right.
> Current workaround applied is that parent pom now again defines the global version even though this is not reliable at all since not all plugins will be rebuilt. (see JBIDE-13452 for earlier attempts on this)
> Opening this jira to make sure we walkthrough and write down which values should be in ide.properties and what level (4.2.0.CR1, 4.2.0 or 4.2. etc), when they get updated (hopefully rarely) and how to avoid parent pom from always having to respin because of a maintanence release.
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
11 years, 8 months
[JBoss JIRA] (JBIDE-18819) When discovery URL is not set, "Software/Updates" page is silently hidden
by Fred Bricon (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18819?page=com.atlassian.jira.plugi... ]
Fred Bricon commented on JBIDE-18819:
-------------------------------------
The stacktrace shows an error loading the proxywizards in a background job.
The software/update page is loaded in a different job, elsewhere, but the failure doesn't show up anywhere. So yeah swallowed exception is bad. should at least be logged.
The page should show up, with an error message if no connectors are found (which is a different state than all connectors hidden cause installed)
> When discovery URL is not set, "Software/Updates" page is silently hidden
> -------------------------------------------------------------------------
>
> Key: JBIDE-18819
> URL: https://issues.jboss.org/browse/JBIDE-18819
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: central
> Affects Versions: 4.2.0.Final
> Reporter: Mickael Istria
> Assignee: Mickael Istria
> Fix For: 4.2.1.CR1, 4.3.0.Alpha1
>
>
> With latest CI build (in http://www.qa.jboss.com/binaries/RHDS/builds/staging/devstudio.product_8.... ), Central editor seems to miss the "Software/Updates" tab.
> Log mentions an error, which doesn't seem related at first sight:
> {code:none}
> !SESSION 2014-11-21 15:51:47.555 -----------------------------------------------
> eclipse.buildId=unknown
> java.version=1.8.0_11
> java.vendor=Oracle Corporation
> BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
> Framework arguments: -product com.jboss.devstudio.core.product
> Command-line arguments: -os linux -ws gtk -arch x86_64 -product com.jboss.devstudio.core.product
> !ENTRY org.jboss.tools.project.examples 4 0 2014-11-21 15:53:24.762
> !MESSAGE All attempts to discover connectors have failed
> !SUBENTRY 1 org.eclipse.mylyn.discovery.core 4 0 2014-11-21 15:53:24.762
> !MESSAGE Failed to get connectors from RemoteProxyWizardDiscoveryStrategy
> !STACK 0
> java.lang.NullPointerException
> at java.net.URI$Parser.parse(URI.java:3042)
> at java.net.URI.<init>(URI.java:588)
> at org.jboss.tools.project.examples.internal.discovery.xpl.RemoteExternalBundleDiscoveryStrategy.loadRegistry(RemoteExternalBundleDiscoveryStrategy.java:90)
> at org.jboss.tools.project.examples.internal.discovery.xpl.ExternalBundleDiscoveryStrategy.performDiscovery(ExternalBundleDiscoveryStrategy.java:117)
> at org.jboss.tools.project.examples.internal.discovery.ChainedDiscoveryStrategy.performDiscovery(ChainedDiscoveryStrategy.java:62)
> at org.eclipse.mylyn.internal.discovery.core.model.ConnectorDiscovery.performDiscovery(ConnectorDiscovery.java:114)
> at org.jboss.tools.central.internal.discovery.wizards.ProxyWizardManager.loadWizards(ProxyWizardManager.java:107)
> at org.jboss.tools.central.internal.discovery.wizards.ProxyWizardUpdateJob.run(ProxyWizardUpdateJob.java:45)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
11 years, 8 months
[JBoss JIRA] (JBIDE-18824) Server adapter: Remove replicated actions, use default actions instead
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18824?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-18824:
-------------------------------------
Affects Version/s: 4.2.1.Final
(was: 4.2.0.Final)
> Server adapter: Remove replicated actions, use default actions instead
> ----------------------------------------------------------------------
>
> Key: JBIDE-18824
> URL: https://issues.jboss.org/browse/JBIDE-18824
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.2.1.Final
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Fix For: 4.3.x
>
> Attachments: duplicate-application-actions.png
>
>
> In JBIDE-11903 we added Start and Stop to the Explorer and Server adapter. In the server adapter we already have default items for start, stop and restart. We should remove our items from the OpenShift submenu and use the default actions instead:
> !duplicate-application-actions.png!
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
11 years, 8 months
[JBoss JIRA] (JBIDE-11903) Explorer: add Application start/stop/restart
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-11903?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-11903:
------------------------------------------
[~mlabuda] please test the topics branch before we merge it into the maintenance branch (as was decided with max apparently).
> Explorer: add Application start/stop/restart
> ---------------------------------------------
>
> Key: JBIDE-11903
> URL: https://issues.jboss.org/browse/JBIDE-11903
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: openshift
> Affects Versions: 3.3.0.Beta2
> Environment: Eclipse plugin
> Reporter: Nam Duong
> Assignee: Marián Labuda
> Priority: Blocker
> Labels: explorer, new_and_noteworthy
> Fix For: 4.2.1.Final, 4.3.x
>
>
> The OpenShift Console view should contain controls for application start|stop|restart to match the functionality of the CLI. Currently, if you select Window->Show View->Others->OpenShift Express Console, then login in and select an application. The right-click menu doesn't have start|stop|restart so users have to either install the rhc client tools or ssh onto the OpenShift host gear.
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
11 years, 8 months
[JBoss JIRA] (JBIDE-11903) Explorer: add Application start/stop/restart
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-11903?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-11903 at 11/24/14 1:41 PM:
--------------------------------------------------------------------
as discussed with max we're just adding star/stop to the OpenShift submenu in the server adapter. we dont map the default actions in the server adapter: start/stop/debug. We postpone this to JBIDE-18824
{quote}
[4:40:40 PM] Max Rydahl Andersen: andre - I think these are okey to add in maintaencne yes since they are not changing anything, just additions ...and they were actually part of requirement of the product.
[4:40:52 PM] Max Rydahl Andersen: I see it similar to the "add iphone 6" skin to browsersim.
[4:45:58 PM] Max Rydahl Andersen: andre - start/stop of these does not map to server start/stop ...they would be in the openshift menu too.
[4:46:15 PM] André Dietisheim: in OpenShift menu, not in the main items of the server adapter?
[4:46:50 PM] Max Rydahl Andersen: yes.
{quote}
was (Author: adietish):
as discussed with max:
{quote}
[4:40:40 PM] Max Rydahl Andersen: andre - I think these are okey to add in maintaencne yes since they are not changing anything, just additions ...and they were actually part of requirement of the product.
[4:40:52 PM] Max Rydahl Andersen: I see it similar to the "add iphone 6" skin to browsersim.
[4:45:58 PM] Max Rydahl Andersen: andre - start/stop of these does not map to server start/stop ...they would be in the openshift menu too.
[4:46:15 PM] André Dietisheim: in OpenShift menu, not in the main items of the server adapter?
[4:46:50 PM] Max Rydahl Andersen: yes.
{quote}
> Explorer: add Application start/stop/restart
> ---------------------------------------------
>
> Key: JBIDE-11903
> URL: https://issues.jboss.org/browse/JBIDE-11903
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: openshift
> Affects Versions: 3.3.0.Beta2
> Environment: Eclipse plugin
> Reporter: Nam Duong
> Assignee: Marián Labuda
> Priority: Blocker
> Labels: explorer, new_and_noteworthy
> Fix For: 4.2.1.Final, 4.3.x
>
>
> The OpenShift Console view should contain controls for application start|stop|restart to match the functionality of the CLI. Currently, if you select Window->Show View->Others->OpenShift Express Console, then login in and select an application. The right-click menu doesn't have start|stop|restart so users have to either install the rhc client tools or ssh onto the OpenShift host gear.
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
11 years, 8 months