[JBoss JIRA] (JBIDE-17924) java add annotation is available on projects but fail when running it
by Koen Aers (JIRA)
[ https://issues.jboss.org/browse/JBIDE-17924?page=com.atlassian.jira.plugi... ]
Koen Aers updated JBIDE-17924:
------------------------------
Fix Version/s: 4.2.0.CR1
> java add annotation is available on projects but fail when running it
> ---------------------------------------------------------------------
>
> Key: JBIDE-17924
> URL: https://issues.jboss.org/browse/JBIDE-17924
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: forge
> Reporter: Max Rydahl Andersen
> Fix For: 4.2.0.CR1
>
>
> EXECUTE: Have an eclipse project in focus in explorer.
> EXECUTE: Cmd+4
>
> Java: Add Annotation shows up.
> Select it.
> result: error in log with this:
> org.jboss.forge.addon.facets.FacetNotFoundException: No Facet of type [interface org.jboss.forge.addon.parser.java.facets.JavaSourceFacet] is installed.
> at org.jboss.forge.addon.facets.AbstractFaceted.getFacet(AbstractFaceted.java:51)
> at org.jboss.forge.addon.parser.java.beans.ProjectOperations.getProjectClasses(ProjectOperations.java:24)
> at org.jboss.forge.addon.parser.java.ui.annotations.JavaAddAnnotationCommandImpl.setupTargetClass(JavaAddAnnotationCommandImpl.java:296)
> at org.jboss.forge.addon.parser.java.ui.annotations.JavaAddAnnotationCommandImpl.initializeUI(JavaAddAnnotationCommandImpl.java:78)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.jboss.forge.furnace.proxy.ClassLoaderInterceptor$1.call(ClassLoaderInterceptor.java:65)
> at org.jboss.forge.furnace.util.ClassLoaders.executeIn(ClassLoaders.java:34)
> at org.jboss.forge.furnace.proxy.ClassLoaderInterceptor.invoke(ClassLoaderInterceptor.java:81)
> at org.jboss.forge.addon.parser.java.ui.annotations.JavaAddAnnotationCommandImpl_$$_javassist_59bd122d-fa09-40ec-857b-60ae17012d9e.initializeUI(JavaAddAnnotationCommandImpl_$$_javassist_59bd122d-fa09-40ec-857b-60ae17012d9e.java)
> at org.jboss.forge.addon.ui.impl.controller.SingleCommandControllerImpl.initialize(SingleCommandControllerImpl.java:55)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.jboss.forge.furnace.proxy.ClassLoaderAdapterCallback$2.call(ClassLoaderAdapterCallback.java:123)
> at org.jboss.forge.furnace.util.ClassLoaders.executeIn(ClassLoaders.java:34)
> at org.jboss.forge.furnace.proxy.ClassLoaderAdapterCallback.invoke(ClassLoaderAdapterCallback.java:96)
> at org.jboss.forge.addon.ui.controller.CommandController_$$_javassist_3230b267-466d-40b8-9fd2-bd6828930098.initialize(CommandController_$$_javassist_3230b267-466d-40b8-9fd2-bd6828930098.java)
> at org.jboss.tools.forge.ui.internal.ext.dialog.WizardDialogHelper.openWizard(WizardDialogHelper.java:103)
> at org.jboss.tools.forge.ui.internal.ext.dialog.UICommandListDialog$1$1.handleElementSelected(UICommandListDialog.java:187)
> at org.jboss.tools.forge.ui.internal.ext.quickaccess.QuickAccessContents.handleSelection(QuickAccessContents.java:326)
> at org.jboss.tools.forge.ui.internal.ext.quickaccess.QuickAccessContents.access$0(QuickAccessContents.java:316)
> at org.jboss.tools.forge.ui.internal.ext.quickaccess.QuickAccessContents$1.keyPressed(QuickAccessContents.java:347)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:167)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4188)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1467)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1490)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1475)
> at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:1504)
> at org.eclipse.swt.widgets.Text.sendKeyEvent(Text.java:1632)
> at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:1500)
> at org.eclipse.swt.widgets.Text.sendKeyEvent(Text.java:1598)
> at org.eclipse.swt.widgets.Control.doCommandBySelector(Control.java:1060)
> at org.eclipse.swt.widgets.Display.windowProc(Display.java:5719)
> at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method)
> at org.eclipse.swt.widgets.Widget.callSuper(Widget.java:221)
> at org.eclipse.swt.widgets.Widget.superKeyDown(Widget.java:1908)
> at org.eclipse.swt.widgets.Widget.keyDown(Widget.java:1085)
> at org.eclipse.swt.widgets.Control.keyDown(Control.java:2400)
> at org.eclipse.swt.widgets.Display.windowProc(Display.java:5629)
> at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method)
> at org.eclipse.swt.widgets.Widget.callSuper(Widget.java:221)
> at org.eclipse.swt.widgets.Widget.windowSendEvent(Widget.java:2105)
> at org.eclipse.swt.widgets.Shell.windowSendEvent(Shell.java:2329)
> at org.eclipse.swt.widgets.Display.windowProc(Display.java:5691)
> at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method)
> at org.eclipse.swt.widgets.Display.applicationSendEvent(Display.java:5128)
> at org.eclipse.swt.widgets.Display.applicationProc(Display.java:5277)
> at org.eclipse.swt.internal.cocoa.OS.objc_msgSend(Native Method)
> at org.eclipse.swt.internal.cocoa.NSApplication.sendEvent(NSApplication.java:128)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3655)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1151)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1032)
> at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:148)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:636)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:579)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:135)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:382)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:236)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:648)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:603)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1465)
> Caused by: org.jboss.forge.addon.facets.FacetNotFoundException: No Facet of type [interface org.jboss.forge.addon.parser.java.facets.JavaSourceFacet] is installed.
> ... 76 more
> I would have expected either:
> a) not having add annotation on projects
> b) when running forge would report a more informative error on why it is failing
> c) run add annotation but let me select which file it is for...
> anything except this silent logged error ;)
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 8 months
[JBoss JIRA] (JBIDE-17924) java add annotation is available on projects but fail when running it
by Koen Aers (JIRA)
[ https://issues.jboss.org/browse/JBIDE-17924?page=com.atlassian.jira.plugi... ]
Koen Aers reassigned JBIDE-17924:
---------------------------------
Assignee: Koen Aers
> java add annotation is available on projects but fail when running it
> ---------------------------------------------------------------------
>
> Key: JBIDE-17924
> URL: https://issues.jboss.org/browse/JBIDE-17924
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: forge
> Reporter: Max Rydahl Andersen
> Assignee: Koen Aers
> Fix For: 4.2.0.CR1
>
>
> EXECUTE: Have an eclipse project in focus in explorer.
> EXECUTE: Cmd+4
>
> Java: Add Annotation shows up.
> Select it.
> result: error in log with this:
> org.jboss.forge.addon.facets.FacetNotFoundException: No Facet of type [interface org.jboss.forge.addon.parser.java.facets.JavaSourceFacet] is installed.
> at org.jboss.forge.addon.facets.AbstractFaceted.getFacet(AbstractFaceted.java:51)
> at org.jboss.forge.addon.parser.java.beans.ProjectOperations.getProjectClasses(ProjectOperations.java:24)
> at org.jboss.forge.addon.parser.java.ui.annotations.JavaAddAnnotationCommandImpl.setupTargetClass(JavaAddAnnotationCommandImpl.java:296)
> at org.jboss.forge.addon.parser.java.ui.annotations.JavaAddAnnotationCommandImpl.initializeUI(JavaAddAnnotationCommandImpl.java:78)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.jboss.forge.furnace.proxy.ClassLoaderInterceptor$1.call(ClassLoaderInterceptor.java:65)
> at org.jboss.forge.furnace.util.ClassLoaders.executeIn(ClassLoaders.java:34)
> at org.jboss.forge.furnace.proxy.ClassLoaderInterceptor.invoke(ClassLoaderInterceptor.java:81)
> at org.jboss.forge.addon.parser.java.ui.annotations.JavaAddAnnotationCommandImpl_$$_javassist_59bd122d-fa09-40ec-857b-60ae17012d9e.initializeUI(JavaAddAnnotationCommandImpl_$$_javassist_59bd122d-fa09-40ec-857b-60ae17012d9e.java)
> at org.jboss.forge.addon.ui.impl.controller.SingleCommandControllerImpl.initialize(SingleCommandControllerImpl.java:55)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.jboss.forge.furnace.proxy.ClassLoaderAdapterCallback$2.call(ClassLoaderAdapterCallback.java:123)
> at org.jboss.forge.furnace.util.ClassLoaders.executeIn(ClassLoaders.java:34)
> at org.jboss.forge.furnace.proxy.ClassLoaderAdapterCallback.invoke(ClassLoaderAdapterCallback.java:96)
> at org.jboss.forge.addon.ui.controller.CommandController_$$_javassist_3230b267-466d-40b8-9fd2-bd6828930098.initialize(CommandController_$$_javassist_3230b267-466d-40b8-9fd2-bd6828930098.java)
> at org.jboss.tools.forge.ui.internal.ext.dialog.WizardDialogHelper.openWizard(WizardDialogHelper.java:103)
> at org.jboss.tools.forge.ui.internal.ext.dialog.UICommandListDialog$1$1.handleElementSelected(UICommandListDialog.java:187)
> at org.jboss.tools.forge.ui.internal.ext.quickaccess.QuickAccessContents.handleSelection(QuickAccessContents.java:326)
> at org.jboss.tools.forge.ui.internal.ext.quickaccess.QuickAccessContents.access$0(QuickAccessContents.java:316)
> at org.jboss.tools.forge.ui.internal.ext.quickaccess.QuickAccessContents$1.keyPressed(QuickAccessContents.java:347)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:167)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4188)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1467)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1490)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1475)
> at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:1504)
> at org.eclipse.swt.widgets.Text.sendKeyEvent(Text.java:1632)
> at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:1500)
> at org.eclipse.swt.widgets.Text.sendKeyEvent(Text.java:1598)
> at org.eclipse.swt.widgets.Control.doCommandBySelector(Control.java:1060)
> at org.eclipse.swt.widgets.Display.windowProc(Display.java:5719)
> at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method)
> at org.eclipse.swt.widgets.Widget.callSuper(Widget.java:221)
> at org.eclipse.swt.widgets.Widget.superKeyDown(Widget.java:1908)
> at org.eclipse.swt.widgets.Widget.keyDown(Widget.java:1085)
> at org.eclipse.swt.widgets.Control.keyDown(Control.java:2400)
> at org.eclipse.swt.widgets.Display.windowProc(Display.java:5629)
> at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method)
> at org.eclipse.swt.widgets.Widget.callSuper(Widget.java:221)
> at org.eclipse.swt.widgets.Widget.windowSendEvent(Widget.java:2105)
> at org.eclipse.swt.widgets.Shell.windowSendEvent(Shell.java:2329)
> at org.eclipse.swt.widgets.Display.windowProc(Display.java:5691)
> at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method)
> at org.eclipse.swt.widgets.Display.applicationSendEvent(Display.java:5128)
> at org.eclipse.swt.widgets.Display.applicationProc(Display.java:5277)
> at org.eclipse.swt.internal.cocoa.OS.objc_msgSend(Native Method)
> at org.eclipse.swt.internal.cocoa.NSApplication.sendEvent(NSApplication.java:128)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3655)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1151)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1032)
> at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:148)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:636)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:579)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:135)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:382)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:236)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:648)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:603)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1465)
> Caused by: org.jboss.forge.addon.facets.FacetNotFoundException: No Facet of type [interface org.jboss.forge.addon.parser.java.facets.JavaSourceFacet] is installed.
> ... 76 more
> I would have expected either:
> a) not having add annotation on projects
> b) when running forge would report a more informative error on why it is failing
> c) run add annotation but let me select which file it is for...
> anything except this silent logged error ;)
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 8 months
[JBoss JIRA] (JBIDE-18110) OpenShift explorer: Shortcuts should be disable if OpenShift Explorer view has lost focus
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18110?page=com.atlassian.jira.plugi... ]
Andre Dietisheim reassigned JBIDE-18110:
----------------------------------------
Assignee: Andre Dietisheim
> OpenShift explorer: Shortcuts should be disable if OpenShift Explorer view has lost focus
> -----------------------------------------------------------------------------------------
>
> Key: JBIDE-18110
> URL: https://issues.jboss.org/browse/JBIDE-18110
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.2.0.CR1
> Reporter: Marián Labuda
> Assignee: Andre Dietisheim
> Priority: Critical
> Labels: explorer
> Fix For: 4.2.0.CR1
>
>
> We have added shortcuts for deletion of application(s), domain(s) and connection(s) in OpenShift Explorer view. The "Delete" shortcut, often used in text editor, invoke dialog to delete an entry (application/domain/connection). The problem is that shortcuts are taken all the time, although the OpenShift Explorer view has lost focus.
> This cause deletion of character in text editors impossible while OpenShift Explorer is opened.
> We should set up to listen for shortcuts if and only if OpenShift Explorer view is opened and has focus.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 8 months
[JBoss JIRA] (JBIDE-18100) Application wizard, server adapter: Wizard choose existing application from server adapter selection
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18100?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-18100:
-------------------------------------
Labels: application_wizard (was: )
> Application wizard, server adapter: Wizard choose existing application from server adapter selection
> ----------------------------------------------------------------------------------------------------
>
> Key: JBIDE-18100
> URL: https://issues.jboss.org/browse/JBIDE-18100
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.2.0.CR1
> Reporter: Marián Labuda
> Assignee: Andre Dietisheim
> Priority: Minor
> Labels: application_wizard
> Fix For: 4.2.0.CR1
>
> Attachments: out-1.ogv, selected-server-adapter.png, used-existing-project.png
>
>
> This is happening only in wizard opened via shell menu (File - New - OpenShift Application). Opening New application wizard via Central and OpenShift explorer works fine (probably because of view focus).
> Issue is preselected existing application in New application wizard although I had no intentions to do it. If I have selected a server adapter and then I opened New application wizard via shell menu and go via wizard to the third wizard page, where the field for using an existing project is placed, there is used project from existing selected server adapter. For better and more obvious explanation see attached video: [^out-1.ogv]
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 8 months
[JBoss JIRA] (JBIDE-18100) Application wizard, server adapter: Wizard choose existing application from server adapter selection
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18100?page=com.atlassian.jira.plugi... ]
Andre Dietisheim reassigned JBIDE-18100:
----------------------------------------
Assignee: Andre Dietisheim
> Application wizard, server adapter: Wizard choose existing application from server adapter selection
> ----------------------------------------------------------------------------------------------------
>
> Key: JBIDE-18100
> URL: https://issues.jboss.org/browse/JBIDE-18100
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.2.0.CR1
> Reporter: Marián Labuda
> Assignee: Andre Dietisheim
> Priority: Minor
> Fix For: 4.2.0.CR1
>
> Attachments: out-1.ogv, selected-server-adapter.png, used-existing-project.png
>
>
> This is happening only in wizard opened via shell menu (File - New - OpenShift Application). Opening New application wizard via Central and OpenShift explorer works fine (probably because of view focus).
> Issue is preselected existing application in New application wizard although I had no intentions to do it. If I have selected a server adapter and then I opened New application wizard via shell menu and go via wizard to the third wizard page, where the field for using an existing project is placed, there is used project from existing selected server adapter. For better and more obvious explanation see attached video: [^out-1.ogv]
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 8 months
[JBoss JIRA] (JBIDE-17919) Snapshot wizard: snapshot file name is not refreshed upon changes between full and deployment type
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-17919?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-17919:
------------------------------------------
as long as JBIDE-18053 is not merged in target platform we cannot merge this since it would cause jenkins to fail.
We discussed splitting the patch in 2 parts extracting the tests to a separate PR which would allow us to merge the fix without having to wait for the target platform to include powermock et all.
> Snapshot wizard: snapshot file name is not refreshed upon changes between full and deployment type
> --------------------------------------------------------------------------------------------------
>
> Key: JBIDE-17919
> URL: https://issues.jboss.org/browse/JBIDE-17919
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.2.0.Beta3
> Reporter: Marián Labuda
> Assignee: Jeff Cantrill
> Labels: snapshot_wizard
> Fix For: 4.2.0.CR1
>
>
> When trying to create a new snapshot of FULL or DEPLOYMENT type after creating a snapshot earlier, there is no change of file name for the snapshot. It's still the same file name as it was for the snapshot created right before.
> I think there was intention to let user overwrite previously created snapshot. But this brings complications because of snapshot type. We should not override FULL snapshot with DEPLOYMENT snapshot. I think also, that there should not be overriding at all, but it should be distinguished as it is (after workaround) by number of snapshot.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 8 months
[JBoss JIRA] (JBIDE-17919) Snapshot wizard: snapshot file name is not refreshed upon changes between full and deployment type
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-17919?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-17919:
------------------------------------------
patch looks good!
the only concern I have is that we get another dependency for a few small invocations (which for sure fix the bug). The general rule of thumb in JBT is to have the least possible number of dependencies so we usually weight benefits/dependencies pretty well.
> Snapshot wizard: snapshot file name is not refreshed upon changes between full and deployment type
> --------------------------------------------------------------------------------------------------
>
> Key: JBIDE-17919
> URL: https://issues.jboss.org/browse/JBIDE-17919
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.2.0.Beta3
> Reporter: Marián Labuda
> Assignee: Jeff Cantrill
> Labels: snapshot_wizard
> Fix For: 4.2.0.CR1
>
>
> When trying to create a new snapshot of FULL or DEPLOYMENT type after creating a snapshot earlier, there is no change of file name for the snapshot. It's still the same file name as it was for the snapshot created right before.
> I think there was intention to let user overwrite previously created snapshot. But this brings complications because of snapshot type. We should not override FULL snapshot with DEPLOYMENT snapshot. I think also, that there should not be overriding at all, but it should be distinguished as it is (after workaround) by number of snapshot.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 8 months