[JBoss JIRA] (JBIDE-18053) Add Powermock to the target platform
by Jeff Cantrill (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18053?page=com.atlassian.jira.plugi... ]
Jeff Cantrill commented on JBIDE-18053:
---------------------------------------
After removing several duplicate dependencies at the request of [~mickael_istria], re-built target platform and re-ran tests with success:
{noformat}
[INFO]
[INFO] openshift.all ...................................... SUCCESS [ 1.962 s]
[INFO] openshift.plugins .................................. SUCCESS [ 0.005 s]
[INFO] org.jboss.tools.openshift.egit.core ................ SUCCESS [ 2.796 s]
[INFO] org.jboss.tools.openshift.express.client ........... SUCCESS [ 2.876 s]
[INFO] org.jboss.tools.openshift.express.core ............. SUCCESS [ 1.324 s]
[INFO] org.jboss.tools.openshift.egit.ui .................. SUCCESS [ 0.494 s]
[INFO] org.jboss.tools.openshift.express.ui ............... SUCCESS [ 3.349 s]
[INFO] openshift.tests .................................... SUCCESS [ 0.005 s]
[INFO] org.jboss.tools.openshift.egit.test ................ SUCCESS [ 20.062 s]
[INFO] org.jboss.tools.openshift.express.test ............. SUCCESS [ 18.035 s]
[INFO] openshift.features ................................. SUCCESS [ 0.008 s]
[INFO] org.jboss.tools.openshift.egit.integration.feature . SUCCESS [ 0.204 s]
[INFO] org.jboss.tools.openshift.express.feature .......... SUCCESS [ 0.154 s]
[INFO] org.jboss.tools.openshift.egit.integration.test.feature SUCCESS [ 0.064 s]
[INFO] org.jboss.tools.openshift.express.test.feature ..... SUCCESS [ 0.102 s]
[INFO] openshift.site ..................................... SUCCESS [ 2.904 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:16 min
[INFO] Finished at: 2014-08-25T08:05:37-04:00
[INFO] Final Memory: 117M/1427M
[INFO] ------------------------------------------------------------------------
{noformat}
> Add Powermock to the target platform
> ------------------------------------
>
> Key: JBIDE-18053
> URL: https://issues.jboss.org/browse/JBIDE-18053
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: build
> Affects Versions: 4.2.x
> Reporter: Jeff Cantrill
> Assignee: Nick Boldt
> Fix For: 4.2.0.CR1
>
>
> *Reason:* To improving testing by allowing the stubbing of scenerios like "new File(path).exists()" which require bytecode modifications in order to accomplish. Example of intended use: https://gist.github.com/jcantrill/fd83c27d3fc542742ec7
> *License and owner:* Apache 2.0 / https://github.com/jayway
> *Original p2 repo:* http://powermock-osgi.googlecode.com/svn/updateSite/1.5.4.1/
> *JBoss mirror:* http://download.jboss.org/jbosstools/updates/requirements/powermock/1.5.4.1/
> *Sources:* https://code.google.com/p/powermock-osgi/ , http://powermock-osgi.googlecode.com/svn/trunk/
> *Affected projects:* OpenShift tests
> *Include in JBDS:* No
> *Type of dependency:* testing
> *List of bundles added/removed:*
> {code}
> + <unit id="org.powermock.mockito-junit.feature.feature.group" version="1.5.4.1"/>
> + <unit id="org.objenesis" version="2.1.0"/>
> + <unit id="javassist" version="3.18.1.GA"/>
> {code}
> *p2diff report:*
> {code}
> mistria@mistria--rh:~/git/jbosstools-target-platforms/jbosstools/multiple$ ~/git/p2diff/org.eclipse.equinox.p2.example.p2diff.packaging/target/products/org.eclipse.equinox.p2.example.p2diff.product/linux/gtk/x86_64/p2diff http://download.jboss.org/jbosstools/targetplatforms/jbosstoolstarget/4.4... file:$(pwd)/target/jbosstools-multiple.target.repo/
> > org.mockito.mockito-core [1.9.5]
> > javassist [3.18.1.GA]
> > org.powermock.powermock-api-support [1.5.4]
> > org.powermock.powermock-reflect [1.5.4]
> > org.powermock.powermock-api-mockito [1.5.4]
> > org.powermock.powermock-module-junit4-common [1.5.4]
> > org.powermock.powermock-module-junit4 [1.5.4]
> > org.powermock.powermock-core [1.5.4]
> > org.objenesis [2.1.0]
> === Summary ===
> file:/home/mistria/git/jbosstools-target-platforms/jbosstools/multiple/target/jbosstools-multiple.target.repo/ contains 9 unique IUs
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 10 months
[JBoss JIRA] (JBIDE-18008) Nested jars prevent SonarQube/FindBugs from running
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18008?page=com.atlassian.jira.plugi... ]
Mickael Istria updated JBIDE-18008:
-----------------------------------
Priority: Minor (was: Major)
> Nested jars prevent SonarQube/FindBugs from running
> ---------------------------------------------------
>
> Key: JBIDE-18008
> URL: https://issues.jboss.org/browse/JBIDE-18008
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: archives
> Reporter: Mickael Istria
> Assignee: Mickael Istria
> Priority: Minor
> Fix For: 4.2.0.CR1
>
>
> Bundle org.jboss.ide.eclipse.archives.core makes SonarQube analysis fail because it's classes get included in some nested jar (and get to different location that target/classes).
> Cf https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/DevStudio/view/DevS...
> {code}
> [ERROR] Failed to execute goal org.codehaus.mojo:sonar-maven-plugin:2.4:sonar (default-cli) on project server.all: Can not execute SonarQube analysis: Can not execute Findbugs: Findbugs needs sources to be compiled. Please build project before executing sonar and check the location of compiled classes. -> [Help 1]
> {code}
> This is an exploded bundles with nested jars, we should investigate whether it's possible to turn it into a more standard jar, which would still be usable in its Ant version. Cf ./archives/tests/org.jboss.ide.eclipse.archives.test/inputs/projects/SimpleAntTest
> Also, the jvmmonitor bundles use nested jars. We should avoid that too.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 10 months
[JBoss JIRA] (JBIDE-12972) Add FestAssert to the TP
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-12972?page=com.atlassian.jira.plugi... ]
Mickael Istria updated JBIDE-12972:
-----------------------------------
Comment: was deleted
(was: Ok, I'll investigate later whether packaging can be improved without risk.)
> Add FestAssert to the TP
> ------------------------
>
> Key: JBIDE-12972
> URL: https://issues.jboss.org/browse/JBIDE-12972
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: target-platform
> Affects Versions: 4.0.0.Beta1
> Reporter: Xavier Coulon
> Assignee: Xavier Coulon
> Fix For: 4.2.x
>
>
> It would be great if we could use in our tests. We would have to add it to our target platform (TP) for our plugins to use it.
> Reason: FestAssert provides us with a Fluent API to write test assertions.
> License and owner: Apache License 2.0 / http://code.google.com/p/fest/
> Original repository: (not an Eclipse bundle yet). Source and binaries available on Maven (https://repository.jboss.org/nexus/content/groups/public/org/easytesting/... and https://repository.jboss.org/nexus/content/groups/public/org/easytesting/...)
> JBoss Mirrored repository: http://downloads.jboss.org/jbosstools/updates/requirements/fest-assert ?
> Source: https://github.com/alexruiz/fest-assert-1.x
> Affected projects: LiveReload for now, JAX-RS in the future
> Required in devstudio: No for now (if LiveReload is considered incubation)
> Type of dependency: testing
> List of bundles added/removed: fest-assert, fest-util
> Fest-assert provides a fluent API to perform asertions in JUnit tests. It is also nice to use when the objects to tests are collections.
> To convince you of the interest of fest-assert, here are a few syntax examples:
> - In LiveReload-test plugin:
> {code}
> assertThat(new String(modifiedContent)).doesNotContain(addition + "</body>");
> {code}
> - a more complete example of usage in openShift-java-client (not an Eclipse plugin, though, but it gives an idea of the chained assertions that can be performed)
> {code}
> assertThat(new GearGroupsAssert(gearGroups))
> .assertGroup(0).hasUUID().hasGears()
> .assertGear(0).hasId().hasState();
> {code}
> - in case of assertion failure on such a statement:
> {code}
> Assertions.assertThat(commands).hasSize(2);
> {code}
> the exception message will look like this:
> {code}
> java.lang.AssertionError: expected size:<2> but was:<1> for <['{"command":"reload","path":null,"liveCSS":true}']>
> at org.fest.assertions.Fail.failure(Fail.java:228)
> at org.fest.assertions.Assert.failure(Assert.java:149)
> at org.fest.assertions.GroupAssert.hasSize(GroupAssert.java:89)
> at org.jboss.tools.livereload.internal.service.LiveReloadCommandGeneratorTestCase.shouldGenerateCommandForIndexHtmlFileAfterSingleChange(LiveReloadCommandGeneratorTestCase.java:45)
> at ...
> {code}
> See more examples here: http://code.google.com/p/fest/#Fluent_Assertions
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 10 months
[JBoss JIRA] (JBIDE-18008) Nested jars prevent SonarQube/FindBugs from running
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18008?page=com.atlassian.jira.plugi... ]
Mickael Istria commented on JBIDE-18008:
----------------------------------------
Ok, I'll investigate later whether packaging can be improved without risk.
> Nested jars prevent SonarQube/FindBugs from running
> ---------------------------------------------------
>
> Key: JBIDE-18008
> URL: https://issues.jboss.org/browse/JBIDE-18008
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: archives
> Reporter: Mickael Istria
> Assignee: Mickael Istria
> Fix For: 4.2.0.CR1
>
>
> Bundle org.jboss.ide.eclipse.archives.core makes SonarQube analysis fail because it's classes get included in some nested jar (and get to different location that target/classes).
> Cf https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/DevStudio/view/DevS...
> {code}
> [ERROR] Failed to execute goal org.codehaus.mojo:sonar-maven-plugin:2.4:sonar (default-cli) on project server.all: Can not execute SonarQube analysis: Can not execute Findbugs: Findbugs needs sources to be compiled. Please build project before executing sonar and check the location of compiled classes. -> [Help 1]
> {code}
> This is an exploded bundles with nested jars, we should investigate whether it's possible to turn it into a more standard jar, which would still be usable in its Ant version. Cf ./archives/tests/org.jboss.ide.eclipse.archives.test/inputs/projects/SimpleAntTest
> Also, the jvmmonitor bundles use nested jars. We should avoid that too.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 10 months