[JBoss JIRA] (JBIDE-18020) For JBIDE 4.2.0.CR1: Ensure copyrights and provider names are correct in all plugins and features [Forge]
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18020?page=com.atlassian.jira.plugi... ]
Nick Boldt updated JBIDE-18020:
-------------------------------
Git Pull Request: https://github.com/jbosstools/jbosstools-forge/commit/83fae7bcc853e9677b7..., https://github.com/jbosstools/jbosstools-forge/commit/709df6db3fdeeb7b546..., https://github.com/jbosstools/jbosstools-forge/commit/01a11c53bcdad503939...
Adding commits to JIRA so we can more easily track what was done and to avoid "reopen for clarification" comments.
> For JBIDE 4.2.0.CR1: Ensure copyrights and provider names are correct in all plugins and features [Forge]
> ---------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-18020
> URL: https://issues.jboss.org/browse/JBIDE-18020
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: forge
> Reporter: Nick Boldt
> Assignee: George Gastaldi
> Priority: Blocker
> Labels: task
> Fix For: 4.2.0.CR1
>
>
> For JBIDE 4.2.0.CR1 [Forge]: Please perform the following *2* tasks:
> 1. Verify that all your plugin and feature copyright dates end in 2014, and that the copyright holder is *{color:red}Red Hat, Inc.{color}* or a variation similar to the examples below.
> Be sure to also include *translated* files, where they exist.
> *java files*
> {code:title=*.java}
> Copyright (c) 2010-2014 Red Hat, Inc. and others.
> {code}
> *html files*
> {code:title=about.html}
> © 2014 Red Hat, Inc. All rights reserved
> {code}
> *properties files*
> {code:title=about.properties}
> Copyright (c) Red Hat, Inc., contributors and others 2004 - 2014. All rights reserved
> {code}
> {code:title=about_fr.properties}
> Copyright (c) Red Hat, Inc., contributors and others 2004 - 2014. Tous droits r\u00E9serv\u00E9s.
> {code}
> {code:title=feature.properties}
> Copyright (c) 2010-2014 Red Hat, Inc. and others.
> {code}
> {code:title=Messages.properties}
> # Copyright (c) 2014 Red Hat, Inc. and others.
> {code}
> *xsd files*
> {code:title=jboss-as-naming_1_3.xsd}
> Copyright 2014, Red Hat, Inc., and individual contributors
> {code}
> 2. Verify that all your plugin and feature provider names are *{color:red}JBoss by Red Hat{color}*.
> Be sure to also include *translated* files, where they exist.
> *This step is particularly important for new plugins and features that have been added recently.*
> Depending on how your plugin is configured you should see something like this in your *plugin.properties* files:
> {code}BundleName = JMX Resources Bundle
> BundleProvider = JBoss by Red Hat{code}
> or
> {code}Bundle-Name.0 = JBossTools Archives Core Plugin
> Bundle-Vendor.0 = JBoss by Red Hat{code}
> Then in your MANIFEST.MF files, you will reference these variables like this.
> *Bundle-Localization* is required or your plugin won't see the values in your *plugin.properties* file!
> {code}Bundle-Localization: plugin
> Bundle-Name: %BundleName
> Bundle-Vendor: %BundleProvider{code}
> or
> {code}Bundle-Localization: plugin
> Bundle-Name: %Bundle-Name.0
> Bundle-Vendor: %Bundle-Vendor.0{code}
> For features, check that your *feature.properties* file contains good values too:
> {code}featureName=JMX Console
> featureProvider=JBoss by Red Hat{code}
> or
> {code}featureName=JBoss Archives Tools
> providerName=JBoss by Red Hat{code}
> Then in your feature.xml files, you will reference these variables like this:
> {code}<feature label="%featureName" provider-name="%featureProvider" ...>{code}
> or
> {code}<feature label="%featureName" provider-name="%providerName" ...>{code}
> 3. If you would like QE to review your changes, please *Resolve* this JIRA when done.
> 4. If you do not require QE to review your changes, please *Close* this JIRA when done.
> 5. If you have any questions, please contact [~nickboldt].
> [Search for all task JIRA|https://issues.jboss.org/issues/?jql=%28%28project+in+%28JBDS%29+and...], or [Search for Forge task JIRA|https://issues.jboss.org/issues/?jql=%28%28project+in+%28JBDS%29+and...]
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 10 months
[JBoss JIRA] (JBIDE-14890) Application wizard: Use EGit recursive merge instead of copying git repository
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-14890?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-14890:
-------------------------------------
Fix Version/s: 4.3.x
(was: 4.2.x)
> Application wizard: Use EGit recursive merge instead of copying git repository
> ------------------------------------------------------------------------------
>
> Key: JBIDE-14890
> URL: https://issues.jboss.org/browse/JBIDE-14890
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.1.0.Beta2, 4.1.1.Final
> Reporter: Andre Dietisheim
> Labels: application_wizard
> Fix For: 4.3.x
>
> Attachments: user-existing-project.png
>
>
> OpenShift tooling is working around missing recursive merge when importing into an existing Project ("use existing")
> !user-existing-project.png!
> When using the git command line one is told to merge by using the recursive merge startegy:
> {code}
> git merge -s recursive -X ours foo
> {code}
> When we created the JBoss Tools for OpenShift there was no recursive merge in EGit/JGit. We therefore worked around it by cloning the OpenShift repository and copying stuff over.
> EGit 3.0 introduced the recursive merge strategy and put it to the default that's being used:
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=380314#c22
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 10 months
[JBoss JIRA] (JBIDE-18046) Application wizard: Label for creating a server adapter is not quite correct
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18046?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-18046 at 8/7/14 7:26 AM:
------------------------------------------------------------------
start, stop etc. are planned to be implemented: JBIDE-11903. They are currently disabled because they're not implemented yet. This is not about a conceptual difference to the other "server adapters"
Yes I guess that we should fix the other naming inconsistencies, rename the OpenShift server to server adapter.
was (Author: adietish):
start, stop etc. are planned to be implemented: JBIDE-11903. They are currently disabled because they're not implemented yet. This is not about a conceptual difference to the other "server adapters"
> Application wizard: Label for creating a server adapter is not quite correct
> ----------------------------------------------------------------------------
>
> Key: JBIDE-18046
> URL: https://issues.jboss.org/browse/JBIDE-18046
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.2.0.Beta3
> Reporter: Marián Labuda
> Assignee: Marián Labuda
> Priority: Minor
> Labels: application_wizard
> Fix For: 4.2.0.CR1
>
> Attachments: create_server_adapter_label.png
>
>
> In a New application wizard on the 3rd wizard page is a check box to create a server adapter for an application. Label next to this check box is "Create and set up a server for easy publishing". I think this is not quite correct and there should be: "Create and set up a server adapter for easy publishing".
> !create_server_adapter_label.png!
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 10 months
[JBoss JIRA] (JBIDE-11903) Explorer: add Application start/stop/restart
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-11903?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-11903:
-------------------------------------
Fix Version/s: 4.3.x
(was: 4.2.x)
> Explorer: add Application start/stop/restart
> ---------------------------------------------
>
> Key: JBIDE-11903
> URL: https://issues.jboss.org/browse/JBIDE-11903
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: openshift
> Affects Versions: 3.3.0.Beta2
> Environment: Eclipse plugin
> Reporter: Nam Duong
> Labels: explorer, new_and_noteworthy
> Fix For: 4.3.x
>
>
> The OpenShift Console view should contain controls for application start|stop|restart to match the functionality of the CLI. Currently, if you select Window->Show View->Others->OpenShift Express Console, then login in and select an application. The right-click menu doesn't have start|stop|restart so users have to either install the rhc client tools or ssh onto the OpenShift host gear.
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 10 months
[JBoss JIRA] (JBIDE-18046) Application wizard: Label for creating a server adapter is not quite correct
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18046?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-18046 at 8/7/14 7:24 AM:
------------------------------------------------------------------
start, stop etc. are planned to be implemented: JBIDE-11903. They are currently disabled because they're not implemented yet. This is not about a conceptual difference to the other "server adapters"
was (Author: adietish):
start, stop etc. are planned to be implemented. They are currently disabled because they're not implemented yet. This is not about a conceptual difference to the other "server adapters"
> Application wizard: Label for creating a server adapter is not quite correct
> ----------------------------------------------------------------------------
>
> Key: JBIDE-18046
> URL: https://issues.jboss.org/browse/JBIDE-18046
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.2.0.Beta3
> Reporter: Marián Labuda
> Assignee: Marián Labuda
> Priority: Minor
> Labels: application_wizard
> Fix For: 4.2.0.CR1
>
> Attachments: create_server_adapter_label.png
>
>
> In a New application wizard on the 3rd wizard page is a check box to create a server adapter for an application. Label next to this check box is "Create and set up a server for easy publishing". I think this is not quite correct and there should be: "Create and set up a server adapter for easy publishing".
> !create_server_adapter_label.png!
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 10 months
[JBoss JIRA] (JBIDE-18046) Application wizard: Label for creating a server adapter is not quite correct
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18046?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-18046:
------------------------------------------
start, stop etc. are planned to be implemented. They are currently disabled because they're not implemented yet. This is not about a conceptual difference to the other "server adapters"
> Application wizard: Label for creating a server adapter is not quite correct
> ----------------------------------------------------------------------------
>
> Key: JBIDE-18046
> URL: https://issues.jboss.org/browse/JBIDE-18046
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.2.0.Beta3
> Reporter: Marián Labuda
> Assignee: Marián Labuda
> Priority: Minor
> Labels: application_wizard
> Fix For: 4.2.0.CR1
>
> Attachments: create_server_adapter_label.png
>
>
> In a New application wizard on the 3rd wizard page is a check box to create a server adapter for an application. Label next to this check box is "Create and set up a server for easy publishing". I think this is not quite correct and there should be: "Create and set up a server adapter for easy publishing".
> !create_server_adapter_label.png!
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 10 months
[JBoss JIRA] (JBIDE-18046) Application wizard: Label for creating a server adapter is not quite correct
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18046?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-18046 at 8/7/14 7:21 AM:
------------------------------------------------------------------
To me there's no issue here:
We usually talk of wtp "Server", not "Server Adapter", right?
the "Servers" view is not "Server Adapters" view
dito in new wizard: "New Server", not "New Server Adapter", and the OpenShift server (adapter) is labelled "OpenShift Server", not "OpenShift Server Adapter"
IMHO we should therefore not use "server adapter" but keep the current labelling "server" in the OpenShift application wizard.
This being said I see that a "Server" is something different than a server adapter to to Eclipse newbie and thus adding "adapter" would help the newbie user.
If we apply this change we should also fix the naming inconsistencies.
was (Author: adietish):
To me there's no issue here:
We usually talk of wtp "Server", not "Server Adapter", right?
the "Servers" view is not "Server Adapters" view
dito in new wizard: "New Server", not "New Server Adapter", and the OpenShift server (adapter) is labelled "OpenShift Server", not "OpenShift Server Adapter"
IMHO we should therefore not use "server adapter" but keep the current labelling "server" in the OpenShift application wizard.
> Application wizard: Label for creating a server adapter is not quite correct
> ----------------------------------------------------------------------------
>
> Key: JBIDE-18046
> URL: https://issues.jboss.org/browse/JBIDE-18046
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.2.0.Beta3
> Reporter: Marián Labuda
> Assignee: Marián Labuda
> Priority: Minor
> Labels: application_wizard
> Fix For: 4.2.0.CR1
>
> Attachments: create_server_adapter_label.png
>
>
> In a New application wizard on the 3rd wizard page is a check box to create a server adapter for an application. Label next to this check box is "Create and set up a server for easy publishing". I think this is not quite correct and there should be: "Create and set up a server adapter for easy publishing".
> !create_server_adapter_label.png!
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 10 months
[JBoss JIRA] (JBIDE-17925) application wizard, embed wizard: content assist fields in "Code Anything" adds invalid/non-used values and seem to retain everything
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-17925?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-17925:
------------------------------------------
if we decide to only store valid URLs we cannot fix B): we only know about the vailidity of the user provided url once the application was created successfully. Creating the application is triggered once the user hits "Finhis" which finally then closes the wizard window.
> application wizard, embed wizard: content assist fields in "Code Anything" adds invalid/non-used values and seem to retain everything
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-17925
> URL: https://issues.jboss.org/browse/JBIDE-17925
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.2.0.Beta3
> Reporter: Max Rydahl Andersen
> Assignee: Andre Dietisheim
> Labels: application_wizard, embed_wizard
> Fix For: 4.2.0.CR1
>
>
> while looking at JBIDE-16904 I found that
> A) all values are stored into content assist history when focus lost - incl. invalid and non valid values
> B) the field does not update its list unless window recreated
> C) the list keeps growing - seem to be no limit. I stopped after reaching 20 values of garbage :)
> I would expect only values that the validator approves to be saved and could even go so far to only store the one that actually gets used on finish.
> All my intermediate typing should not be considered okey for use IMO
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 10 months
[JBoss JIRA] (JBIDE-18046) Application wizard: Label for creating a server adapter is not quite correct
by Marián Labuda (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18046?page=com.atlassian.jira.plugi... ]
Marián Labuda commented on JBIDE-18046:
---------------------------------------
"OpenShift Server" or "OpenShift Server Adapter" is not usual Server. It is really only adapter - you cannot start, stop, restart this server, only OpenShift application (start, stop, restart has been disabled in context menu of OpenShift Server (Adapter)) and it creates a connection between existing application on OpenShift and project in the workspace.
Servers View is correct, because there are servers, but also OpenShift Server Adapter - it does not exclude, I think. Maybe in New - Server we could have instead of "OpenShift Server" label "OpenShift Server Adapter". I don't wanna quibble on this topic, if you feel OK with OpenShift Server everywhere, please revert.
By the way - we are already talking in documentation for a long time about OpenShift Server Adapter, but in IDE we use OpenShift Server - we should probably solve this ambiguity and use one term for it.
[~adietish] WDYT?
> Application wizard: Label for creating a server adapter is not quite correct
> ----------------------------------------------------------------------------
>
> Key: JBIDE-18046
> URL: https://issues.jboss.org/browse/JBIDE-18046
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.2.0.Beta3
> Reporter: Marián Labuda
> Assignee: Marián Labuda
> Priority: Minor
> Labels: application_wizard
> Fix For: 4.2.0.CR1
>
> Attachments: create_server_adapter_label.png
>
>
> In a New application wizard on the 3rd wizard page is a check box to create a server adapter for an application. Label next to this check box is "Create and set up a server for easy publishing". I think this is not quite correct and there should be: "Create and set up a server adapter for easy publishing".
> !create_server_adapter_label.png!
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 10 months
[JBoss JIRA] (JBIDE-17925) application wizard, embed wizard: content assist fields in "Code Anything" adds invalid/non-used values and seem to retain everything
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-17925?page=com.atlassian.jira.plugi... ]
Andre Dietisheim reassigned JBIDE-17925:
----------------------------------------
Assignee: Andre Dietisheim
> application wizard, embed wizard: content assist fields in "Code Anything" adds invalid/non-used values and seem to retain everything
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-17925
> URL: https://issues.jboss.org/browse/JBIDE-17925
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.2.0.Beta3
> Reporter: Max Rydahl Andersen
> Assignee: Andre Dietisheim
> Labels: application_wizard, embed_wizard
> Fix For: 4.2.0.CR1
>
>
> while looking at JBIDE-16904 I found that
> A) all values are stored into content assist history when focus lost - incl. invalid and non valid values
> B) the field does not update its list unless window recreated
> C) the list keeps growing - seem to be no limit. I stopped after reaching 20 values of garbage :)
> I would expect only values that the validator approves to be saved and could even go so far to only store the one that actually gets used on finish.
> All my intermediate typing should not be considered okey for use IMO
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 10 months