[JBoss JIRA] (JBIDE-18047) Browsersim: View Source does not display <html> and </html>
by Konstantin Marmalyukov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18047?page=com.atlassian.jira.plugi... ]
Konstantin Marmalyukov updated JBIDE-18047:
-------------------------------------------
Steps to Reproduce:
1. Open Brosersim
1a. Ensure JavaFx engine is selected
2. Open a webpage, e.g. www.github.com
3. In the context menu, select View source
4. See that the opened source does not have <html>
was:
1. Open Brosersim
2. Open a webpage, e.g. www.github.com
3. In the context menu, select View source
4. See that the opened source does not have <html>
> Browsersim: View Source does not display <html> and </html>
> -----------------------------------------------------------
>
> Key: JBIDE-18047
> URL: https://issues.jboss.org/browse/JBIDE-18047
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: browsersim
> Affects Versions: 4.2.0.CR1
> Reporter: Martin Malina
> Assignee: Konstantin Marmalyukov
> Fix For: 4.2.0.CR1
>
> Attachments: Screenshot 2014-08-06 09.21.52.png
>
>
> When you open a page (e.g. gmail.com or www.github.com) in Browsersim and then try to view the source, it will show most of it, but <html> tag is missing. The doctype seems incomplete, too:
> {code}
> <!DOCTYPE html>
> {code}
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 8 months
[JBoss JIRA] (JBIDE-18047) Browsersim: View Source does not display <html> and </html>
by Martin Malina (JIRA)
Martin Malina created JBIDE-18047:
-------------------------------------
Summary: Browsersim: View Source does not display <html> and </html>
Key: JBIDE-18047
URL: https://issues.jboss.org/browse/JBIDE-18047
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: browsersim
Affects Versions: 4.2.0.CR1
Reporter: Martin Malina
Fix For: 4.2.0.CR1
Attachments: Screenshot 2014-08-06 09.21.52.png
When you open a page (e.g. gmail.com or www.github.com) in Browsersim and then try to view the source, it will show most of it, but <html> tag is missing. The doctype seems incomplete, too:
{code}
<!DOCTYPE html>
{code}
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 8 months
[JBoss JIRA] (JBIDE-17524) BrowserSim: not all source is shown for external URL
by Ilya Buziuk (JIRA)
[ https://issues.jboss.org/browse/JBIDE-17524?page=com.atlassian.jira.plugi... ]
Ilya Buziuk commented on JBIDE-17524:
-------------------------------------
[~mmalina], Sorry for being misleading
{quote}
I see exactly the same as in the screenshot on this page. Could not open the Visual Page Editor: External file cannot be shown in Visual Editor.
{quote}
This is expected behavior, cause preview can't handle external files. It will be fixed in 17818. For now we will show the error message (see [~kmarmaliykov] comment with steps to verify). So I guess everything works fine. I was mainly interested in NPE, which was found by Rastislav
{quote}
And the source tab shows more or less the whole page, but there is no <html> and </html>.
{quote}
This is definitely a bug. Working on it right now
{quote}
(As suggested, I also checked that the configuration is saved correctly in configuration/org.jboss.tools.vpe.browsersim subdirectory of my JBoss Tools installation dir.)
{quote}
Cool ;-)
> BrowserSim: not all source is shown for external URL
> ----------------------------------------------------
>
> Key: JBIDE-17524
> URL: https://issues.jboss.org/browse/JBIDE-17524
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: browsersim
> Affects Versions: 4.2.0.Beta1
> Reporter: Konstantin Marmalyukov
> Assignee: Konstantin Marmalyukov
> Fix For: 4.2.0.CR1
>
> Attachments: Screenshot 2014-07-24 16.32.11.png
>
>
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 8 months
[JBoss JIRA] (JBIDE-17524) BrowserSim: not all source is shown for external URL
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-17524?page=com.atlassian.jira.plugi... ]
Martin Malina edited comment on JBIDE-17524 at 8/6/14 2:56 AM:
---------------------------------------------------------------
[~ibuziuk], I tried this in the latest nightly (from August 5) and I see exactly the same as in the screenshot on this page:
Could not open the Visual Page Editor:
External file cannot be shown in Visual Editor.
org.jboss.tools.vpe.preview.core.exceptions.CannotOpenExternalFileException: External file cannot be shown in Visual Editor.
And the source tab shows more or less the whole page, but there is no <html> and </html>.
(As suggested, I also checked that the configuration is saved correctly in configuration/org.jboss.tools.vpe.browsersim subdirectory of my JBoss Tools installation dir.)
was (Author: mmalina):
[~ibuziuk], I tried this in the latest nightly (from August 5) and I see exactly the same as in the screenshot on this page:
Could not open the Visual Page Editor:
External file cannot be shown in Visual Editor.
org.jboss.tools.vpe.preview.core.exceptions.CannotOpenExternalFileException: External file cannot be shown in Visual Editor.
And the source tab shows more or less the whole page, but there is no <html> and </html>.
> BrowserSim: not all source is shown for external URL
> ----------------------------------------------------
>
> Key: JBIDE-17524
> URL: https://issues.jboss.org/browse/JBIDE-17524
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: browsersim
> Affects Versions: 4.2.0.Beta1
> Reporter: Konstantin Marmalyukov
> Assignee: Konstantin Marmalyukov
> Fix For: 4.2.0.CR1
>
> Attachments: Screenshot 2014-07-24 16.32.11.png
>
>
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 8 months
[JBoss JIRA] (JBIDE-17423) BrowserSim is not opening source code of opened web page
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-17423?page=com.atlassian.jira.plugi... ]
Martin Malina commented on JBIDE-17423:
---------------------------------------
I checked this in the nightly and this particular issue is fixed I believe - the source code is opened. But it's still not 100% correct as reported in JBIDE-17524 which I reopened.
> BrowserSim is not opening source code of opened web page
> --------------------------------------------------------
>
> Key: JBIDE-17423
> URL: https://issues.jboss.org/browse/JBIDE-17423
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: browsersim
> Affects Versions: 4.2.0.Beta2
> Environment: JBDS 8.0.0.Beta2-v20140525-2146-B104
> Reporter: Vlado Pakan
> Assignee: Konstantin Marmalyukov
> Priority: Blocker
> Fix For: 4.2.0.CR1
>
>
> 1. Open BrowserSim
> 2. Open page www.github.com in BrowserSim
> 3. Choose View Page Source from BrowserSim context menu
> ERROR: No source code displayed in JBDS just error message in VPE and Error Log view
> {noformat}
> java.lang.ClassCastException: org.jboss.tools.vpe.browsersim.eclipse.callbacks.StringInput cannot be cast to org.eclipse.ui.IFileEditorInput
> at org.jboss.tools.vpe.preview.editor.VpeEditorPartFactory.createVisualEditor(VpeEditorPartFactory.java:35)
> at org.jboss.tools.jst.web.ui.internal.editor.jspeditor.JSPMultiPageEditor.createPagesForVPE(JSPMultiPageEditor.java:589)
> at org.jboss.tools.jst.web.ui.internal.editor.jspeditor.JSPMultiPageEditor.createPages(JSPMultiPageEditor.java:506)
> at org.eclipse.ui.part.MultiPageEditorPart.createPartControl(MultiPageEditorPart.java:362)
> at org.eclipse.ui.internal.e4.compatibility.CompatibilityPart.createPartControl(CompatibilityPart.java:140)
> at org.eclipse.ui.internal.e4.compatibility.CompatibilityEditor.createPartControl(CompatibilityEditor.java:99)
> at org.eclipse.ui.internal.e4.compatibility.CompatibilityPart.create(CompatibilityPart.java:321)
> at sun.reflect.GeneratedMethodAccessor143.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:55)
> at org.eclipse.e4.core.internal.di.InjectorImpl.processAnnotated(InjectorImpl.java:888)
> at org.eclipse.e4.core.internal.di.InjectorImpl.processAnnotated(InjectorImpl.java:869)
> at org.eclipse.e4.core.internal.di.InjectorImpl.inject(InjectorImpl.java:120)
> at org.eclipse.e4.core.internal.di.InjectorImpl.internalMake(InjectorImpl.java:337)
> at org.eclipse.e4.core.internal.di.InjectorImpl.make(InjectorImpl.java:258)
> at org.eclipse.e4.core.contexts.ContextInjectionFactory.make(ContextInjectionFactory.java:162)
> at org.eclipse.e4.ui.internal.workbench.ReflectionContributionFactory.createFromBundle(ReflectionContributionFactory.java:104)
> at org.eclipse.e4.ui.internal.workbench.ReflectionContributionFactory.doCreate(ReflectionContributionFactory.java:73)
> at org.eclipse.e4.ui.internal.workbench.ReflectionContributionFactory.create(ReflectionContributionFactory.java:55)
> at org.eclipse.e4.ui.workbench.renderers.swt.ContributedPartRenderer.createWidget(ContributedPartRenderer.java:127)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.createWidget(PartRenderingEngine.java:984)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.safeCreateGui(PartRenderingEngine.java:663)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.safeCreateGui(PartRenderingEngine.java:767)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.access$2(PartRenderingEngine.java:738)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$7.run(PartRenderingEngine.java:732)
> at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.createGui(PartRenderingEngine.java:716)
> at org.eclipse.e4.ui.workbench.renderers.swt.StackRenderer.showTab(StackRenderer.java:1250)
> at org.eclipse.e4.ui.workbench.renderers.swt.LazyStackRenderer$1.handleEvent(LazyStackRenderer.java:66)
> at org.eclipse.e4.ui.services.internal.events.UIEventHandler$1.run(UIEventHandler.java:40)
> at org.eclipse.swt.widgets.Synchronizer.syncExec(Synchronizer.java:187)
> at org.eclipse.ui.internal.UISynchronizer.syncExec(UISynchronizer.java:156)
> at org.eclipse.swt.widgets.Display.syncExec(Display.java:4598)
> at org.eclipse.e4.ui.internal.workbench.swt.E4Application$1.syncExec(E4Application.java:207)
> at org.eclipse.e4.ui.services.internal.events.UIEventHandler.handleEvent(UIEventHandler.java:36)
> at org.eclipse.equinox.internal.event.EventHandlerWrapper.handleEvent(EventHandlerWrapper.java:197)
> at org.eclipse.equinox.internal.event.EventHandlerTracker.dispatchEvent(EventHandlerTracker.java:197)
> at org.eclipse.equinox.internal.event.EventHandlerTracker.dispatchEvent(EventHandlerTracker.java:1)
> at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
> at org.eclipse.osgi.framework.eventmgr.ListenerQueue.dispatchEventSynchronous(ListenerQueue.java:148)
> at org.eclipse.equinox.internal.event.EventAdminImpl.dispatchEvent(EventAdminImpl.java:135)
> at org.eclipse.equinox.internal.event.EventAdminImpl.sendEvent(EventAdminImpl.java:78)
> at org.eclipse.equinox.internal.event.EventComponent.sendEvent(EventComponent.java:39)
> at org.eclipse.e4.ui.services.internal.events.EventBroker.send(EventBroker.java:81)
> at org.eclipse.e4.ui.internal.workbench.UIEventPublisher.notifyChanged(UIEventPublisher.java:59)
> at org.eclipse.emf.common.notify.impl.BasicNotifierImpl.eNotify(BasicNotifierImpl.java:374)
> at org.eclipse.e4.ui.model.application.ui.impl.ElementContainerImpl.setSelectedElement(ElementContainerImpl.java:171)
> at org.eclipse.e4.ui.internal.workbench.ModelServiceImpl.showElementInWindow(ModelServiceImpl.java:479)
> at org.eclipse.e4.ui.internal.workbench.ModelServiceImpl.bringToTop(ModelServiceImpl.java:445)
> at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.delegateBringToTop(PartServiceImpl.java:692)
> at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.showPart(PartServiceImpl.java:1123)
> at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditor(WorkbenchPage.java:3127)
> at org.eclipse.ui.internal.WorkbenchPage.access$23(WorkbenchPage.java:3049)
> at org.eclipse.ui.internal.WorkbenchPage$9.run(WorkbenchPage.java:3031)
> at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
> at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:3026)
> at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2990)
> at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2971)
> at org.jboss.tools.vpe.browsersim.eclipse.callbacks.ViewSourceCallback.openInMemoryHtmlEditor(ViewSourceCallback.java:100)
> at org.jboss.tools.vpe.browsersim.eclipse.callbacks.ViewSourceCallback.access$0(ViewSourceCallback.java:83)
> at org.jboss.tools.vpe.browsersim.eclipse.callbacks.ViewSourceCallback$1.run(ViewSourceCallback.java:75)
> at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
> at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:136)
> at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3781)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3419)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1152)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1033)
> at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:148)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:635)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:578)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:135)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:379)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:233)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:648)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:603)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1465)
> at org.eclipse.equinox.launcher.Main.main(Main.java:1438)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 8 months
[JBoss JIRA] (JBIDE-18046) Application wizard: Label for creating a server adapter is not quite correct
by Marián Labuda (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18046?page=com.atlassian.jira.plugi... ]
Marián Labuda commented on JBIDE-18046:
---------------------------------------
[~adietish] please review PR.
> Application wizard: Label for creating a server adapter is not quite correct
> ----------------------------------------------------------------------------
>
> Key: JBIDE-18046
> URL: https://issues.jboss.org/browse/JBIDE-18046
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.2.0.Beta3
> Reporter: Marián Labuda
> Assignee: Marián Labuda
> Priority: Minor
> Labels: application_wizard
> Fix For: 4.2.0.CR1
>
> Attachments: create_server_adapter_label.png
>
>
> In a New application wizard on the 3rd wizard page is a check box to create a server adapter for an application. Label next to this check box is "Create and set up a server for easy publishing". I think this is not quite correct and there should be: "Create and set up a server adapter for easy publishing".
> !create_server_adapter_label.png!
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 8 months
[JBoss JIRA] (JBIDE-18046) Application wizard: Label for creating a server adapter is not quite correct
by Marián Labuda (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18046?page=com.atlassian.jira.plugi... ]
Marián Labuda updated JBIDE-18046:
----------------------------------
Fix Version/s: 4.2.0.CR1
> Application wizard: Label for creating a server adapter is not quite correct
> ----------------------------------------------------------------------------
>
> Key: JBIDE-18046
> URL: https://issues.jboss.org/browse/JBIDE-18046
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.2.0.Beta3
> Reporter: Marián Labuda
> Assignee: Marián Labuda
> Priority: Minor
> Labels: application_wizard
> Fix For: 4.2.0.CR1
>
> Attachments: create_server_adapter_label.png
>
>
> In a New application wizard on the 3rd wizard page is a check box to create a server adapter for an application. Label next to this check box is "Create and set up a server for easy publishing". I think this is not quite correct and there should be: "Create and set up a server adapter for easy publishing".
> !create_server_adapter_label.png!
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 8 months