[JBoss JIRA] (JBIDE-18995) Early Access features can be installed from JBoss Tools p2 repository even if 'Enable Early Access' is disabled in Central
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18995?page=com.atlassian.jira.plugi... ]
Mickael Istria commented on JBIDE-18995:
----------------------------------------
I better understand your initial question.
I believe you're right, it's a good idea to make the earlyaccess listing part of the earlyaccess site. The coupling between both seems strong, as we'll often need to update them together and we'll always want to publish them together.
+1 for your suggestion.
> Early Access features can be installed from JBoss Tools p2 repository even if 'Enable Early Access' is disabled in Central
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-18995
> URL: https://issues.jboss.org/browse/JBIDE-18995
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: updatesite
> Affects Versions: 4.2.1.Final
> Reporter: Denis Golovin
> Assignee: Nick Boldt
> Priority: Minor
> Fix For: 4.2.1.Final
>
> Attachments: ea-disabled.png, ea-installed.png
>
>
> I noticed central has "(Early Access Installed)" sign in after I installed everything from JBos Tools stable p2 repository.
> !ea-installed.png!
> "Enable Early Access" checkbox is not set by default in Central Editor
> !ea-disabled.png!
> This means I bypassed warning dialog in this scenario.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months
[JBoss JIRA] (JBIDE-18678) Make dependencies to org.jboss.tools.usage optional
by Alexey Kazakov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18678?page=com.atlassian.jira.plugi... ]
Alexey Kazakov commented on JBIDE-18678:
----------------------------------------
I added one more commit to the [~kaloyan-raev]'s one with updated usage feature.xml - https://github.com/jbosstools/jbosstools-base/pull/365
And if we want to enable JBT usage automaticly when installing some feature (e.g. browsersim) then we have to include the usage feature (which includes both usage api and impl plugins) as required in the feature.xml: https://github.com/jbosstools/jbosstools-browsersim/pull/50
We have to update every JBoss Tools (and integration stack plugins too) feature.xml if we think that this approach is good.
How it's supposed to work:
1. Install browsersim feature (it will trigger usage feature installation).
2. As result both usage plugins (api + impl) are available and usage is enabled.
If some third party product doesn't want to enable usage, then it should not to include browsersim feature. It's OK to include/depend on browsersim plugins or/and create a new feature for browsersim plugins but w/o usage dependency in the feature.xml. In this case the usage api plugin will be available (not the impl one) and usage will be disabled.
[~kaloyan-raev] does it work for you?
[~maxandersen] is it acceptable approach? WDYT?
> Make dependencies to org.jboss.tools.usage optional
> ---------------------------------------------------
>
> Key: JBIDE-18678
> URL: https://issues.jboss.org/browse/JBIDE-18678
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: browsersim, usage
> Affects Versions: 4.2.0.CR1
> Reporter: Kaloyan Raev
> Assignee: Alexey Kazakov
> Fix For: 4.3.x
>
>
> I am interested in adopting the CordovaSim feature in our product. However, most of the browsersim bundles have a strong dependency to org.jboss.tools.usage bundle, which force a Usage Reporting popup on startup. I want to avoid this and have the org.jboss.tools.usage excluded from my build.
> Is it possible to make the dependencies to org.jboss.tools.usage optional?
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months
[JBoss JIRA] (JBIDE-18998) Floating 'Welcome to JBoss' title in Central
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18998?page=com.atlassian.jira.plugi... ]
Denis Golovin commented on JBIDE-18998:
---------------------------------------
Here is stacktrace:
{code}"main" prio=10 tid=0x00007f3c9800a800 nid=0x776e runnable [0x00007f3ca0fa6000]
java.lang.Thread.State: RUNNABLE
at org.eclipse.swt.internal.gtk.OS._pango_context_get_metrics(Native Method)
at org.eclipse.swt.internal.gtk.OS.pango_context_get_metrics(OS.java:15746)
at org.eclipse.swt.widgets.Label.computeSize(Label.java:185)
at org.eclipse.swt.layout.GridData.computeSize(GridData.java:491)
at org.eclipse.swt.layout.GridLayout.layout(GridLayout.java:221)
at org.eclipse.swt.layout.GridLayout.computeSize(GridLayout.java:164)
at org.eclipse.swt.widgets.Composite.computeSize(Composite.java:239)
at org.eclipse.swt.layout.GridData.computeSize(GridData.java:491)
at org.eclipse.swt.layout.GridLayout.layout(GridLayout.java:221)
at org.eclipse.swt.layout.GridLayout.computeSize(GridLayout.java:164)
at org.eclipse.swt.widgets.Composite.computeSize(Composite.java:239)
at org.eclipse.swt.custom.ScrolledCompositeLayout.computeSize(ScrolledCompositeLayout.java:33)
at org.eclipse.swt.widgets.Composite.computeSize(Composite.java:239)
at org.eclipse.swt.layout.GridData.computeSize(GridData.java:491)
at org.eclipse.swt.layout.GridLayout.layout(GridLayout.java:221)
at org.eclipse.swt.layout.GridLayout.computeSize(GridLayout.java:164)
at org.eclipse.swt.widgets.Composite.computeSize(Composite.java:239)
at org.eclipse.swt.layout.GridData.computeSize(GridData.java:491)
at org.eclipse.swt.layout.GridLayout.layout(GridLayout.java:221)
at org.eclipse.swt.layout.GridLayout.computeSize(GridLayout.java:164)
at org.eclipse.swt.widgets.Composite.computeSize(Composite.java:239)
at org.eclipse.ui.part.PageBook$PageBookLayout.computeSize(PageBook.java:51)
at org.eclipse.swt.widgets.Composite.computeSize(Composite.java:239)
at org.eclipse.swt.layout.GridData.computeSize(GridData.java:491)
at org.eclipse.swt.layout.GridLayout.layout(GridLayout.java:221)
at org.eclipse.swt.layout.GridLayout.layout(GridLayout.java:197)
at org.eclipse.swt.widgets.Composite.updateLayout(Composite.java:1644)
at org.eclipse.swt.widgets.Composite.layout(Composite.java:996)
at org.eclipse.swt.widgets.Composite.layout(Composite.java:954)
at org.eclipse.ui.forms.widgets.SizeCache.layoutIfNecessary(SizeCache.java:526)
at org.eclipse.ui.forms.widgets.SizeCache.setBounds(SizeCache.java:512)
at org.eclipse.ui.forms.widgets.ExpandableComposite$ExpandableLayout.layout(ExpandableComposite.java:389)
at org.eclipse.swt.widgets.Composite.updateLayout(Composite.java:1644)
at org.eclipse.swt.widgets.Composite.updateLayout(Composite.java:1650)
at org.eclipse.swt.widgets.Composite.updateLayout(Composite.java:1650)
at org.eclipse.swt.widgets.Composite.updateLayout(Composite.java:1650)
at org.eclipse.swt.widgets.Composite.updateLayout(Composite.java:1650)
at org.eclipse.swt.widgets.Composite.updateLayout(Composite.java:1650)
at org.eclipse.swt.widgets.Composite.updateLayout(Composite.java:1650)
at org.eclipse.swt.widgets.Composite.updateLayout(Composite.java:1650)
at org.eclipse.swt.widgets.Composite.updateLayout(Composite.java:1650)
at org.eclipse.swt.widgets.Composite.updateLayout(Composite.java:1650)
at org.eclipse.swt.widgets.Composite.updateLayout(Composite.java:1650)
at org.eclipse.swt.widgets.Composite.updateLayout(Composite.java:1650)
at org.eclipse.swt.widgets.Composite.updateLayout(Composite.java:1650)
at org.eclipse.swt.widgets.Composite.layout(Composite.java:996)
at org.jboss.tools.central.editors.GettingStartedPage.refreshSharedArea(GettingStartedPage.java:1169)
at org.jboss.tools.central.editors.GettingStartedPage.access$19(GettingStartedPage.java:1159)
at org.jboss.tools.central.editors.GettingStartedPage$16.mouseExit(GettingStartedPage.java:1153)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:204)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4454)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1388)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3799)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3409)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1151)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1032)
at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:148)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:636)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:579)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:135)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:648)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:603)
at org.eclipse.equinox.launcher.Main.run(Main.java:1465)
at org.eclipse.equinox.launcher.Main.main(Main.java:1438)
{code}
> Floating 'Welcome to JBoss' title in Central
> --------------------------------------------
>
> Key: JBIDE-18998
> URL: https://issues.jboss.org/browse/JBIDE-18998
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: central
> Affects Versions: 4.2.1.Final
> Environment: Linux x86_64
> SWT_GTK3=1
> OpenJDK 7
> Reporter: Denis Golovin
> Attachments: jumping-weclome.ogg
>
>
> See attached screen recording in [^jumping-weclome.ogg]
> "Welcome to JBoss" title moves down and right when mouse is moving over "JBoss Buzz" section.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months
[JBoss JIRA] (JBDS-3289) JBoss Central proxy wizards need to recognize early access.
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBDS-3289?page=com.atlassian.jira.plugin.... ]
Denis Golovin commented on JBDS-3289:
-------------------------------------
This approach should work and code in PR looks good to me, but that is going to force us to revise proxy wizards every time some features are graduated from EA to remove dependent proxyWizard from earlyaccess category.
BTW Currently 'Enable Early Access' check is available only for Software/Update tab, so it is not really legit to say it should also affect 'Get Started' tab. If 'Eanble Early Acces' is going to affect both tabs it should be always visible no matter waht tab is active as it is done for 'Show on Startup'.
> JBoss Central proxy wizards need to recognize early access.
> -----------------------------------------------------------
>
> Key: JBDS-3289
> URL: https://issues.jboss.org/browse/JBDS-3289
> Project: Developer Studio (JBoss Developer Studio)
> Issue Type: Bug
> Components: central
> Affects Versions: 8.0.2.GA
> Reporter: Paul Leacu
> Assignee: Fred Bricon
> Priority: Blocker
> Fix For: 8.0.2.GA
>
> Attachments: ea1.png
>
>
> Using a JBoss Central proxy wizard that references an early access feature will install that feature correctly even if the "Early Access Enabled" checkbox is unchecked.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months
[JBoss JIRA] (JBDS-3303) [unit test] versionwatch should not fail silently when the report is empty
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBDS-3303?page=com.atlassian.jira.plugin.... ]
Nick Boldt edited comment on JBDS-3303 at 1/7/15 6:18 PM:
----------------------------------------------------------
This PR does a few things:
a) adds support for filtering which versions to compare (eg., to exclude diffing a JBDS 8 build against a future JBDS 9 build when we just want versionwatch for JBDS 8.0.x)
b) provides a shell script wrapper for the versionwatch tool, to replace the mix of maven and shell (which was why we were getting empty reports - maven vars wer being passed in incorrectly)
c) shell script also now includes a couple unit tests on the results.
Unit tests currently include:
{code}
1. `egrep -l "<td>|<tr>"` -- empty report
1. `egrep -l "ERROR` -- report with errors
{code}
https://github.com/jbdevstudio/jbdevstudio-qa/pull/30
was (Author: nickboldt):
This PR does a few things:
a) adds support for filtering which versions to compare (eg., to exclude diffing a JBDS 8 build against a future JBDS 9 build when we just want versionwatch for JBDS 8.0.x)
b) provides a shell script wrapper for the versionwatch tool, to replace the mix of maven and shell (which was why we were getting empty reports - maven vars wer being passed in incorrectly)
c) shell script also now includes a couple unit tests on the results.
Unit tests currently include:
{code}
1. `egrep -l "<td>|<tr>"` -- empty report
1. 1egrep -l "ERROR` -- report with errors
{code}
https://github.com/jbdevstudio/jbdevstudio-qa/pull/30
[~psrna], please review.
> [unit test] versionwatch should not fail silently when the report is empty
> --------------------------------------------------------------------------
>
> Key: JBDS-3303
> URL: https://issues.jboss.org/browse/JBDS-3303
> Project: Developer Studio (JBoss Developer Studio)
> Issue Type: Bug
> Components: build
> Affects Versions: 8.0.1.GA
> Reporter: Nick Boldt
> Assignee: Nick Boldt
>
> versionwatch should not fail silently when the report is empty, such as:
> {code}
> JBDS Version Watch
> Feature list for filter = .*(hibernate\|jboss\|xulrunner).*
> Plugin list for filter = .*(hibernate\|jboss\|xulrunner).*
> Generated by VersionWatch 0.3.0 in 0 min, 4 sec at 2014-12-14 20:19:34.853.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months
[JBoss JIRA] (JBDS-3304) [unit test] versionwatch should run against latest builds, not hardcoded older Betas
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBDS-3304?page=com.atlassian.jira.plugin.... ]
Nick Boldt closed JBDS-3304.
----------------------------
Fix Version/s: 9.0.0.Alpha1
8.0.1.GA
Resolution: Done
Fixed in Jenkins. See also https://github.com/jbdevstudio/jbdevstudio-qa/pull/30 in JBDS-3303 for more enhancements & even some unit testing of the resulting reports/artifacts (cc: [~maxandersen] ).
> [unit test] versionwatch should run against latest builds, not hardcoded older Betas
> ------------------------------------------------------------------------------------
>
> Key: JBDS-3304
> URL: https://issues.jboss.org/browse/JBDS-3304
> Project: Developer Studio (JBoss Developer Studio)
> Issue Type: Bug
> Components: build
> Affects Versions: 8.0.1.GA
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 9.0.0.Alpha1, 8.0.1.GA
>
>
> versionwatch should run against latest builds, not hardcoded older Betas.
> Need a way to pull the latest builds from /staging/ so that instead of testing hardcoded Beta2 builds we use the latest.
> This might have broken as a result of a bug in install.jbds.sh - I thought this used to work:
> {code}
> ++ TMPDIR=/tmp
> /mnt/hudson_workspace/workspace/devstudio.versionwatch_8.0.luna/sources/vwatch/install.jbds.sh: command substitution: line 151: unexpected EOF while looking for matching `"'
> /mnt/hudson_workspace/workspace/devstudio.versionwatch_8.0.luna/sources/vwatch/install.jbds.sh: command substitution: line 152: syntax error: unexpected end of file
> {code}
> Either way, we need a better unit test here to ensure that the versions diffed are NOT just the list of hardcoded ones, but instead include the hardcoded list + at least one more (latest build).
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months
[JBoss JIRA] (JBDS-3303) [unit test] versionwatch should not fail silently when the report is empty
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBDS-3303?page=com.atlassian.jira.plugin.... ]
Nick Boldt edited comment on JBDS-3303 at 1/7/15 5:43 PM:
----------------------------------------------------------
This PR does a few things:
a) adds support for filtering which versions to compare (eg., to exclude diffing a JBDS 8 build against a future JBDS 9 build when we just want versionwatch for JBDS 8.0.x)
b) provides a shell script wrapper for the versionwatch tool, to replace the mix of maven and shell (which was why we were getting empty reports - maven vars wer being passed in incorrectly)
c) shell script also now includes a couple unit tests on the results.
Unit tests currently include:
{code}
1. `egrep -l "<td>|<tr>"` -- empty report
1. 1egrep -l "ERROR` -- report with errors
{code}
https://github.com/jbdevstudio/jbdevstudio-qa/pull/30
[~psrna], please review.
was (Author: nickboldt):
PR to support filtering which versions to compare (eg., to exclude diffing a JBDS 8 build against a future JBDS 9 build when we just want versionwatch for JBDS 8.0.x), and to better run the versionwatch tool (via shell script in Jenkins, instead of a mix of maven and shell) so we can perform unit testing on the results. Unit tests currently include:
{code}
egrep -l "<td>|<tr>" -- empty report
egrep -l "ERROR -- report with errors
{code}
https://github.com/jbdevstudio/jbdevstudio-qa/pull/30
[~psrna], please review.
> [unit test] versionwatch should not fail silently when the report is empty
> --------------------------------------------------------------------------
>
> Key: JBDS-3303
> URL: https://issues.jboss.org/browse/JBDS-3303
> Project: Developer Studio (JBoss Developer Studio)
> Issue Type: Bug
> Components: build
> Affects Versions: 8.0.1.GA
> Reporter: Nick Boldt
> Assignee: Nick Boldt
>
> versionwatch should not fail silently when the report is empty, such as:
> {code}
> JBDS Version Watch
> Feature list for filter = .*(hibernate\|jboss\|xulrunner).*
> Plugin list for filter = .*(hibernate\|jboss\|xulrunner).*
> Generated by VersionWatch 0.3.0 in 0 min, 4 sec at 2014-12-14 20:19:34.853.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months
[JBoss JIRA] (JBDS-3303) [unit test] versionwatch should not fail silently when the report is empty
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBDS-3303?page=com.atlassian.jira.plugin.... ]
Nick Boldt commented on JBDS-3303:
----------------------------------
PR to support filtering which versions to compare (eg., to exclude diffing a JBDS 8 build against a future JBDS 9 build when we just want versionwatch for JBDS 8.0.x), and to better run the versionwatch tool (via shell script in Jenkins, instead of a mix of maven and shell) so we can perform unit testing on the results. Unit tests currently include:
{code}
egrep -l "<td>|<tr>" -- empty report
egrep -l "ERROR -- report with errors
{code}
https://github.com/jbdevstudio/jbdevstudio-qa/pull/30
[~psrna], please review.
> [unit test] versionwatch should not fail silently when the report is empty
> --------------------------------------------------------------------------
>
> Key: JBDS-3303
> URL: https://issues.jboss.org/browse/JBDS-3303
> Project: Developer Studio (JBoss Developer Studio)
> Issue Type: Bug
> Components: build
> Affects Versions: 8.0.1.GA
> Reporter: Nick Boldt
> Assignee: Nick Boldt
>
> versionwatch should not fail silently when the report is empty, such as:
> {code}
> JBDS Version Watch
> Feature list for filter = .*(hibernate\|jboss\|xulrunner).*
> Plugin list for filter = .*(hibernate\|jboss\|xulrunner).*
> Generated by VersionWatch 0.3.0 in 0 min, 4 sec at 2014-12-14 20:19:34.853.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months
[JBoss JIRA] (JBIDE-18995) Early Access features can be installed from JBoss Tools p2 repository even if 'Enable Early Access' is disabled in Central
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18995?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-18995:
------------------------------------
{quote} shouldn't depend on this files from the discovery plugins, and should instead depend on the ones on download.jboss.org.{quote}
Yes, we agree here.
But I was asking if we ought to include this file inside the early access site (rather than the discovery plugin), since otherwise it needs to be manually created for each staged build. If it's simply part of the EA site, then when we stage the site, the file's already on the server. And when we're ready to move from staging to development, there's no manual step in copying content in the file; rather, we just move the whole EA site and voila, published.
If we treat this as an artifact independent of the EA site, then maybe it should live in http://download.jboss.org/jbosstools/configuration/ ?
> Early Access features can be installed from JBoss Tools p2 repository even if 'Enable Early Access' is disabled in Central
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-18995
> URL: https://issues.jboss.org/browse/JBIDE-18995
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: updatesite
> Affects Versions: 4.2.1.Final
> Reporter: Denis Golovin
> Assignee: Nick Boldt
> Priority: Minor
> Fix For: 4.2.1.Final
>
> Attachments: ea-disabled.png, ea-installed.png
>
>
> I noticed central has "(Early Access Installed)" sign in after I installed everything from JBos Tools stable p2 repository.
> !ea-installed.png!
> "Enable Early Access" checkbox is not set by default in Central Editor
> !ea-disabled.png!
> This means I bypassed warning dialog in this scenario.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months