[JBoss JIRA] (JBIDE-21113) Incorrect JSF Phase Listener Warning
by Cody Lerum (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21113?page=com.atlassian.jira.plugi... ]
Cody Lerum updated JBIDE-21113:
-------------------------------
Description:
When adding a JSF phase listener to faces-config.xml
{code}
<lifecycle>
<phase-listener>com.demo.web.jsf.JsfCdiPhaseListener</phase-listener>
</lifecycle>
{code}
You are presented a warning that {{phase-listener references to "com.demo.web.jsf.JsfCdiPhaseListener" that does not extend javax.faces.event.PhaseListener}}
In reality you cannot extend javax.faces.event.PhaseListener you must implement it. So this check should be looking for implements rather than extends. See http://balusc.omnifaces.org/2006/09/debug-jsf-lifecycle.html
In java 8 at least you get a compiler error if you try and extend avax.faces.event.PhaseListener.
The type PhaseListener cannot be the superclass of JsfCdiPhaseListener; a superclass must be a class
was:
When adding a JSF phase listener to faces-config.xml
{code}
<lifecycle>
<phase-listener>com.demo.web.jsf.JsfCdiPhaseListener</phase-listener>
</lifecycle>
{code}
You are presented a warning that {{phase-listener references to "com.demo.web.jsf.JsfCdiPhaseListener" that does not extend javax.faces.event.PhaseListener}}
In reality you cannot extend javax.faces.event.PhaseListener you must implement it. So this check should be looking for implements rather than extends. See http://balusc.omnifaces.org/2006/09/debug-jsf-lifecycle.html
> Incorrect JSF Phase Listener Warning
> ------------------------------------
>
> Key: JBIDE-21113
> URL: https://issues.jboss.org/browse/JBIDE-21113
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: jsf
> Affects Versions: 4.3.0.Final
> Environment: Mars.1
> Java 8
> Reporter: Cody Lerum
>
> When adding a JSF phase listener to faces-config.xml
> {code}
> <lifecycle>
> <phase-listener>com.demo.web.jsf.JsfCdiPhaseListener</phase-listener>
> </lifecycle>
> {code}
> You are presented a warning that {{phase-listener references to "com.demo.web.jsf.JsfCdiPhaseListener" that does not extend javax.faces.event.PhaseListener}}
> In reality you cannot extend javax.faces.event.PhaseListener you must implement it. So this check should be looking for implements rather than extends. See http://balusc.omnifaces.org/2006/09/debug-jsf-lifecycle.html
> In java 8 at least you get a compiler error if you try and extend avax.faces.event.PhaseListener.
> The type PhaseListener cannot be the superclass of JsfCdiPhaseListener; a superclass must be a class
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21109) [application wizard] 2 connections from same server but for different users result in project mismatch
by Fred Bricon (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21109?page=com.atlassian.jira.plugi... ]
Fred Bricon resolved JBIDE-21109.
---------------------------------
Resolution: Done
Labels: application_wizard upstream (was: application_wizard)
Upstream fix has been applied. It fixes the problem in Eclipse.
> [application wizard] 2 connections from same server but for different users result in project mismatch
> ------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-21109
> URL: https://issues.jboss.org/browse/JBIDE-21109
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: openshift
> Reporter: Fred Bricon
> Assignee: Fred Bricon
> Labels: application_wizard, upstream
> Fix For: 4.3.1.Beta1, 4.4.0.Alpha1
>
>
> In JBT, connecting 2 users on the same server, results in wrong projects being shown for the 2nd connection (in the new application wizard).
> This is caused by calling Connection.ownResource(project), having
> {code}
> public boolean ownsResource(IResource resource) {
> if (resource == null) {
> return false;
> }
> IClient client = resource.accept(new CapabilityVisitor<IClientCapability, IClient>() {
> @Override
> public IClient visit(IClientCapability capability) {
> return capability.getClient();
> }
> }, null);
> return ObjectUtils.equals(this.client, client);
> }
> {code}
> The problem is the clients are equals for both connections. A check for token equality should be performed to distinguish them
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21109) [application wizard] 2 connections from same server but for different users result in project mismatch
by Fred Bricon (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21109?page=com.atlassian.jira.plugi... ]
Fred Bricon reassigned JBIDE-21109:
-----------------------------------
Assignee: Fred Bricon
> [application wizard] 2 connections from same server but for different users result in project mismatch
> ------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-21109
> URL: https://issues.jboss.org/browse/JBIDE-21109
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: openshift
> Reporter: Fred Bricon
> Assignee: Fred Bricon
> Labels: application_wizard
> Fix For: 4.3.1.Beta1, 4.4.0.Alpha1
>
>
> In JBT, connecting 2 users on the same server, results in wrong projects being shown for the 2nd connection (in the new application wizard).
> This is caused by calling Connection.ownResource(project), having
> {code}
> public boolean ownsResource(IResource resource) {
> if (resource == null) {
> return false;
> }
> IClient client = resource.accept(new CapabilityVisitor<IClientCapability, IClient>() {
> @Override
> public IClient visit(IClientCapability capability) {
> return capability.getClient();
> }
> }, null);
> return ObjectUtils.equals(this.client, client);
> }
> {code}
> The problem is the clients are equals for both connections. A check for token equality should be performed to distinguish them
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21113) Incorrect JSF Phase Listener Warning
by Cody Lerum (JIRA)
Cody Lerum created JBIDE-21113:
----------------------------------
Summary: Incorrect JSF Phase Listener Warning
Key: JBIDE-21113
URL: https://issues.jboss.org/browse/JBIDE-21113
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: jsf
Affects Versions: 4.3.0.Final
Environment: Mars.1
Java 8
Reporter: Cody Lerum
When adding a JSF phase listener to faces-config.xml
{code}
<lifecycle>
<phase-listener>com.demo.web.jsf.JsfCdiPhaseListener</phase-listener>
</lifecycle>
{code}
You are presented a warning that {{phase-listener references to "com.demo.web.jsf.JsfCdiPhaseListener" that does not extend javax.faces.event.PhaseListener}}
In reality you cannot extend javax.faces.event.PhaseListener you must implement it. So this check should be looking for implements rather than extends. See http://balusc.omnifaces.org/2006/09/debug-jsf-lifecycle.html
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21072) Application wizard: Server templates tree is not rendered
by Snjezana Peco (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21072?page=com.atlassian.jira.plugi... ]
Snjezana Peco commented on JBIDE-21072:
---------------------------------------
{quote}
I assume that the similarity is in the stacked panels being used in both cases (afaik the editor-pane is using a CTabFolder while we're using a TabFolder) which I assume use a native way to stack composites?
{quote}
All widgets in GTK3 are transparent, so that the "visible widget" term doesn't make sense.
In my opinion that is the reason why a layout can be different depending on whether a component is visible or not.
There are bugs similar to this: https://bugs.eclipse.org/bugs/show_bug.cgi?id=465056, https://issues.jboss.org/browse/JBIDE-16503 ...
> Application wizard: Server templates tree is not rendered
> ---------------------------------------------------------
>
> Key: JBIDE-21072
> URL: https://issues.jboss.org/browse/JBIDE-21072
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift, upstream
> Affects Versions: 4.3.1.Beta1
> Reporter: Marián Labuda
> Assignee: Andre Dietisheim
> Labels: application_wizard, openshift_v3, upstream
> Fix For: 4.3.1.Beta1
>
> Attachments: wizard.png
>
>
> When I select at first a local template then proceed to next wizard page in a New OpenShift Application wizard and hit back button then tree containing server templates is not rendered correctly. Only search text field is shown but the tree with templates is missing there.
> !wizard.png!
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months