[JBoss JIRA] (JBIDE-21084) Connection/application wizard: reconnects if you get back and forth to the connection page
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21084?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-21084:
-------------------------------------
Description:
What makes this necessary is the internal behaviour of the connection page being used when application- or import-wizard are launched from central or file-menu. It there is a delegating wizard page which invokes either v2 or v3 wizard based on the server type that the user is choosing. Behind the scenes I see the conn wizard connecting several times when launched from central/file-menu. The delegating wizard page needs to connect in the WizardPage#getNextPage(), a method that is also used in PageChangingListener(s) which it's using to determine the page change direction (forward or backward).
how to reproduce:
# EXEC: launch application wizard
# ASSERT: connection page shows up
# EXEC: select an existing or create a new connection
# EXEC: get to the next page
# EXEC: get back to the connection page and hit "Next" again
Result:
You see the progress bar coming up and getting to the 2nd page again after some delay caused by the the wizard re-connecting.
was:
how to reproduce:
# EXEC: launch application wizard
# ASSERT: connection page shows up
# EXEC: select an existing or create a new connection
# EXEC: get to the next page
# EXEC: get back to the connection page and hit "Next" again
Result:
You see the progress bar coming up and getting to the 2nd page again after some delay caused by the the wizard re-connecting.
> Connection/application wizard: reconnects if you get back and forth to the connection page
> ------------------------------------------------------------------------------------------
>
> Key: JBIDE-21084
> URL: https://issues.jboss.org/browse/JBIDE-21084
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.0.Beta1
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Fix For: 4.3.1.Beta1
>
>
> What makes this necessary is the internal behaviour of the connection page being used when application- or import-wizard are launched from central or file-menu. It there is a delegating wizard page which invokes either v2 or v3 wizard based on the server type that the user is choosing. Behind the scenes I see the conn wizard connecting several times when launched from central/file-menu. The delegating wizard page needs to connect in the WizardPage#getNextPage(), a method that is also used in PageChangingListener(s) which it's using to determine the page change direction (forward or backward).
> how to reproduce:
> # EXEC: launch application wizard
> # ASSERT: connection page shows up
> # EXEC: select an existing or create a new connection
> # EXEC: get to the next page
> # EXEC: get back to the connection page and hit "Next" again
> Result:
> You see the progress bar coming up and getting to the 2nd page again after some delay caused by the the wizard re-connecting.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months
[JBoss JIRA] (JBIDE-21084) Connection/application wizard: reconnects if you get back and forth to the connection page
by Andre Dietisheim (JIRA)
Andre Dietisheim created JBIDE-21084:
----------------------------------------
Summary: Connection/application wizard: reconnects if you get back and forth to the connection page
Key: JBIDE-21084
URL: https://issues.jboss.org/browse/JBIDE-21084
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: openshift
Affects Versions: 4.3.0.Beta1
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 4.3.1.Beta1
how to reproduce:
# EXEC: launch application wizard
# ASSERT: connection page shows up
# EXEC: select an existing or create a new connection
# EXEC: get to the next page
# EXEC: get back to the connection page and hit "Next" again
Result:
You see the progress bar coming up and getting to the 2nd page again after some delay caused by the the wizard re-connecting.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months
[JBoss JIRA] (JBIDE-20969) NPE in BatchHyperlinkDetector.getBatchProject when Ctrl+Hover links in external files
by Lucia Jelinkova (JIRA)
[ https://issues.jboss.org/browse/JBIDE-20969?page=com.atlassian.jira.plugi... ]
Lucia Jelinkova closed JBIDE-20969.
-----------------------------------
Verified JBT 4.3.1 nightly
> NPE in BatchHyperlinkDetector.getBatchProject when Ctrl+Hover links in external files
> -------------------------------------------------------------------------------------
>
> Key: JBIDE-20969
> URL: https://issues.jboss.org/browse/JBIDE-20969
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: batch
> Affects Versions: 4.3.0.Final
> Reporter: Fred Bricon
> Assignee: Daniel Azarov
> Fix For: 4.3.1.Beta1
>
> Attachments: broken-hyperlink.xml
>
>
> If you open an external file via the File > Open File... menu, then Ctrl+Hover links in that file, BatchHyperlinkDetector.getBatchProject throws an NPE, shown in Eclipse's log
> {noformat}
> ava.lang.NullPointerException
> at org.jboss.tools.batch.ui.hyperlink.BatchHyperlinkDetector.getBatchProject(BatchHyperlinkDetector.java:140)
> at org.jboss.tools.batch.ui.hyperlink.BatchHyperlinkDetector.detectHyperlinks(BatchHyperlinkDetector.java:43)
> at org.eclipse.ui.texteditor.HyperlinkDetectorRegistry$HyperlinkDetectorDelegate.detectHyperlinks(HyperlinkDetectorRegistry.java:80)
> at org.eclipse.jface.text.hyperlink.HyperlinkManager.findHyperlinks(HyperlinkManager.java:289)
> at org.eclipse.jface.text.hyperlink.HyperlinkManager.findHyperlinks(HyperlinkManager.java:261)
> at org.eclipse.jface.text.hyperlink.HyperlinkManager.mouseMove(HyperlinkManager.java:469)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:212)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4230)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1491)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1514)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1499)
> at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1299)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4072)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3698)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1127)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1018)
> at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:156)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:654)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:598)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:139)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:669)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:608)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1515)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months
[JBoss JIRA] (JBIDE-19846) Remove generated files after user decides to delete imported unuseful root
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19846?page=com.atlassian.jira.plugi... ]
Mickael Istria closed JBIDE-19846.
----------------------------------
Resolution: Out of Date
> Remove generated files after user decides to delete imported unuseful root
> --------------------------------------------------------------------------
>
> Key: JBIDE-19846
> URL: https://issues.jboss.org/browse/JBIDE-19846
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: easymport
> Affects Versions: 4.3.0.Beta1
> Reporter: Lucia Jelinkova
> Assignee: Mickael Istria
> Priority: Minor
> Fix For: 4.3.1.Beta1
>
>
> When user selects folder root that contains no real data (e.g. workspace root) importer asks if he wants to delete the project after import. However, even if the project is deleted from workspace, the generated files (e.g .settings, .project) still remain on the filesystem. These should be deleted as they are clearly not needed nor desired.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months
[JBoss JIRA] (JBIDE-19846) Remove generated files after user decides to delete imported unuseful root
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19846?page=com.atlassian.jira.plugi... ]
Mickael Istria commented on JBIDE-19846:
----------------------------------------
Right, I agree that giving user ability to select what to include makes this issue out of date.
> Remove generated files after user decides to delete imported unuseful root
> --------------------------------------------------------------------------
>
> Key: JBIDE-19846
> URL: https://issues.jboss.org/browse/JBIDE-19846
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: easymport
> Affects Versions: 4.3.0.Beta1
> Reporter: Lucia Jelinkova
> Assignee: Mickael Istria
> Priority: Minor
> Fix For: 4.3.1.Beta1
>
>
> When user selects folder root that contains no real data (e.g. workspace root) importer asks if he wants to delete the project after import. However, even if the project is deleted from workspace, the generated files (e.g .settings, .project) still remain on the filesystem. These should be deleted as they are clearly not needed nor desired.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months
[JBoss JIRA] (JBIDE-19846) Remove generated files after user decides to delete imported unuseful root
by Lucia Jelinkova (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19846?page=com.atlassian.jira.plugi... ]
Lucia Jelinkova commented on JBIDE-19846:
-----------------------------------------
I tried the new version and it seems there is no check if the folder is workspace root any more. I don't really care since you're now able to select folders you want to import but I just wanna check this is intended.
If this is the case we should mark the Jira as outdated instead of resolving it.
> Remove generated files after user decides to delete imported unuseful root
> --------------------------------------------------------------------------
>
> Key: JBIDE-19846
> URL: https://issues.jboss.org/browse/JBIDE-19846
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: easymport
> Affects Versions: 4.3.0.Beta1
> Reporter: Lucia Jelinkova
> Assignee: Mickael Istria
> Priority: Minor
> Fix For: 4.3.1.Beta1
>
>
> When user selects folder root that contains no real data (e.g. workspace root) importer asks if he wants to delete the project after import. However, even if the project is deleted from workspace, the generated files (e.g .settings, .project) still remain on the filesystem. These should be deleted as they are clearly not needed nor desired.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months
[JBoss JIRA] (JBIDE-21079) Importing OpenShift 3 application via shell menu shows empty build configs table
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21079?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-21079:
------------------------------------------
I can unfortuantely reproduce this. Investigating...
> Importing OpenShift 3 application via shell menu shows empty build configs table
> --------------------------------------------------------------------------------
>
> Key: JBIDE-21079
> URL: https://issues.jboss.org/browse/JBIDE-21079
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Marián Labuda
> Assignee: Andre Dietisheim
> Priority: Critical
> Fix For: 4.3.1.Beta1
>
>
> Table in Import OpenShift Application wizard is empty when trying to import an OpenShift application via shell menu File - Import - Existing OpenShift Application. It is necessary to hit Refresh button to get any build config to the table and making it possible to import an application.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 5 months