[JBoss JIRA] (JBIDE-20847) Only "retrieve" and "sign up here" link inside styled text should be accessible
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-20847?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich updated JBIDE-20847:
------------------------------------------
Description:
In New Connection dialog are 2 styled texts with links.
First one is for OpenShift 2 server selection on top saying "If you do not have an account on OpenShift, please +sign up here+."
Second one is for OpenShift 3 while OAuth authentication protocol is selected "Enter a token or +retrieve+ a new one."
Issue is that both are clickable whole, not just the underlined parts.
Issue is also differences while mouse cursor is moving over them. Second one, about a token, has hand cursor while mouse is over the text. First one has typical cursor for text. The cursor could be:
- for clickable part hand cursor
- for nonclickable part arrow cursor
Example of nice working text with link is link for OpenShift 3 server on top of wizard "New to OpenShift 3? Explore the +getting started documentation+." (Since JBIDE-20849 this link works as the two above.)
was:
In New Connection dialog are 2 styled texts with links.
First one is for OpenShift 2 server selection on top saying "If you do not have an account on OpenShift, please +sign up here+."
Second one is for OpenShift 3 while OAuth authentication protocol is selected "Enter a token or +retrieve+ a new one."
Issue is that both are clickable whole, not just the underlined parts.
Issue is also differences while mouse cursor is moving over them. Second one, about a token, has hand cursor while mouse is over the text. First one has typical cursor for text. The cursor could be:
- for clickable part hand cursor
- for nonclickable part arrow cursor
Example of nice working text with link is link for OpenShift 3 server on top of wizard "New to OpenShift 3? Explore the +getting started documentation+."
> Only "retrieve" and "sign up here" link inside styled text should be accessible
> -------------------------------------------------------------------------------
>
> Key: JBIDE-20847
> URL: https://issues.jboss.org/browse/JBIDE-20847
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.0.CR2
> Reporter: Marián Labuda
> Labels: connection_wizard
> Fix For: 4.3.1.Beta2
>
>
> In New Connection dialog are 2 styled texts with links.
> First one is for OpenShift 2 server selection on top saying "If you do not have an account on OpenShift, please +sign up here+."
> Second one is for OpenShift 3 while OAuth authentication protocol is selected "Enter a token or +retrieve+ a new one."
> Issue is that both are clickable whole, not just the underlined parts.
> Issue is also differences while mouse cursor is moving over them. Second one, about a token, has hand cursor while mouse is over the text. First one has typical cursor for text. The cursor could be:
> - for clickable part hand cursor
> - for nonclickable part arrow cursor
> Example of nice working text with link is link for OpenShift 3 server on top of wizard "New to OpenShift 3? Explore the +getting started documentation+." (Since JBIDE-20849 this link works as the two above.)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 3 months
[JBoss JIRA] (JBIDE-21379) Enhance emulated link
by Marián Labuda (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21379?page=com.atlassian.jira.plugi... ]
Marián Labuda commented on JBIDE-21379:
---------------------------------------
This is a duplicate of JBIDE-20847.
> Enhance emulated link
> ---------------------
>
> Key: JBIDE-21379
> URL: https://issues.jboss.org/browse/JBIDE-21379
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.4.0.Alpha1
> Reporter: Viacheslav Kabanovich
> Assignee: Viacheslav Kabanovich
> Fix For: 4.4.0.Alpha1
>
>
> Emulated link in 'Sign in to Openshift' wizard 'Deploy Image to OpenShift', etc has several drawbacks:
> 1. It shows hand cursor at the entire text, not only the one styled as link.
> 2. It acts on mouse down, whereas commonly links act on mouse up.
> 3. It acts on clicking at any place in the text, not only the one styled as link.
> 4. If mouse remains down, action is called repeatedly.
> I suggest the enhancement, [~fbricon], please take a look at it. It should be taken into account, that the emulation itself exists because of failure of standard Link on Mac, so that my suggestion should be tested on Mac.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 3 months
[JBoss JIRA] (JBIDE-21171) Need to remove bower / npm from jboss.tools.jsdt
by Ilya Buziuk (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21171?page=com.atlassian.jira.plugi... ]
Ilya Buziuk commented on JBIDE-21171:
-------------------------------------
[~nickboldt], I guess nothing stops us from applying those PRs. So, for now we just removing all stuff and TP update for M4 consumption will be done as a separate issue
> Need to remove bower / npm from jboss.tools.jsdt
> ------------------------------------------------
>
> Key: JBIDE-21171
> URL: https://issues.jboss.org/browse/JBIDE-21171
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: build, nodejs
> Affects Versions: 4.3.0.Final
> Reporter: Ilya Buziuk
> Assignee: Ilya Buziuk
> Labels: new_and_noteworthy
> Fix For: 4.4.0.Alpha1
>
>
> Assuming that bower / npm were moved to eclipse jsdt - https://git.eclipse.org/r/#/c/61336/
> Need to perform a cleanup in jboss.tools.jst.jsdt repo and remove related plugins / tests / features
> Bower is in eclipse upstream and we probably will need reflect it in new & noteworthy
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 3 months
[JBoss JIRA] (JBIDE-21165) Need to improve js tools (npm / bower) launch
by Ilya Buziuk (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21165?page=com.atlassian.jira.plugi... ]
Ilya Buziuk resolved JBIDE-21165.
---------------------------------
Resolution: Done
> Need to improve js tools (npm / bower) launch
> ----------------------------------------------
>
> Key: JBIDE-21165
> URL: https://issues.jboss.org/browse/JBIDE-21165
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: nodejs
> Reporter: Ilya Buziuk
> Assignee: Ilya Buziuk
> Fix For: 4.4.0.Alpha1
>
>
> For now npm / bower is launched via node. Basically, this was done due to the fact that on Mac Os launched from desktop node PATH var not available:
> {quote}
> env: node: No such file or directory
> {quote}
> In order to handle it, it was suggested to launch npm / bower tools via node and have a preference for each tool. However, on thym project more elegant solution was found - execute the given command and returns a handle to the process.
> More details can be found here:
> - https://github.com/gorkem/thym/blob/use_cli/plugins/org.eclipse.thym.core...
> - https://github.com/gorkem/thym/blob/use_cli/plugins/org.eclipse.thym.core...
> Basically, this approach kills two birds with one stone:
> 1. No mac os Path issue
> 2. No need to have preferences for node / npm / bower
> Also, it will be quite easy to provide cheatsheets for this tools which will include sets of commands
> The plan is:
> - reimplement the launch process that will be generic for both jsdt and thym (maybe some other tools in future)
> - remove irrelevant code with preferences, detectors etc
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 3 months
[JBoss JIRA] (JBIDE-21380) EL syntax error: String is not closed.
by Andrei Ivanov (JIRA)
Andrei Ivanov created JBIDE-21380:
-------------------------------------
Summary: EL syntax error: String is not closed.
Key: JBIDE-21380
URL: https://issues.jboss.org/browse/JBIDE-21380
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 4.3.x
Environment: Eclipse Mars.1 (4.5.1)
Reporter: Andrei Ivanov
Priority: Minor
I get a {{EL syntax error: String is not closed.}} warning when an expression is composed using string concatenation:
{code:java}
String expression = "#{" + entry.getValue() + "}";
{code}
\\
\\
A different issue I think might be that when enabling the JSF support for the web module, the JBoss Tools Knowledge Support is enabled for the other modules too, including the data module.
This leads to {{EL syntax error: Expecting expression.}} for a JPA query with Spring EL expressions:
{code:java}
import org.springframework.data.jpa.repository.Query;
import org.springframework.data.repository.PagingAndSortingRepository;
public interface FunctionsRepository extends PagingAndSortingRepository<Function, Integer> {
@Query("SELECT DISTINCT r.workCenter.function"
+ " FROM StaffingAgreementDataRecord r"
+ " WHERE r.staffingAgreement.customer.id IN :customerIds"
+ " AND r.staffingAgreement.startDate <= :#{#interval.end}"
+ " AND r.staffingAgreement.endDate >= :#{#interval.start}")
List<Function> findByCustomersAndInterval(List<Integer> customerIds, Interval interval);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 3 months
[JBoss JIRA] (JBIDE-21380) EL syntax error: String is not closed with string concatenation
by Andrei Ivanov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21380?page=com.atlassian.jira.plugi... ]
Andrei Ivanov updated JBIDE-21380:
----------------------------------
Summary: EL syntax error: String is not closed with string concatenation (was: EL syntax error: String is not closed.)
> EL syntax error: String is not closed with string concatenation
> ---------------------------------------------------------------
>
> Key: JBIDE-21380
> URL: https://issues.jboss.org/browse/JBIDE-21380
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Affects Versions: 4.3.x
> Environment: Eclipse Mars.1 (4.5.1)
> Reporter: Andrei Ivanov
> Priority: Minor
>
> I get a {{EL syntax error: String is not closed.}} warning when an expression is composed using string concatenation:
> {code:java}
> String expression = "#{" + entry.getValue() + "}";
> {code}
> \\
> \\
> A different issue I think might be that when enabling the JSF support for the web module, the JBoss Tools Knowledge Support is enabled for the other modules too, including the data module.
> This leads to {{EL syntax error: Expecting expression.}} for a JPA query with Spring EL expressions:
> {code:java}
> import org.springframework.data.jpa.repository.Query;
> import org.springframework.data.repository.PagingAndSortingRepository;
> public interface FunctionsRepository extends PagingAndSortingRepository<Function, Integer> {
> @Query("SELECT DISTINCT r.workCenter.function"
> + " FROM StaffingAgreementDataRecord r"
> + " WHERE r.staffingAgreement.customer.id IN :customerIds"
> + " AND r.staffingAgreement.startDate <= :#{#interval.end}"
> + " AND r.staffingAgreement.endDate >= :#{#interval.start}")
> List<Function> findByCustomersAndInterval(List<Integer> customerIds, Interval interval);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 3 months
[JBoss JIRA] (JBIDE-21316) Creating artifact for non-batch project results in NPE
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21316?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich updated JBIDE-21316:
------------------------------------------
Fix Version/s: 4.4.0.Alpha1
> Creating artifact for non-batch project results in NPE
> ------------------------------------------------------
>
> Key: JBIDE-21316
> URL: https://issues.jboss.org/browse/JBIDE-21316
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: batch
> Affects Versions: 4.3.1.Beta1
> Reporter: Rastislav Wagner
> Assignee: Viacheslav Kabanovich
> Fix For: 4.3.1.Beta2, 4.4.0.Alpha1
>
>
> {code}
> java.lang.NullPointerException
> at org.jboss.tools.batch.internal.core.impl.PreferredPackageManager.savePreferredPackage(PreferredPackageManager.java:95)
> at org.jboss.tools.batch.ui.internal.wizard.NewBatchArtifactWizard.performFinish(NewBatchArtifactWizard.java:116)
> at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:799)
> at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:429)
> at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:619)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4481)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1329)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3819)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3430)
> at org.eclipse.jface.window.Window.runEventLoop(Window.java:827)
> at org.eclipse.jface.window.Window.open(Window.java:803)
> at org.eclipse.ui.internal.handlers.WizardHandler$New.executeHandler(WizardHandler.java:269)
> at org.eclipse.ui.internal.handlers.WizardHandler.execute(WizardHandler.java:290)
> at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:295)
> at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:56)
> at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:252)
> at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:234)
> at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
> at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:152)
> at org.eclipse.core.commands.Command.executeWithChecks(Command.java:493)
> at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:486)
> at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:210)
> at org.eclipse.ui.internal.handlers.LegacyHandlerService.executeCommand(LegacyHandlerService.java:343)
> at org.eclipse.ui.internal.actions.CommandAction.runWithEvent(CommandAction.java:160)
> at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:595)
> at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:511)
> at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:420)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4481)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1329)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3819)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3430)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1127)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1018)
> at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:156)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:654)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:598)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:139)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:669)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:608)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1515)
> at org.eclipse.equinox.launcher.Main.main(Main.java:1488)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 3 months
[JBoss JIRA] (JBIDE-21379) Enhance emulated link
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21379?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich updated JBIDE-21379:
------------------------------------------
Description:
Emulated link in 'Sign in to Openshift' wizard 'Deploy Image to OpenShift', etc has several drawbacks:
1. It shows hand cursor at the entire text, not only the one styled as link.
2. It acts on mouse down, whereas commonly links act on mouse up.
3. It acts on clicking at any place in the text, not only the one styled as link.
4. If mouse remains down, action is called repeatedly.
I suggest the enhancement, [~fbricon], please take a look at it. It should be taken into account, that the emulation itself exists because of failure of standard Link on Mac, so that my suggestion should be tested on Mac.
was:
Emulated link in 'Sign in to Openshift' wizard 'Deploy Image to OpenShift', etc has several drawbacks:
1. It shows hand cursor at the entire text, not only the one styled as link.
2. It acts on mouse down, whereas commonly links act on mouse up.
3. If mouse remains down, action is called repeatedly.
I suggest the enhancement, [~fbricon], please take a look at it. It should be taken into account, that the emulation itself exists because of failure of standard Link on Mac, so that my suggestion should be tested on Mac.
> Enhance emulated link
> ---------------------
>
> Key: JBIDE-21379
> URL: https://issues.jboss.org/browse/JBIDE-21379
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.4.0.Alpha1
> Reporter: Viacheslav Kabanovich
> Assignee: Viacheslav Kabanovich
> Fix For: 4.4.0.Alpha1
>
>
> Emulated link in 'Sign in to Openshift' wizard 'Deploy Image to OpenShift', etc has several drawbacks:
> 1. It shows hand cursor at the entire text, not only the one styled as link.
> 2. It acts on mouse down, whereas commonly links act on mouse up.
> 3. It acts on clicking at any place in the text, not only the one styled as link.
> 4. If mouse remains down, action is called repeatedly.
> I suggest the enhancement, [~fbricon], please take a look at it. It should be taken into account, that the emulation itself exists because of failure of standard Link on Mac, so that my suggestion should be tested on Mac.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 3 months