[JBoss JIRA] (JBIDE-21218) Allow a user to add environment variables in deploy image wizard
by Marián Labuda (JIRA)
Marián Labuda created JBIDE-21218:
-------------------------------------
Summary: Allow a user to add environment variables in deploy image wizard
Key: JBIDE-21218
URL: https://issues.jboss.org/browse/JBIDE-21218
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: openshift
Affects Versions: 4.3.0.CR1
Reporter: Jeff Cantrill
Assignee: Jeff Cantrill
Fix For: 4.3.1.Beta1
Allow a user to add and remove(the ones they added) environment variables to their deployment. We should consider also refactoring the env section of the deployment config to only declare modified values since the non-modified once are set to the same as what is expressed by the image.
* Also only remove those which were added
* Only reset those which are defaults
* Edit via double click
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21217) Unhandled loop event exception is thrown if local template file path contains invalid value
by Marián Labuda (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21217?page=com.atlassian.jira.plugi... ]
Marián Labuda resolved JBIDE-21217.
-----------------------------------
Resolution: Done
> Unhandled loop event exception is thrown if local template file path contains invalid value
> -------------------------------------------------------------------------------------------
>
> Key: JBIDE-21217
> URL: https://issues.jboss.org/browse/JBIDE-21217
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Marián Labuda
> Assignee: Fred Bricon
> Labels: application_wizard, openshift_v3
> Fix For: 4.4.0.Alpha1
>
>
> In New OpenShift Application wizard while Local template tab is selected on first wizard page and if in text widget for a file is invalid value, click on a File system... button throws following exception and nothing happens:
> {code}
> java.lang.NullPointerException
> at org.jboss.tools.openshift.internal.ui.wizard.newapp.TemplateListPage$14.createFileDialog(TemplateListPage.java:712)
> at org.jboss.tools.openshift.internal.ui.wizard.newapp.TemplateListPage$14.widgetSelected(TemplateListPage.java:702)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4481)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1329)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3819)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3430)
> at org.eclipse.jface.window.Window.runEventLoop(Window.java:827)
> at org.eclipse.jface.window.Window.open(Window.java:803)
> at org.jboss.tools.common.ui.WizardUtils.openWizardDialog(WizardUtils.java:279)
> at org.jboss.tools.common.ui.WizardUtils.openWizardDialog(WizardUtils.java:270)
> at org.jboss.tools.openshift.internal.ui.handler.NewApplicationHandler.execute(NewApplicationHandler.java:37)
> at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:295)
> at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:56)
> at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:252)
> at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:234)
> at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
> at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:152)
> at org.eclipse.core.commands.Command.executeWithChecks(Command.java:493)
> at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:486)
> at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:210)
> at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.executeItem(HandledContributionItem.java:799)
> at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.handleWidgetSelection(HandledContributionItem.java:675)
> at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.access$7(HandledContributionItem.java:659)
> at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem$4.handleEvent(HandledContributionItem.java:592)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4481)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1329)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3819)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3430)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1127)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1018)
> at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:156)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:654)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:598)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:139)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:669)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:608)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1515)
> at org.eclipse.equinox.launcher.Main.main(Main.java:1488)
> {code}
> I expect value should be ignored and file browser dialog should be opened to allow user choose template.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21217) Unhandled loop event exception is thrown if local template file path contains invalid value
by Marián Labuda (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21217?page=com.atlassian.jira.plugi... ]
Marián Labuda updated JBIDE-21217:
----------------------------------
Fix Version/s: 4.4.0.Alpha1
(was: 4.3.1.Beta1)
> Unhandled loop event exception is thrown if local template file path contains invalid value
> -------------------------------------------------------------------------------------------
>
> Key: JBIDE-21217
> URL: https://issues.jboss.org/browse/JBIDE-21217
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Marián Labuda
> Assignee: Fred Bricon
> Labels: application_wizard, openshift_v3
> Fix For: 4.4.0.Alpha1
>
>
> In New OpenShift Application wizard while Local template tab is selected on first wizard page and if in text widget for a file is invalid value, click on a File system... button throws following exception and nothing happens:
> {code}
> java.lang.NullPointerException
> at org.jboss.tools.openshift.internal.ui.wizard.newapp.TemplateListPage$14.createFileDialog(TemplateListPage.java:712)
> at org.jboss.tools.openshift.internal.ui.wizard.newapp.TemplateListPage$14.widgetSelected(TemplateListPage.java:702)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4481)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1329)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3819)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3430)
> at org.eclipse.jface.window.Window.runEventLoop(Window.java:827)
> at org.eclipse.jface.window.Window.open(Window.java:803)
> at org.jboss.tools.common.ui.WizardUtils.openWizardDialog(WizardUtils.java:279)
> at org.jboss.tools.common.ui.WizardUtils.openWizardDialog(WizardUtils.java:270)
> at org.jboss.tools.openshift.internal.ui.handler.NewApplicationHandler.execute(NewApplicationHandler.java:37)
> at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:295)
> at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:56)
> at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:252)
> at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:234)
> at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
> at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:152)
> at org.eclipse.core.commands.Command.executeWithChecks(Command.java:493)
> at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:486)
> at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:210)
> at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.executeItem(HandledContributionItem.java:799)
> at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.handleWidgetSelection(HandledContributionItem.java:675)
> at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.access$7(HandledContributionItem.java:659)
> at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem$4.handleEvent(HandledContributionItem.java:592)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4481)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1329)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3819)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3430)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1127)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1018)
> at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:156)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:654)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:598)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:139)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:669)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:608)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1515)
> at org.eclipse.equinox.launcher.Main.main(Main.java:1488)
> {code}
> I expect value should be ignored and file browser dialog should be opened to allow user choose template.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21217) Unhandled loop event exception is thrown if local template file path contains invalid value
by Marián Labuda (JIRA)
Marián Labuda created JBIDE-21217:
-------------------------------------
Summary: Unhandled loop event exception is thrown if local template file path contains invalid value
Key: JBIDE-21217
URL: https://issues.jboss.org/browse/JBIDE-21217
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 4.3.1.Beta1
Reporter: Marián Labuda
Assignee: Fred Bricon
Fix For: 4.3.1.Beta1
In New OpenShift Application wizard while Local template tab is selected on first wizard page and if in text widget for a file is invalid value, click on a File system... button throws following exception and nothing happens:
{code}
java.lang.NullPointerException
at org.jboss.tools.openshift.internal.ui.wizard.newapp.TemplateListPage$14.createFileDialog(TemplateListPage.java:712)
at org.jboss.tools.openshift.internal.ui.wizard.newapp.TemplateListPage$14.widgetSelected(TemplateListPage.java:702)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4481)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1329)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3819)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3430)
at org.eclipse.jface.window.Window.runEventLoop(Window.java:827)
at org.eclipse.jface.window.Window.open(Window.java:803)
at org.jboss.tools.common.ui.WizardUtils.openWizardDialog(WizardUtils.java:279)
at org.jboss.tools.common.ui.WizardUtils.openWizardDialog(WizardUtils.java:270)
at org.jboss.tools.openshift.internal.ui.handler.NewApplicationHandler.execute(NewApplicationHandler.java:37)
at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:295)
at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:56)
at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:252)
at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:234)
at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:152)
at org.eclipse.core.commands.Command.executeWithChecks(Command.java:493)
at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:486)
at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:210)
at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.executeItem(HandledContributionItem.java:799)
at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.handleWidgetSelection(HandledContributionItem.java:675)
at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.access$7(HandledContributionItem.java:659)
at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem$4.handleEvent(HandledContributionItem.java:592)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4481)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1329)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3819)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3430)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1127)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1018)
at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:156)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:654)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:598)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:139)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:669)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:608)
at org.eclipse.equinox.launcher.Main.run(Main.java:1515)
at org.eclipse.equinox.launcher.Main.main(Main.java:1488)
{code}
I expect value should be ignored and file browser dialog should be opened to allow user choose template.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21148) Unhandled loop event exception is thrown if local template file path contains invalid value
by Marián Labuda (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21148?page=com.atlassian.jira.plugi... ]
Marián Labuda closed JBIDE-21148.
---------------------------------
Verified in nightly build with OpenShift plugin of version v20151208-0343-B110.
> Unhandled loop event exception is thrown if local template file path contains invalid value
> -------------------------------------------------------------------------------------------
>
> Key: JBIDE-21148
> URL: https://issues.jboss.org/browse/JBIDE-21148
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta1
> Reporter: Marián Labuda
> Assignee: Fred Bricon
> Labels: application_wizard, openshift_v3
> Fix For: 4.3.1.Beta1
>
>
> In New OpenShift Application wizard while Local template tab is selected on first wizard page and if in text widget for a file is invalid value, click on a File system... button throws following exception and nothing happens:
> {code}
> java.lang.NullPointerException
> at org.jboss.tools.openshift.internal.ui.wizard.newapp.TemplateListPage$14.createFileDialog(TemplateListPage.java:712)
> at org.jboss.tools.openshift.internal.ui.wizard.newapp.TemplateListPage$14.widgetSelected(TemplateListPage.java:702)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4481)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1329)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3819)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3430)
> at org.eclipse.jface.window.Window.runEventLoop(Window.java:827)
> at org.eclipse.jface.window.Window.open(Window.java:803)
> at org.jboss.tools.common.ui.WizardUtils.openWizardDialog(WizardUtils.java:279)
> at org.jboss.tools.common.ui.WizardUtils.openWizardDialog(WizardUtils.java:270)
> at org.jboss.tools.openshift.internal.ui.handler.NewApplicationHandler.execute(NewApplicationHandler.java:37)
> at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:295)
> at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:56)
> at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:252)
> at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:234)
> at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
> at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:152)
> at org.eclipse.core.commands.Command.executeWithChecks(Command.java:493)
> at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:486)
> at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:210)
> at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.executeItem(HandledContributionItem.java:799)
> at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.handleWidgetSelection(HandledContributionItem.java:675)
> at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.access$7(HandledContributionItem.java:659)
> at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem$4.handleEvent(HandledContributionItem.java:592)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4481)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1329)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3819)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3430)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1127)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1018)
> at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:156)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:654)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:598)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:139)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:669)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:608)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1515)
> at org.eclipse.equinox.launcher.Main.main(Main.java:1488)
> {code}
> I expect value should be ignored and file browser dialog should be opened to allow user choose template.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21158) Improve BaseExplorerContentProvider.loadChildren()
by Marián Labuda (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21158?page=com.atlassian.jira.plugi... ]
Marián Labuda closed JBIDE-21158.
---------------------------------
Closing, nothing to verify.
> Improve BaseExplorerContentProvider.loadChildren()
> --------------------------------------------------
>
> Key: JBIDE-21158
> URL: https://issues.jboss.org/browse/JBIDE-21158
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.4.0.Alpha1
> Reporter: Viacheslav Kabanovich
> Assignee: Viacheslav Kabanovich
> Labels: performance
> Fix For: 4.3.1.Beta1
>
>
> This method may be called concurrently while children for current parentElement are being loaded. Now for this case implementation calls directly getChildrenFor(parentElement) which loads children in ui thread. So, if by some reason loading children in a separate job took a lot of time, by the same reason this second call in ui thread may hang Eclipse for some time.
> Instead, it seams reasonable just to return the available loading stub as a child, when loading job is completed it will call refresh.
> [~adietish] please take a look at the pull request.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21158) Improve BaseExplorerContentProvider.loadChildren()
by Marián Labuda (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21158?page=com.atlassian.jira.plugi... ]
Marián Labuda updated JBIDE-21158:
----------------------------------
Fix Version/s: (was: 4.4.0.Alpha1)
> Improve BaseExplorerContentProvider.loadChildren()
> --------------------------------------------------
>
> Key: JBIDE-21158
> URL: https://issues.jboss.org/browse/JBIDE-21158
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.4.0.Alpha1
> Reporter: Viacheslav Kabanovich
> Assignee: Viacheslav Kabanovich
> Labels: performance
> Fix For: 4.3.1.Beta1
>
>
> This method may be called concurrently while children for current parentElement are being loaded. Now for this case implementation calls directly getChildrenFor(parentElement) which loads children in ui thread. So, if by some reason loading children in a separate job took a lot of time, by the same reason this second call in ui thread may hang Eclipse for some time.
> Instead, it seams reasonable just to return the available loading stub as a child, when loading job is completed it will call refresh.
> [~adietish] please take a look at the pull request.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21200) Plug-in "org.jboss.tools.vpe" was unable to instantiate class "org.jboss.tools.vpe.editor.menu.SetupTemplateContributionItem
by Konstantin Marmalyukov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21200?page=com.atlassian.jira.plugi... ]
Konstantin Marmalyukov commented on JBIDE-21200:
------------------------------------------------
I test this issue on Windows and wasn't able to reproduce it. So, as I mentioned before, this is Mac OS specific problem which was caused by removing visual tabs. So nullcheck resolves this issue.
> Plug-in "org.jboss.tools.vpe" was unable to instantiate class "org.jboss.tools.vpe.editor.menu.SetupTemplateContributionItem
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-21200
> URL: https://issues.jboss.org/browse/JBIDE-21200
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: visual-page-editor-core
> Affects Versions: 4.3.0.Beta1
> Environment: Mac OS
> Reporter: Pavol Srna
> Assignee: Konstantin Marmalyukov
> Fix For: 4.3.0.Beta1, 4.4.0.Alpha1
>
>
> 1. Create JSF 1.2 Kick Start project
> 2. Open inputUserName.jsp in VPE
> 3. Right Click on 'user' text within <h:inputText> tag
> {code}
> org.eclipse.core.runtime.CoreException: Plug-in "org.jboss.tools.vpe" was unable to instantiate class "org.jboss.tools.vpe.editor.menu.SetupTemplateContributionItem".
> at org.eclipse.core.internal.registry.osgi.RegistryStrategyOSGI.throwException(RegistryStrategyOSGI.java:194)
> at org.eclipse.core.internal.registry.osgi.RegistryStrategyOSGI.createExecutableExtension(RegistryStrategyOSGI.java:186)
> at org.eclipse.core.internal.registry.ExtensionRegistry.createExecutableExtension(ExtensionRegistry.java:905)
> at org.eclipse.core.internal.registry.ConfigurationElement.createExecutableExtension(ConfigurationElement.java:243)
> at org.eclipse.core.internal.registry.ConfigurationElementHandle.createExecutableExtension(ConfigurationElementHandle.java:55)
> at org.eclipse.ui.internal.util.Util.safeLoadExecutableExtension(Util.java:872)
> at org.eclipse.ui.internal.menus.DynamicMenuContributionItem.createContributionItem(DynamicMenuContributionItem.java:234)
> at org.eclipse.ui.internal.menus.DynamicMenuContributionItem.getContributionItem(DynamicMenuContributionItem.java:227)
> at org.eclipse.ui.internal.menus.DynamicMenuContributionItem.fill(DynamicMenuContributionItem.java:206)
> at org.eclipse.jface.action.MenuManager.doItemFill(MenuManager.java:724)
> at org.eclipse.jface.action.MenuManager.update(MenuManager.java:806)
> at org.eclipse.jface.action.MenuManager.update(MenuManager.java:665)
> at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.scheduleManagerUpdate(MenuManagerRenderer.java:1164)
> at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.processContents(MenuManagerRenderer.java:636)
> at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.subscribeTopicChildAdded(MenuManagerRenderer.java:313)
> at sun.reflect.GeneratedMethodAccessor24.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:56)
> at org.eclipse.e4.ui.internal.di.UIEventObjectSupplier$UIEventHandler$1.run(UIEventObjectSupplier.java:56)
> at org.eclipse.swt.widgets.Synchronizer.syncExec(Synchronizer.java:186)
> at org.eclipse.ui.internal.UISynchronizer.syncExec(UISynchronizer.java:145)
> at org.eclipse.swt.widgets.Display.syncExec(Display.java:4781)
> at org.eclipse.e4.ui.internal.workbench.swt.E4Application$1.syncExec(E4Application.java:211)
> at org.eclipse.e4.ui.internal.di.UIEventObjectSupplier$UIEventHandler.handleEvent(UIEventObjectSupplier.java:53)
> at org.eclipse.equinox.internal.event.EventHandlerWrapper.handleEvent(EventHandlerWrapper.java:197)
> at org.eclipse.equinox.internal.event.EventHandlerTracker.dispatchEvent(EventHandlerTracker.java:197)
> at org.eclipse.equinox.internal.event.EventHandlerTracker.dispatchEvent(EventHandlerTracker.java:1)
> at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
> at org.eclipse.osgi.framework.eventmgr.ListenerQueue.dispatchEventSynchronous(ListenerQueue.java:148)
> at org.eclipse.equinox.internal.event.EventAdminImpl.dispatchEvent(EventAdminImpl.java:135)
> at org.eclipse.equinox.internal.event.EventAdminImpl.sendEvent(EventAdminImpl.java:78)
> at org.eclipse.equinox.internal.event.EventComponent.sendEvent(EventComponent.java:39)
> at org.eclipse.e4.ui.services.internal.events.EventBroker.send(EventBroker.java:85)
> at org.eclipse.e4.ui.internal.workbench.UIEventPublisher.notifyChanged(UIEventPublisher.java:59)
> at org.eclipse.emf.common.notify.impl.BasicNotifierImpl.eNotify(BasicNotifierImpl.java:374)
> at org.eclipse.emf.ecore.util.EcoreEList.dispatchNotification(EcoreEList.java:249)
> at org.eclipse.emf.common.notify.impl.NotifyingListImpl.addUnique(NotifyingListImpl.java:356)
> at org.eclipse.emf.common.util.AbstractEList.add(AbstractEList.java:341)
> at org.eclipse.e4.ui.workbench.renderers.swt.ContributionRecord.mergeIntoModel(ContributionRecord.java:250)
> at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.processAddition(MenuManagerRenderer.java:554)
> at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.generateContributions(MenuManagerRenderer.java:529)
> at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.processContributions(MenuManagerRenderer.java:494)
> at org.eclipse.ui.internal.PopupMenuExtender.addMenuContributions(PopupMenuExtender.java:409)
> at org.eclipse.ui.internal.PopupMenuExtender.menuAboutToShow(PopupMenuExtender.java:381)
> at org.eclipse.jface.action.MenuManager.fireAboutToShow(MenuManager.java:333)
> at org.eclipse.jface.action.MenuManager.handleAboutToShow(MenuManager.java:466)
> at org.eclipse.jface.action.MenuManager.access$1(MenuManager.java:461)
> at org.eclipse.jface.action.MenuManager$2.menuShown(MenuManager.java:493)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:255)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4230)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1491)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1514)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1495)
> at org.eclipse.swt.widgets.Menu.menuWillOpen(Menu.java:811)
> at org.eclipse.swt.widgets.Display.windowProc(Display.java:5746)
> at org.eclipse.swt.internal.cocoa.OS.objc_msgSend(Native Method)
> at org.eclipse.swt.internal.cocoa.NSMenu.popUpContextMenu(NSMenu.java:77)
> at org.eclipse.swt.widgets.Menu._setVisible(Menu.java:280)
> at org.eclipse.swt.widgets.Display.runPopups(Display.java:4149)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3691)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1127)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1018)
> at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:156)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:654)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:598)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:139)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:669)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:608)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1515)
> Caused by: java.lang.NullPointerException
> at org.jboss.tools.vpe.editor.menu.SetupTemplateContributionItem.<init>(SetupTemplateContributionItem.java:55)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:422)
> at java.lang.Class.newInstance(Class.java:442)
> at org.eclipse.core.internal.registry.osgi.RegistryStrategyOSGI.createExecutableExtension(RegistryStrategyOSGI.java:184)
> ... 81 more
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months
[JBoss JIRA] (JBIDE-21216) Improve BaseExplorerContentProvider.loadChildren()
by Marián Labuda (JIRA)
Marián Labuda created JBIDE-21216:
-------------------------------------
Summary: Improve BaseExplorerContentProvider.loadChildren()
Key: JBIDE-21216
URL: https://issues.jboss.org/browse/JBIDE-21216
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: openshift
Affects Versions: 4.4.0.Alpha1
Reporter: Viacheslav Kabanovich
Assignee: Viacheslav Kabanovich
Fix For: 4.3.1.Beta1, 4.4.0.Alpha1
This method may be called concurrently while children for current parentElement are being loaded. Now for this case implementation calls directly getChildrenFor(parentElement) which loads children in ui thread. So, if by some reason loading children in a separate job took a lot of time, by the same reason this second call in ui thread may hang Eclipse for some time.
Instead, it seams reasonable just to return the available loading stub as a child, when loading job is completed it will call refresh.
[~adietish] please take a look at the pull request.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 4 months